Any chance of getting http://jira.qos.ch/browse/LBCLASSIC-276 / https://github.com/ceki/logback/pull/16 pulled in the near future? Otherwise I'd do another Lilith release without fully supporting Throwable.getSuppressed(). Joern.
Hi Joern, It's on my todo list. On 03/11/2011 4:09 PM, Joern Huxhorn wrote:
Any chance of getting http://jira.qos.ch/browse/LBCLASSIC-276 / https://github.com/ceki/logback/pull/16 pulled in the near future?
Otherwise I'd do another Lilith release without fully supporting Throwable.getSuppressed().
Joern.
-- Ceki http://twitter.com/#!/ceki
Hi Joern, I just added you as a project participant on https://github.com/ceki/logback/. You should be able to apply the patch yourself. It'd be cool if you can also have a look at LBCLASSIC-296 and the patch submitted by Chris Dolan? It's a tough assignment, so please feel free to decline. -- Ceki http://twitter.com/#!/ceki On 03/11/2011 8:56 PM, ceki wrote:
Hi Joern,
It's on my todo list.
On 03/11/2011 4:09 PM, Joern Huxhorn wrote:
Any chance of getting http://jira.qos.ch/browse/LBCLASSIC-276 / https://github.com/ceki/logback/pull/16 pulled in the near future?
Otherwise I'd do another Lilith release without fully supporting Throwable.getSuppressed().
Joern.
Hi Ceki, thanks a lot! I just merged my pull request. Now we'd need to decide how support should be added to • ch.qos.logback.classic.db.DBAppender • ch.qos.logback.classic.html.DefaultThrowableRenderer • ch.qos.logback.classic.net.SyslogAppender • ch.qos.logback.classic.pattern.ThrowableProxyConverter • ch.qos.logback.classic.spi.ThrowableProxyUtil.asString I've taken a look at the LBCLASSIC-296 code (both https://github.com/chrisdolan/logback/commit/eb1b03ac72f0534d9152279e39d85a8... and https://github.com/chrisdolan/logback/commit/01c4b17766e59eee613d2777963f536... ) and it looks quite reasonable to me. Unfortunately, OSGi isn't something I have a lot of experience with - so I can only say "Yes, looks reasonable". I'd suggest that Chris pulls in my changes and creates a branch with his changes so we can just pull them in. I'm not sure about <scope>provided</scope> in logback-classic/pom.xml, though. I think it should be <scope>compile</scope><optional>true</optional> instead. Cheers, Joern. On 04.11.2011, at 08:57, ceki wrote:
Hi Joern,
I just added you as a project participant on https://github.com/ceki/logback/. You should be able to apply the patch yourself.
It'd be cool if you can also have a look at LBCLASSIC-296 and the patch submitted by Chris Dolan? It's a tough assignment, so please feel free to decline.
-- Ceki http://twitter.com/#!/ceki
On 03/11/2011 8:56 PM, ceki wrote:
Hi Joern,
It's on my todo list.
On 03/11/2011 4:09 PM, Joern Huxhorn wrote:
Any chance of getting http://jira.qos.ch/browse/LBCLASSIC-276 / https://github.com/ceki/logback/pull/16 pulled in the near future?
Otherwise I'd do another Lilith release without fully supporting Throwable.getSuppressed().
Joern.
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev
On 04/11/2011 9:46 AM, Joern Huxhorn wrote:
Hi Ceki, thanks a lot! I just merged my pull request.
Now we'd need to decide how support should be added to • ch.qos.logback.classic.db.DBAppender • ch.qos.logback.classic.html.DefaultThrowableRenderer • ch.qos.logback.classic.net.SyslogAppender • ch.qos.logback.classic.pattern.ThrowableProxyConverter • ch.qos.logback.classic.spi.ThrowableProxyUtil.asString
I'd start with ThrowableProxyConverter and build from there. Annoyingly enough, testing this feature would require JDK 1.7 which in turn would force the build to require JDK 1.7. Alternatively, we could populate ThrowableProxy with suppressed exceptions and have the tests work from there (without requiring JDK 1.7). Any other ideas?
I've taken a look at the LBCLASSIC-296 code (both https://github.com/chrisdolan/logback/commit/eb1b03ac72f and https://github.com/chrisdolan/logback/commit/01c4b1776 ) and it looks quite reasonable to me.
They do look reasonable.
Unfortunately, OSGi isn't something I have a lot of experience with - so I can only say "Yes, looks reasonable". I'd suggest that Chris pulls in my changes and creates a branch with his changes so we can just pull them in.
Yes, we can ask him. I'll contact him.
I'm not sure about<scope>provided</scope> in logback-classic/pom.xml, though. I think it should be<scope>compile</scope><optional>true</optional> instead.
Yes, compile+optional is what we do elsewhere. -- Ceki
On 04.11.2011, at 17:22, ceki wrote:
On 04/11/2011 9:46 AM, Joern Huxhorn wrote:
Hi Ceki, thanks a lot! I just merged my pull request.
Now we'd need to decide how support should be added to • ch.qos.logback.classic.db.DBAppender • ch.qos.logback.classic.html.DefaultThrowableRenderer • ch.qos.logback.classic.net.SyslogAppender • ch.qos.logback.classic.pattern.ThrowableProxyConverter • ch.qos.logback.classic.spi.ThrowableProxyUtil.asString
I'd start with ThrowableProxyConverter and build from there. Annoyingly enough, testing this feature would require JDK 1.7 which in turn would force the build to require JDK 1.7. Alternatively, we could populate ThrowableProxy with suppressed exceptions and have the tests work from there (without requiring JDK 1.7). Any other ideas?
I've given it a shot in the https://github.com/ceki/logback/tree/suppressed branch. I implemented asString and added two tests that are only executed if running on Java 7. They already succeed. Merge the branch in if you like it. On a side note, I updated JUnit to 4.10 since I use Assume and I think that some previous version had an issues with that feature. Not sure, better safe than sorry. Cheers, Joern.
participants (2)
-
ceki -
Joern Huxhorn