[JIRA] Created: (LBGENERAL-23) add support for package version & jar name in the stack trace

add support for package version & jar name in the stack trace ------------------------------------------------------------- Key: LBGENERAL-23 URL: http://jira.qos.ch/browse/LBGENERAL-23 Project: logback-general Issue Type: New Feature Reporter: James Strachan Assignee: Logback dev list add support for this patch... https://issues.apache.org/bugzilla/show_bug.cgi?id=45721 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBGENERAL-23?page=com.atlassian.jira.plugin.system... ] Ceki Gulcu commented on LBGENERAL-23: ------------------------------------- Thank you for this contribution. Are you aware that logback is distributed under a different license? (I know you are aware, but I need a public statement).
add support for package version & jar name in the stack trace -------------------------------------------------------------
Key: LBGENERAL-23 URL: http://jira.qos.ch/browse/LBGENERAL-23 Project: logback-general Issue Type: New Feature Reporter: James Strachan Assignee: Logback dev list
add support for this patch... https://issues.apache.org/bugzilla/show_bug.cgi?id=45721
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBGENERAL-23?page=com.atlassian.jira.plugin.system... ] James Strachan commented on LBGENERAL-23: ----------------------------------------- feel free to reuse this patch under any license you like
add support for package version & jar name in the stack trace -------------------------------------------------------------
Key: LBGENERAL-23 URL: http://jira.qos.ch/browse/LBGENERAL-23 Project: logback-general Issue Type: New Feature Reporter: James Strachan Assignee: Logback dev list
add support for this patch... https://issues.apache.org/bugzilla/show_bug.cgi?id=45721
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBGENERAL-23?page=com.atlassian.jira.plugin.system... ] Ceki Gulcu commented on LBGENERAL-23: ------------------------------------- My tests show that extracting version information can be very costly. For example, computing stack trace information without package data takes 100 microseconds. With package data the figure jumps to 5 milliseconds, a 50 fold increase.
add support for package version & jar name in the stack trace -------------------------------------------------------------
Key: LBGENERAL-23 URL: http://jira.qos.ch/browse/LBGENERAL-23 Project: logback-general Issue Type: New Feature Reporter: James Strachan Assignee: Ceki Gulcu
add support for this patch... https://issues.apache.org/bugzilla/show_bug.cgi?id=45721
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBGENERAL-23?page=com.atlassian.jira.plugin.system... ] Ceki Gulcu edited comment on LBGENERAL-23 at 9/2/08 6:39 PM: ------------------------------------------------------------- My tests show that extracting version information can be very costly. For example, computing stack trace information without package data takes 100 microseconds. With package data the figure jumps to 5 milliseconds, a 50 fold increase. In revision 1790, support for an LRUCache was added. Caching previously found data should improve performance. was (Author: noreply.ceki@qos.ch): My tests show that extracting version information can be very costly. For example, computing stack trace information without package data takes 100 microseconds. With package data the figure jumps to 5 milliseconds, a 50 fold increase.
add support for package version & jar name in the stack trace -------------------------------------------------------------
Key: LBGENERAL-23 URL: http://jira.qos.ch/browse/LBGENERAL-23 Project: logback-general Issue Type: New Feature Reporter: James Strachan Assignee: Ceki Gulcu
add support for this patch... https://issues.apache.org/bugzilla/show_bug.cgi?id=45721
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBGENERAL-23?page=com.atlassian.jira.plugin.system... ] Ceki Gulcu resolved LBGENERAL-23. --------------------------------- Fix Version/s: 0.9.10 Resolution: Fixed After some work, PatternLayout will *by default* append packaging information at the end of each stack frame. The code goes to great lengths to ensure that the data it displays is correct. However, whenever it cannot guarantee that, it will prefix packaging information with a tilde, .i.e. te '~' character, to signal the user that the information is only tentative.
add support for package version & jar name in the stack trace -------------------------------------------------------------
Key: LBGENERAL-23 URL: http://jira.qos.ch/browse/LBGENERAL-23 Project: logback-general Issue Type: New Feature Reporter: James Strachan Assignee: Ceki Gulcu Fix For: 0.9.10
add support for this patch... https://issues.apache.org/bugzilla/show_bug.cgi?id=45721
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBGENERAL-23?page=com.atlassian.jira.plugin.system... ] Thorbjørn Ravn Andersen commented on LBGENERAL-23: -------------------------------------------------- It would be nice if the jarfile information included the timestamp(s) of the jarfile. This helps those who deal with legacy deployments without version information.
add support for package version & jar name in the stack trace -------------------------------------------------------------
Key: LBGENERAL-23 URL: http://jira.qos.ch/browse/LBGENERAL-23 Project: logback-general Issue Type: New Feature Reporter: James Strachan Assignee: Ceki Gulcu Fix For: 0.9.10
add support for this patch... https://issues.apache.org/bugzilla/show_bug.cgi?id=45721
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBGENERAL-23?page=com.atlassian.jira.plugin.system... ] Ceki Gulcu commented on LBGENERAL-23: ------------------------------------- Hopefully, developers will start iincluding "ImplementationVersion" in the manifest of their jar files. Developers will do it if their users ask for it. As for your suggestion, I can't imagine how data as fickle as file timestamps would be of any value.
add support for package version & jar name in the stack trace -------------------------------------------------------------
Key: LBGENERAL-23 URL: http://jira.qos.ch/browse/LBGENERAL-23 Project: logback-general Issue Type: New Feature Reporter: James Strachan Assignee: Ceki Gulcu Fix For: 0.9.10
add support for this patch... https://issues.apache.org/bugzilla/show_bug.cgi?id=45721
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
participants (3)
-
Ceki Gulcu (JIRA)
-
James Strachan (JIRA)
-
Thorbjørn Ravn Andersen (JIRA)