[JIRA] Created: (LBCORE-119) ReconfigureOnChangeFilter doesn't pick up changes if there are spaces in the filename

ReconfigureOnChangeFilter doesn't pick up changes if there are spaces in the filename ------------------------------------------------------------------------------------- Key: LBCORE-119 URL: http://jira.qos.ch/browse/LBCORE-119 Project: logback-core Issue Type: Bug Affects Versions: 0.9.17 Reporter: Anders Wallgren Assignee: Logback dev list ReconfigureOnChangeFilter.start doesn't unencode the URL encoding of spaces, so it will never detect changes since the url-encoded filename doesn't exist. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBCORE-119?page=com.atlassian.jira.plugin.system.i... ] Anders Wallgren commented on LBCORE-119: ---------------------------------------- Oops, I guess this should be in logback-classic, not core.
ReconfigureOnChangeFilter doesn't pick up changes if there are spaces in the filename -------------------------------------------------------------------------------------
Key: LBCORE-119 URL: http://jira.qos.ch/browse/LBCORE-119 Project: logback-core Issue Type: Bug Affects Versions: 0.9.17 Reporter: Anders Wallgren Assignee: Logback dev list
ReconfigureOnChangeFilter.start doesn't unencode the URL encoding of spaces, so it will never detect changes since the url-encoded filename doesn't exist.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBCORE-119?page=com.atlassian.jira.plugin.system.i... ] Ceki Gulcu edited comment on LBCORE-119 at 9/4/09 9:20 AM: ----------------------------------------------------------- The location (LBCORE or LBCLASSIC) is unimportant. It's early in the morning and I haven't quite woken up so I am not following you. Could you please give an example of how ReconfigureOnChangeFilter failing to uuencode spaces? What spaces, in the file name? How do I reproduce the problem? was (Author: noreply.ceki@qos.ch): The location (LBCORE or LBCLASSIC) is unimportant. It's early in the morning and I haven't quite woken up so I am not following you. Could you please give an example of how ReconfigureOnChangeFilter failing to uuencode spaces? What spaces, in the file name?
ReconfigureOnChangeFilter doesn't pick up changes if there are spaces in the filename -------------------------------------------------------------------------------------
Key: LBCORE-119 URL: http://jira.qos.ch/browse/LBCORE-119 Project: logback-core Issue Type: Bug Affects Versions: 0.9.17 Reporter: Anders Wallgren Assignee: Ceki Gulcu
ReconfigureOnChangeFilter.start doesn't unencode the URL encoding of spaces, so it will never detect changes since the url-encoded filename doesn't exist.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBCORE-119?page=com.atlassian.jira.plugin.system.i... ] Ceki Gulcu commented on LBCORE-119: ----------------------------------- The location (LBCORE or LBCLASSIC) is unimportant. It's early in the morning and I haven't quite woken up so I am not following you. Could you please give an example of how ReconfigureOnChangeFilter failing to uuencode spaces? What spaces, in the file name?
ReconfigureOnChangeFilter doesn't pick up changes if there are spaces in the filename -------------------------------------------------------------------------------------
Key: LBCORE-119 URL: http://jira.qos.ch/browse/LBCORE-119 Project: logback-core Issue Type: Bug Affects Versions: 0.9.17 Reporter: Anders Wallgren Assignee: Logback dev list
ReconfigureOnChangeFilter.start doesn't unencode the URL encoding of spaces, so it will never detect changes since the url-encoded filename doesn't exist.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBCORE-119?page=com.atlassian.jira.plugin.system.i... ] Ceki Gulcu edited comment on LBCORE-119 at 9/4/09 9:20 AM: ----------------------------------------------------------- The location (LBCORE or LBCLASSIC) is unimportant. It's early in the morning and I haven't quite woken up so I am not following you. Could you please give an example of how ReconfigureOnChangeFilter failing to uuencode spaces? What spaces, in the file name? How do can the problem be reproduced? was (Author: noreply.ceki@qos.ch): The location (LBCORE or LBCLASSIC) is unimportant. It's early in the morning and I haven't quite woken up so I am not following you. Could you please give an example of how ReconfigureOnChangeFilter failing to uuencode spaces? What spaces, in the file name? How do I reproduce the problem?
ReconfigureOnChangeFilter doesn't pick up changes if there are spaces in the filename -------------------------------------------------------------------------------------
Key: LBCORE-119 URL: http://jira.qos.ch/browse/LBCORE-119 Project: logback-core Issue Type: Bug Affects Versions: 0.9.17 Reporter: Anders Wallgren Assignee: Ceki Gulcu
ReconfigureOnChangeFilter.start doesn't unencode the URL encoding of spaces, so it will never detect changes since the url-encoded filename doesn't exist.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBCORE-119?page=com.atlassian.jira.plugin.system.i... ] Anders Wallgren commented on LBCORE-119: ---------------------------------------- * configure logback to use a file with spaces in the path name, for example, "C:\Documents and Settings\All Users\Application Data\foo\logback.xml" and set the "scan" attribute to true so it will look for changes to that file. * ReconfigureOnChangeFilter gets the URL and converts it to a File. * The filename will be C:\Documents%20Settings\All%20Users\Application%20Data\foo\logback.xml because the URL encoded the spaces in the filename. * File doesn't support encoded filenames, so it doesn't think that filename exists, so file.lastModified always return 0 as the time stamp and changes to the file are never detected The code needs to call URLDecoder.decode on the filename before creating the File object
ReconfigureOnChangeFilter doesn't pick up changes if there are spaces in the filename -------------------------------------------------------------------------------------
Key: LBCORE-119 URL: http://jira.qos.ch/browse/LBCORE-119 Project: logback-core Issue Type: Bug Affects Versions: 0.9.17 Reporter: Anders Wallgren Assignee: Ceki Gulcu
ReconfigureOnChangeFilter.start doesn't unencode the URL encoding of spaces, so it will never detect changes since the url-encoded filename doesn't exist.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBCORE-119?page=com.atlassian.jira.plugin.system.i... ] Ceki Gulcu commented on LBCORE-119: ----------------------------------- that's pretty clear. Thanks.
ReconfigureOnChangeFilter doesn't pick up changes if there are spaces in the filename -------------------------------------------------------------------------------------
Key: LBCORE-119 URL: http://jira.qos.ch/browse/LBCORE-119 Project: logback-core Issue Type: Bug Affects Versions: 0.9.17 Reporter: Anders Wallgren Assignee: Ceki Gulcu
ReconfigureOnChangeFilter.start doesn't unencode the URL encoding of spaces, so it will never detect changes since the url-encoded filename doesn't exist.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBCORE-119?page=com.atlassian.jira.plugin.system.i... ] Ceki Gulcu resolved LBCORE-119. ------------------------------- Fix Version/s: 0.9.18 Resolution: Fixed Fixed in http://github.com/ceki/logback/commit/b228e86a5cee41e0617ba04a8350754a011d49...
ReconfigureOnChangeFilter doesn't pick up changes if there are spaces in the filename -------------------------------------------------------------------------------------
Key: LBCORE-119 URL: http://jira.qos.ch/browse/LBCORE-119 Project: logback-core Issue Type: Bug Affects Versions: 0.9.17 Reporter: Anders Wallgren Assignee: Ceki Gulcu Fix For: 0.9.18
ReconfigureOnChangeFilter.start doesn't unencode the URL encoding of spaces, so it will never detect changes since the url-encoded filename doesn't exist.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
participants (2)
-
Anders Wallgren (JIRA)
-
Ceki Gulcu (JIRA)