Problem with current snapshot

http://github.com/ceki/logback/commit/b6bb584c8cb7ff7e6ebf9a0eefcfec48f5a841... Does not compile, it has some xxxxxx in ConsoleAppender. Also, I think there's a problem with logback-classic pom. It overrides logback-core compile dependency with a logback-core test- dependency. Regards, Joern.

On 26.02.2010 12:37, Joern Huxhorn wrote:
http://github.com/ceki/logback/commit/b6bb584c8cb7ff7e6ebf9a0eefcfec48f5a841...
Does not compile, it has some xxxxxx in ConsoleAppender.
Yes, I know. It's there to remind me to write a test. You can safely remove it.
Also, I think there's a problem with logback-classic pom. It overrides logback-core compile dependency with a logback-core test-dependency.
In logbacl-classic pom, I see <dependency> <groupId>ch.qos.logback</groupId> <artifactId>logback-core</artifactId> <scope>compile</scope> </dependency> <dependency> <groupId>ch.qos.logback</groupId> <artifactId>logback-core</artifactId> <type>test-jar</type> <scope>test</scope> </dependency> It seems correct to me.
Regards, Joern.

On 26.02.2010, at 13:22, Ceki Gulcu wrote:
On 26.02.2010 12:37, Joern Huxhorn wrote:
http://github.com/ceki/logback/commit/b6bb584c8cb7ff7e6ebf9a0eefcfec48f5a841...
Does not compile, it has some xxxxxx in ConsoleAppender.
Yes, I know. It's there to remind me to write a test. You can safely remove it.
Ok, done.
Also, I think there's a problem with logback-classic pom. It overrides logback-core compile dependency with a logback-core test-dependency.
In logbacl-classic pom, I see
<dependency> <groupId>ch.qos.logback</groupId> <artifactId>logback-core</artifactId> <scope>compile</scope> </dependency>
<dependency> <groupId>ch.qos.logback</groupId> <artifactId>logback-core</artifactId> <type>test-jar</type> <scope>test</scope> </dependency>
It seems correct to me.
Sorry, I thought this would remove the transitive dependency to logback-core from logback-classic, but that's not the case. I had a mistake in one of my POMs (logback-core had test-dependency) and this mistake did suddenly have an impact after updating to logback 0.9.19-SNAPSHOT. While I'm already writing a mail, I still get a test-failure in IncludeActionTest java.lang.AssertionError: at org.junit.Assert.fail(Assert.java:74) at org.junit.Assert.assertTrue(Assert.java:37) at org.junit.Assert.assertTrue(Assert.java:46) at ch .qos .logback .core.joran.action.IncludeActionTest.unknownURL(IncludeActionTest.java: 179) Those are the exceptions contained: java.io.FileNotFoundException org.xml.sax.SAXParseException java.net.MalformedURLException java.io.IOException The test checks for UnknownHostException instead. It runs correctly when I unplug my network cable: java.io.FileNotFoundException org.xml.sax.SAXParseException java.net.MalformedURLException java.net.UnknownHostException I'm running Mac OS X which is likely the cause of this problem. I think I reported this problem, somewhere... Uups, yes: http://jira.qos.ch/browse/LBCORE-129 I'll copy this to the report... Regards & Thanks, Joern.
participants (2)
-
Ceki Gulcu
-
Joern Huxhorn