[qos-ch/logback] 495929: Added relativePath to parent.

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 495929dc9620f1f0fbfcd8da73afaee16da946f2 https://github.com/qos-ch/logback/commit/495929dc9620f1f0fbfcd8da73afaee16da... Author: Joern Huxhorn <jhuxhorn@googlemail.com> Date: 2014-04-08 (Tue, 08 Apr 2014) Changed paths: M logback-access/pom.xml M logback-classic/pom.xml M logback-core/pom.xml M logback-examples/pom.xml M logback-site/pom.xml Log Message: ----------- Added relativePath to parent. Commit: 04868fab69732d1803a2b6672bccfcf7a2a5997f https://github.com/qos-ch/logback/commit/04868fab69732d1803a2b6672bccfcf7a2a... Author: Joern Huxhorn <jhuxhorn@googlemail.com> Date: 2014-04-08 (Tue, 08 Apr 2014) Changed paths: M pom.xml Log Message: ----------- Fix build. Reverted parent version from 1.2.0 to 1.1.3 for now. Compare: https://github.com/qos-ch/logback/compare/45b0cd961aca...04868fab6973

Hi Joern, Many thanks for catching the version problem with the parent! Having said that I don't think we need the relative paths to the parent pom. Tony, what do you think? Cheers, -- Ceki On 08.04.2014 23:46, Joern Huxhorn wrote:
Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 495929dc9620f1f0fbfcd8da73afaee16da946f2 https://github.com/qos-ch/logback/commit/495929dc9620f1f0fbfcd8da73afaee16da... Author: Joern Huxhorn<jhuxhorn@googlemail.com> Date: 2014-04-08 (Tue, 08 Apr 2014)
Changed paths: M logback-access/pom.xml M logback-classic/pom.xml M logback-core/pom.xml M logback-examples/pom.xml M logback-site/pom.xml
Log Message: ----------- Added relativePath to parent.
Commit: 04868fab69732d1803a2b6672bccfcf7a2a5997f https://github.com/qos-ch/logback/commit/04868fab69732d1803a2b6672bccfcf7a2a... Author: Joern Huxhorn<jhuxhorn@googlemail.com> Date: 2014-04-08 (Tue, 08 Apr 2014)
Changed paths: M pom.xml
Log Message: ----------- Fix build.
Reverted parent version from 1.2.0 to 1.1.3 for now.

Hi Ceki, I agree. We don't need to set parent.relativePath to "../pom.xml", especially since that setting is already the default value [1]. IMO, we should keep the pom as simple as possible. [1] http://maven.apache.org/ref/3.2.1/maven-model/maven.html#class_parent Tony On Wed, Apr 9, 2014 at 6:48 AM, Ceki Gulcu <ceki@qos.ch> wrote:
Hi Joern,
Many thanks for catching the version problem with the parent!
Having said that I don't think we need the relative paths to the parent pom. Tony, what do you think?
Cheers,
-- Ceki
On 08.04.2014 23:46, Joern Huxhorn wrote:
Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 495929dc9620f1f0fbfcd8da73afaee16da946f2 https://github.com/qos-ch/logback/commit/ 495929dc9620f1f0fbfcd8da73afaee16da946f2 Author: Joern Huxhorn<jhuxhorn@googlemail.com> Date: 2014-04-08 (Tue, 08 Apr 2014)
Changed paths: M logback-access/pom.xml M logback-classic/pom.xml M logback-core/pom.xml M logback-examples/pom.xml M logback-site/pom.xml
Log Message: ----------- Added relativePath to parent.
Commit: 04868fab69732d1803a2b6672bccfcf7a2a5997f https://github.com/qos-ch/logback/commit/ 04868fab69732d1803a2b6672bccfcf7a2a5997f Author: Joern Huxhorn<jhuxhorn@googlemail.com> Date: 2014-04-08 (Tue, 08 Apr 2014)
Changed paths: M pom.xml
Log Message: ----------- Fix build.
Reverted parent version from 1.2.0 to 1.1.3 for now.

Hi Tony & Ceki. Is it possible that this behavior has changed or was buggy? I’m quite sure that this was necessary at some point and that omitting it would result in parent resolve via repository (as would now be the case with empty <relativePath/>). Sorry for that. Cheers, Jörn. On 10. April 2014 at 05:32:27, Tony Trinh (tony19@gmail.com) wrote:
Hi Ceki,
I agree. We don't need to set parent.relativePath to "../pom.xml", especially since that setting is already the default value [1]. IMO, we should keep the pom as simple as possible.
[1] http://maven.apache.org/ref/3.2.1/maven-model/maven.html#class_parent
Tony
On Wed, Apr 9, 2014 at 6:48 AM, Ceki Gulcu wrote:
Hi Joern,
Many thanks for catching the version problem with the parent!
Having said that I don't think we need the relative paths to the parent pom. Tony, what do you think?
Cheers,
-- Ceki
On 08.04.2014 23:46, Joern Huxhorn wrote:
Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 495929dc9620f1f0fbfcd8da73afaee16da946f2 https://github.com/qos-ch/logback/commit/ 495929dc9620f1f0fbfcd8da73afaee16da946f2 Author: Joern Huxhorn Date: 2014-04-08 (Tue, 08 Apr 2014)
Changed paths: M logback-access/pom.xml M logback-classic/pom.xml M logback-core/pom.xml M logback-examples/pom.xml M logback-site/pom.xml
Log Message: ----------- Added relativePath to parent.
Commit: 04868fab69732d1803a2b6672bccfcf7a2a5997f https://github.com/qos-ch/logback/commit/ 04868fab69732d1803a2b6672bccfcf7a2a5997f Author: Joern Huxhorn Date: 2014-04-08 (Tue, 08 Apr 2014)
Changed paths: M pom.xml
Log Message: ----------- Fix build.
Reverted parent version from 1.2.0 to 1.1.3 for now.
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev
participants (4)
-
Ceki Gulcu
-
Joern Huxhorn
-
Jörn Huxhorn
-
Tony Trinh