Logback PR #352: Add appender for TestNG Reporter
Hi! My PR #352 (https://github.com/qos-ch/logback/pull/352) was closed, stating that it's not generic enough. Given that TestNG is the most widely used Java testing framework in the world, how much more generic does a Logback logger need to be for it to be included in the mainline project? The primary challenge with spinning this up as a separate project is that much of the basic building blocks for developing loggers and unit tests haven't been defined or published in a form that facilitates extension and importation of these existing declarations. Consequently, it's necessary to duplicate a significant volume of the implementation from the mainline project into the companion logger project. This is terribly inefficient and exposes the external project to the risk of breakage as revisions are applied to the mainline project that aren't automatically picked up by the companion project. Please advise. Thanks! = Scott Babcock =
Hi Scoot, Thank you for posting your question on this list. ReporterAppender is probably not useful enough for a wider audience. As such, I do not think it is advisable to incorporate it into logback proper. Best regards, -- Ceki On 1/11/2017 21:29, Scott Babcock wrote:
Hi!
My PR #352 (https://github.com/qos-ch/logback/pull/352) was closed, stating that it’s not generic enough. Given that TestNG is the most widely used Java testing framework in the world, how much more generic does a Logback logger need to be for it to be included in the mainline project?
The primary challenge with spinning this up as a separate project is that much of the basic building blocks for developing loggers and unit tests haven’t been defined or published in a form that facilitates extension and importation of these existing declarations. Consequently, it’s necessary to duplicate a significant volume of the implementation from the mainline project into the companion logger project. This is terribly inefficient and exposes the external project to the risk of breakage as revisions are applied to the mainline project that aren’t automatically picked up by the companion project.
Please advise.
Thanks!
= Scott Babcock =
The set of appenders provided by the main Logback project includes implementations for nine vendor-specific database products. The target audience for each of these database appenders is significantly smaller than the target audience for the TestNG Reporter appender provided by this PR. In a recent survey of dependency references in GitHub, the TestNG library comes in at #20 on the list of the top 100 most frequently used libraries. The only database flavor that comes close to this level of popularity is MySQL, which came in at #26. HSQL comes in at #54, and the remaining SQL flavors didn't make it onto the Top 100 list. I can migrate the TestNG Reporter appender to a companion project without the need to duplicate core unit test classes, by adding a "test-jar" dependency to my Maven project. While this is functional, it's less than ideal, as it makes this appender more difficult for potential users to find. Does any of these factors tip the balance in favor of incorporating this new appender into the main Logback project? ________________________________ From: logback-dev <logback-dev-bounces@qos.ch> on behalf of Ceki Gülcü <ceki@qos.ch> Sent: Wednesday, January 11, 2017 1:00 PM To: logback developers list Subject: Re: [logback-dev] Logback PR #352: Add appender for TestNG Reporter Hi Scoot, Thank you for posting your question on this list. ReporterAppender is probably not useful enough for a wider audience. As such, I do not think it is advisable to incorporate it into logback proper. Best regards, -- Ceki On 1/11/2017 21:29, Scott Babcock wrote:
Hi!
My PR #352 (https://github.com/qos-ch/logback/pull/352) was closed, stating that it's not generic enough. Given that TestNG is the most widely used Java testing framework in the world, how much more generic does a Logback logger need to be for it to be included in the mainline project?
The primary challenge with spinning this up as a separate project is that much of the basic building blocks for developing loggers and unit tests haven't been defined or published in a form that facilitates extension and importation of these existing declarations. Consequently, it's necessary to duplicate a significant volume of the implementation from the mainline project into the companion logger project. This is terribly inefficient and exposes the external project to the risk of breakage as revisions are applied to the mainline project that aren't automatically picked up by the companion project.
Please advise.
Thanks!
= Scott Babcock =
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev
I agree that with hindsight the inclusion of DBAppender in Logback might have been a mistake. If it were today, it probably would have not made the cut. My offer to reference ReporterAppender from logback's web-site still stands. On 1/12/2017 7:08, Scott Babcock wrote:
The set of appenders provided by the main Logback project includes implementations for nine vendor-specific database products. The target audience for each of these database appenders is significantly smaller than the target audience for the TestNG Reporter appender provided by this PR.
In a recent survey of dependency references in GitHub, the TestNG library comes in at #20 on the list of the top 100 most frequently used libraries. The only database flavor that comes close to this level of popularity is MySQL, which came in at #26. HSQL comes in at #54, and the remaining SQL flavors didn't make it onto the Top 100 list.
I can migrate the TestNG Reporter appender to a companion project without the need to duplicate core unit test classes, by adding a "test-jar" dependency to my Maven project. While this is functional, it's less than ideal, as it makes this appender more difficult for potential users to find.
Does any of these factors tip the balance in favor of incorporating this new appender into the main Logback project?
------------------------------------------------------------------------ *From:* logback-dev <logback-dev-bounces@qos.ch> on behalf of Ceki Gülcü <ceki@qos.ch> *Sent:* Wednesday, January 11, 2017 1:00 PM *To:* logback developers list *Subject:* Re: [logback-dev] Logback PR #352: Add appender for TestNG Reporter
Hi Scoot,
Thank you for posting your question on this list.
ReporterAppender is probably not useful enough for a wider audience. As such, I do not think it is advisable to incorporate it into logback proper.
Best regards,
-- Ceki
On 1/11/2017 21:29, Scott Babcock wrote:
Hi!
My PR #352 (https://github.com/qos-ch/logback/pull/352) was closed, stating that it’s not generic enough. Given that TestNG is the most widely used Java testing framework in the world, how much more generic does a Logback logger need to be for it to be included in the mainline project?
The primary challenge with spinning this up as a separate project is that much of the basic building blocks for developing loggers and unit tests haven’t been defined or published in a form that facilitates extension and importation of these existing declarations. Consequently, it’s necessary to duplicate a significant volume of the implementation from the mainline project into the companion logger project. This is terribly inefficient and exposes the external project to the risk of breakage as revisions are applied to the mainline project that aren’t automatically picked up by the companion project.
Please advise.
Thanks!
= Scott Babcock =
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev
Thanks for the reply. I've created a repository for the companion appender project at https://github.com/sbabcoc/logback-testng. I still need to create a README for this project, but it's in a usable state. I'm a relative newcomer to open-source software development. Besides a README file, what other documentation should I include with this project? Also, should I produce official releases of the associated JAR file? If so, where can I find detailed descriptions of this process? ________________________________ From: logback-dev <logback-dev-bounces@qos.ch> on behalf of Ceki Gülcü <ceki@qos.ch> Sent: Thursday, January 12, 2017 1:22 AM To: logback developers list Subject: Re: [logback-dev] Logback PR #352: Add appender for TestNG Reporter I agree that with hindsight the inclusion of DBAppender in Logback might have been a mistake. If it were today, it probably would have not made the cut. My offer to reference ReporterAppender from logback's web-site still stands. On 1/12/2017 7:08, Scott Babcock wrote:
The set of appenders provided by the main Logback project includes implementations for nine vendor-specific database products. The target audience for each of these database appenders is significantly smaller than the target audience for the TestNG Reporter appender provided by this PR.
In a recent survey of dependency references in GitHub, the TestNG library comes in at #20 on the list of the top 100 most frequently used libraries. The only database flavor that comes close to this level of popularity is MySQL, which came in at #26. HSQL comes in at #54, and the remaining SQL flavors didn't make it onto the Top 100 list.
I can migrate the TestNG Reporter appender to a companion project without the need to duplicate core unit test classes, by adding a "test-jar" dependency to my Maven project. While this is functional, it's less than ideal, as it makes this appender more difficult for potential users to find.
Does any of these factors tip the balance in favor of incorporating this new appender into the main Logback project?
------------------------------------------------------------------------ *From:* logback-dev <logback-dev-bounces@qos.ch> on behalf of Ceki Gülcü <ceki@qos.ch> *Sent:* Wednesday, January 11, 2017 1:00 PM *To:* logback developers list *Subject:* Re: [logback-dev] Logback PR #352: Add appender for TestNG Reporter
Hi Scoot,
Thank you for posting your question on this list.
ReporterAppender is probably not useful enough for a wider audience. As such, I do not think it is advisable to incorporate it into logback proper.
Best regards,
-- Ceki
On 1/11/2017 21:29, Scott Babcock wrote:
Hi!
My PR #352 (https://github.com/qos-ch/logback/pull/352) was closed, [https://avatars1.githubusercontent.com/u/3493745?v=3&s=400]<https://github.com/qos-ch/logback/pull/352>
Add appender for TestNG Reporter by sbabcoc · Pull Request #352 · qos-ch/logback<https://github.com/qos-ch/logback/pull/352> github.com This appender posts its output to the TestNG Reporter.
stating that it’s not generic enough. Given that TestNG is the most widely used Java testing framework in the world, how much more generic does a Logback logger need to be for it to be included in the mainline project?
The primary challenge with spinning this up as a separate project is that much of the basic building blocks for developing loggers and unit tests haven’t been defined or published in a form that facilitates extension and importation of these existing declarations. Consequently, it’s necessary to duplicate a significant volume of the implementation from the mainline project into the companion logger project. This is terribly inefficient and exposes the external project to the risk of breakage as revisions are applied to the mainline project that aren’t automatically picked up by the companion project.
Please advise.
Thanks!
= Scott Babcock =
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev logback-dev Info Page - mailman.qos.ch<http://mailman.qos.ch/mailman/listinfo/logback-dev> mailman.qos.ch Your email address: Your name (optional): You may enter a privacy password below. This provides only mild security, but should prevent others from messing with ...
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev
logback-dev Info Page - mailman.qos.ch<http://mailman.qos.ch/mailman/listinfo/logback-dev> mailman.qos.ch Your email address: Your name (optional): You may enter a privacy password below. This provides only mild security, but should prevent others from messing with ...
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev logback-dev Info Page - mailman.qos.ch<http://mailman.qos.ch/mailman/listinfo/logback-dev> mailman.qos.ch Your email address: Your name (optional): You may enter a privacy password below. This provides only mild security, but should prevent others from messing with ...
I would recommend publishing com.github.sbabcock:logback-testng in Maven Central. See [1] Otherwise, an example logback.xml file with ReporterAppender would be useful. [1] http://central.sonatype.org/pages/ossrh-guide.html On 1/12/2017 19:06, Scott Babcock wrote:
Thanks for the reply. I've created a repository for the companion appender project at https://github.com/sbabcoc/logback-testng. I still need to create a README for this project, but it's in a usable state.
I'm a relative newcomer to open-source software development. Besides a README file, what other documentation should I include with this project? Also, should I produce official releases of the associated JAR file? If so, where can I find detailed descriptions of this process?
------------------------------------------------------------------------ *From:* logback-dev <logback-dev-bounces@qos.ch> on behalf of Ceki Gülcü <ceki@qos.ch> *Sent:* Thursday, January 12, 2017 1:22 AM *To:* logback developers list *Subject:* Re: [logback-dev] Logback PR #352: Add appender for TestNG Reporter
I agree that with hindsight the inclusion of DBAppender in Logback might have been a mistake. If it were today, it probably would have not made the cut.
My offer to reference ReporterAppender from logback's web-site still stands.
On 1/12/2017 7:08, Scott Babcock wrote:
The set of appenders provided by the main Logback project includes implementations for nine vendor-specific database products. The target audience for each of these database appenders is significantly smaller than the target audience for the TestNG Reporter appender provided by this PR.
In a recent survey of dependency references in GitHub, the TestNG library comes in at #20 on the list of the top 100 most frequently used libraries. The only database flavor that comes close to this level of popularity is MySQL, which came in at #26. HSQL comes in at #54, and the remaining SQL flavors didn't make it onto the Top 100 list.
I can migrate the TestNG Reporter appender to a companion project without the need to duplicate core unit test classes, by adding a "test-jar" dependency to my Maven project. While this is functional, it's less than ideal, as it makes this appender more difficult for potential users to find.
Does any of these factors tip the balance in favor of incorporating this new appender into the main Logback project?
------------------------------------------------------------------------ *From:* logback-dev <logback-dev-bounces@qos.ch> on behalf of Ceki Gülcü <ceki@qos.ch> *Sent:* Wednesday, January 11, 2017 1:00 PM *To:* logback developers list *Subject:* Re: [logback-dev] Logback PR #352: Add appender for TestNG Reporter
Hi Scoot,
Thank you for posting your question on this list.
ReporterAppender is probably not useful enough for a wider audience. As such, I do not think it is advisable to incorporate it into logback proper.
Best regards,
-- Ceki
On 1/11/2017 21:29, Scott Babcock wrote:
Hi!
My PR #352 (https://github.com/qos-ch/logback/pull/352) was closed, <https://github.com/qos-ch/logback/pull/352>
Add appender for TestNG Reporter by sbabcoc · Pull Request #352 · qos-ch/logback <https://github.com/qos-ch/logback/pull/352> github.com This appender posts its output to the TestNG Reporter.
stating that it’s not generic enough. Given that TestNG is the most widely used Java testing framework in the world, how much more generic does a Logback logger need to be for it to be included in the mainline project?
The primary challenge with spinning this up as a separate project is that much of the basic building blocks for developing loggers and unit tests haven’t been defined or published in a form that facilitates extension and importation of these existing declarations. Consequently, it’s necessary to duplicate a significant volume of the implementation from the mainline project into the companion logger project. This is terribly inefficient and exposes the external project to the risk of breakage as revisions are applied to the mainline project that aren’t automatically picked up by the companion project.
Please advise.
Thanks!
= Scott Babcock =
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev logback-dev Info Page - mailman.qos.ch <http://mailman.qos.ch/mailman/listinfo/logback-dev> mailman.qos.ch Your email address: Your name (optional): You may enter a privacy password below. This provides only mild security, but should prevent others from messing with ...
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev
logback-dev Info Page - mailman.qos.ch <http://mailman.qos.ch/mailman/listinfo/logback-dev> mailman.qos.ch Your email address: Your name (optional): You may enter a privacy password below. This provides only mild security, but should prevent others from messing with ...
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev logback-dev Info Page - mailman.qos.ch <http://mailman.qos.ch/mailman/listinfo/logback-dev> mailman.qos.ch Your email address: Your name (optional): You may enter a privacy password below. This provides only mild security, but should prevent others from messing with ...
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev
The TestNG Reporter appender has now been published to Maven Central. artifact: https://search.maven.org/#search%7Cga%7C1%7Csbabcoc project: https://github.com/sbabcoc/logback-testng [https://avatars1.githubusercontent.com/u/3493745?v=3&s=400]<https://github.com/sbabcoc/logback-testng> sbabcoc/logback-testng<https://github.com/sbabcoc/logback-testng> github.com logback-testng - Logback appender for TestNG Reporter ________________________________ From: logback-dev <logback-dev-bounces@qos.ch> on behalf of Ceki Gülcü <ceki@qos.ch> Sent: Thursday, January 12, 2017 11:08 AM To: logback developers list Subject: Re: [logback-dev] Logback PR #352: Add appender for TestNG Reporter I would recommend publishing com.github.sbabcock:logback-testng in Maven Central. See [1] Otherwise, an example logback.xml file with ReporterAppender would be useful. [1] http://central.sonatype.org/pages/ossrh-guide.html Sonatype OSSRH Guide - The Central Repository<http://central.sonatype.org/pages/ossrh-guide.html> central.sonatype.org Introduction. Sonatype OSSRH (OSS Repository Hosting) uses Sonatype Nexus Repository Manager to provide repository hosting service for open source project binaries ... On 1/12/2017 19:06, Scott Babcock wrote:
Thanks for the reply. I've created a repository for the companion appender project at https://github.com/sbabcoc/logback-testng. I still [https://avatars1.githubusercontent.com/u/3493745?v=3&s=400]<https://github.com/sbabcoc/logback-testng>
sbabcoc/logback-testng<https://github.com/sbabcoc/logback-testng> github.com logback-testng - Logback appender for TestNG Reporter
need to create a README for this project, but it's in a usable state.
I'm a relative newcomer to open-source software development. Besides a README file, what other documentation should I include with this project? Also, should I produce official releases of the associated JAR file? If so, where can I find detailed descriptions of this process?
------------------------------------------------------------------------ *From:* logback-dev <logback-dev-bounces@qos.ch> on behalf of Ceki Gülcü <ceki@qos.ch> *Sent:* Thursday, January 12, 2017 1:22 AM *To:* logback developers list *Subject:* Re: [logback-dev] Logback PR #352: Add appender for TestNG Reporter
I agree that with hindsight the inclusion of DBAppender in Logback might have been a mistake. If it were today, it probably would have not made the cut.
My offer to reference ReporterAppender from logback's web-site still stands.
On 1/12/2017 7:08, Scott Babcock wrote:
The set of appenders provided by the main Logback project includes implementations for nine vendor-specific database products. The target audience for each of these database appenders is significantly smaller than the target audience for the TestNG Reporter appender provided by this PR.
In a recent survey of dependency references in GitHub, the TestNG library comes in at #20 on the list of the top 100 most frequently used libraries. The only database flavor that comes close to this level of popularity is MySQL, which came in at #26. HSQL comes in at #54, and the remaining SQL flavors didn't make it onto the Top 100 list.
I can migrate the TestNG Reporter appender to a companion project without the need to duplicate core unit test classes, by adding a "test-jar" dependency to my Maven project. While this is functional, it's less than ideal, as it makes this appender more difficult for potential users to find.
Does any of these factors tip the balance in favor of incorporating this new appender into the main Logback project?
------------------------------------------------------------------------ *From:* logback-dev <logback-dev-bounces@qos.ch> on behalf of Ceki Gülcü <ceki@qos.ch> *Sent:* Wednesday, January 11, 2017 1:00 PM *To:* logback developers list *Subject:* Re: [logback-dev] Logback PR #352: Add appender for TestNG Reporter
Hi Scoot,
Thank you for posting your question on this list.
ReporterAppender is probably not useful enough for a wider audience. As such, I do not think it is advisable to incorporate it into logback proper.
Best regards,
-- Ceki
On 1/11/2017 21:29, Scott Babcock wrote:
Hi!
My PR #352 (https://github.com/qos-ch/logback/pull/352) was closed, [https://avatars1.githubusercontent.com/u/3493745?v=3&s=400]<https://github.com/qos-ch/logback/pull/352>
Add appender for TestNG Reporter by sbabcoc · Pull Request #352 · qos-ch/logback<https://github.com/qos-ch/logback/pull/352> github.com This appender posts its output to the TestNG Reporter.
<https://github.com/qos-ch/logback/pull/352> [https://avatars1.githubusercontent.com/u/3493745?v=3&s=400]<https://github.com/qos-ch/logback/pull/352>
Add appender for TestNG Reporter by sbabcoc · Pull Request #352 · qos-ch/logback<https://github.com/qos-ch/logback/pull/352> github.com This appender posts its output to the TestNG Reporter.
Add appender for TestNG Reporter by sbabcoc · Pull Request #352 · qos-ch/logback <https://github.com/qos-ch/logback/pull/352>
[https://avatars1.githubusercontent.com/u/3493745?v=3&s=400]<https://github.com/qos-ch/logback/pull/352> Add appender for TestNG Reporter by sbabcoc · Pull Request #352 · qos-ch/logback<https://github.com/qos-ch/logback/pull/352> github.com This appender posts its output to the TestNG Reporter.
github.com This appender posts its output to the TestNG Reporter.
stating that it’s not generic enough. Given that TestNG is the most widely used Java testing framework in the world, how much more generic does a Logback logger need to be for it to be included in the mainline project?
The primary challenge with spinning this up as a separate project is that much of the basic building blocks for developing loggers and unit tests haven’t been defined or published in a form that facilitates extension and importation of these existing declarations. Consequently, it’s necessary to duplicate a significant volume of the implementation from the mainline project into the companion logger project. This is terribly inefficient and exposes the external project to the risk of breakage as revisions are applied to the mainline project that aren’t automatically picked up by the companion project.
Please advise.
Thanks!
= Scott Babcock =
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev logback-dev Info Page - mailman.qos.ch<http://mailman.qos.ch/mailman/listinfo/logback-dev> mailman.qos.ch Your email address: Your name (optional): You may enter a privacy password below. This provides only mild security, but should prevent others from messing with ...
logback-dev Info Page - mailman.qos.ch <http://mailman.qos.ch/mailman/listinfo/logback-dev> logback-dev Info Page - mailman.qos.ch<http://mailman.qos.ch/mailman/listinfo/logback-dev> mailman.qos.ch Your email address: Your name (optional): You may enter a privacy password below. This provides only mild security, but should prevent others from messing with ...
mailman.qos.ch Your email address: Your name (optional): You may enter a privacy password below. This provides only mild security, but should prevent others from messing with ...
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev
logback-dev Info Page - mailman.qos.ch<http://mailman.qos.ch/mailman/listinfo/logback-dev> mailman.qos.ch Your email address: Your name (optional): You may enter a privacy password below. This provides only mild security, but should prevent others from messing with ...
logback-dev Info Page - mailman.qos.ch <http://mailman.qos.ch/mailman/listinfo/logback-dev> mailman.qos.ch Your email address: Your name (optional): You may enter a privacy password below. This provides only mild security, but should prevent others from messing with ...
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev logback-dev Info Page - mailman.qos.ch <http://mailman.qos.ch/mailman/listinfo/logback-dev> mailman.qos.ch Your email address: Your name (optional): You may enter a privacy password below. This provides only mild security, but should prevent others from messing with ...
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev
Well done. Commit ff705cac [1] adds a link to https://github.com/sbabcoc/logback-testng from the logback downloads page. The link will become visible on the web-site with the next release of logback. -- Ceki [1] https://github.com/qos-ch/logback/commit/ff705cac On 1/18/2017 1:08, Scott Babcock wrote:
The TestNG Reporter appender has now been published to Maven Central.
artifact: https://search.maven.org/#search%7Cga%7C1%7Csbabcoc
project: https://github.com/sbabcoc/logback-testng
<https://github.com/sbabcoc/logback-testng>
sbabcoc/logback-testng <https://github.com/sbabcoc/logback-testng> github.com logback-testng - Logback appender for TestNG Reporter
------------------------------------------------------------------------ *From:* logback-dev <logback-dev-bounces@qos.ch> on behalf of Ceki Gülcü <ceki@qos.ch> *Sent:* Thursday, January 12, 2017 11:08 AM *To:* logback developers list *Subject:* Re: [logback-dev] Logback PR #352: Add appender for TestNG Reporter
I would recommend publishing com.github.sbabcock:logback-testng in Maven Central. See [1]
Otherwise, an example logback.xml file with ReporterAppender would be useful.
[1] http://central.sonatype.org/pages/ossrh-guide.html Sonatype OSSRH Guide - The Central Repository <http://central.sonatype.org/pages/ossrh-guide.html> central.sonatype.org Introduction. Sonatype OSSRH (OSS Repository Hosting) uses Sonatype Nexus Repository Manager to provide repository hosting service for open source project binaries ...
On 1/12/2017 19:06, Scott Babcock wrote:
Thanks for the reply. I've created a repository for the companion appender project at https://github.com/sbabcoc/logback-testng. I still <https://github.com/sbabcoc/logback-testng>
sbabcoc/logback-testng <https://github.com/sbabcoc/logback-testng> github.com logback-testng - Logback appender for TestNG Reporter
need to create a README for this project, but it's in a usable state.
I'm a relative newcomer to open-source software development. Besides a README file, what other documentation should I include with this project? Also, should I produce official releases of the associated JAR file? If so, where can I find detailed descriptions of this process?
------------------------------------------------------------------------ *From:* logback-dev <logback-dev-bounces@qos.ch> on behalf of Ceki Gülcü <ceki@qos.ch> *Sent:* Thursday, January 12, 2017 1:22 AM *To:* logback developers list *Subject:* Re: [logback-dev] Logback PR #352: Add appender for TestNG Reporter
I agree that with hindsight the inclusion of DBAppender in Logback might have been a mistake. If it were today, it probably would have not made the cut.
My offer to reference ReporterAppender from logback's web-site still stands.
On 1/12/2017 7:08, Scott Babcock wrote:
The set of appenders provided by the main Logback project includes implementations for nine vendor-specific database products. The target audience for each of these database appenders is significantly smaller than the target audience for the TestNG Reporter appender provided by this PR.
In a recent survey of dependency references in GitHub, the TestNG library comes in at #20 on the list of the top 100 most frequently used libraries. The only database flavor that comes close to this level of popularity is MySQL, which came in at #26. HSQL comes in at #54, and the remaining SQL flavors didn't make it onto the Top 100 list.
I can migrate the TestNG Reporter appender to a companion project without the need to duplicate core unit test classes, by adding a "test-jar" dependency to my Maven project. While this is functional, it's less than ideal, as it makes this appender more difficult for potential users to find.
Does any of these factors tip the balance in favor of incorporating this new appender into the main Logback project?
------------------------------------------------------------------------ *From:* logback-dev <logback-dev-bounces@qos.ch> on behalf of Ceki Gülcü <ceki@qos.ch> *Sent:* Wednesday, January 11, 2017 1:00 PM *To:* logback developers list *Subject:* Re: [logback-dev] Logback PR #352: Add appender for TestNG Reporter
Hi Scoot,
Thank you for posting your question on this list.
ReporterAppender is probably not useful enough for a wider audience. As such, I do not think it is advisable to incorporate it into logback proper.
Best regards,
-- Ceki
On 1/11/2017 21:29, Scott Babcock wrote:
Hi!
My PR #352 (https://github.com/qos-ch/logback/pull/352) was closed, <https://github.com/qos-ch/logback/pull/352>
Add appender for TestNG Reporter by sbabcoc · Pull Request #352 · qos-ch/logback <https://github.com/qos-ch/logback/pull/352> github.com This appender posts its output to the TestNG Reporter.
<https://github.com/qos-ch/logback/pull/352> <https://github.com/qos-ch/logback/pull/352>
Add appender for TestNG Reporter by sbabcoc · Pull Request #352 · qos-ch/logback <https://github.com/qos-ch/logback/pull/352> github.com This appender posts its output to the TestNG Reporter.
Add appender for TestNG Reporter by sbabcoc · Pull Request #352 · qos-ch/logback <https://github.com/qos-ch/logback/pull/352>
<https://github.com/qos-ch/logback/pull/352>
Add appender for TestNG Reporter by sbabcoc · Pull Request #352 · qos-ch/logback <https://github.com/qos-ch/logback/pull/352> github.com This appender posts its output to the TestNG Reporter.
github.com This appender posts its output to the TestNG Reporter.
stating that it’s not generic enough. Given that TestNG is the most widely used Java testing framework in the world, how much more generic does a Logback logger need to be for it to be included in the mainline project?
The primary challenge with spinning this up as a separate project is that much of the basic building blocks for developing loggers and unit tests haven’t been defined or published in a form that facilitates extension and importation of these existing declarations. Consequently, it’s necessary to duplicate a significant volume of the implementation from the mainline project into the companion logger project. This is terribly inefficient and exposes the external project to the risk of breakage as revisions are applied to the mainline project that aren’t automatically picked up by the companion project.
Please advise.
Thanks!
= Scott Babcock =
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev logback-dev Info Page - mailman.qos.ch <http://mailman.qos.ch/mailman/listinfo/logback-dev> mailman.qos.ch Your email address: Your name (optional): You may enter a privacy password below. This provides only mild security, but should prevent others from messing with ...
logback-dev Info Page - mailman.qos.ch <http://mailman.qos.ch/mailman/listinfo/logback-dev> logback-dev Info Page - mailman.qos.ch <http://mailman.qos.ch/mailman/listinfo/logback-dev> mailman.qos.ch Your email address: Your name (optional): You may enter a privacy password below. This provides only mild security, but should prevent others from messing with ...
mailman.qos.ch Your email address: Your name (optional): You may enter a privacy password below. This provides only mild security, but should prevent others from messing with ...
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev
logback-dev Info Page - mailman.qos.ch <http://mailman.qos.ch/mailman/listinfo/logback-dev> mailman.qos.ch Your email address: Your name (optional): You may enter a privacy password below. This provides only mild security, but should prevent others from messing with ...
logback-dev Info Page - mailman.qos.ch <http://mailman.qos.ch/mailman/listinfo/logback-dev> mailman.qos.ch Your email address: Your name (optional): You may enter a privacy password below. This provides only mild security, but should prevent others from messing with ...
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev logback-dev Info Page - mailman.qos.ch <http://mailman.qos.ch/mailman/listinfo/logback-dev> mailman.qos.ch Your email address: Your name (optional): You may enter a privacy password below. This provides only mild security, but should prevent others from messing with ...
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev
participants (2)
-
Ceki Gülcü -
Scott Babcock