[Bug 89] New: <include> does not search classpath

http://bugzilla.qos.ch/show_bug.cgi?id=89 Summary: <include> does not search classpath Product: logback-classic Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: blocker Priority: P1 Component: Other AssignedTo: logback-dev@qos.ch ReportedBy: michael.newcomb@gdc4s.com Logback searches the classpath for logback.xml or logback-test.xml, but when using <include> there is no way to specify a resource to include (ie something in a jar file) that is on the classpath. <include> is limited to file (explicit file location) or a url (which doesn't allow just a file name). Please add another mechanism for <include> to search the classpath for the file to be included: <include resource="xxx.xml"/> -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

http://bugzilla.qos.ch/show_bug.cgi?id=89 ------- Comment #1 from michael.newcomb@gdc4s.com 2007-08-09 19:07 ------- Created an attachment (id=7) --> (http://bugzilla.qos.ch/attachment.cgi?id=7&action=view) patch Implements suggested fix: adds 'resource' as an attribute to <include>. Logback will search the classpath for the specified resource. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

http://bugzilla.qos.ch/show_bug.cgi?id=89 noreply.ceki@qos.ch changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Comment #2 from noreply.ceki@qos.ch 2007-08-22 20:47 ------- Thanks for the report as well as the accompanying path. The resource attribute has been added in revision 1570. I also refactoreed the code in IncludeFileAction to make it a bit easier to follow. See also http://svn.qos.ch/viewvc?view=rev&revision=1570 -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

http://bugzilla.qos.ch/show_bug.cgi?id=89 michael.newcomb@gdc4s.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED ------- Comment #3 from michael.newcomb@gdc4s.com 2007-08-22 21:09 ------- (In reply to comment #2)
Thanks for the report as well as the accompanying path. The resource attribute has been added in revision 1570. I also refactoreed the code in IncludeFileAction to make it a bit easier to follow. See also http://svn.qos.ch/viewvc?view=rev&revision=1570
Consider: if (count == 0) { addError("One of \"path\", \"resource\" or \"url\" attributes must be set."); return false; } else if (count > 1) { addError("Only one of \"file\", \"url\" or \"resource\" attributes should be set."); return false; One message refers to 'path' and one to 'file'. 'file' is the correct name of the attribute. I can open a new bug, but figured it could just get hotfixed with this one. Thanks, Michael -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
participants (1)
-
bugzilla-daemon@pixie.qos.ch