[JIRA] Created: (LBCORE-210) Upgrade Janino support to latest 2.6.1

Upgrade Janino support to latest 2.6.1 -------------------------------------- Key: LBCORE-210 URL: http://jira.qos.ch/browse/LBCORE-210 Project: logback-core Issue Type: Improvement Components: Joran Affects Versions: 0.9.28, 0.9.29 Reporter: Jason Klapste Assignee: Logback dev list Logback officially supports 2.4.3 (from 2006!) and should probably be upgraded to a more recent version. Janino 2.6.1 *WAS* working previously in logback (0.9.27) until EnvUtil.isJaninoAvailable()'s check was added. org.codehaus.janino.Cookable does not exist in 2.6.1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBCORE-210?page=com.atlassian.jira.plugin.system.i... ] Ceki Gulcu reassigned LBCORE-210: --------------------------------- Assignee: Ceki Gulcu (was: Logback dev list)
Upgrade Janino support to latest 2.6.1 --------------------------------------
Key: LBCORE-210 URL: http://jira.qos.ch/browse/LBCORE-210 Project: logback-core Issue Type: Improvement Components: Joran Affects Versions: 0.9.28, 0.9.29 Reporter: Jason Klapste Assignee: Ceki Gulcu
Logback officially supports 2.4.3 (from 2006!) and should probably be upgraded to a more recent version. Janino 2.6.1 *WAS* working previously in logback (0.9.27) until EnvUtil.isJaninoAvailable()'s check was added. org.codehaus.janino.Cookable does not exist in 2.6.1.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBCORE-210?page=com.atlassian.jira.plugin.system.i... ] Andrey Adamovich commented on LBCORE-210: ----------------------------------------- org.codehaus.janino.Cookable is not even used directly by logback. it probably should be replaced with some class that code base has direct dependency on e.g. "org.codehaus.janino.CompileException" static public boolean isJaninoAvailable() { ClassLoader classLoader = EnvUtil.class.getClassLoader(); try { Class bindingClass = classLoader.loadClass("org.codehaus.janino.CompileException"); return (bindingClass != null); } catch (ClassNotFoundException e) { return false; } }
Upgrade Janino support to latest 2.6.1 --------------------------------------
Key: LBCORE-210 URL: http://jira.qos.ch/browse/LBCORE-210 Project: logback-core Issue Type: Improvement Components: Joran Affects Versions: 0.9.28, 0.9.29 Reporter: Jason Klapste Assignee: Ceki Gulcu
Logback officially supports 2.4.3 (from 2006!) and should probably be upgraded to a more recent version. Janino 2.6.1 *WAS* working previously in logback (0.9.27) until EnvUtil.isJaninoAvailable()'s check was added. org.codehaus.janino.Cookable does not exist in 2.6.1.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBCORE-210?page=com.atlassian.jira.plugin.system.i... ] Andrey Adamovich updated LBCORE-210: ------------------------------------ Attachment: patch.txt
Upgrade Janino support to latest 2.6.1 --------------------------------------
Key: LBCORE-210 URL: http://jira.qos.ch/browse/LBCORE-210 Project: logback-core Issue Type: Improvement Components: Joran Affects Versions: 0.9.28, 0.9.29 Reporter: Jason Klapste Assignee: Ceki Gulcu Attachments: patch.txt
Logback officially supports 2.4.3 (from 2006!) and should probably be upgraded to a more recent version. Janino 2.6.1 *WAS* working previously in logback (0.9.27) until EnvUtil.isJaninoAvailable()'s check was added. org.codehaus.janino.Cookable does not exist in 2.6.1.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBCORE-210?page=com.atlassian.jira.plugin.system.i... ] Ceki Gulcu commented on LBCORE-210: ----------------------------------- Janino 2.6.1. is not available on the maven central repo. The latest version I could find is 2.5.16. I changed the isJaninoAvailable() method so that it looks for org.codehaus.janino.ScriptEvaluator.
Upgrade Janino support to latest 2.6.1 --------------------------------------
Key: LBCORE-210 URL: http://jira.qos.ch/browse/LBCORE-210 Project: logback-core Issue Type: Improvement Components: Joran Affects Versions: 0.9.28, 0.9.29 Reporter: Jason Klapste Assignee: Ceki Gulcu Attachments: patch.txt
Logback officially supports 2.4.3 (from 2006!) and should probably be upgraded to a more recent version. Janino 2.6.1 *WAS* working previously in logback (0.9.27) until EnvUtil.isJaninoAvailable()'s check was added. org.codehaus.janino.Cookable does not exist in 2.6.1.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

Hi all, FYI, I will be on vacation for 10 days with limited internet access. -- Ceki http://twitter.com/#!/ceki

Have a relaxing vacation! Cheers, Joern. On 11.11.2011, at 13:18, ceki wrote:
Hi all,
FYI, I will be on vacation for 10 days with limited internet access.
-- Ceki http://twitter.com/#!/ceki _______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev

[ http://jira.qos.ch/browse/LBCORE-210?page=com.atlassian.jira.plugin.system.i... ] Jason Klapste commented on LBCORE-210: -------------------------------------- Looks like that should work-- ScriptEvaluator is also available 2.6.1 so it should work for that along with 2.5.16. Is there a logback snapshot I can test with to confirm?
Upgrade Janino support to latest 2.6.1 --------------------------------------
Key: LBCORE-210 URL: http://jira.qos.ch/browse/LBCORE-210 Project: logback-core Issue Type: Improvement Components: Joran Affects Versions: 0.9.28, 0.9.29 Reporter: Jason Klapste Assignee: Ceki Gulcu Attachments: patch.txt
Logback officially supports 2.4.3 (from 2006!) and should probably be upgraded to a more recent version. Janino 2.6.1 *WAS* working previously in logback (0.9.27) until EnvUtil.isJaninoAvailable()'s check was added. org.codehaus.janino.Cookable does not exist in 2.6.1.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBCORE-210?page=com.atlassian.jira.plugin.system.i... ] Ceki Gulcu commented on LBCORE-210: ----------------------------------- You can checkout the latest source for logback from source repository. See https://github.com/ceki/logback There is a button labeled "zip". You will still need to build the downloaded file with Maven though.
Upgrade Janino support to latest 2.6.1 --------------------------------------
Key: LBCORE-210 URL: http://jira.qos.ch/browse/LBCORE-210 Project: logback-core Issue Type: Improvement Components: Joran Affects Versions: 0.9.28, 0.9.29 Reporter: Jason Klapste Assignee: Ceki Gulcu Attachments: patch.txt
Logback officially supports 2.4.3 (from 2006!) and should probably be upgraded to a more recent version. Janino 2.6.1 *WAS* working previously in logback (0.9.27) until EnvUtil.isJaninoAvailable()'s check was added. org.codehaus.janino.Cookable does not exist in 2.6.1.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBCORE-210?page=com.atlassian.jira.plugin.system.i... ] Emerson Farrugia commented on LBCORE-210: ----------------------------------------- Janino 2.6.1 is now available on central (I just ran into this issue.) I'd never heard of Janino before logback, but if people use it and this version incompatibility is a one-liner fix in isJaninoAvailable(), can the fix be rolled into the next logback release please?
Upgrade Janino support to latest 2.6.1 --------------------------------------
Key: LBCORE-210 URL: http://jira.qos.ch/browse/LBCORE-210 Project: logback-core Issue Type: Improvement Components: Joran Affects Versions: 0.9.28, 0.9.29 Reporter: Jason Klapste Assignee: Ceki Gulcu Attachments: patch.txt
Logback officially supports 2.4.3 (from 2006!) and should probably be upgraded to a more recent version. Janino 2.6.1 *WAS* working previously in logback (0.9.27) until EnvUtil.isJaninoAvailable()'s check was added. org.codehaus.janino.Cookable does not exist in 2.6.1.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
participants (7)
-
Andrey Adamovich (JIRA)
-
ceki
-
Ceki Gulcu (JIRA)
-
Emerson Farrugia (JIRA)
-
Greg Thomas
-
Jason Klapste (JIRA)
-
Joern Huxhorn