This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via cc3b519ef885a7e779a6c179867dc05a51de81ff (commit) from 85d47057b85ae7f800915418ef8c3549322effd4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=cc3b519ef885a7e779a6c1798... http://github.com/ceki/logback/commit/cc3b519ef885a7e779a6c179867dc05a51de81... commit cc3b519ef885a7e779a6c179867dc05a51de81ff Author: Ceki Gulcu <ceki@qos.ch> Date: Tue Jan 18 11:34:37 2011 +0100 let the caller determine the success ratio lower bound diff --git a/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilienceTest.java b/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilienceTest.java index 497caad..960c63a 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilienceTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilienceTest.java @@ -76,7 +76,7 @@ public class FileAppenderResilienceTest { double bestCaseSuccessRatio = 1/delayCoeff; ResilienceUtil - .verify(logfileStr, "^hello (\\d{1,5})$", runner.getCounter(), bestCaseSuccessRatio); + .verify(logfileStr, "^hello (\\d{1,5})$", runner.getCounter(), bestCaseSuccessRatio*0.9); } } diff --git a/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilience_AS_ROOT_Test.java b/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilience_AS_ROOT_Test.java index 2e39ae6..b556ea6 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilience_AS_ROOT_Test.java +++ b/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilience_AS_ROOT_Test.java @@ -117,7 +117,7 @@ public class FileAppenderResilience_AS_ROOT_Test { p.waitFor(); // the extrernal script has the file system ready for IO 50% of the time double bestCase = 0.5; - ResilienceUtil.verify(logfileStr, "^(\\d{1,3}) x*$", NUM_STEPS, bestCase); + ResilienceUtil.verify(logfileStr, "^(\\d{1,3}) x*$", NUM_STEPS, bestCase*0.7); System.out.println("Done go"); } diff --git a/logback-core/src/test/java/ch/qos/logback/core/util/ResilienceUtil.java b/logback-core/src/test/java/ch/qos/logback/core/util/ResilienceUtil.java index 6119fb9..070a0fe 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/util/ResilienceUtil.java +++ b/logback-core/src/test/java/ch/qos/logback/core/util/ResilienceUtil.java @@ -11,7 +11,7 @@ import java.util.regex.Pattern; public class ResilienceUtil { - static public void verify(String logfile, String regexp, long totalSteps, double bestCaseSuccessRatio) throws NumberFormatException, IOException { + static public void verify(String logfile, String regexp, long totalSteps, double successRatioLowerBound) throws NumberFormatException, IOException { FileReader fr = new FileReader(logfile); BufferedReader br = new BufferedReader(fr); Pattern p = Pattern.compile(regexp); @@ -35,7 +35,6 @@ public class ResilienceUtil { fr.close(); br.close(); - double successRatioLowerBound = bestCaseSuccessRatio * 0.9; int lowerLimit = (int) (totalSteps*successRatioLowerBound); assertTrue("totalLines="+totalLines+" less than "+lowerLimit, totalLines > lowerLimit); ----------------------------------------------------------------------- Summary of changes: .../logback/core/FileAppenderResilienceTest.java | 2 +- .../core/FileAppenderResilience_AS_ROOT_Test.java | 2 +- .../ch/qos/logback/core/util/ResilienceUtil.java | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.