http://bugzilla.qos.ch/show_bug.cgi?id=115 Summary: Improve WriterAppender Product: logback-core Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: enhancement Priority: P4 Component: Appender AssignedTo: logback-dev@qos.ch ReportedBy: anders@hammar.net Reviewing the ch.qos.logback.core.WriterAppender class, I see that the attributes are 'protected' (not 'private'). However, there are set and get methods for most of them (but not all). I suggest making the attributes private and create setters and getters for all of them (there is no getWriter() for instance). This would prevent subclasses from incorrectly working directly against the attributes (for instance, not using the setWriter() would cause errors). If some 'public' getters are not desirable, at least 'protected' ones should be provided. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.