Failing tests when building v1.0.9

I am trying to build the v1.0.9 of the project to make a hot fix for the issue LOGBACK-782 on my fork while v_1.0.10 is not released yet: git clone https://github.com/qos-ch/logback.git cd logback git checkout v_1.0.9 mvn clean test Im getting tests failures on the core module: testDay(ch.qos.logback.core.util.TimeUtilTest): expected:<1164078000000> but was:<1164074400000> testWeek(ch.qos.logback.core.util.TimeUtilTest): expected:<1164596400000> but was:<1164592800000> testMonth(ch.qos.logback.core.util.TimeUtilTest): expected:<1164942000000> but was:<1164938400000> testVaryingNumberOfDailyPeriods(ch.qos.logback.core.rolling.helper.RollingCalendarTest): p=13 expected:<1224381600000> but was:<1224385200000> If it is relevant, I am running the project on a mac If this is not a know issue and need more information, let me know Thanks, Bruno "Polaco"

Looking inside the test, i noticed the following: The dates are corrected by the long correctBasedOnTimeZone(long) method. Inside this method there is a TimeZone.getDefault() As i live in São Paulo - Brazil, this method will return the "America/Sao_Paulo" timezone. Also, as we are in summer, we are on daylight saving mode. Anyway, this means that the test is dependent on the infrastructure it runs, what is generally a bad thing. I tried changing TimeZone.getDefault() to TimeZone.getTimeZone("GMT"), but that did not fix the issue. Needs more investigation On Fri, Dec 21, 2012 at 2:10 PM, Bruno Penteado <polaco@gmail.com> wrote:
I am trying to build the v1.0.9 of the project to make a hot fix for the issue LOGBACK-782 on my fork while v_1.0.10 is not released yet:
git clone https://github.com/qos-ch/logback.git cd logback git checkout v_1.0.9 mvn clean test
Im getting tests failures on the core module: testDay(ch.qos.logback.core.util.TimeUtilTest): expected:<1164078000000> but was:<1164074400000> testWeek(ch.qos.logback.core.util.TimeUtilTest): expected:<1164596400000> but was:<1164592800000> testMonth(ch.qos.logback.core.util.TimeUtilTest): expected:<1164942000000> but was:<1164938400000>
testVaryingNumberOfDailyPeriods(ch.qos.logback.core.rolling.helper.RollingCalendarTest): p=13 expected:<1224381600000> but was:<1224385200000>
If it is relevant, I am running the project on a mac
If this is not a know issue and need more information, let me know
Thanks, Bruno "Polaco"
participants (1)
-
Bruno Penteado