[qos-ch/logback] 9300fe: Removes redundant and forever dangling connection

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 9300fe3c1b02110072ba13104bef3f217bc9af85 https://github.com/qos-ch/logback/commit/9300fe3c1b02110072ba13104bef3f217bc... Author: Thomas Hallgren <thomas@tada.se> Date: 2013-05-26 (Sun, 26 May 2013) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/db/DataSourceConnectionSource.java Log Message: ----------- Removes redundant and forever dangling connection The DataSourceConnectionSource.start() method opens a new connection only to determine whether or not the discoverConnectionProperties() should be called. This is unnecessary since that method will perform the same check and issue a very similar warning. A more serious problem is that the connection is never closed. This commit removes the use of this extra connection completely. I think this is the last issue in need of a fix before LOGBACK-376 can be closed. Commit: e300fdee24fcfe32e1162480daec9342db7357c0 https://github.com/qos-ch/logback/commit/e300fdee24fcfe32e1162480daec9342db7... Author: Tony Trinh <tony19@gmail.com> Date: 2013-08-31 (Sat, 31 Aug 2013) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/db/DataSourceConnectionSource.java Log Message: ----------- Merge pull request #128 from thallgren/LOGBACK-376 Removes redundant and forever dangling connection Compare: https://github.com/qos-ch/logback/compare/9da0eb953be9...e300fdee24fc
participants (1)
-
Tony Trinh