[JIRA] Created: (LBCLASSIC-177) Provide an appender similar to log4js AsyncAppender
Provide an appender similar to log4js AsyncAppender --------------------------------------------------- Key: LBCLASSIC-177 URL: http://jira.qos.ch/browse/LBCLASSIC-177 Project: logback-classic Issue Type: New Feature Components: appender Affects Versions: unspecified Reporter: Torsten Juergeleit Assignee: Logback dev list We're using log4j successfully in financial B2B / B2C web applications for years. Now we would like to adopt Logback but therefore we need support for an asynchronous appender decorator like log4js AsyncAppender. Attached you can find my take on this kind of appender cobbled together from ideas and code from various places: * http://logging.apache.org/log4j/1.2/xref/org/apache/log4j/AsyncAppender.html * http://jira.qos.ch/browse/LBCLASSIC-20 * http://jira.qos.ch/browse/LBCLASSIC-176 * http://www.simonsite.org.uk/ -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[ http://jira.qos.ch/browse/LBCLASSIC-177?page=com.atlassian.jira.plugin.syste... ] Torsten Juergeleit updated LBCLASSIC-177: ----------------------------------------- Attachment: AsyncAppenderInitializationTest.java AsyncAppender_logback-test.xml Attached initialization test
Provide an appender similar to log4js AsyncAppender ---------------------------------------------------
Key: LBCLASSIC-177 URL: http://jira.qos.ch/browse/LBCLASSIC-177 Project: logback-classic Issue Type: New Feature Components: appender Affects Versions: unspecified Reporter: Torsten Juergeleit Assignee: Logback dev list Attachments: AsyncAppender.java, AsyncAppender_logback-test.xml, AsyncAppenderInitializationTest.java, AsyncAppenderTest.java
We're using log4j successfully in financial B2B / B2C web applications for years. Now we would like to adopt Logback but therefore we need support for an asynchronous appender decorator like log4js AsyncAppender. Attached you can find my take on this kind of appender cobbled together from ideas and code from various places: * http://logging.apache.org/log4j/1.2/xref/org/apache/log4j/AsyncAppender.html * http://jira.qos.ch/browse/LBCLASSIC-20 * http://jira.qos.ch/browse/LBCLASSIC-176 * http://www.simonsite.org.uk/
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[ http://jira.qos.ch/browse/LBCLASSIC-177?page=com.atlassian.jira.plugin.syste... ] Torsten Juergeleit updated LBCLASSIC-177: ----------------------------------------- Attachment: AsyncAppender.java AsyncAppenderTest.java Attached implementation and test
Provide an appender similar to log4js AsyncAppender ---------------------------------------------------
Key: LBCLASSIC-177 URL: http://jira.qos.ch/browse/LBCLASSIC-177 Project: logback-classic Issue Type: New Feature Components: appender Affects Versions: unspecified Reporter: Torsten Juergeleit Assignee: Logback dev list Attachments: AsyncAppender.java, AsyncAppender_logback-test.xml, AsyncAppenderInitializationTest.java, AsyncAppenderTest.java
We're using log4j successfully in financial B2B / B2C web applications for years. Now we would like to adopt Logback but therefore we need support for an asynchronous appender decorator like log4js AsyncAppender. Attached you can find my take on this kind of appender cobbled together from ideas and code from various places: * http://logging.apache.org/log4j/1.2/xref/org/apache/log4j/AsyncAppender.html * http://jira.qos.ch/browse/LBCLASSIC-20 * http://jira.qos.ch/browse/LBCLASSIC-176 * http://www.simonsite.org.uk/
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[ http://jira.qos.ch/browse/LBCLASSIC-177?page=com.atlassian.jira.plugin.syste... ] Torsten Juergeleit commented on LBCLASSIC-177: ---------------------------------------------- Ups, I missed a place where I borrowed from: * http://jira.qos.ch/browse/LBCORE-92
Provide an appender similar to log4js AsyncAppender ---------------------------------------------------
Key: LBCLASSIC-177 URL: http://jira.qos.ch/browse/LBCLASSIC-177 Project: logback-classic Issue Type: New Feature Components: appender Affects Versions: unspecified Reporter: Torsten Juergeleit Assignee: Logback dev list Attachments: AsyncAppender.java, AsyncAppender_logback-test.xml, AsyncAppenderInitializationTest.java, AsyncAppenderTest.java
We're using log4j successfully in financial B2B / B2C web applications for years. Now we would like to adopt Logback but therefore we need support for an asynchronous appender decorator like log4js AsyncAppender. Attached you can find my take on this kind of appender cobbled together from ideas and code from various places: * http://logging.apache.org/log4j/1.2/xref/org/apache/log4j/AsyncAppender.html * http://jira.qos.ch/browse/LBCLASSIC-20 * http://jira.qos.ch/browse/LBCLASSIC-176 * http://www.simonsite.org.uk/
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[ http://jira.qos.ch/browse/LBCLASSIC-177?page=com.atlassian.jira.plugin.syste... ] Torsten Juergeleit edited comment on LBCLASSIC-177 at 1/2/10 12:26 AM: ----------------------------------------------------------------------- Ups, I missed a place where I borrowed from: * LBCORE-92 was (Author: tjuerge): Ups, I missed a place where I borrowed from: * http://jira.qos.ch/browse/LBCORE-92
Provide an appender similar to log4js AsyncAppender ---------------------------------------------------
Key: LBCLASSIC-177 URL: http://jira.qos.ch/browse/LBCLASSIC-177 Project: logback-classic Issue Type: New Feature Components: appender Affects Versions: unspecified Reporter: Torsten Juergeleit Assignee: Logback dev list Attachments: AsyncAppender.java, AsyncAppender_logback-test.xml, AsyncAppenderInitializationTest.java, AsyncAppenderTest.java
We're using log4j successfully in financial B2B / B2C web applications for years. Now we would like to adopt Logback but therefore we need support for an asynchronous appender decorator like log4js AsyncAppender. Attached you can find my take on this kind of appender cobbled together from ideas and code from various places: * http://logging.apache.org/log4j/1.2/xref/org/apache/log4j/AsyncAppender.html * http://jira.qos.ch/browse/LBCLASSIC-20 * http://jira.qos.ch/browse/LBCLASSIC-176 * http://www.simonsite.org.uk/
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[ http://jira.qos.ch/browse/LBCLASSIC-177?page=com.atlassian.jira.plugin.syste... ] Torsten Juergeleit commented on LBCLASSIC-177: ---------------------------------------------- This appender could be moved to logback-core (and therefore used with logback-access as well) if the interface with the method prepareForDeferredProcessing() would be available in logback-core as suggested in LBCORE-132.
Provide an appender similar to log4js AsyncAppender ---------------------------------------------------
Key: LBCLASSIC-177 URL: http://jira.qos.ch/browse/LBCLASSIC-177 Project: logback-classic Issue Type: New Feature Components: appender Affects Versions: unspecified Reporter: Torsten Juergeleit Assignee: Logback dev list Attachments: AsyncAppender.java, AsyncAppender_logback-test.xml, AsyncAppenderInitializationTest.java, AsyncAppenderTest.java
We're using log4j successfully in financial B2B / B2C web applications for years. Now we would like to adopt Logback but therefore we need support for an asynchronous appender decorator like log4js AsyncAppender. Attached you can find my take on this kind of appender cobbled together from ideas and code from various places: * http://logging.apache.org/log4j/1.2/xref/org/apache/log4j/AsyncAppender.html * http://jira.qos.ch/browse/LBCLASSIC-20 * http://jira.qos.ch/browse/LBCLASSIC-176 * http://www.simonsite.org.uk/
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[ http://jira.qos.ch/browse/LBCLASSIC-177?page=com.atlassian.jira.plugin.syste... ] Gordon Sims updated LBCLASSIC-177: ---------------------------------- Attachment: 0001-Addition-of-AsyncAppender-class-and-tests.patch Posting on behalf of colleague Derek Libby. This is what we use at ITA Software. Derek's comments: The only real difference between the attached patch and the files submitted original to LBCLASSIC-177 is the addition of the blockWhenFull parameter which as its name implies instructs the appender to either block when the BlockingQueue reaches the queueCapacity paramter, or to simply drop messages on the floor. I also modfied the AsyncAppenderInitializationTest.java file to more closely match other initilization tests I found in the logback classic project.
Provide an appender similar to log4js AsyncAppender ---------------------------------------------------
Key: LBCLASSIC-177 URL: http://jira.qos.ch/browse/LBCLASSIC-177 Project: logback-classic Issue Type: New Feature Components: appender Affects Versions: unspecified Reporter: Torsten Juergeleit Assignee: Logback dev list Attachments: 0001-Addition-of-AsyncAppender-class-and-tests.patch, AsyncAppender.java, AsyncAppender_logback-test.xml, AsyncAppenderInitializationTest.java, AsyncAppenderTest.java
We're using log4j successfully in financial B2B / B2C web applications for years. Now we would like to adopt Logback but therefore we need support for an asynchronous appender decorator like log4js AsyncAppender. Attached you can find my take on this kind of appender cobbled together from ideas and code from various places: * http://logging.apache.org/log4j/1.2/xref/org/apache/log4j/AsyncAppender.html * http://jira.qos.ch/browse/LBCLASSIC-20 * http://jira.qos.ch/browse/LBCLASSIC-176 * http://www.simonsite.org.uk/
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[ http://jira.qos.ch/browse/LBCLASSIC-177?page=com.atlassian.jira.plugin.syste... ] Gordon Sims commented on LBCLASSIC-177: --------------------------------------- attached 0001-Addition-of-AsyncAppender-class-and-tests.patch
Provide an appender similar to log4js AsyncAppender ---------------------------------------------------
Key: LBCLASSIC-177 URL: http://jira.qos.ch/browse/LBCLASSIC-177 Project: logback-classic Issue Type: New Feature Components: appender Affects Versions: unspecified Reporter: Torsten Juergeleit Assignee: Logback dev list Attachments: 0001-Addition-of-AsyncAppender-class-and-tests.patch, AsyncAppender.java, AsyncAppender_logback-test.xml, AsyncAppenderInitializationTest.java, AsyncAppenderTest.java
We're using log4j successfully in financial B2B / B2C web applications for years. Now we would like to adopt Logback but therefore we need support for an asynchronous appender decorator like log4js AsyncAppender. Attached you can find my take on this kind of appender cobbled together from ideas and code from various places: * http://logging.apache.org/log4j/1.2/xref/org/apache/log4j/AsyncAppender.html * http://jira.qos.ch/browse/LBCLASSIC-20 * http://jira.qos.ch/browse/LBCLASSIC-176 * http://www.simonsite.org.uk/
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[ http://jira.qos.ch/browse/LBCLASSIC-177?page=com.atlassian.jira.plugin.syste... ] yair ogen commented on LBCLASSIC-177: ------------------------------------- Is this appender going to be officially included in logback classic any time soon?
Provide an appender similar to log4js AsyncAppender ---------------------------------------------------
Key: LBCLASSIC-177 URL: http://jira.qos.ch/browse/LBCLASSIC-177 Project: logback-classic Issue Type: New Feature Components: appender Affects Versions: unspecified Reporter: Torsten Juergeleit Assignee: Logback dev list Attachments: 0001-Addition-of-AsyncAppender-class-and-tests.patch, AsyncAppender.java, AsyncAppender_logback-test.xml, AsyncAppenderInitializationTest.java, AsyncAppenderTest.java
We're using log4j successfully in financial B2B / B2C web applications for years. Now we would like to adopt Logback but therefore we need support for an asynchronous appender decorator like log4js AsyncAppender. Attached you can find my take on this kind of appender cobbled together from ideas and code from various places: * http://logging.apache.org/log4j/1.2/xref/org/apache/log4j/AsyncAppender.html * http://jira.qos.ch/browse/LBCLASSIC-20 * http://jira.qos.ch/browse/LBCLASSIC-176 * http://www.simonsite.org.uk/
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[ http://jira.qos.ch/browse/LBCLASSIC-177?page=com.atlassian.jira.plugin.syste... ] Borislav Andruschuk commented on LBCLASSIC-177: ----------------------------------------------- I've reviewed patch and found the piece of code that's not thread safe. Look at exceptionRepeatCount variable in appender, It can be modified from several threads without exclusive access in append method - you got race condition in this place. Variable should be just converted from class field to method local variable.
Provide an appender similar to log4js AsyncAppender ---------------------------------------------------
Key: LBCLASSIC-177 URL: http://jira.qos.ch/browse/LBCLASSIC-177 Project: logback-classic Issue Type: New Feature Components: appender Affects Versions: unspecified Reporter: Torsten Juergeleit Assignee: Logback dev list Attachments: 0001-Addition-of-AsyncAppender-class-and-tests.patch, AsyncAppender.java, AsyncAppender_logback-test.xml, AsyncAppenderInitializationTest.java, AsyncAppenderTest.java
We're using log4j successfully in financial B2B / B2C web applications for years. Now we would like to adopt Logback but therefore we need support for an asynchronous appender decorator like log4js AsyncAppender. Attached you can find my take on this kind of appender cobbled together from ideas and code from various places: * http://logging.apache.org/log4j/1.2/xref/org/apache/log4j/AsyncAppender.html * http://jira.qos.ch/browse/LBCLASSIC-20 * http://jira.qos.ch/browse/LBCLASSIC-176 * http://www.simonsite.org.uk/
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
participants (5)
-
Borislav Andruschuk (JIRA) -
Ceki Gulcu (JIRA)
-
Gordon Sims (JIRA)
-
Torsten Juergeleit (JIRA)
-
yair ogen (JIRA)