Another unit test failure - TimeBasedRollingWithArchiveRemovalTe

I have no idea what is going on here. I know my machine is a lot faster than yours but having these unit tests randomly fail is very annoying. ------------------------------------------------------------------------------- Test set: ch.qos.logback.core.rolling.TimeBasedRollingWithArchiveRemovalTest ------------------------------------------------------------------------------- Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.411 sec <<< FAILURE! montlyRollover (ch.qos.logback.core.rolling.TimeBasedRollingWithArchiveRemovalTest) Time elapsed: 0.114 sec montlyRolloverOverManyPeriods (ch.qos.logback.core.rolling.TimeBasedRollingWithArchiveRemovalTest) Time elapsed: 0.253 sec dailyRollover (ch.qos.logback.core.rolling.TimeBasedRollingWithArchiveRemovalTest) Time elapsed: 0.058 sec dailyCronologRollover (ch.qos.logback.core.rolling.TimeBasedRollingWithArchiveRemovalTest) Time elapsed: 0.108 sec dailySizeBasedRollover (ch.qos.logback.core.rolling.TimeBasedRollingWithArchiveRemovalTest) Time elapsed: 0.454 sec dailyChronologSizeBasedRollover (ch.qos.logback.core.rolling.TimeBasedRollingWithArchiveRemovalTest) Time elapsed: 0.417 sec <<< ERROR! java.util.concurrent.TimeoutException at java.util.concurrent.FutureTask$Sync.innerGet (FutureTask.java:228) at java.util.concurrent.FutureTask.get(FutureTask.java:91) at ch.qos.logback.core.rolling.TimeBasedRollingWithArchiveRemovalTest.doRollover (TimeBasedRollingWithArchiveRemovalTest.java:194) at ch.qos.logback.core.rolling.TimeBasedRollingWithArchiveRemovalTest.dailyChronologSizeBasedRollover (TimeBasedRollingWithArchiveRemovalTest.java:157) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.internal.runners.TestMethod.invoke (TestMethod.java:59) at org.junit.internal.runners.MethodRoadie.runTestMethod (MethodRoadie.java:98) at org.junit.internal.runners.MethodRoadie$2.run (MethodRoadie.java:79) at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters (MethodRoadie.java:87) at org.junit.internal.runners.MethodRoadie.runTest (MethodRoadie.java:77) at org.junit.internal.runners.MethodRoadie.run (MethodRoadie.java:42) at org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod (JUnit4ClassRunner.java:88) at org.junit.internal.runners.JUnit4ClassRunner.runMethods (JUnit4ClassRunner.java:51) at org.junit.internal.runners.JUnit4ClassRunner$1.run (JUnit4ClassRunner.java:44) at org.junit.internal.runners.ClassRoadie.runUnprotected (ClassRoadie.java:27) at org.junit.internal.runners.ClassRoadie.runProtected (ClassRoadie.java:37) at org.junit.internal.runners.JUnit4ClassRunner.run (JUnit4ClassRunner.java:42) at org.apache.maven.surefire.junit4.JUnit4TestSet.execute (JUnit4TestSet.java:62) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet (AbstractDirectoryTestSuite.java:140) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute (AbstractDirectoryTestSuite.java:127) at org.apache.maven.surefire.Surefire.run(Surefire.java:177) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess (SurefireBooter.java:338) at org.apache.maven.surefire.booter.SurefireBooter.main (SurefireBooter.java:997)

Ralph Goers skrev:
I have no idea what is going on here. I know my machine is a lot faster than yours but having these unit tests randomly fail is very annoying.
I've seen the same causing mvn install to fail. It would be really nice if the tests based on time were non-fatal, or a separate test suite. -- Thorbjørn Ravn Andersen "...plus... Tubular Bells!"

Thorbjoern Ravn Andersen wrote:
Ralph Goers skrev:
I have no idea what is going on here. I know my machine is a lot faster than yours but having these unit tests randomly fail is very annoying.
I've seen the same causing mvn install to fail. It would be really nice if the tests based on time were non-fatal, or a separate test suite.
That's an approach TestNG would allow. Another approach would be to fix the tests so that they always succeed but that's admittedly easier said than done. I'd like to pursue the second alternative, the first one being essentially a cop out. -- Ceki Gülcü Logback: The reliable, generic, fast and flexible logging framework for Java. http://logback.qos.ch

Ralph Goers wrote:
I have no idea what is going on here. I know my machine is a lot faster than yours but having these unit tests randomly fail is very annoying.
I agree. I am equally annoyed by these failures. As for TimeBasedRollingWithArchiveRemovalTest, it is a complicated beast. In the meant time I suggest that you open a bug report for every test that fails. I'll look into each separately. Better yet, set them as sub-tasks of http://jira.qos.ch/browse/LBGENERAL-31 I apologize for the inconvenience.
-------------------------------------------------------------------------------
Test set: ch.qos.logback.core.rolling.TimeBasedRollingWithArchiveRemovalTest ------------------------------------------------------------------------------- -- Ceki Gülcü Logback: The reliable, generic, fast and flexible logging framework for Java. http://logback.qos.ch
participants (3)
-
Ceki Gulcu
-
Ralph Goers
-
Thorbjoern Ravn Andersen