Missing file from Git?
I may have missed something, but I recently forked ceki/logback on github and it seems to be missing GafferConfigurator? It's referenced in the code, but not in the git source. Judging by the number of classes in that package (6 - http://logback.qos.ch/apidocs/ch/qos/logback/classic/gaffer/package-summary....) and the number of files in git (1 - https://github.com/ceki/logback/tree/master/logback-classic/src/main/java/ch...) there could be as many as five files missing. I could always grab the source release, add them to my fork, and issue a pull request, but I suspect it's probably easier to simply add/commit the files that you probably already have. Greg
Ceki, Did you ever get a chance to look at this? Are the files missing from git, or have I missed something larger? Thanks, Greg On 29 September 2011 02:52, Greg Thomas <greg.d.thomas@gmail.com> wrote:
I may have missed something, but I recently forked ceki/logback on github and it seems to be missing GafferConfigurator?
It's referenced in the code, but not in the git source. Judging by the number of classes in that package (6 - http://logback.qos.ch/apidocs/ch/qos/logback/classic/gaffer/package-summary....) and the number of files in git (1 - https://github.com/ceki/logback/tree/master/logback-classic/src/main/java/ch...) there could be as many as five files missing.
I could always grab the source release, add them to my fork, and issue a pull request, but I suspect it's probably easier to simply add/commit the files that you probably already have.
Greg
GafferConfigurator is written in Groovy. Files ending in STest are tests written in Scaala. You have to either build logback from the command line using mvn, and then import the project into Eclipse, or use IntelliJ IDEA. I am currently working on getting logback to build from after projet clean from within Eclipse with unreproducible success thus far. On 28/10/2011 8:56 PM, Greg Thomas wrote:
Ceki,
Did you ever get a chance to look at this? Are the files missing from git, or have I missed something larger?
Thanks,
Greg
On 29 September 2011 02:52, Greg Thomas<greg.d.thomas@gmail.com> wrote:
I may have missed something, but I recently forked ceki/logback on github and it seems to be missing GafferConfigurator?
It's referenced in the code, but not in the git source. Judging by the number of classes in that package (6 - http://logback.qos.ch/apidocs/ch/qos/logback/classic/gaffer/package-summary....) and the number of files in git (1 - https://github.com/ceki/logback/tree/master/logback-classic/src/main/java/ch...) there could be as many as five files missing.
I could always grab the source release, add them to my fork, and issue a pull request, but I suspect it's probably easier to simply add/commit the files that you probably already have.
Greg
-- Ceki http://twitter.com/#!/ceki
On 28 October 2011 20:24, ceki <ceki@qos.ch> wrote:
GafferConfigurator is written in Groovy. Files ending in STest are tests written in Scaala. You have to either build logback from the command line using mvn, and then import the project into Eclipse, or use IntelliJ IDEA.
You know, I'd seen that thread, but somehow managed to entirely miss the connection with my own problems. I'll give your latest instructions a go, and see how I get on, Apologies, Greg
On 29/10/2011 1:51 PM, Greg Thomas wrote:
On 28 October 2011 20:24, ceki<ceki@qos.ch> wrote:
GafferConfigurator is written in Groovy. Files ending in STest are tests written in Scaala. You have to either build logback from the command line using mvn, and then import the project into Eclipse, or use IntelliJ IDEA.
You know, I'd seen that thread, but somehow managed to entirely miss the connection with my own problems. I'll give your latest instructions a go, and see how I get on,
Just to be sure, here are the step by step instructions on building logback with Eclipse. It ain't pretty but it seem to work: http://mailman.qos.ch/pipermail/logback-dev/2011-October/006752.html
Apologies,
Sure, no worries. -- Ceki http://twitter.com/#!/ceki
participants (2)
-
ceki -
Greg Thomas