[JIRA] Created: (LBCLASSIC-72) Please implement a getter for StackTraceElementProxy.ste
Please implement a getter for StackTraceElementProxy.ste -------------------------------------------------------- Key: LBCLASSIC-72 URL: http://jira.qos.ch/browse/LBCLASSIC-72 Project: logback-classic Issue Type: Improvement Reporter: Joern Huxhorn Assignee: Logback dev list I just checked out your latest changes concerning package version information because I have to implement it for Lilith when the next version of Logback is released. At the moment StackTraceElementProxy does not have a getter for the contained StackTraceElement. It would be really helpful for me if I could access it. Otherwise I'd have to parse it from steAsString which I'd really like to prevent. I'd suggest to implement both a getter and a setter for the StackTraceElement. steAsString would need to be set to null if the STE is changed. Additionally, I'd suggest to make steAsString transient since it can be restored after deserialization. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[ http://jira.qos.ch/browse/LBCLASSIC-72?page=com.atlassian.jira.plugin.system... ] Joern Huxhorn commented on LBCLASSIC-72: ---------------------------------------- I'd really appreciate if you could implement this... there shouldn't be a downside, I think. Also, StackTraceElementProxy currently has the methods void setPackageInfo(ClassPackagingData cpd) { this.cpd = cpd; } public ClassPackagingData getClassPackagingData() { return cpd; } those should be changed into something symmetrical, e.g. set/getClassPackagingData. As I said before, I really applaud this change in general and you'd really help me a lot (read: improve Lilith performance / remove an additional setAccessible(true) from my code). Thanks, Joern.
Please implement a getter for StackTraceElementProxy.ste --------------------------------------------------------
Key: LBCLASSIC-72 URL: http://jira.qos.ch/browse/LBCLASSIC-72 Project: logback-classic Issue Type: Improvement Reporter: Joern Huxhorn Assignee: Logback dev list
I just checked out your latest changes concerning package version information because I have to implement it for Lilith when the next version of Logback is released. At the moment StackTraceElementProxy does not have a getter for the contained StackTraceElement. It would be really helpful for me if I could access it. Otherwise I'd have to parse it from steAsString which I'd really like to prevent. I'd suggest to implement both a getter and a setter for the StackTraceElement. steAsString would need to be set to null if the STE is changed. Additionally, I'd suggest to make steAsString transient since it can be restored after deserialization.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[ http://jira.qos.ch/browse/LBCLASSIC-72?page=com.atlassian.jira.plugin.system... ] Joern Huxhorn commented on LBCLASSIC-72: ---------------------------------------- I need the Throwable structure intact because I'd like to be able to decide - on the fly - how they are displayed. I need several different representations for different cases, e.g. the Throwable column in the table view of Lilith, the detailsView of the message (which is fully customizable by the user himself if he wants to do the work and knows some Groovy) or the IDEA (or, more generally, IDE) integration feature that jumps to the line of code if the link is clicked in the detailsView. All those expect an ordinary StackTraceElement. My latest version uses an ExtendedStackTraceElement that contains your additional location infos but is also easily tranformed back into a simple StackTraceElement again for transmission to the IDE of choice. Well, that's the reason why I'd really appreciate to be able to access the unformatted raw information. Otherwise I'm forced to parse the created String. I also desperately need the infos because of the XML structure used to transfer the events in a java-independent manner. I plan to also be able to receive LoggingEvents from Flash and C# using just that XML structure. Regards, Joern.
Please implement a getter for StackTraceElementProxy.ste --------------------------------------------------------
Key: LBCLASSIC-72 URL: http://jira.qos.ch/browse/LBCLASSIC-72 Project: logback-classic Issue Type: Improvement Reporter: Joern Huxhorn Assignee: Logback dev list
I just checked out your latest changes concerning package version information because I have to implement it for Lilith when the next version of Logback is released. At the moment StackTraceElementProxy does not have a getter for the contained StackTraceElement. It would be really helpful for me if I could access it. Otherwise I'd have to parse it from steAsString which I'd really like to prevent. I'd suggest to implement both a getter and a setter for the StackTraceElement. steAsString would need to be set to null if the STE is changed. Additionally, I'd suggest to make steAsString transient since it can be restored after deserialization.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[ http://jira.qos.ch/browse/LBCLASSIC-72?page=com.atlassian.jira.plugin.system... ] Joern Huxhorn commented on LBCLASSIC-72: ---------------------------------------- Ok, my comments are a bit mixed right now. The comments above about Throwable should be in LBCLASSIC-46 while my explanation why I need access to the unformatted, raw StackTraceElement data is at the right place right here. Should I copy my above comment over? Sorry but I somehow expected that StackTraceElementProxy would be used in ThrowableProxy as a Throwable does contain StackTraceElements. That caused the mix-up.
Please implement a getter for StackTraceElementProxy.ste --------------------------------------------------------
Key: LBCLASSIC-72 URL: http://jira.qos.ch/browse/LBCLASSIC-72 Project: logback-classic Issue Type: Improvement Reporter: Joern Huxhorn Assignee: Logback dev list
I just checked out your latest changes concerning package version information because I have to implement it for Lilith when the next version of Logback is released. At the moment StackTraceElementProxy does not have a getter for the contained StackTraceElement. It would be really helpful for me if I could access it. Otherwise I'd have to parse it from steAsString which I'd really like to prevent. I'd suggest to implement both a getter and a setter for the StackTraceElement. steAsString would need to be set to null if the STE is changed. Additionally, I'd suggest to make steAsString transient since it can be restored after deserialization.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[ http://jira.qos.ch/browse/LBCLASSIC-72?page=com.atlassian.jira.plugin.system... ] Ceki Gulcu commented on LBCLASSIC-72: ------------------------------------- I just added a getter for StackTraceElement in StackTraceElementProxy. The setter for StackTraceElement is a different matter because the code relies on the fact that the underlying StackTraceElement is immutable. In StackTraceElementProxy, the getter and the setter for ClassPackagingData are now named consistently. The steAsString field has been marked as transient. If there is nothing else, I'd like to mark this issue as resolved.
Please implement a getter for StackTraceElementProxy.ste --------------------------------------------------------
Key: LBCLASSIC-72 URL: http://jira.qos.ch/browse/LBCLASSIC-72 Project: logback-classic Issue Type: Improvement Reporter: Joern Huxhorn Assignee: Ceki Gulcu
I just checked out your latest changes concerning package version information because I have to implement it for Lilith when the next version of Logback is released. At the moment StackTraceElementProxy does not have a getter for the contained StackTraceElement. It would be really helpful for me if I could access it. Otherwise I'd have to parse it from steAsString which I'd really like to prevent. I'd suggest to implement both a getter and a setter for the StackTraceElement. steAsString would need to be set to null if the STE is changed. Additionally, I'd suggest to make steAsString transient since it can be restored after deserialization.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[ http://jira.qos.ch/browse/LBCLASSIC-72?page=com.atlassian.jira.plugin.system... ] Joern Huxhorn commented on LBCLASSIC-72: ---------------------------------------- I'm absolutely fine with your change, thank you very much! I personally tend to keep my datatypes mutable because there is no way to absolutely ensure that the data isn't changed anyway. Instead, I make sure that "the correct thing" is happening when data is changed, i.e. I'd null steAsString in case of setSTE... but that is just a personal preference, I don't need the setter myself.
Please implement a getter for StackTraceElementProxy.ste --------------------------------------------------------
Key: LBCLASSIC-72 URL: http://jira.qos.ch/browse/LBCLASSIC-72 Project: logback-classic Issue Type: Improvement Reporter: Joern Huxhorn Assignee: Ceki Gulcu
I just checked out your latest changes concerning package version information because I have to implement it for Lilith when the next version of Logback is released. At the moment StackTraceElementProxy does not have a getter for the contained StackTraceElement. It would be really helpful for me if I could access it. Otherwise I'd have to parse it from steAsString which I'd really like to prevent. I'd suggest to implement both a getter and a setter for the StackTraceElement. steAsString would need to be set to null if the STE is changed. Additionally, I'd suggest to make steAsString transient since it can be restored after deserialization.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[ http://jira.qos.ch/browse/LBCLASSIC-72?page=com.atlassian.jira.plugin.system... ] Ceki Gulcu resolved LBCLASSIC-72. --------------------------------- Fix Version/s: 0.9.12 Resolution: Fixed
Please implement a getter for StackTraceElementProxy.ste --------------------------------------------------------
Key: LBCLASSIC-72 URL: http://jira.qos.ch/browse/LBCLASSIC-72 Project: logback-classic Issue Type: Improvement Reporter: Joern Huxhorn Assignee: Ceki Gulcu Fix For: 0.9.12
I just checked out your latest changes concerning package version information because I have to implement it for Lilith when the next version of Logback is released. At the moment StackTraceElementProxy does not have a getter for the contained StackTraceElement. It would be really helpful for me if I could access it. Otherwise I'd have to parse it from steAsString which I'd really like to prevent. I'd suggest to implement both a getter and a setter for the StackTraceElement. steAsString would need to be set to null if the STE is changed. Additionally, I'd suggest to make steAsString transient since it can be restored after deserialization.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
participants (2)
-
Ceki Gulcu (JIRA) -
Joern Huxhorn (JIRA)