[ http://jira.qos.ch/browse/LBCORE-98?page=com.atlassian.jira.plugin.system.is... ] Anders Wallgren commented on LBCORE-98: --------------------------------------- Based on this code: boolean rolloverTargetIsParentFile() { return (getParentsRawFileProperty() != null && getParentsRawFileProperty() .equals(elapsedPeriodsFileName)); } public void rollover() throws RolloverFailure { // when rollover is called the elapsed period's file has // been already closed. This is a working assumption of this method. if(compressionMode == CompressionMode.NONE) { if (getParentsRawFileProperty() != null) { util.rename(getParentsRawFileProperty(), elapsedPeriodsFileName); } } else { if(getParentsRawFileProperty() == null) { doCompression(false, elapsedPeriodsFileName, elapsedPeriodsFileName); } else { doCompression(true, elapsedPeriodsFileName, elapsedPeriodsFileName); } } if (tbCleaner != null) { tbCleaner.clean(new Date(getCurrentTime())); } } and the fact that rolloverTargetIsParentFile is unused, it looks like the intent may have been to only archive the tempfile if the target and parent file names collide.

TimeBasedRollingPolicy: name of file in zip archive is <FileNamePattern>.nanos.tmp ----------------------------------------------------------------------------------

Key: LBCORE-98 URL: http://jira.qos.ch/browse/LBCORE-98 Project: logback-core Issue Type: Bug Components: Rolling Affects Versions: 0.9.15 Environment: Windows Reporter: Anders Wallgren Assignee: Logback dev list Priority: Minor

The name of the filename in the zip archive is a temp filename, based on the FileNamePattern, no the FileNamePattern itself.

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBCORE-98?page=com.atlassian.jira.plugin.system.is... ] Anders Wallgren updated LBCORE-98: ---------------------------------- Attachment: LBCORE-98.patch A slightly different patch, based on 0.9.17. Patch ch.qos.logback.core.rolling.helper.Compressor to use the name of the archive, minus ".zip" as the name of the zip entry, rather than the .tmp file.

TimeBasedRollingPolicy: name of file in zip archive is <FileNamePattern>.nanos.tmp ----------------------------------------------------------------------------------

Key: LBCORE-98 URL: http://jira.qos.ch/browse/LBCORE-98 Project: logback-core Issue Type: Bug Components: Rolling Affects Versions: 0.9.15 Environment: Windows Reporter: Anders Wallgren Assignee: Logback dev list Priority: Minor Attachments: LBCORE-98.patch, LBCORE-98.patch

The name of the filename in the zip archive is a temp filename, based on the FileNamePattern, no the FileNamePattern itself.

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira