[Bug 104] New: Copy/Paste errors in Logger. TurboFilter probably not working correctly.
http://bugzilla.qos.ch/show_bug.cgi?id=104 Summary: Copy/Paste errors in Logger. TurboFilter probably not working correctly. Product: logback-classic Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P1 Component: Other AssignedTo: logback-dev@qos.ch ReportedBy: joern@huxhorn.de I just found 4 copy-paste mistakes. - trace(String msg, Throwable t) is calling isDebugEnabled instead of isTraceEnabled. - loggerContext.getTurboFilterChainDecision is receiving Level.DEBUG instead of 'level' variable. Please see attached patch. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
http://bugzilla.qos.ch/show_bug.cgi?id=104 ------- Comment #1 from joern@huxhorn.de 2007-10-05 20:18 ------- Created an attachment (id=9) --> (http://bugzilla.qos.ch/attachment.cgi?id=9&action=view) Patch fixing the described problems. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
http://bugzilla.qos.ch/show_bug.cgi?id=104 noreply.ceki@qos.ch changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Comment #2 from noreply.ceki@qos.ch 2008-01-23 13:28 ------- Hello Joern, Thanks for your patch. I've applied it in revision 1606. See also http://svn.qos.ch/viewvc?view=rev&revision=1606 -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
http://bugzilla.qos.ch/show_bug.cgi?id=104 ------- Comment #3 from joern@huxhorn.de 2008-01-23 16:32 ------- Looks fine. I just think that the "if (isDebugEnabled())" in line 414 isn't necessary if a "if (isTraceEnabled())" isn't necessary in line 390. I thought that this was probably a performance optimization since debug and trace is called more often than info, warn and error... I wasn't sure so I just changed it to isTrace instead of isDebug. Am I supposed to close this bug? I don't have a testcase but reviewed the changes. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
http://bugzilla.qos.ch/show_bug.cgi?id=104 ------- Comment #4 from noreply.ceki@qos.ch 2008-01-25 12:35 ------- Joern, I agree with your remark about line 414. Just committed a fix reflecting on this. If the fix looks good to you, you can mark this report as "VERIFIED". Thank you for your comments helping logback to improve. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
http://bugzilla.qos.ch/show_bug.cgi?id=104 joern@huxhorn.de changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
participants (1)
-
bugzilla-daemon＠pixie.qos.ch