Hi, I think ceki has said that the next release will be 2.0. Once you have your branch ready, got onto git hub website, view the branch, and click a button to create a pull request. That is the best way to contribute your changes back. Thanks David On 20 Aug 2013, at 18:28, Leonardo Souza <lsouza@amtera.com.br> wrote:
Hi,
I'm working in a patch to record markers in the logging_event table. The patch is almost done in the master branch, 2.0.0-SNAPSHOT. Should i move to the 1.0.x branch? I'm not sure how to contribute back to the project.
https://github.com/leonardossz/logback
thanks, -- Leonardo S Souza Amtera Semantic Technologies Rua da Quitanda, 194, sala 1201 - Centro Rio de Janeiro - RJ - Brasil Tel: + 55 21 2213 3220 Cel: + 55 21 9877 7081 www.amtera.com.br
2013/6/19 Leonardo Souza <lsouza@amtera.com.br>:
Hi David,
I'm not working in this issue right now but i can help in the near future..
In my environment i ran the tests without forking and got the same results.
$ mvn -Dsurefire.forkCount=0 clean install
Results :
Failed tests: TimeUtilTest.testDay:74 expected:<1164078000000> but was:<1164074400000> TimeUtilTest.testWeek:100 expected:<1164596400000> but was:<1164592800000> TimeUtilTest.testMonth:115 expected:<1164942000000> but was:<1164938400000> RollingCalendarTest.testVaryingNumberOfDailyPeriods:92 p=13 expected:<1224381600000> but was:<1224385200000>
Tests run: 445, Failures: 4, Errors: 0, Skipped: 6
$ mvn -Duser.timezone=CET -Dsurefire.forkCount=0 clean install
Results :
Failed tests: MDCBasedDiscriminatorTest.nullMDC:75 expected:<{}> but was:<{compositeProperty=1778710127, max=1363994495, linger=session2005380814, userId=user3, propertyDefinedWithinSift=1630846478, localProperty=62716588}>
Tests run: 417, Failures: 1, Errors: 0, Skipped: 16
regards,
-- Leonardo S Souza Amtera Semantic Technologies Rua da Quitanda, 194, sala 1201 - Centro Rio de Janeiro - RJ - Brasil Tel: + 55 21 2213 3220 Cel: + 55 21 9877 7081 www.amtera.com.br
2013/6/18 David Roussel <nabble@diroussel.xsmail.com>
Leonardo,
Interesting. Can you see how to fix them? When I've seen timezone unit set failures in the past, it's usually been a bit tricky to fix.
I tried running: $ mvn -Duser.timezone=CET clean install
But the tests still passed. I guess the surefire test forking is getting in the way. But when I set -Dsurefire.forkCount=0 I got other problems.
David
On 17 Jun 2013, at 14:44, Leonardo Souza <lsouza@amtera.com.br> wrote:
Hi David,
Here is my outputs.
$ git show --summary commit 2a73e043e149693fcd0ad2f90b04702c2dba4851 Author: Ceki Gulcu <ceki@qos.ch> Date: Fri Jun 14 11:55:05 2013 +0200
$ javac -version javac 1.6.0_41
$ mvn -version Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.6.0_41, vendor: Sun Microsystems Inc. Java home: /usr/lib/jvm/java-6-sun-1.6.0.41/jre Default locale: pt_BR, platform encoding: UTF-8 OS name: "linux", version: "3.2.0-32-generic", arch: "amd64", family: "unix"
First run:
$ mvn clean install
Results :
Failed tests: TimeUtilTest.testDay:74 expected:<1164078000000> but was:<1164074400000> TimeUtilTest.testWeek:100 expected:<1164596400000> but was:<1164592800000> TimeUtilTest.testMonth:115 expected:<1164942000000> but was:<1164938400000> RollingCalendarTest.testVaryingNumberOfDailyPeriods:92 p=13 expected:<1224381600000> but was:<1224385200000>
Tests run: 445, Failures: 4, Errors: 0, Skipped: 6
Suspecting of some timezone issues. My default timezone is America/Sao_Paulo.
Second run:
$ mvn -Duser.timezone=CET clean install
Results :
Failed tests: MDCBasedDiscriminatorTest.nullMDC:75 expected:<{}> but was:<{compositeProperty=1763803913, max=1559727973, linger=session1424346104, userId=user3, propertyDefinedWithinSift=1694640543, localProperty=848086231}>
Tests run: 417, Failures: 1, Errors: 0, Skipped: 16
I have attached the reported failures.
regards,
-- Leonardo S Souza Amtera Semantic Technologies Rua da Quitanda, 194, sala 1201 - Centro Rio de Janeiro - RJ - Brasil Tel: + 55 21 2213 3220 Cel: + 55 21 9877 7081 www.amtera.com.br
2013/6/16 David Roussel <nabble@diroussel.xsmail.com>
Leonardo,
I just tried a "mvm clean install" on:
commit 2a73e043e149693fcd0ad2f90b04702c2dba4851 Author: Ceki Gulcu <ceki@qos.ch> Date: Fri Jun 14 11:55:05 2013 +0200
It built successfully. I was using Java 1.7.0_17.
What failed for you?
David
On 14 Jun 2013, at 17:49, Leonardo Souza <lsouza@amtera.com.br> wrote:
Hi,
Thanks for the quick reply. I have been busy so sorry for the late answer. The plan is to provide a patch for the DBAppender asap.
I have cloned the repo and issued a mvn clean test, detected some test failures. This is the trunk version (2.0.0-SNAPSHOT), but there's no snapshot version tag to fill a bug in Jira. Can i fill the issue without an affected version?
regards,
-- Leonardo S Souza Amtera Semantic Technologies Rua da Quitanda, 194, sala 1201 - Centro Rio de Janeiro - RJ - Brasil Tel: + 55 21 2213 3220 Cel: + 55 21 9877 7081 www.amtera.com.br
2013/5/31 ceki <ceki@qos.ch>
Hi Leonardo,
Marker information should be part of the data written into the DB. Please create a jira issue for this bug. Better yet, provide a patch to DBAppender by way of a github pull request.
Best regards,
On 31.05.2013 03:34, Leonardo Souza wrote:
Hi,
We have a system with a lot of log statements using markers,
this.logger.info(this.marker, "ex fvmo dare lvcem");
We are planning to store the logs in a database using DBAppender but ther marker do not have a column, only appears in the formatted_message field. We will query this database filtering by the markers, a sql like query is not a desirable solution.
Anyone has a better idea instead of creating a custom appender?
thanks ..
-- Leonardo S Souza
-- Ceki 65% of statistics are made up on the spot _______________________________________________ Logback-user mailing list Logback-user@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-user
_______________________________________________ Logback-user mailing list Logback-user@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-user
_______________________________________________ Logback-user mailing list Logback-user@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-user
<ch.qos.logback.classic.sift.MDCBasedDiscriminatorTest.txt><ch.qos.logback.core.rolling.helper.RollingCalendarTest.txt><ch.qos.logback.core.util.TimeUtilTest.txt>_______________________________________________
Logback-user mailing list Logback-user@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-user
_______________________________________________ Logback-user mailing list Logback-user@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-user
_______________________________________________ Logback-user mailing list Logback-user@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-user