Cheers Ceki! Keep in touch! Regards, Pierre On Thu, Apr 11, 2013 at 5:53 PM, ceki <ceki@qos.ch> wrote:

Hi Pierre,

The repository is at:

https://github.com/ceki/**mistletoe <https://github.com/ceki/mistletoe>

Your github pull request is most welcome. :-)

Cheers,

On 11.04.2013 17:19, Pierre Goupil wrote:

...

Good afternoon,

I can't find the Mistletoe source repository. I'd like to upgrade Mistletoe-Wicket to Wicket 6.0.

Regards,

Pierre GOUPIL

-- Ceki 65% of statistics are made up on the spot ______________________________**_________________ mistletoe mailing list mistletoe@qos.ch http://mailman.qos.ch/mailman/**listinfo/mistletoe<http://mailman.qos.ch/mailman/listinfo/mistletoe>

-- "Parce que c'est la nuit qu'il est beau de croire à la lumière." Edmond Rostand

In the class "MyAttributeModifier", this code is problematic for me: @Override public void onComponentTag(final Component component, final ComponentTag tag) { System.out.println("ononComponentTag called. component="+component+", tag="+tag); if (isEnabled(component)) { System.out.println("changing attribute, value="+value); tag.getAttributes().put(attribute, value); } } What is this construct trying to achieve, please? I don't know this method in Wicket 1.4 and in 6.0 the super class declares it as final! Once I know what's it's for, I'll be able to ask for help to the Wicket mailing-list. Regards, Pierre On Thu, Apr 11, 2013 at 6:59 PM, ceki <ceki@qos.ch> wrote:

I am looking forward for your contribution.

On 11.04.2013 18:38, Pierre Goupil wrote:

...

Cheers Ceki! Keep in touch!

Regards,

Pierre

On Thu, Apr 11, 2013 at 5:53 PM, ceki <ceki@qos.ch <mailto:ceki@qos.ch>>

wrote:

Hi Pierre,

The repository is at:

https://github.com/ceki/__**mistletoe<https://github.com/ceki/__mistletoe><; https://github.com/ceki/**mistletoe <https://github.com/ceki/mistletoe>>

Your github pull request is most welcome. :-)

Cheers,

On 11.04.2013 17:19, Pierre Goupil wrote:

Good afternoon,

I can't find the Mistletoe source repository. I'd like to upgrade Mistletoe-Wicket to Wicket 6.0.

Regards,

Pierre GOUPIL

-- Ceki 65% of statistics are made up on the spot

-- Ceki 65% of statistics are made up on the spot ______________________________**_________________ mistletoe mailing list mistletoe@qos.ch http://mailman.qos.ch/mailman/**listinfo/mistletoe<http://mailman.qos.ch/mailman/listinfo/mistletoe>

-- "Parce que c'est la nuit qu'il est beau de croire à la lumière." Edmond Rostand

Good catch! :-) One more problem left! On Thu, Apr 11, 2013 at 10:36 PM, ceki <ceki@qos.ch> wrote:

I don't think MyAttributeModifier is being used anywhere.

On 11.04.2013 20:40, Pierre Goupil wrote:

...

In the class "MyAttributeModifier", this code is problematic for me:

@Override public void onComponentTag(final Component component, final ComponentTag tag) { System.out.println("**ononComponentTag called. component="+component+", tag="+tag); if (isEnabled(component)) { System.out.println("changing attribute, value="+value); tag.getAttributes().put(**attribute, value); } }

What is this construct trying to achieve, please? I don't know this method in Wicket 1.4 and in 6.0 the super class declares it as final! Once I know what's it's for, I'll be able to ask for help to the Wicket mailing-list.

Regards,

Pierre

On Thu, Apr 11, 2013 at 6:59 PM, ceki <ceki@qos.ch <mailto:ceki@qos.ch>>

wrote:

I am looking forward for your contribution.

On 11.04.2013 18:38, Pierre Goupil wrote:

Cheers Ceki! Keep in touch!

Regards,

Pierre

On Thu, Apr 11, 2013 at 5:53 PM, ceki <ceki@qos.ch <mailto:ceki@qos.ch> <mailto:ceki@qos.ch <mailto:ceki@qos.ch>>>

wrote:

Hi Pierre,

The repository is at:

https://github.com/ceki/____**mistletoe<https://github.com/ceki/____mistletoe> <https://github.com/ceki/__**mistletoe<https://github.com/ceki/__mistletoe>

...

<https://github.com/ceki/__**mistletoe<https://github.com/ceki/__mistletoe> <https://github.com/ceki/**mistletoe<https://github.com/ceki/mistletoe>

...

...

Your github pull request is most welcome. :-)

Cheers,

On 11.04.2013 17:19, Pierre Goupil wrote:

Good afternoon,

I can't find the Mistletoe source repository. I'd like to upgrade Mistletoe-Wicket to Wicket 6.0.

Regards,

Pierre GOUPIL

-- Ceki 65% of statistics are made up on the spot

...

-- Ceki 65% of statistics are made up on the spot ______________________________**_________________ mistletoe mailing list mistletoe@qos.ch http://mailman.qos.ch/mailman/**listinfo/mistletoe<http://mailman.qos.ch/mailman/listinfo/mistletoe>

-- "Parce que c'est la nuit qu'il est beau de croire à la lumière." Edmond Rostand

Thank you for this patch. It appears that you have re-indented certain files. This makes it hard to track file changes. I am going to cherry pick the changes I can. Please checkout the version found in HEAD (latest code from the repo) and test whether it works for you. If I miss anything, please provide a new patch and please mind the indentation and the white space. In the mean time I'll continue to prepare for release of version 0.3. On 11.04.2013 23:18, Pierre Goupil wrote:

Pull request done :-)

Hope to hear from you, now.

Regards,

Pierre

On Thu, Apr 11, 2013 at 10:39 PM, Pierre Goupil <goupilpierre@gmail.com <mailto:goupilpierre@gmail.com>> wrote:

Good catch! :-) One more problem left!

On Thu, Apr 11, 2013 at 10:36 PM, ceki <ceki@qos.ch <mailto:ceki@qos.ch>> wrote:

I don't think MyAttributeModifier is being used anywhere.

On 11.04.2013 20:40, Pierre Goupil wrote:

In the class "MyAttributeModifier", this code is problematic for me:

@Override public void onComponentTag(final Component component, final ComponentTag tag) { System.out.println("__ononComponentTag called. component="+component+", tag="+tag); if (isEnabled(component)) { System.out.println("changing attribute, value="+value); tag.getAttributes().put(__attribute, value); } }

What is this construct trying to achieve, please? I don't know this method in Wicket 1.4 and in 6.0 the super class declares it as final! Once I know what's it's for, I'll be able to ask for help to the Wicket mailing-list.

Regards,

Pierre

On Thu, Apr 11, 2013 at 6:59 PM, ceki <ceki@qos.ch <mailto:ceki@qos.ch> <mailto:ceki@qos.ch <mailto:ceki@qos.ch>>>

wrote:

I am looking forward for your contribution.

On 11.04.2013 18:38, Pierre Goupil wrote:

Cheers Ceki! Keep in touch!

Regards,

Pierre

-- Ceki 65% of statistics are made up on the spot

Good afternoon, On Fri, Apr 12, 2013 at 8:26 AM, ceki <ceki@qos.ch> wrote:

Thank you for this patch. It appears that you have re-indented certain files. This makes it hard to track file changes. I am going to cherry pick the changes I can.

Sorry, my bad.

Please checkout the version found in HEAD (latest code from the repo) and test whether it works for you.

I'll do that ASAP. Regards, Pierre -- "Parce que c'est la nuit qu'il est beau de croire à la lumière." Edmond Rostand