On 15/09/2010 9:03 AM, Heiko Seeberger wrote:
Hi,
My recent changes to the POM of the slf4j-scala-api module show how we should IMHO be doing OSGi in every module: Don't write the whole manifest manually, but let the Maven Bundle plugin generate it.
Looking at the manifest of slf4j-api there are several issues:
* There is no Bundle-Version * The bundle symbolic name does not follow "well recognized OSGi conventions": It should follow the reverse domain naming convention, i.e. org.slf4j.api
Wouldn't this cause other bundles expecting the current symbolic name to fail?
* I guess that SLF4J is compiled to target 1.5. At least for the JUL module it has to be 1.4 at minimum. Therefore I doubt that the 1.3 execution environment ist the correct setting
SLF4J targets JDK 1.4.
* I think the import for org.slf4j.impl should be optional, but I have to play with that one
Hugues spent some time to tweak the manifests. I'd seek his input.
* There is no uses directive for the exported packages. Well, that cannot be done manually (see Maven Bundle plugin above)
ditto -- Ceki