[ https://jira.qos.ch/browse/SLF4J-394?page=com.atlassian.jira.plugin.system.i... ] Ceki Gülcü commented on SLF4J-394: ---------------------------------- Thank you for looking into this, We are talking about a single null check. Moreover, methods calls are cheap.
add renderThrowable() and renderLevel() protected methods + mark LOG_LEVEL_* protected in simple provider ---------------------------------------------------------------------------------------------------------
Key: SLF4J-394 URL: https://jira.qos.ch/browse/SLF4J-394 Project: SLF4J Issue Type: Improvement Components: slf4j-simple Affects Versions: 1.7.24 Environment: Apache Maven 3.5 with maven-slf4j-provider http://maven.apache.org/ref/3-LATEST/maven-slf4j-provider/ Reporter: Hervé Boutemy Assignee: Ceki Gülcü Fix For: 1.7.25
Apache Maven created a Groovy monkey patch to extract such renderThrowable() and renderLevel() and being able to override these methods in a local provider, which is essentially slf4j-simple with a little rendering improvement see [https://git-wip-us.apache.org/repos/asf/maven/?p=maven.git;a=blob;f=maven-sl...] Having these changes directly in slf4j simple provider should not change much things, and would avoid us the Groovy patch dependency: the provider will still be required, since we can't have 2 providers in the classpath, and adding real extension/configuration to slf4j simple is much more complex
-- This message was sent by Atlassian JIRA (v7.3.1#73012)