Logging null messages

While searching through the logging framework(s) to see why something was being logged as it was, I came across some curious code (unrelated to my issue). https://github.com/qos-ch/slf4j/blob/1c6cbf05e6a99a8805397d1c06008021fdc9652... While the comment seems valid, `message` is an otherwise unused local variable. If the comment is still relevant, and I'm not going crazy, I'm assuming it should instead be `record.setMessage("")`? Cheers, -Devin

Indeed. I'd appreciate if you could create a Jira issue for this. On 23-May-17 8:12 PM, Devin Smith wrote:
While searching through the logging framework(s) to see why something was being logged as it was, I came across some curious code (unrelated to my issue).
https://github.com/qos-ch/slf4j/blob/1c6cbf05e6a99a8805397d1c06008021fdc9652...
While the comment seems valid, `message` is an otherwise unused local variable. If the comment is still relevant, and I'm not going crazy, I'm assuming it should instead be `record.setMessage("")`?
Cheers, -Devin
_______________________________________________ slf4j-dev mailing list slf4j-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/slf4j-dev
participants (2)
-
Ceki Gulcu
-
Devin Smith