[Bug 170] New: Add log4j's NDC support in log4j-over-slf4j

http://bugzilla.slf4j.org/show_bug.cgi?id=170 Summary: Add log4j's NDC support in log4j-over-slf4j Product: SLF4J Version: 1.5.x Platform: PC OS/Version: Linux Status: NEW Severity: blocker Priority: P1 Component: log4j-over-slf4j AssignedTo: slf4j-dev@qos.ch ReportedBy: hmalphettes@intalio.com It would be nice to support log4j's NDC class. For example http://opensaml.org depends on that. It is a straight forward port that simply delegate all log4j's NDC calls to slf4j's NDC static methods. This commit http://github.com/hmalphettes/slf4j/commit/2d30df3bd74e920d505308b322579d6fb... Does add such support and behaves well with opensaml. I also found a missing Import-Package in log4j-over-slf4j's MANIFEST for OSGi. org.apache.log4j.Log4jLoggerFactory requires org.slf4j.helpers.Util Cheers, Hugues. -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.slf4j.org/show_bug.cgi?id=170 Joern Huxhorn <joern@huxhorn.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joern@huxhorn.de --- Comment #1 from Joern Huxhorn <joern@huxhorn.de> 2010-03-06 12:28:29 --- This would require a slf4j-ext dependency in log4j-over-slf4j. Because of that, log4j-over-slf4j would then require Java>=1.5. -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.slf4j.org/show_bug.cgi?id=170 --- Comment #2 from Hugues Malphettes <hmalphettes@intalio.com> 2010-03-06 16:47:15 --- Ok thanks for looking at it Joern. I have filed the missing import as a new bug so we don't forget about it: http://bugzilla.slf4j.org/show_bug.cgi?id=171 If it was not for my email I would have suggested to place this NDC support in a log4j-over-slf4j-ext project and mirror slf4j itself to that regard. Reading your answer to Ceki's plan for slf4j-2.0, you have worked a lot more on this topic than myself: please let me know if the approach above is viable. Otherwise I'll follow the discussions on the mailing list and live with my fork in the mean time. Thanks, Hugues -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.slf4j.org/show_bug.cgi?id=170 --- Comment #3 from Joern Huxhorn <joern@huxhorn.de> 2010-03-06 17:58:11 --- Just for the record, I'm not an official developer of SLF4J. It's just that #31, #43 and lack of NDC are my only remaining complaints about an otherwise perfect logging API and I proposed a fix them in my branch at http://github.com/huxi/slf4j/tree/slf4j-redesign Please feel free to give it a glance and let me know what you think about it. -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.slf4j.org/show_bug.cgi?id=170 Ceki Gulcu <lists@slf4j.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #4 from Ceki Gulcu <lists@slf4j.org> 2010-04-04 21:52:15 --- Added a bare-bones implementation of the NDC class in log4j-over-slf4j. Added missing import for org.slf4j.helpers in log4j-over-slf4j's MANIFEST for OSGi. See http://github.com/ceki/slf4j/commit/75cf4a0c012f4158 and http://github.com/ceki/slf4j/commit/e2f99d41724cde145e4e -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@pixie.qos.ch