[Bug 272] New: NOPLogger should use varargs

http://bugzilla.slf4j.org/show_bug.cgi?id=272 Summary: NOPLogger should use varargs Product: SLF4J Version: unspecified Platform: Macintosh OS/Version: All Status: NEW Severity: normal Priority: P3 Component: Core API AssignedTo: slf4j-dev@qos.ch ReportedBy: thorsten.Moeller@unibas.ch Now that SLF4J makes use of varargs in the source code, org.slf4j.helpers.NOPLogger should be aligned rather than still using arrays, which produces compiler warnings for me in Eclipse. On a related point, there are also a few JavaDoc warnings; e.g. org.slf4j.Marker.contains(String name) does not declare a parameter named "other" (but this is used in the JavaDoc); org.slf4j.helpers.MessageFormatter.format(String, Object). I recommend configuring Eclipse (or any other static source code analyzer) to also warn about JavaDoc problems. -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.slf4j.org/show_bug.cgi?id=272 --- Comment #1 from Thorsten <thorsten.Moeller@unibas.ch> 2012-09-16 09:22:31 CEST --- Created attachment 87 --> http://bugzilla.slf4j.org/attachment.cgi?id=87 Patch that resolves a couple of compiler warnings Patch that resolves a couple of compiler warnings: - use varargs (instead of arrarys) - broken JavaDoc references Note that there are also a couple of trailing whitespace changes due to the fact that I'M using Eclipse save actions that remove such trailing whitespace. -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.slf4j.org/show_bug.cgi?id=272 Ceki Gulcu <listid@qos.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |listid@qos.ch Resolution| |FIXED --- Comment #2 from Ceki Gulcu <listid@qos.ch> 2012-09-17 23:38:42 CEST --- Hi Thorsten, I started working on correcting the various compiler warnings before seeing your patch. Largely fixed in https://github.com/qos-ch/slf4j/commit/3b040e36ff -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@qos.ch