[Bug 287] New: Beautification of error message in Logger.createChildByName()
http://bugzilla.slf4j.org/show_bug.cgi?id=287 Summary: Beautification of error message in Logger.createChildByName() Product: SLF4J Version: 1.6.x Platform: PC OS/Version: Linux Status: NEW Severity: minor Priority: P1 Component: Core API AssignedTo: slf4j-dev@qos.ch ReportedBy: d.tonhofer@m-plify.com Currently the following text is generated: throw new IllegalArgumentException("For logger [" + this.name + "] child name [" + childName + " passed as parameter, may not include '.' after index" + (this.name.length() + 1)); This is missing a ] and a " ", (I also would replace "index" by "position" and use CoreConstants.DOT) thus: throw new IllegalArgumentException("For logger [" + this.name + "], child name [" + childName + "] passed as parameter may not include the dot separator '" + CoreConstants.DOT + "' after position " + (this.name.length() + 1)); -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
http://bugzilla.slf4j.org/show_bug.cgi?id=287 --- Comment #1 from David Tonhofer <d.tonhofer@m-plify.com> 2012-12-20 17:12:12 CET --- Sorry, still wrong text. It turns out that the separator of a Logger name is DOT, but for the last string not containing any DOT it is DOLLAR. This leads to a problem though. I get an Exception when constructing a Logger in 1.7.2 but not in 1.6.1, will open bug... Anyway, the exception should thus read: throw new IllegalArgumentException("For logger [" + this.name + "], child name [" + childName + "] passed as parameter shall not include the separators '" + CoreConstants.DOT + ' or ' + CoreConstants.DOLLAR + + "' after position " + (this.name.length() + 1)); Attention: This is for SLF4J 1.7.2, but bugzilla doesn't list that version yet. -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
On 20.12.2012 17:12, bugzilla-daemon@qos.ch wrote:
Attention: This is for SLF4J 1.7.2, but bugzilla doesn't list that version yet.
Thank you for bringing this up. Just fixed. -- Ceki 65% of statistics are made up on the spot
http://bugzilla.slf4j.org/show_bug.cgi?id=287 --- Comment #2 from David Tonhofer <d.tonhofer@m-plify.com> 2012-12-20 19:00:55 CET --- This belongs properly to Logback Classic; will file in JIRA. -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
http://bugzilla.slf4j.org/show_bug.cgi?id=287 David Tonhofer <d.tonhofer@m-plify.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID --- Comment #3 from David Tonhofer <d.tonhofer@m-plify.com> 2012-12-20 19:05:39 CET --- Filed as http://jira.qos.ch/browse/LOGBACK-780 -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
participants (2)
-
bugzilla-daemon＠qos.ch -
ceki