SLF4J / SLF4J-554 [Open] MessageFormatter refactor (declare field variable, naming, not used variable) ============================== Here's what changed in this issue in the last few minutes. This issue has been created This issue is now assigned to you. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-554 ============================== Issue created ------------------------------ jaehunchoi created this issue on 15/Aug/22 1:32 PM Summary: MessageFormatter refactor (declare field variable, naming, not used variable) Issue Type: Improvement Assignee: SLF4J developers list Created: 15/Aug/22 1:32 PM Priority: Minor Reporter: jaehunchoi Severity: normal Description: I changed three things from MessageFormatter class. First, declare field variables in for-loop. Before I change, field variables named "j", "l" declared out from for-loop. I thought that it was because of the performance. but from performance perspective, It was not faster than declaring in for-loop (rather, the latter was faster). So, I changed these based on a maintenance perspective. "declare where use." Second, There was wrong spelled method in messageFormatter (isEscapedDelimeter -> isEscapedDelimiter). It is only used in same class. So I changed. Last, static char `DELIM_STOP` never used in messageFormatter class. so I deleted.   this is my first time to contribute!  ============================== This message was sent by Atlassian Jira (v8.8.0#808000-sha1:e2c7e59)