July 2007 - logback-dev - mailman3.qos.ch

[Bug 56] New: Improve filters
by bugzilla-daemon＠pixie.qos.ch 22 Aug '07

22 Aug '07

http://bugzilla.qos.ch/show_bug.cgi?id=56 Summary: Improve filters Product: Console Plugin Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: enhancement Priority: P1 Component: interface AssignedTo: logback-dev(a)qos.ch ReportedBy: xavier.hanin(a)gmail.com On my wish list for the plugin, more customizable filters: * having two kind of filters, the current one, and in memory one, so that the filter could be applied to already logged events, as the pattern. * being able to configure filters per project. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[Bug 87] New: logback-demo not working
by bugzilla-daemon＠pixie.qos.ch 21 Aug '07

21 Aug '07

http://bugzilla.qos.ch/show_bug.cgi?id=87 Summary: logback-demo not working Product: logback-general Version: unspecified Platform: PC URL: http://svn.qos.ch/repos/logback-demo/trunk OS/Version: Windows Status: NEW Severity: normal Priority: P4 Component: build-structure AssignedTo: logback-dev(a)qos.ch ReportedBy: tbondz(a)gmail.com logback-demo depends on an older version of logback (0.9) which does not implement getContextSelector(). Need to update the logback-demo pom to depend on version 0.9.7 or later. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 1

[Bug 85] New: ch.qos.logback.classic.spi.LoggingEvent swallows Object[]
by bugzilla-daemon＠pixie.qos.ch 21 Aug '07

21 Aug '07

http://bugzilla.qos.ch/show_bug.cgi?id=85 Summary: ch.qos.logback.classic.spi.LoggingEvent swallows Object[] Product: logback-classic Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: blocker Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: robertjchristian(a)gmail.com The Object[] used to construct LoggingEvent should be populated in the argumentArray field. Unfortunately, Logger does not populate this via the setter method, and the LoggingEvent constructor swallows it. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 1

[Bug 78] New: bad index in extract CallerData
by bugzilla-daemon＠pixie.qos.ch 21 Aug '07

21 Aug '07

http://bugzilla.qos.ch/show_bug.cgi?id=78 Summary: bad index in extract CallerData Product: logback-classic Version: unspecified Platform: Macintosh OS/Version: Mac OS Status: NEW Severity: blocker Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: hansm(a)science.uva.nl CC: hansm(a)science.uva.nl Below is code from CallerData (logback 0.9.7) This gives an error as shown below. java.lang.ArrayIndexOutOfBoundsException: -1 at ch.qos.logback.classic.spi.CallerData.extract(CallerData.java:101) at ch.qos.logback.classic.spi.LoggingEvent.getCallerData(LoggingEvent.java:246) In my code (Eclipse RCP) LoggingEvent's are collected by an appender in a java.util.List. Then a Jface TableViewer is allocated and the input set to that list. The processing of the accumulated LoggingEvents now each throw the ArrayIndexOutOfBoundsException. After registering the viewer containing object with the appender, new incoming LoggingEvents are given to the viewer and are processed without problem. It looks like the "int found" has kept its value of -1, presumably because the equals in line 88 never becomes true. I am inclined to consider this a bug, or at least unsafe coding, because a bad index in certain circumstances can reach the code in line 101. The code in lines 86-97 does not guarantee that a bad index cannot occur. 78 public static CallerData[] extract(Throwable t, String fqnOfInvokingClass) { 79 if (t == null) { 80 return null; 81 } 82 83 StackTraceElement[] steArray = t.getStackTrace(); 84 CallerData[] callerDataArray; 85 86 int found = -1; 87 for (int i = 0; i < steArray.length; i++) { 88 if(steArray[i].getClassName().equals(fqnOfInvokingClass)) { 89 // the caller is assumed to be the next stack frame, hence the +1. 90 found = i + 1; 91 } else { 92 if(found != -1) { 93 break; 94 } 95 } 96 97 } 98 99 callerDataArray = new CallerData[steArray.length - found]; 100 for (int i = found; i < steArray.length; i++) { 101 callerDataArray[i-found] = new CallerData(steArray[i]); 102 } 103 return callerDataArray; 104 } 105 -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 3

[Bug 38] New: Display a message when used behind slf4j
by bugzilla-daemon＠pixie.qos.ch 21 Aug '07

21 Aug '07

http://bugzilla.qos.ch/show_bug.cgi?id=38 Summary: Display a message when used behind slf4j Product: logback-general Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P1 Component: build-structure AssignedTo: logback-dev(a)qos.ch ReportedBy: noreply.sebastien(a)qos.ch Logback should display a message when it is used as SLF4J's implementation. We should find a way to tell the user that it's logback that is being used, without polluting any output. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 1

[Bug 39] New: Introduce concept of MDC as soon ass they are referenced
by bugzilla-daemon＠pixie.qos.ch 21 Aug '07

21 Aug '07

http://bugzilla.qos.ch/show_bug.cgi?id=39 Summary: Introduce concept of MDC as soon ass they are referenced Product: logback-site Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: normal Priority: P3 Component: Documentation AssignedTo: logback-dev(a)qos.ch ReportedBy: xavier.hanin(a)gmail.com While reading the documentation I had the feeling that MDC was introduced too late. Indeed, you reference MDC the first time in chapter 2 (as far as I can say), without giving even an hint on what it is. Several other chapters reference this concept, but it's only in chapter 7 that I understood what it is. Maybe adding a short introduction to this concept (and the concept of Marker) in chapter 2 would help the reader? -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[Bug 79] New: typo on main logback web page
by bugzilla-daemon＠pixie.qos.ch 21 Aug '07

21 Aug '07

http://bugzilla.qos.ch/show_bug.cgi?id=79 Summary: typo on main logback web page Product: logback-general Version: unspecified Platform: All URL: http://logback.qos.ch/ OS/Version: All Status: NEW Severity: trivial Priority: P1 Component: build-structure AssignedTo: logback-dev(a)qos.ch ReportedBy: blakesys(a)yahoo.com There is a typo on the main logback web page: "exerience" should be spelled "experience" -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 1

[Bug 88] New: Update Chapter 7 to use org.slf4j.MDC
by bugzilla-daemon＠pixie.qos.ch 21 Aug '07

21 Aug '07

http://bugzilla.qos.ch/show_bug.cgi?id=88 Summary: Update Chapter 7 to use org.slf4j.MDC Product: logback-site Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P3 Component: Documentation AssignedTo: logback-dev(a)qos.ch ReportedBy: sdavids(a)gmx.de http://www.slf4j.org/api/org/slf4j/MDC.html The chapter uses ch.qos.logback.classic.MDC You cross-reference it from here: http://www.slf4j.org/manual.html Therefore, the SLF4J-API usage should be shown and not the "native" LogBack one. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

svn commit: r1558 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util
by noreply.ceki＠qos.ch 19 Jul '07

19 Jul '07

Author: ceki Date: Thu Jul 19 22:42:02 2007 New Revision: 1558 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/PropertySetter.java Log: correcting bug fix observed when running with Orion. See also http://www.qos.ch/pipermail/logback-user/2007-May/000216.html Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/PropertySetter.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/PropertySetter.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/PropertySetter.java Thu Jul 19 22:42:02 2007 @@ -231,7 +231,7 @@ Package p = clazz.getPackage(); if (clazz.isPrimitive()) { return X_AS_PROPERTY; - } else if ("java.lang".equals(p.getName())) { + } else if (p != null && "java.lang".equals(p.getName())) { return X_AS_PROPERTY; } else if (Duration.class.isAssignableFrom(clazz)) { return X_AS_PROPERTY;

1 0

svn commit: r1557 - in logback/trunk: . logback-examples/src/main/java/chapter4 logback-examples/src/main/java/chapter5 logback-examples/src/main/java/chapter6 logback-examples/src/main/java/chapter7 logback-site/src/site/pages logback-site/src/site/pages/manual
by noreply.ceki＠qos.ch 12 Jul '07

12 Jul '07

Author: ceki Date: Thu Jul 12 22:47:16 2007 New Revision: 1557 Modified: logback/trunk/ (props changed) logback/trunk/logback-examples/src/main/java/chapter4/ConfigurationTester.java logback/trunk/logback-examples/src/main/java/chapter5/GoMDC.java logback/trunk/logback-examples/src/main/java/chapter6/FilterEvents.java logback/trunk/logback-examples/src/main/java/chapter7/NumberCruncherServer.java logback/trunk/logback-examples/src/main/java/chapter7/SimpleMDC.java logback/trunk/logback-examples/src/main/java/chapter7/UserServletFilter.java logback/trunk/logback-site/src/site/pages/bridge.html logback/trunk/logback-site/src/site/pages/manual/layouts.html logback/trunk/logback-site/src/site/pages/manual/mdc.html logback/trunk/pom.xml Log: aligning with MDC support in SLF4J Modified: logback/trunk/logback-examples/src/main/java/chapter4/ConfigurationTester.java ============================================================================== --- logback/trunk/logback-examples/src/main/java/chapter4/ConfigurationTester.java (original) +++ logback/trunk/logback-examples/src/main/java/chapter4/ConfigurationTester.java Thu Jul 12 22:47:16 2007 @@ -2,10 +2,9 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; - +import org.slf4j.MDC; import ch.qos.logback.classic.LoggerContext; -import ch.qos.logback.classic.MDC; import ch.qos.logback.classic.joran.JoranConfigurator; import ch.qos.logback.core.joran.spi.JoranException; import ch.qos.logback.core.util.StatusPrinter; Modified: logback/trunk/logback-examples/src/main/java/chapter5/GoMDC.java ============================================================================== --- logback/trunk/logback-examples/src/main/java/chapter5/GoMDC.java (original) +++ logback/trunk/logback-examples/src/main/java/chapter5/GoMDC.java Thu Jul 12 22:47:16 2007 @@ -2,9 +2,9 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import org.slf4j.MDC; import ch.qos.logback.classic.LoggerContext; -import ch.qos.logback.classic.MDC; import ch.qos.logback.classic.joran.JoranConfigurator; import ch.qos.logback.core.joran.spi.JoranException; import ch.qos.logback.core.util.StatusPrinter; Modified: logback/trunk/logback-examples/src/main/java/chapter6/FilterEvents.java ============================================================================== --- logback/trunk/logback-examples/src/main/java/chapter6/FilterEvents.java (original) +++ logback/trunk/logback-examples/src/main/java/chapter6/FilterEvents.java Thu Jul 12 22:47:16 2007 @@ -2,11 +2,11 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import org.slf4j.MDC; import org.slf4j.Marker; import org.slf4j.MarkerFactory; import ch.qos.logback.classic.LoggerContext; -import ch.qos.logback.classic.MDC; import ch.qos.logback.classic.joran.JoranConfigurator; import ch.qos.logback.core.joran.spi.JoranException; Modified: logback/trunk/logback-examples/src/main/java/chapter7/NumberCruncherServer.java ============================================================================== --- logback/trunk/logback-examples/src/main/java/chapter7/NumberCruncherServer.java (original) +++ logback/trunk/logback-examples/src/main/java/chapter7/NumberCruncherServer.java Thu Jul 12 22:47:16 2007 @@ -18,9 +18,9 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import org.slf4j.MDC; import ch.qos.logback.classic.LoggerContext; -import ch.qos.logback.classic.MDC; import ch.qos.logback.classic.joran.JoranConfigurator; import ch.qos.logback.core.joran.spi.JoranException; Modified: logback/trunk/logback-examples/src/main/java/chapter7/SimpleMDC.java ============================================================================== --- logback/trunk/logback-examples/src/main/java/chapter7/SimpleMDC.java (original) +++ logback/trunk/logback-examples/src/main/java/chapter7/SimpleMDC.java Thu Jul 12 22:47:16 2007 @@ -11,9 +11,9 @@ package chapter7; import org.slf4j.LoggerFactory; +import org.slf4j.MDC; import ch.qos.logback.classic.Logger; -import ch.qos.logback.classic.MDC; import ch.qos.logback.classic.PatternLayout; import ch.qos.logback.classic.spi.LoggingEvent; import ch.qos.logback.core.ConsoleAppender; Modified: logback/trunk/logback-examples/src/main/java/chapter7/UserServletFilter.java ============================================================================== --- logback/trunk/logback-examples/src/main/java/chapter7/UserServletFilter.java (original) +++ logback/trunk/logback-examples/src/main/java/chapter7/UserServletFilter.java Thu Jul 12 22:47:16 2007 @@ -22,7 +22,7 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpSession; -import ch.qos.logback.classic.MDC; +import org.slf4j.MDC; /** * A simple servlet filter that puts the username Modified: logback/trunk/logback-site/src/site/pages/bridge.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/bridge.html (original) +++ logback/trunk/logback-site/src/site/pages/bridge.html Thu Jul 12 22:47:16 2007 @@ -23,92 +23,10 @@ <h2>Log4j bridge</h2> - <p>Recent versions of logback ship with a module called - <em>log4j-bridge</em>. It allows log4j users to use logback - without changing <em>a single line of code</em> in their existing - applications by replacing the <em>log4j.jar</em> file with - appropriate jars, as described below. + <p>This module has migrated into the SLF4J project, its original + home. It has also been renamed as <a + href="http://www.slf4j.org/log4j-over-slf4j.html">log4j-over-slf4j</a>. </p> - - <h3>How does it work?</h3> - - <p>The log4j-bridge module contains replacements of most widely - used log4j classes, namely <code>org.apache.log4j.Category</code>, - <code>org.apache.log4j.Logger</code>, - <code>org.apache.log4j.Priority</code>, - <code>org.apache.log4j.Level</code>, - <code>org.apache.log4j.MDC</code>, and - <code>org.apache.log4j.BasicConfigurator</code>. These replacement - classes redirect all work to their corresponding logback classes. - </p> - - <p> - To use log4j-bridge in your own application, the first step is - to locate and then remove <em>log4j.jar</em> replacing it with - <em>log4j-bridge.jar</em> which ships with logback. Note that - you still need logback-classic and its dependencies for the - log4j-bridge to work properly. In summary, here is a list of the - required jars: - </p> - - <ul> - <li> - log4j-bridge-<em>VERSION</em>.jar - </li> - <li> - logback-classic-<em>VERSION</em>.jar - </li> - <li> - logback-core-<em>VERSION</em>.jar - </li> - <li> - slf4j-api-<em>VERSION</em>.jar - </li> - </ul> - - <p> - In most situtations, replacing a jar file is all it takes in - order to migrate from log4j to logback. - </p> - - <p>Note that as a result of this migration, log4j configuration - files will no longer be picked up. If you need to migrate your - log4j.properties file to logback, the <a - href="http://logback.qos.ch/translator/">log4j translator</a> - might be of help. For configuring logback, please refer to <a - href="manual/index.html">the manual</a>. - </p> - - <p>We are happy to report that several applications are - successfully using log4j-bridge in production. - </p> - - - <h3>When does it not work?</h3> - - <p>The <em>log4-bridge</em> module will not work when the - application calls log4j components that are not present in the - bridge. For example, direct references to log4j appenders, - filters or PropertyConfigurator are not supported by log4j-bridge. - While the number of cases where log4j-bridge is insufficient is - not completely negligible, in a vast majority of cases where log4j - is configured through a configuration file, be it - <em>log4j.properties</em> or <em>log4j.xml</em>, log4j-bridge is - enough in order to migrate youran application to logback. - </p> - - <h3>What about the overhead?</h3> - - <p>There overhead of using log4j-bridge instead of log4j directly - is relatively small. Given that log4j-bridge immediately delegates - all work to logback, the CPU overhead should be negligible, in the - order of a few <em>nanoseconds</em>. There is a memory overhead - corresponding to an entry in a hasmap per logger, which should be - usually acceptable even for very large applications consisting of - several thousand loggers. Moreover, given that logback is both - much faster and more memory-efficient, the gains made by using - logback should compensate for the overhead of using log4j-bridge - instead of log4j directly.</p> <script src="templates/footer.js"></script> Modified: logback/trunk/logback-site/src/site/pages/manual/layouts.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/manual/layouts.html (original) +++ logback/trunk/logback-site/src/site/pages/manual/layouts.html Thu Jul 12 22:47:16 2007 @@ -1238,7 +1238,7 @@ specifier, the stack trace is displayed when <em>the expression evaluates to <b>false</b>.</em></p> - <h3>Creating a custom conversion specifier</h3> + <h2>Creating a custom conversion specifier</h2> <p>Up to this point we have presented the built-inconversion specifiers of <code>PatternLayout</code>. But it is also possible Modified: logback/trunk/logback-site/src/site/pages/manual/mdc.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/manual/mdc.html (original) +++ logback/trunk/logback-site/src/site/pages/manual/mdc.html Thu Jul 12 22:47:16 2007 @@ -48,18 +48,19 @@ method in the book <em>Patterns for Logging Diagnostic Messages</em> in Pattern Languages of Program Design 3, edited by R. Martin, D. Riehle, and F. Buschmann (Addison-Wesley, - 1997). Logback offers a variant of this technique: Mapped - Diagnostic Contexts (MDC). + 1997). Logback leverages a variant of this technique includde in + the SLF4J API: Mapped Diagnostic Contexts (MDC). </p> <p> - To uniquely stamp each request, the user puts contextual information into the - <code><a href="../xref/ch/qos/logback/classic/MDC.html">MDC</a></code>, - the abbreviation of Mapped Diagnostic Context. - The public interface of the MDC class is shown below. + To uniquely stamp each request, the user puts contextual + information into the <code><a + href="http://www.slf4j.org/api/org/slf4j/MDC.html">MDC</a></code>, + the abbreviation of Mapped Diagnostic Context. The public + interface of the MDC class is shown below. </p> -<div class="source"><pre>package ch.qos.logback.classic; +<div class="source"><pre>package org.slf4j; public class MDC { //Put a context value as identified by <em>key</em> @@ -79,16 +80,17 @@ <b>public static Set<String> getKeys();</b> }</pre></div> - <p> - The <code>MDC</code> class contains only static methods. - It lets the developer place information in a <em>diagnostic context</em> that can be - subsequently retrieved by certain logback components. The - <code>MDC</code> manages contextual information on a <em>per thread basis</em>. - Typically, while starting to service a new client request, the developer will - insert pertinent contextual information, such as the client id, client's IP - address, request parameters etc. into the <code>MDC</code>. Logback components, - if appropriately configured, will automatically include this information - in each log entry. + <p>The <code>MDC</code> class contains only static methods. It + lets the developer place information in a <em>diagnostic + context</em> that can be subsequently retrieved by certain + logback components. The <code>MDC</code> manages contextual + information on a <em>per thread basis</em>. Typically, while + starting to service a new client request, the developer will + insert pertinent contextual information, such as the client id, + client's IP address, request parameters etc. into the + <code>MDC</code>. Logback components, if appropriately + configured, will automatically include this information in each + log entry. </p> <p> @@ -101,6 +103,7 @@ <div class="source"><pre>package chapter7; import org.slf4j.LoggerFactory; +import org.slf4j.MDC; import ch.qos.logback.classic.Logger; import ch.qos.logback.classic.MDC; @@ -233,9 +236,9 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import org.slf4j.MDC; import ch.qos.logback.classic.LoggerContext; -import ch.qos.logback.classic.MDC; import ch.qos.logback.classic.joran.JoranConfigurator; import ch.qos.logback.core.joran.spi.JoranException; @@ -532,7 +535,7 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpSession; -import ch.qos.logback.classic.MDC; +import org.slf4j.MDC; public class UserServletFilter implements Filter { Modified: logback/trunk/pom.xml ============================================================================== --- logback/trunk/pom.xml (original) +++ logback/trunk/pom.xml Thu Jul 12 22:47:16 2007 @@ -36,7 +36,7 @@ <properties>  - <slf4j.version>1.4.2-SNAPSHOT</slf4j.version> + <slf4j.version>1.4.2</slf4j.version> <consolePlugin.version>1.0.1</consolePlugin.version> <retrotranslator.verify>false</retrotranslator.verify> </properties>

1 0