July 2007 - logback-dev - mailman3.qos.ch

[Bug 80] New: TimeBasedRollingPolicy do NOT work as expected
by bugzilla-daemon＠pixie.qos.ch 11 Jul '07

11 Jul '07

http://bugzilla.qos.ch/show_bug.cgi?id=80 Summary: TimeBasedRollingPolicy do NOT work as expected Product: logback-core Version: unspecified Platform: All OS/Version: Linux Status: NEW Severity: blocker Priority: P1 Component: Rolling AssignedTo: logback-dev(a)qos.ch ReportedBy: eric.yung(a)jspectrum.com When I use TimeBasedRollingPolicy as the rolling & triggering policy for the RollingFileAppender, only the last log line appears in the new log file after the 1st rolling trigger. The reason is that the TimeBasedRollingPolicy kept rolling for every log event after the 1st rolling trigger. It causes by a bug in isTriggeringEvent() method - the method uses the un-initialized value of 'currentTime' (which is 0) to set the time of the 'lastCheck' Date object. Original method : public boolean isTriggeringEvent(File activeFile, final Object event) { //currentTime= System.currentTimeMillis(); if (getCurrentTime() >= nextCheck) { //addInfo("Time to trigger roll-over"); // We set the elapsedPeriodsFileName before we set the 'lastCheck' variable // The elapsedPeriodsFileName corresponds to the file name of the period // that just elapsed. elapsedPeriodsFileName = activeFileNamePattern.convertDate(lastCheck); //addInfo("elapsedPeriodsFileName set to "+elapsedPeriodsFileName); lastCheck.setTime(currentTime); nextCheck = rc.getNextCheckMillis(lastCheck); Date x = new Date(); x.setTime(nextCheck); //addInfo("Next check on "+ x); return true; } else { return false; } } Suggested Changes - uses a local long variable to store the value of getCurrentTime() and uses it in the method for comparison and assignment: public boolean isTriggeringEvent(File activeFile, final Object event) { //currentTime= System.currentTimeMillis(); long curT = getCurrentTime(); if (curT >= nextCheck) { //addInfo("Time to trigger roll-over"); // We set the elapsedPeriodsFileName before we set the 'lastCheck' variable // The elapsedPeriodsFileName corresponds to the file name of the period // that just elapsed. elapsedPeriodsFileName = activeFileNamePattern.convertDate(lastCheck); //addInfo("elapsedPeriodsFileName set to "+elapsedPeriodsFileName); lastCheck.setTime(curT); nextCheck = rc.getNextCheckMillis(lastCheck); //Date x = new Date(); //x.setTime(nextCheck); //addInfo("Next check on "+ x); return true; } else { return false; } } -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[Bug 86] New: Time based logfile rotation does not log, uses 1970-01-01 as date
by bugzilla-daemon＠pixie.qos.ch 11 Jul '07

11 Jul '07

http://bugzilla.qos.ch/show_bug.cgi?id=86 Summary: Time based logfile rotation does not log, uses 1970-01- 01 as date Product: logback-core Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: critical Priority: P2 Component: Rolling AssignedTo: logback-dev(a)qos.ch ReportedBy: 8625330(a)web.de Sometimes/Most of the time TimebasedRolling does not work. - Log files have 1970-01-01 for %d in the name. - Log files contain only one line i.e. file gets overwritten with every log statement. - restart seems to help, probably till midnight - did not happen with older versions SLF4J 1.3 and (probably) Logback 0.9.3 Used in combination with jcl-over-slf. <appender name="XXX_FILE" class="ch.qos.logback.core.rolling.RollingFileAppender" > <rollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy"> <FileNamePattern> ${XxxLogDir}/xxx.%d.log </FileNamePattern> </rollingPolicy> <layout class="ch.qos.logback.classic.PatternLayout"> <pattern> %date %-5level [%8.-8mdc{tid}][%15.15mdc{uid}] [%logger{20}] %msg%n </pattern> </layout> </appender> -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[continuum] BUILD ERROR: Log4j Bridge Module
by John Noreplai 10 Jul '07

10 Jul '07

Online report : http://localhost:8090/continuum/servlet/continuum/target/ProjectBuild.vm/vi… Build statistics: State: Error Previous State: Error Started at: Tue, 10 Jul 2007 17:20:09 +0200 Finished at: Tue, 10 Jul 2007 17:20:10 +0200 Total time: 1s Build Trigger: Schedule Exit code: 0 Building machine hostname: pixie Operating system : Linux(unknown) Java version : 1.5.0_08(Sun Microsystems Inc.) Changes No files changed **************************************************************************** Build Error: **************************************************************************** Provider message: The svn command failed. Command output: ------------------------------------------------------------------------------- svn: REPORT request failed on '/repos/!svn/vcc/default' svn: Cannot replace a directory from within -------------------------------------------------------------------------------

1 0

[continuum] BUILD ERROR: Log4j Bridge Module
by John Noreplai 10 Jul '07

10 Jul '07

Online report : http://localhost:8090/continuum/servlet/continuum/target/ProjectBuild.vm/vi… Build statistics: State: Error Previous State: Error Started at: Tue, 10 Jul 2007 17:00:11 +0200 Finished at: Tue, 10 Jul 2007 17:00:12 +0200 Total time: 0s Build Trigger: Schedule Exit code: 0 Building machine hostname: pixie Operating system : Linux(unknown) Java version : 1.5.0_08(Sun Microsystems Inc.) Changes No files changed **************************************************************************** Build Error: **************************************************************************** Provider message: The svn command failed. Command output: ------------------------------------------------------------------------------- svn: REPORT request failed on '/repos/!svn/vcc/default' svn: Cannot replace a directory from within -------------------------------------------------------------------------------

1 0

[continuum] BUILD ERROR: Log4j Bridge Module
by John Noreplai 10 Jul '07

10 Jul '07

Online report : http://localhost:8090/continuum/servlet/continuum/target/ProjectBuild.vm/vi… Build statistics: State: Error Previous State: Error Started at: Tue, 10 Jul 2007 16:40:09 +0200 Finished at: Tue, 10 Jul 2007 16:40:10 +0200 Total time: 0s Build Trigger: Schedule Exit code: 0 Building machine hostname: pixie Operating system : Linux(unknown) Java version : 1.5.0_08(Sun Microsystems Inc.) Changes No files changed **************************************************************************** Build Error: **************************************************************************** Provider message: The svn command failed. Command output: ------------------------------------------------------------------------------- svn: REPORT request failed on '/repos/!svn/vcc/default' svn: Cannot replace a directory from within -------------------------------------------------------------------------------

1 0

[continuum] BUILD ERROR: Log4j Bridge Module
by John Noreplai 10 Jul '07

10 Jul '07

Online report : http://localhost:8090/continuum/servlet/continuum/target/ProjectBuild.vm/vi… Build statistics: State: Error Previous State: Error Started at: Tue, 10 Jul 2007 16:20:09 +0200 Finished at: Tue, 10 Jul 2007 16:20:10 +0200 Total time: 0s Build Trigger: Schedule Exit code: 0 Building machine hostname: pixie Operating system : Linux(unknown) Java version : 1.5.0_08(Sun Microsystems Inc.) Changes No files changed **************************************************************************** Build Error: **************************************************************************** Provider message: The svn command failed. Command output: ------------------------------------------------------------------------------- svn: REPORT request failed on '/repos/!svn/vcc/default' svn: Cannot replace a directory from within -------------------------------------------------------------------------------

1 0

[continuum] BUILD ERROR: Log4j Bridge Module
by John Noreplai 10 Jul '07

10 Jul '07

Online report : http://localhost:8090/continuum/servlet/continuum/target/ProjectBuild.vm/vi… Build statistics: State: Error Previous State: Error Started at: Tue, 10 Jul 2007 16:00:09 +0200 Finished at: Tue, 10 Jul 2007 16:00:11 +0200 Total time: 1s Build Trigger: Schedule Exit code: 0 Building machine hostname: pixie Operating system : Linux(unknown) Java version : 1.5.0_08(Sun Microsystems Inc.) Changes No files changed **************************************************************************** Build Error: **************************************************************************** Provider message: The svn command failed. Command output: ------------------------------------------------------------------------------- svn: REPORT request failed on '/repos/!svn/vcc/default' svn: Cannot replace a directory from within -------------------------------------------------------------------------------

1 0

[continuum] BUILD ERROR: Log4j Bridge Module
by John Noreplai 10 Jul '07

10 Jul '07

Online report : http://localhost:8090/continuum/servlet/continuum/target/ProjectBuild.vm/vi… Build statistics: State: Error Previous State: Error Started at: Tue, 10 Jul 2007 15:40:10 +0200 Finished at: Tue, 10 Jul 2007 15:40:11 +0200 Total time: 0s Build Trigger: Schedule Exit code: 0 Building machine hostname: pixie Operating system : Linux(unknown) Java version : 1.5.0_08(Sun Microsystems Inc.) Changes No files changed **************************************************************************** Build Error: **************************************************************************** Provider message: The svn command failed. Command output: ------------------------------------------------------------------------------- svn: REPORT request failed on '/repos/!svn/vcc/default' svn: Cannot replace a directory from within -------------------------------------------------------------------------------

1 0

[continuum] BUILD ERROR: Log4j Bridge Module
by John Noreplai 10 Jul '07

10 Jul '07

Online report : http://localhost:8090/continuum/servlet/continuum/target/ProjectBuild.vm/vi… Build statistics: State: Error Previous State: Error Started at: Tue, 10 Jul 2007 15:20:09 +0200 Finished at: Tue, 10 Jul 2007 15:20:10 +0200 Total time: 0s Build Trigger: Schedule Exit code: 0 Building machine hostname: pixie Operating system : Linux(unknown) Java version : 1.5.0_08(Sun Microsystems Inc.) Changes No files changed **************************************************************************** Build Error: **************************************************************************** Provider message: The svn command failed. Command output: ------------------------------------------------------------------------------- svn: REPORT request failed on '/repos/!svn/vcc/default' svn: Cannot replace a directory from within -------------------------------------------------------------------------------

1 0

[continuum] BUILD ERROR: Log4j Bridge Module
by John Noreplai 10 Jul '07

10 Jul '07

Online report : http://localhost:8090/continuum/servlet/continuum/target/ProjectBuild.vm/vi… Build statistics: State: Error Previous State: Error Started at: Tue, 10 Jul 2007 15:00:10 +0200 Finished at: Tue, 10 Jul 2007 15:00:11 +0200 Total time: 0s Build Trigger: Schedule Exit code: 0 Building machine hostname: pixie Operating system : Linux(unknown) Java version : 1.5.0_08(Sun Microsystems Inc.) Changes No files changed **************************************************************************** Build Error: **************************************************************************** Provider message: The svn command failed. Command output: ------------------------------------------------------------------------------- svn: REPORT request failed on '/repos/!svn/vcc/default' svn: Cannot replace a directory from within -------------------------------------------------------------------------------

1 0