January 2008 - logback-dev - mailman3.qos.ch

[Bug 105] New: SocketAppenderBase - ObjectOutputStream is not closed in case of an IOException.
by bugzilla-daemon＠pixie.qos.ch 11 Mar '08

11 Mar '08

http://bugzilla.qos.ch/show_bug.cgi?id=105 Summary: SocketAppenderBase - ObjectOutputStream is not closed in case of an IOException. Product: logback-core Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P1 Component: Appender AssignedTo: logback-dev(a)qos.ch ReportedBy: joern(a)huxhorn.de I think this is the cause of "hanging connections" in case of webserver restarts that I sometimes experience in lumberjack. Anyway, the stream should be closed in case of exception. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 5

[Bug 64] New: Logback MDC context is not inherited by child threads.
by bugzilla-daemon＠pixie.qos.ch 04 Mar '08

04 Mar '08

http://bugzilla.qos.ch/show_bug.cgi?id=64 Summary: Logback MDC context is not inherited by child threads. Product: logback-classic Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: bendis(a)bendis.cz As stated in the javadoc documentation, the ch.qos.logback.classic.MDC should be inherited by a child thread: "A child thread automatically inherits a copy of the mapped diagnostic context of its parent." But the context is NOT ihnerited by child threads - the context HashMap is stored in the ThreadLocal, not in the InheritableThreadLocal. Regards, Bendis -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[Bug 120] New: Clean up a typo in SizeBasedRollingTest.java
by bugzilla-daemon＠pixie.qos.ch 04 Feb '08

04 Feb '08

http://bugzilla.qos.ch/show_bug.cgi?id=120 Summary: Clean up a typo in SizeBasedRollingTest.java Product: logback-core Version: unspecified Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: P1 Component: Rolling AssignedTo: logback-dev(a)qos.ch ReportedBy: matt.fowles(a)gmail.com This patch just fixes a typo in a unit test. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 5

[continuum] BUILD FAILURE: Logback-XXXX - Logback Classic Module - Build Def: default maven2 buildDefinition
by John Noreplai 31 Jan '08

31 Jan '08

Online report : http://pixie:8091/continuum/buildResult.action?buildId=288&projectId=18 Build statistics: State: Failed Previous State: Error Started at: Thu 31 Jan 2008 11:58:56 +0100 Finished at: Thu 31 Jan 2008 11:58:59 +0100 Total time: 3s Build Trigger: Forced Build Number: 10 Exit code: 1 Building machine hostname: pixie Operating system : Linux(unknown) Java Home version : java version "1.5.0_08" Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_08-b03) Java HotSpot(TM) 64-Bit Server VM (build 1.5.0_08-b03, mixed mode) Builder version : Maven version: 2.0.4 **************************************************************************** SCM Changes: **************************************************************************** No files changed **************************************************************************** Dependencies Changes: **************************************************************************** No dependencies changed **************************************************************************** Build Defintion: **************************************************************************** POM filename: pom.xml Goals: clean install Arguments: --batch-mode --non-recursive Build Fresh: false Always Build: false Default Build Definition: true Schedule: DEFAULT_SCHEDULE Description: default maven2 buildDefinition **************************************************************************** Test Summary: **************************************************************************** Tests: 146 Failures: 0 Total time: 4.011

1 0

svn commit: r1616 - logback/trunk
by noreply.ceki＠qos.ch 31 Jan '08

31 Jan '08

Author: ceki Date: Thu Jan 31 11:51:26 2008 New Revision: 1616 Modified: logback/trunk/pom.xml Log: - disable sending CONTINUUM messages on the logback-dev mailing lists (they are annoying) Modified: logback/trunk/pom.xml ============================================================================== --- logback/trunk/pom.xml (original) +++ logback/trunk/pom.xml Thu Jan 31 11:51:26 2008 @@ -36,7 +36,7 @@ <properties>  - <slf4j.version>1.4.3</slf4j.version> + <slf4j.version>1.5.0-SNAPSHOT</slf4j.version> <consolePlugin.version>1.0.1</consolePlugin.version> <retrotranslator.verify>false</retrotranslator.verify> </properties> @@ -73,6 +73,11 @@ <artifactId>slf4j-api</artifactId> <version>${slf4j.version}</version> </dependency> + <dependency> + <groupId>org.slf4j</groupId> + <artifactId>log4j-over-slf4j</artifactId> + <version>${slf4j.version}</version> + </dependency> <dependency> <groupId>janino</groupId> @@ -290,6 +295,7 @@ <url>http://svn.qos.ch/repos/logback/trunk/</url> </scm> +  + <distributionManagement> <site> <id>pixie</id>

1 0

[continuum] BUILD FAILURE: Logback-Parent - Logback Classic Module - Build Def: default maven2 buildDefinition
by John Noreplai 31 Jan '08

31 Jan '08

Online report : http://pixie:8091/continuum/buildResult.action?buildId=284&projectId=18 Build statistics: State: Failed Previous State: Error Started at: Thu 31 Jan 2008 11:40:45 +0100 Finished at: Thu 31 Jan 2008 11:40:47 +0100 Total time: 1s Build Trigger: Schedule Build Number: 10 Exit code: 1 Building machine hostname: pixie Operating system : Linux(unknown) Java Home version : java version "1.5.0_08" Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_08-b03) Java HotSpot(TM) 64-Bit Server VM (build 1.5.0_08-b03, mixed mode) Builder version : Maven version: 2.0.4 **************************************************************************** SCM Changes: **************************************************************************** No files changed **************************************************************************** Dependencies Changes: **************************************************************************** ch.qos.logback:logback-core:0.9.9-SNAPSHOT ch.qos.logback:logback-core:0.9.9-SNAPSHOT ch.qos.logback:logback-parent:0.9.9-SNAPSHOT **************************************************************************** Build Defintion: **************************************************************************** POM filename: pom.xml Goals: clean install Arguments: --batch-mode --non-recursive Build Fresh: false Always Build: false Default Build Definition: true Schedule: DEFAULT_SCHEDULE Description: default maven2 buildDefinition **************************************************************************** Test Summary: **************************************************************************** Tests: 146 Failures: 0 Total time: 4.011

1 0

[continuum] BUILD FAILURE: Logback-Parent - Logback Access Module - Build Def: default maven2 buildDefinition
by John Noreplai 31 Jan '08

31 Jan '08

Online report : http://pixie:8091/continuum/buildResult.action?buildId=282&projectId=19 Build statistics: State: Failed Previous State: Failed Started at: Thu 31 Jan 2008 11:40:32 +0100 Finished at: Thu 31 Jan 2008 11:40:43 +0100 Total time: 10s Build Trigger: Schedule Build Number: 2 Exit code: 1 Building machine hostname: pixie Operating system : Linux(unknown) Java Home version : java version "1.5.0_08" Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_08-b03) Java HotSpot(TM) 64-Bit Server VM (build 1.5.0_08-b03, mixed mode) Builder version : Maven version: 2.0.4 **************************************************************************** SCM Changes: **************************************************************************** No files changed **************************************************************************** Dependencies Changes: **************************************************************************** ch.qos.logback:logback-core:0.9.9-SNAPSHOT ch.qos.logback:logback-core:0.9.9-SNAPSHOT ch.qos.logback:logback-parent:0.9.9-SNAPSHOT **************************************************************************** Build Defintion: **************************************************************************** POM filename: pom.xml Goals: clean install Arguments: --batch-mode --non-recursive Build Fresh: false Always Build: false Default Build Definition: true Schedule: DEFAULT_SCHEDULE Description: default maven2 buildDefinition **************************************************************************** Test Summary: **************************************************************************** Tests: 0 Failures: 0 Total time: 0.0

1 0

svn commit: r1615 - in logback/trunk/logback-classic: . src/main/java/ch/qos/logback/classic/spi src/test/java/org src/test/java/org/dummy
by noreply.ceki＠qos.ch 31 Jan '08

31 Jan '08

Author: ceki Date: Thu Jan 31 11:32:17 2008 New Revision: 1615 Added: logback/trunk/logback-classic/src/test/java/org/ logback/trunk/logback-classic/src/test/java/org/dummy/ logback/trunk/logback-classic/src/test/java/org/dummy/DummyLBAppender.java logback/trunk/logback-classic/src/test/java/org/dummy/Log4jInvocation.java Modified: logback/trunk/logback-classic/pom.xml logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/CallerData.java Log: - fix bug 66 reported by Franck Routier on the SLF4J site. See http://bugzilla.slf4j.org/show_bug.cgi?id=66 for more details. In short, the caller data was not correctly extracted when going through log4j-over-slf4j. Modified: logback/trunk/logback-classic/pom.xml ============================================================================== --- logback/trunk/logback-classic/pom.xml (original) +++ logback/trunk/logback-classic/pom.xml Thu Jan 31 11:32:17 2008 @@ -46,6 +46,13 @@ </dependency> <dependency> + <groupId>org.slf4j</groupId> + <artifactId>log4j-over-slf4j</artifactId> + <scope>test</scope> + </dependency> + + + <dependency> <groupId>dom4j</groupId> <artifactId>dom4j</artifactId> <scope>test</scope> Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/CallerData.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/CallerData.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/CallerData.java Thu Jan 31 11:32:17 2008 @@ -26,6 +26,9 @@ */ public static final String NA = "?"; + // All logger call's in log4j-over-slf4j use the Category class + private static final String LOG4J_CATEGORY = "org.apache.log4j.Category"; + /** * When caller information is not available this constant is used for the line * number. @@ -91,7 +94,7 @@ int found = LINE_NA; for (int i = 0; i < steArray.length; i++) { - if(steArray[i].getClassName().equals(fqnOfInvokingClass)) { + if(isDirectlyInvokingClass(steArray[i].getClassName(), fqnOfInvokingClass)) { // the caller is assumed to be the next stack frame, hence the +1. found = i + 1; } else { @@ -113,6 +116,15 @@ return callerDataArray; } + public static boolean isDirectlyInvokingClass(String currentClass, String fqnOfInvokingClass) { + // the check for org.apachje.log4j.Category class is intended to support log4j-over-slf4j + // it solves http://bugzilla.slf4j.org/show_bug.cgi?id=66 + if(currentClass.equals(fqnOfInvokingClass) || currentClass.equals(LOG4J_CATEGORY)) { + return true; + } else { + return false; + } + } public boolean equals(Object o) { // LogLog.info("equals called"); Added: logback/trunk/logback-classic/src/test/java/org/dummy/DummyLBAppender.java ============================================================================== --- (empty file) +++ logback/trunk/logback-classic/src/test/java/org/dummy/DummyLBAppender.java Thu Jan 31 11:32:17 2008 @@ -0,0 +1,41 @@ +/** + * LOGBack: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 1999-2008, QOS.ch + * + * This library is free software, you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public License as + * published by the Free Software Foundation. + */ +package org.dummy; + +import java.util.ArrayList; +import java.util.List; + +import ch.qos.logback.classic.PatternLayout; +import ch.qos.logback.classic.spi.LoggingEvent; +import ch.qos.logback.core.AppenderBase; + +public class DummyLBAppender extends AppenderBase<LoggingEvent> { + + public List<LoggingEvent> list = new ArrayList<LoggingEvent>(); + public List<String> stringList = new ArrayList<String>(); + + PatternLayout layout; + + DummyLBAppender() { + this(null); + } + + DummyLBAppender(PatternLayout layout) { + this.layout = layout; + } + + protected void append(LoggingEvent e) { + list.add(e); + if(layout != null) { + String s = layout.doLayout(e); + stringList.add(s); + } + } +} Added: logback/trunk/logback-classic/src/test/java/org/dummy/Log4jInvocation.java ============================================================================== --- (empty file) +++ logback/trunk/logback-classic/src/test/java/org/dummy/Log4jInvocation.java Thu Jan 31 11:32:17 2008 @@ -0,0 +1,72 @@ +package org.dummy; + +import static org.junit.Assert.assertEquals; + +import org.apache.log4j.Logger; +import org.junit.Before; +import org.junit.Test; +import org.slf4j.LoggerFactory; + +import ch.qos.logback.classic.Level; +import ch.qos.logback.classic.LoggerContext; +import ch.qos.logback.classic.PatternLayout; +import ch.qos.logback.classic.spi.LoggingEvent; + +public class Log4jInvocation { + + static final String HELLO = "Hello"; + + DummyLBAppender listAppender; + LoggerContext lc; + ch.qos.logback.classic.Logger rootLogger; + + @Before + public void fixture() { + lc = (LoggerContext) LoggerFactory.getILoggerFactory(); + lc.shutdownAndReset(); + + listAppender = new DummyLBAppender(); + listAppender.setContext(lc); + listAppender.start(); + rootLogger = lc.getLogger("root"); + rootLogger.addAppender(listAppender); + } + + @Test + public void basic() { + assertEquals(0, listAppender.list.size()); + + Logger logger = Logger.getLogger("basic-test"); + logger.debug(HELLO); + + assertEquals(1, listAppender.list.size()); + LoggingEvent event = (LoggingEvent) listAppender.list.get(0); + assertEquals(HELLO, event.getMessage()); + } + + @Test + public void callerData() { + assertEquals(0, listAppender.list.size()); + + PatternLayout pl = new PatternLayout(); + pl.setPattern("%-5level [%class] %logger - %msg"); + pl.setContext(lc); + pl.start(); + listAppender.layout = pl; + + Logger logger = Logger.getLogger("basic-test"); + logger.trace("none"); + assertEquals(0, listAppender.list.size()); + + rootLogger.setLevel(Level.TRACE); + logger.trace(HELLO); + assertEquals(1, listAppender.list.size()); + + LoggingEvent event = (LoggingEvent) listAppender.list.get(0); + assertEquals(HELLO, event.getMessage()); + + assertEquals(1, listAppender.stringList.size()); + assertEquals("TRACE [" + Log4jInvocation.class.getName() + + "] basic-test - Hello", listAppender.stringList.get(0)); + } +}

1 0

[continuum] BUILD FAILURE: Logback-Parent - Logback Access Module - Build Def: default maven2 buildDefinition
by John Noreplai 30 Jan '08

30 Jan '08

Online report : http://pixie:8091/continuum/buildResult.action?buildId=265&projectId=19 Build statistics: State: Failed Previous State: Failed Started at: Wed 30 Jan 2008 17:24:01 +0100 Finished at: Wed 30 Jan 2008 17:24:14 +0100 Total time: 12s Build Trigger: Schedule Build Number: 2 Exit code: 1 Building machine hostname: pixie Operating system : Linux(unknown) Java Home version : java version "1.5.0_08" Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_08-b03) Java HotSpot(TM) 64-Bit Server VM (build 1.5.0_08-b03, mixed mode) Builder version : Maven version: 2.0.4 **************************************************************************** SCM Changes: **************************************************************************** No files changed **************************************************************************** Dependencies Changes: **************************************************************************** ch.qos.logback:logback-core:0.9.9-SNAPSHOT ch.qos.logback:logback-core:0.9.9-SNAPSHOT ch.qos.logback:logback-parent:0.9.9-SNAPSHOT **************************************************************************** Build Defintion: **************************************************************************** POM filename: pom.xml Goals: clean install Arguments: --batch-mode --non-recursive Build Fresh: false Always Build: false Default Build Definition: true Schedule: DEFAULT_SCHEDULE Description: default maven2 buildDefinition **************************************************************************** Test Summary: **************************************************************************** Tests: 0 Failures: 0 Total time: 0.0

1 0

svn commit: r1614 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net
by noreply.ceki＠qos.ch 30 Jan '08

30 Jan '08

Author: ceki Date: Wed Jan 30 17:11:42 2008 New Revision: 1614 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SocketAppenderTest.java Log: - minor change Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SocketAppenderTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SocketAppenderTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SocketAppenderTest.java Wed Jan 30 17:11:42 2008 @@ -148,8 +148,8 @@ assertEquals("updatedTestValue", MDCPropertyMap.get("key")); } - private void startServer(int expectedEventNumber) throws InterruptedException { - mockSocketServer = new MockSocketServer(expectedEventNumber); + private void startServer(int expectedNumberOfEvents) throws InterruptedException { + mockSocketServer = new MockSocketServer(expectedNumberOfEvents); mockSocketServer.start(); // give MockSocketServer head start Thread.sleep(100);

1 0