January 2008 - logback-dev - mailman3.qos.ch

svn commit: r1606 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic
by noreply.ceki＠qos.ch 23 Jan '08

23 Jan '08

Author: ceki Date: Wed Jan 23 13:18:38 2008 New Revision: 1606 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/Logger.java Log: - fixing silly but nonetheless serious copy-and-paste bugs, as reported by by Joern Huxhorn in bug #104 http://bugzilla.qos.ch/show_bug.cgi?id=104 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/Logger.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/Logger.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/Logger.java Wed Jan 23 13:18:38 2008 @@ -254,7 +254,7 @@ * Invoke all the appenders of this logger. * * @param event - * The event to log + * The event to log */ public void callAppenders(LoggingEvent event) { int writes = 0; @@ -304,9 +304,9 @@ * logger. * * @param lastPart - * the suffix (i.e. last part) of the child logger name. This - * parameter may not include dots, i.e. the logger separator - * character. + * the suffix (i.e. last part) of the child logger + * name. This parameter may not include dots, i.e. the + * logger separator character. * @return */ Logger createChildByLastNamePart(final String lastPart) { @@ -387,9 +387,7 @@ } public void trace(String msg, Throwable t) { - if (isDebugEnabled()) { - filterAndLog(FQCN, null, Level.TRACE, msg, null, t); - } + filterAndLog(FQCN, null, Level.TRACE, msg, null, t); } public final void trace(Marker marker, String msg) { @@ -432,7 +430,7 @@ final Level level, final String msg, final Object param, final Throwable t) { final FilterReply decision = loggerContext.getTurboFilterChainDecision( - marker, this, Level.DEBUG, msg, param, t); + marker, this, level, msg, param, t); if (decision == FilterReply.NEUTRAL) { if (effectiveLevelInt > level.levelInt) { @@ -451,7 +449,7 @@ final Object param2, final Throwable t) { final FilterReply decision = loggerContext.getTurboFilterChainDecision( - marker, this, Level.DEBUG, msg, param1, param2, t); + marker, this, level, msg, param1, param2, t); if (decision == FilterReply.NEUTRAL) { if (effectiveLevelInt > level.levelInt) { @@ -470,7 +468,7 @@ final Throwable t) { final FilterReply decision = loggerContext.getTurboFilterChainDecision( - marker, this, Level.DEBUG, msg, params, t); + marker, this, level, msg, params, t); if (decision == FilterReply.NEUTRAL) { if (effectiveLevelInt > level.levelInt) { @@ -817,8 +815,7 @@ level = Level.ERROR; break; default: - throw new IllegalArgumentException(levelInt - + " not a valid level value"); + throw new IllegalArgumentException(levelInt + " not a valid level value"); } filterAndLog(fqcn, marker, level, message, null, t); }

1 0

[continuum] BUILD SUCCESSFUL: Logback Access Module
by John Noreplai 23 Jan '08

23 Jan '08

Online report : http://localhost:8090/continuum/servlet/continuum/target/ProjectBuild.vm/vi… Build statistics: State: Ok Previous State: Failed Started at: Wed, 23 Jan 2008 11:00:19 +0100 Finished at: Wed, 23 Jan 2008 11:00:45 +0100 Total time: 25s Build Trigger: Schedule Exit code: 0 Building machine hostname: pixie Operating system : Linux(unknown) Java version : 1.5.0_08(Sun Microsystems Inc.) Changes ceki - request parameters can be multi-valued as observed in bug 110 http://bugzilla.qos.ch/show_bug.cgi?id=110 /logback/trunk/logback-access/src/main/java/ch/qos/logback/access/pattern/RequestParameterConverter.java /logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessEvent.java **************************************************************************** Output: **************************************************************************** [INFO] Scanning for projects... [INFO] ---------------------------------------------------------------------------- [INFO] Building Logback Access Module [INFO] task-segment: [clean, install] [INFO] ---------------------------------------------------------------------------- [INFO] [clean:clean] [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/47/target [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/classes [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/test-classes [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:compile] Compiling 65 source files to /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/classes [INFO] [resources:testResources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:testCompile] Compiling 22 source files to /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/test-classes [INFO] [surefire:test] [INFO] Surefire report directory: /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/surefire-reports ------------------------------------------------------- T E S T S ------------------------------------------------------- Running ch.qos.logback.access.db.DBAppenderTest [Server@2d92b996]: [Thread[main,5,main]]: checkRunning(false) entered [Server@2d92b996]: [Thread[main,5,main]]: checkRunning(false) exited [Server@2d92b996]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@2d92b996]: [Thread[main,5,main]]: checkRunning(false) entered [Server@2d92b996]: [Thread[main,5,main]]: checkRunning(false) exited [Server@2d92b996]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) [Server@12b7eea]: [Thread[main,5,main]]: checkRunning(false) entered [Server@12b7eea]: [Thread[main,5,main]]: checkRunning(false) exited [Server@12b7eea]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@12b7eea]: [Thread[main,5,main]]: checkRunning(false) entered [Server@12b7eea]: [Thread[main,5,main]]: checkRunning(false) exited [Server@12b7eea]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) [Server@1d10c424]: [Thread[main,5,main]]: checkRunning(false) entered [Server@1d10c424]: [Thread[main,5,main]]: checkRunning(false) exited [Server@1d10c424]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@1d10c424]: [Thread[main,5,main]]: checkRunning(false) entered [Server@1d10c424]: [Thread[main,5,main]]: checkRunning(false) exited [Server@1d10c424]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) [Server@b551d7f]: [Thread[main,5,main]]: checkRunning(false) entered [Server@b551d7f]: [Thread[main,5,main]]: checkRunning(false) exited [Server@b551d7f]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@b551d7f]: [Thread[main,5,main]]: checkRunning(false) entered [Server@b551d7f]: [Thread[main,5,main]]: checkRunning(false) exited [Server@b551d7f]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.644 sec Running ch.qos.logback.access.jetty.JettyBasicTest 2008-01-23 11:00:38.764::INFO: Logging to STDERR via org.mortbay.log.StdErrLog 2008-01-23 11:00:40.338::INFO: jetty-6.1.1 2008-01-23 11:00:40.479::INFO: Started SelectChannelConnector @ 0.0.0.0:1234 23/01/2008:11:00:40 +0100 localhost 127.0.0.1 23/01/2008:11:00:40 +0100 localhost 127.0.0.1 Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.181 sec Running ch.qos.logback.access.filter.AccessStatsTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec Running ch.qos.logback.access.pattern.ConverterTest Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.022 sec Running ch.qos.logback.access.filter.StatsByDayTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec Running ch.qos.logback.access.net.URLEvaluatorTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec Running ch.qos.logback.access.net.SocketAppenderTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.231 sec Results : Tests run: 29, Failures: 0, Errors: 0, Skipped: 0 [INFO] [jar:jar] [INFO] Building jar: /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/logback-access-0.9.9-SNAPSHOT.jar [INFO] Preparing source:jar [WARNING] Removing: jar from forked lifecycle, to prevent recursive invocation. [INFO] No goals needed for project - skipping [INFO] [source:jar {execution: default}] [INFO] Building jar: /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/logback-access-0.9.9-SNAPSHOT-sources.jar [INFO] [jar:jar {execution: bundle-test-jar}] [INFO] Building jar: /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/logback-access-0.9.9-SNAPSHOT.jar [INFO] [jar:test-jar {execution: bundle-test-jar}] [INFO] Building jar: /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/logback-access-0.9.9-SNAPSHOT-tests.jar [INFO] [install:install] [INFO] Installing /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/logback-access-0.9.9-SNAPSHOT.jar to /root/.m2/repository/ch/qos/logback/logback-access/0.9.9-SNAPSHOT/logback-access-0.9.9-SNAPSHOT.jar [INFO] Installing /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/logback-access-0.9.9-SNAPSHOT-sources.jar to /root/.m2/repository/ch/qos/logback/logback-access/0.9.9-SNAPSHOT/logback-access-0.9.9-SNAPSHOT-sources.jar [INFO] Installing /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/logback-access-0.9.9-SNAPSHOT-tests.jar to /root/.m2/repository/ch/qos/logback/logback-access/0.9.9-SNAPSHOT/logback-access-0.9.9-SNAPSHOT-tests.jar [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESSFUL [INFO] ------------------------------------------------------------------------ [INFO] Total time: 23 seconds [INFO] Finished at: Wed Jan 23 11:00:44 CET 2008 [INFO] Final Memory: 17M/182M [INFO] ------------------------------------------------------------------------ ****************************************************************************

1 0

[continuum] BUILD FAILURE: Logback-Parent
by John Noreplai 23 Jan '08

23 Jan '08

Online report : http://localhost:8090/continuum/servlet/continuum/target/ProjectBuild.vm/vi… Build statistics: State: Failed Previous State: Failed Started at: Wed, 23 Jan 2008 11:00:08 +0100 Finished at: Wed, 23 Jan 2008 11:00:15 +0100 Total time: 7s Build Trigger: Schedule Exit code: 1 Building machine hostname: pixie Operating system : Linux(unknown) Java version : 1.5.0_08(Sun Microsystems Inc.) Changes ceki - request parameters can be multi-valued as observed in bug 110 http://bugzilla.qos.ch/show_bug.cgi?id=110 /logback/trunk/logback-access/src/main/java/ch/qos/logback/access/pattern/RequestParameterConverter.java /logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessEvent.java **************************************************************************** Output: **************************************************************************** [INFO] Scanning for projects... [INFO] ---------------------------------------------------------------------------- [INFO] Building Logback-Parent [INFO] task-segment: [clean, install] [INFO] ---------------------------------------------------------------------------- [INFO] ------------------------------------------------------------------------ [ERROR] BUILD ERROR [INFO] ------------------------------------------------------------------------ [INFO] 'translate-project' was specified in an execution, but not found in the plugin [INFO] ------------------------------------------------------------------------ [INFO] For more information, run Maven with the -e switch [INFO] ------------------------------------------------------------------------ [INFO] Total time: 4 seconds [INFO] Finished at: Wed Jan 23 11:00:15 CET 2008 [INFO] Final Memory: 8M/83M [INFO] ------------------------------------------------------------------------ ****************************************************************************

1 0

svn commit: r1605 - in logback/trunk/logback-access/src/main/java/ch/qos/logback/access: pattern spi
by noreply.ceki＠qos.ch 23 Jan '08

23 Jan '08

Author: ceki Date: Wed Jan 23 10:52:19 2008 New Revision: 1605 Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/pattern/RequestParameterConverter.java logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessEvent.java Log: - request parameters can be multi-valued as observed in bug 110 http://bugzilla.qos.ch/show_bug.cgi?id=110 Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/pattern/RequestParameterConverter.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/pattern/RequestParameterConverter.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/pattern/RequestParameterConverter.java Wed Jan 23 10:52:19 2008 @@ -1,9 +1,10 @@ package ch.qos.logback.access.pattern; +import java.util.Arrays; + import ch.qos.logback.access.spi.AccessEvent; import ch.qos.logback.core.util.OptionHelper; - public class RequestParameterConverter extends AccessConverter { String key; @@ -22,7 +23,14 @@ return "INACTIVE_REQUEST_PARAM_CONV"; } - return accessEvent.getRequestParameter(key); + String[] paramArray = accessEvent.getRequestParameter(key); + if (paramArray.length == 1) { + return paramArray[0]; + } else { + // for an array string {"a", "b"} named 'sa', Array.toString(sa) returns the string + // "[a, b]". + return Arrays.toString(paramArray); + } } } Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessEvent.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessEvent.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessEvent.java Wed Jan 23 10:52:19 2008 @@ -14,6 +14,8 @@ import ch.qos.logback.access.pattern.AccessConverter; import ch.qos.logback.access.servlet.Util; +// Contributors: Joern Huxhorn (see also bug #110) + /** * The Access module's internal representation of logging events. When the * logging component instance is called in the container to log then a @@ -28,6 +30,8 @@ private static final long serialVersionUID = -3118194368414470960L; public final static String NA = "-"; + public final static String[] NA_STRING_ARRAY = new String[] {AccessEvent.NA}; + public final static String EMPTY = ""; public static final int SENTINEL = -1; @@ -46,7 +50,7 @@ String responseContent; Map<String, String> requestHeaderMap; - Map<String, Object> requestParameterMap; + Map<String, String[]> requestParameterMap; long contentLength = SENTINEL; int statusCode = SENTINEL; @@ -235,17 +239,24 @@ } public void buildRequestParameterMap() { - requestParameterMap = new HashMap<String, Object>(); + requestParameterMap = new HashMap<String, String[]>(); Enumeration e = httpRequest.getParameterNames(); if (e == null) { return; } while (e.hasMoreElements()) { String key = (String) e.nextElement(); - requestParameterMap.put(key, httpRequest.getParameter(key)); + requestParameterMap.put(key, httpRequest.getParameterValues(key)); } } + public Map<String, String[]> getRequestParameterMap() { + if (requestParameterMap == null) { + buildRequestParameterMap(); + } + return requestParameterMap; +} + public String getResponseHeader(String key) { return serverAdapter.getResponseHeader(key); } @@ -273,16 +284,16 @@ } } - public String getRequestParameter(String key) { + public String[] getRequestParameter(String key) { if (httpRequest != null) { - Object value = httpRequest.getParameter(key); + String[] value = httpRequest.getParameterValues(key); if (value == null) { - return AccessEvent.NA; + return NA_STRING_ARRAY; } else { - return value.toString(); + return value; } } else { - return AccessEvent.NA; + return NA_STRING_ARRAY; } }

1 0

Contributing patches
by Matt Fowles 21 Jan '08

21 Jan '08

All~ What is the preferred way to provide patches for new functionality or fixes? I emailed two patches directly to the list, but I could move them to tickets in bugzilla if people prefer. Matt

3 2

[Bug 122] New: evaluator on MDC conversion word
by bugzilla-daemon＠pixie.qos.ch 18 Jan '08

18 Jan '08

http://bugzilla.qos.ch/show_bug.cgi?id=122 Summary: evaluator on MDC conversion word Product: logback-classic Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P3 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: hontvari3(a)solware.com It would be useful if the MDC keyword also has evaluator parameters just like the caller conversion word. An example usage: In a web application I store HTTP headers, parameters, URL into an MDC variable. This context information should be displayed with most log message. However there are a few types of log messages which are very frequent. Eventually (but it may take years) the reason for this messages are eliminated, but until then the long context information should be supressed from the log file. (In such cases the frequency or the existence of the event is the information, not the content of the event.) -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0

[Bug 57] New: Problems getting autogenerated Keys in Oracle with Oracle JDBC 10.2.03
by bugzilla-daemon＠pixie.qos.ch 11 Jan '08

11 Jan '08

http://bugzilla.qos.ch/show_bug.cgi?id=57 Summary: Problems getting autogenerated Keys in Oracle with Oracle JDBC 10.2.03 Product: logback-core Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: critical Priority: P1 Component: Appender AssignedTo: logback-dev(a)qos.ch ReportedBy: klaus(a)ungers-online.com I've encountered troubles logging StackTrace/MDC entries with die DBAppender on our plattform! We are using Oracle 9.2.0.6.0 on a Solaris Box with Oracle JDBC Driver 10.2.0.3! I've debugged the processing of LogMessages into DBAppenderBase.append()! There I found a call "con.prepareStatement(getInsertSQL())" which is followed by a call "subAppend(...)" As far as I understand Oracle Drivers return generatedKeys only, if you use the right prepareStatement() methods, which is in my understanding the following: PreparedStatement prepareStatement(String sql, int autoGeneratedKeys) throws SQLException @see http://java.sun.com/j2se/1.5.0/docs/api/java/sql/Connection.html#prepareSta… which is available since JDK 1.4 -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 4

[Bug 119] New: Make BasicStatusManager more sub-class friendly
by bugzilla-daemon＠pixie.qos.ch 10 Jan '08

10 Jan '08

http://bugzilla.qos.ch/show_bug.cgi?id=119 Summary: Make BasicStatusManager more sub-class friendly Product: logback-core Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P2 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: anders(a)hammar.net To allow for more implementation specific sub-classes of BasicStatusManager, class attribute should be 'protected' (or add setters and getters). In the current implementation, a sub-class cannot (for instance) modify the statusList (to clear the statuses or such). -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0

[Bug 117] New: Synchronization of SimpleDateFormat object in DateConverter
by bugzilla-daemon＠pixie.qos.ch 10 Jan '08

10 Jan '08

http://bugzilla.qos.ch/show_bug.cgi?id=117 Summary: Synchronization of SimpleDateFormat object in DateConverter Product: logback-classic Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: anders(a)hammar.net According to the API documentation of SimpleDateFormat, date formats are not synchronized and it is recommended to create separate format instances for each thread. However, a possibly simpler (mer efficient) solution would be to synchronize on the SimpleDateFormat object in the convert() method to prevent two threads to access it concurrently. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 4

[Bug 115] New: Improve WriterAppender
by bugzilla-daemon＠pixie.qos.ch 09 Jan '08

09 Jan '08

http://bugzilla.qos.ch/show_bug.cgi?id=115 Summary: Improve WriterAppender Product: logback-core Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: enhancement Priority: P4 Component: Appender AssignedTo: logback-dev(a)qos.ch ReportedBy: anders(a)hammar.net Reviewing the ch.qos.logback.core.WriterAppender class, I see that the attributes are 'protected' (not 'private'). However, there are set and get methods for most of them (but not all). I suggest making the attributes private and create setters and getters for all of them (there is no getWriter() for instance). This would prevent subclasses from incorrectly working directly against the attributes (for instance, not using the setWriter() would cause errors). If some 'public' getters are not desirable, at least 'protected' ones should be provided. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 1