October 2008 - logback-dev - mailman3.qos.ch

svn commit: r1855 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic
by noreply.ceki＠qos.ch 22 Oct '08

22 Oct '08

Author: ceki Date: Mon Oct 20 21:57:39 2008 New Revision: 1855 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerPerfTest.java Log: Related to LBCORE-58 SleepAppender can derive from UnsynchronizedAppenderBase Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerPerfTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerPerfTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerPerfTest.java Mon Oct 20 21:57:39 2008 @@ -9,89 +9,111 @@ */ package ch.qos.logback.classic; +import static org.junit.Assert.assertTrue; -import java.net.InetAddress; - -import junit.framework.TestCase; - +import org.junit.Before; +import org.junit.Test; import org.slf4j.helpers.BogoPerf; import ch.qos.logback.classic.spi.LoggingEvent; import ch.qos.logback.classic.turbo.NOPTurboFilter; +import ch.qos.logback.core.UnsynchronizedAppenderBase; import ch.qos.logback.core.appender.NOPAppender; -public class LoggerPerfTest extends TestCase { - - final static String KAL = "kal"; - String localhostName = null; - static long NORMAL_RUN_LENGTH = 1000*1000; +public class LoggerPerfTest { + long NANOS_IN_ONE_SEC = 1000*1000*1000L; + static long NORMAL_RUN_LENGTH = 1000 * 1000; + static long SHORTENED_RUN_LENGTH = 500 * 1000; static long REFERENCE_BIPS = 9324; - + + @Before public void setUp() throws Exception { - localhostName = InetAddress.getLocalHost().getCanonicalHostName(); } - public void testBasic() { - basicDurationInNanos(NORMAL_RUN_LENGTH); - double avg = basicDurationInNanos(NORMAL_RUN_LENGTH); - + + @Test + public void testDurationOfDisabledLogWithStraightStringParameter() { + computeDurationOfDisabledLogWithStraightStringParameter(NORMAL_RUN_LENGTH); + double avg = computeDurationOfDisabledLogWithStraightStringParameter(NORMAL_RUN_LENGTH); + long referencePerf = 17; BogoPerf.assertDuration(avg, referencePerf, REFERENCE_BIPS); - //System.out.println("Average log time for disabled statements: "+avg+" nanos."); - } - - public void testParameterized() { - loopParameterized(NORMAL_RUN_LENGTH); - double avgDuration = loopParameterized(NORMAL_RUN_LENGTH); - long referencePerf = 36; - BogoPerf.assertDuration(avgDuration, referencePerf, REFERENCE_BIPS); - //System.out.println("Average log time for disabled (parameterized) statements: "+avg+" nanos."); } - - - public void testNOPFilter() { - loopNopFilter(NORMAL_RUN_LENGTH); - double avg = loopNopFilter(NORMAL_RUN_LENGTH); - //System.out.println("Average log time for disabled (NOPFilter) statements: "+avg+" nanos."); - long referencePerf = 48; - BogoPerf.assertDuration(avg, referencePerf, REFERENCE_BIPS); - } - - double basicDurationInNanos(long len) { + + double computeDurationOfDisabledLogWithStraightStringParameter(long len) { LoggerContext lc = new LoggerContext(); - NOPAppender<LoggingEvent> mopAppender = new NOPAppender<LoggingEvent>(); - mopAppender.start(); Logger logger = lc.getLogger(this.getClass()); logger.setLevel(Level.OFF); - for(long i = 0; i < len; i++) { + for (long i = 0; i < len; i++) { logger.debug("Toto"); } long start = System.nanoTime(); - for(long i = 0; i < len; i++) { + for (long i = 0; i < len; i++) { logger.debug("Toto"); } long end = System.nanoTime(); - return (end-start)/len; + return (end - start) / len; } - double loopParameterized(long len) { + @Test + public void testDurationOfDisabledLogWithParameters() { + computeDurationOfDisabledLogWithParameters(NORMAL_RUN_LENGTH); + double avgDuration = computeDurationOfDisabledLogWithParameters(NORMAL_RUN_LENGTH); + long referencePerf = 36; + BogoPerf.assertDuration(avgDuration, referencePerf, REFERENCE_BIPS); + } + + double computeDurationOfDisabledLogWithParameters(long len) { LoggerContext lc = new LoggerContext(); - NOPAppender<LoggingEvent> mopAppender = new NOPAppender<LoggingEvent>(); - mopAppender.start(); Logger logger = lc.getLogger(this.getClass()); logger.setLevel(Level.OFF); - for(long i = 0; i < len; i++) { + for (long i = 0; i < len; i++) { logger.debug("Toto {}", i); } long start = System.nanoTime(); - for(long i = 0; i < len; i++) { + for (long i = 0; i < len; i++) { logger.debug("Toto {}", i); } long end = System.nanoTime(); - return (end-start)/len; + return (end - start) / len; + } + + @Test + public void testDurationOfEnabledWithStraightStringParameter() { + computeDurationOfEnabledLogWithStraightStringParameter(SHORTENED_RUN_LENGTH); + double avgDuration = computeDurationOfEnabledLogWithStraightStringParameter(SHORTENED_RUN_LENGTH); + long referencePerf = 500; + BogoPerf.assertDuration(avgDuration, referencePerf, REFERENCE_BIPS); + System.out.println("avgDuration="+avgDuration); } - double loopNopFilter(long len) { + double computeDurationOfEnabledLogWithStraightStringParameter(long len) { + LoggerContext lc = new LoggerContext(); + Logger logger = lc.getLogger(this.getClass()); + logger.setLevel(Level.ALL); + NOPAppender<LoggingEvent> nopAppender = new NOPAppender<LoggingEvent>(); + nopAppender.start(); + logger.addAppender(nopAppender); + for (long i = 0; i < len; i++) { + logger.debug("Toto", i); + } + long start = System.nanoTime(); + for (long i = 0; i < len; i++) { + logger.debug("Toto"); + } + long end = System.nanoTime(); + return (end - start) / len; + } + + @Test + public void testComputeDurationOfDisabledLogsWithNOPFilter() { + computeDurationOfDisabledLogsWithNOPFilter(NORMAL_RUN_LENGTH); + double avg = computeDurationOfDisabledLogsWithNOPFilter(NORMAL_RUN_LENGTH); + long referencePerf = 48; + BogoPerf.assertDuration(avg, referencePerf, REFERENCE_BIPS); + } + + double computeDurationOfDisabledLogsWithNOPFilter(long len) { LoggerContext lc = new LoggerContext(); NOPAppender<LoggingEvent> mopAppender = new NOPAppender<LoggingEvent>(); NOPTurboFilter nopFilter = new NOPTurboFilter(); @@ -100,15 +122,92 @@ lc.addTurboFilter(nopFilter); Logger logger = lc.getLogger(this.getClass()); logger.setLevel(Level.OFF); - for(long i = 0; i < len; i++) { + for (long i = 0; i < len; i++) { logger.debug("Toto"); } long start = System.nanoTime(); - for(long i = 0; i < len; i++) { + for (long i = 0; i < len; i++) { logger.debug("Toto"); } long end = System.nanoTime(); - return (end-start)/len; + return (end - start) / len; } - + + @Test + public void testThreadedLogging() throws InterruptedException { + LoggerContext lc = new LoggerContext(); + SleepAppender<LoggingEvent> appender = new SleepAppender<LoggingEvent>(); + + int MILLIS_PER_CALL = 250; + int NANOS_PER_CALL = 250*1000*1000;; + appender.setDuration(MILLIS_PER_CALL); + appender.start(); + Logger logger = lc.getLogger(this.getClass()); + logger.addAppender(appender); + logger.setLevel(Level.DEBUG); + long start; + long end; + int threadCount = 10; + int iterCount = 5; + TestRunner[] threads = new TestRunner[threadCount]; + for (int i = 0; i < threads.length; ++i) { + threads[i] = new TestRunner(logger, iterCount); + } + start = System.nanoTime(); + for (Thread thread : threads) { + thread.start(); + } + for (TestRunner thread : threads) { + thread.join(); + } + end = System.nanoTime(); + double tolerance = threadCount * .125; // Very little thread contention + // should occur in this test. + double max = ((((double) NANOS_PER_CALL) / NANOS_IN_ONE_SEC) * iterCount) * tolerance; + double serialized = (((double) NANOS_PER_CALL) / NANOS_IN_ONE_SEC) * iterCount + * threadCount; + double actual = ((double) (end - start)) / NANOS_IN_ONE_SEC; + System.out + .printf( + "Sleep duration: %,.4f seconds. Max expected: %,.4f seconds, Serialized: %,.4f\n", + actual, max, serialized); + assertTrue("Exceeded maximum expected time.", actual < max); + } + + // ============================================================ + private static class TestRunner extends Thread { + private Logger logger; + private long len; + + public TestRunner(Logger logger, long len) { + this.logger = logger; + this.len = len; + } + + public void run() { + Thread.yield(); + for (long i = 0; i < len; i++) { + logger.debug("Toto"); + } + } + } + + // ============================================================ + public static class SleepAppender<E> extends UnsynchronizedAppenderBase<E> { + private static long duration = 500; + + public void setDuration(long millis) { + duration = millis; + } + + @Override + protected void append(E eventObject) { + try { + Thread.sleep(duration); + } catch (InterruptedException ie) { + // Ignore + } + } + } + // ============================================================ }

3 6

[JIRA] Resolved: (LBCORE-15) Problems getting autogenerated Keys in Oracle with Oracle JDBC 10.2.03
by Ceki Gulcu (JIRA) 22 Oct '08

22 Oct '08

[ http://jira.qos.ch/browse/LBCORE-15?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu resolved LBCORE-15. ------------------------------ Fix Version/s: 0.9.10 Resolution: Fixed It's actually more of a JDBC driver issue then a RDBMS version issue. I could reproduce the problem on Oracle 10g using ojdbc14.jar (version 10.2.0.1). This JDBC drivers support the getGeneratedKeys method. The problem cannot be reproduced with an older driver, classic12.jar, version 9.0.1.4.0, because it does not support getGeneratedKeys(). Anyway, the code has been modified to use the connection. prepareStatement() method taking two arguments, the sql statement follows by the auto-generated columnNames, as suggested John Gibson. Surprisingly enough, this change is compatible with other databases supporting getGeneratedKeys(). Fixed in revision 1859 > Problems getting autogenerated Keys in Oracle with Oracle JDBC 10.2.03 > ---------------------------------------------------------------------- > > Key: LBCORE-15 > URL: http://jira.qos.ch/browse/LBCORE-15 > Project: logback-core > Issue Type: Bug > Components: Appender > Affects Versions: unspecified > Environment: Operating System: Windows > Platform: PC > Reporter: Klaus Unger > Assignee: Logback dev list > Priority: Blocker > Fix For: 0.9.10 > > > I've encountered troubles logging StackTrace/MDC entries with die DBAppender on our plattform! We are using Oracle 9.2.0.6.0 on a Solaris Box with Oracle JDBC Driver 10.2.0.3! > I've debugged the processing of LogMessages into DBAppenderBase.append()! > There I found a call "con.prepareStatement(getInsertSQL())" which is followed by a call "subAppend(...)" > As far as I understand Oracle Drivers return generatedKeys only, if you use the right prepareStatement() methods, which is in my understanding the following: > PreparedStatement prepareStatement(String sql, int autoGeneratedKeys) > throws SQLException > @see http://java.sun.com/j2se/1.5.0/docs/api/java/sql/Connection.html#prepareSta… > which is available since JDK 1.4 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Issue Comment Edited: (LBCORE-15) Problems getting autogenerated Keys in Oracle with Oracle JDBC 10.2.03
by Ceki Gulcu (JIRA) 22 Oct '08

22 Oct '08

[ http://jira.qos.ch/browse/LBCORE-15?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu edited comment on LBCORE-15 at 10/22/08 11:00 PM: ------------------------------------------------------------- It's actually more of a JDBC driver issue then a RDBMS version issue. I could reproduce the problem on Oracle 10g using ojdbc14.jar (version 10.2.0.1). This JDBC drivers support the getGeneratedKeys method. The problem cannot be reproduced with an older driver, classic12.jar, version 9.0.1.4.0, because it does not support getGeneratedKeys(). Anyway, the code has been modified to use the connection. prepareStatement() method taking two arguments, the sql statement follows by the auto-generated columnNames, as suggested John Gibson. Surprisingly enough, this change is compatible with other databases supporting getGeneratedKeys(). Fixed in revision 1860 was (Author: noreply.ceki(a)qos.ch) It's actually more of a JDBC driver issue then a RDBMS version issue. I could reproduce the problem on Oracle 10g using ojdbc14.jar (version 10.2.0.1). This JDBC drivers support the getGeneratedKeys method. The problem cannot be reproduced with an older driver, classic12.jar, version 9.0.1.4.0, because it does not support getGeneratedKeys(). Anyway, the code has been modified to use the connection. prepareStatement() method taking two arguments, the sql statement follows by the auto-generated columnNames, as suggested John Gibson. Surprisingly enough, this change is compatible with other databases supporting getGeneratedKeys(). Fixed in revision 1859 > Problems getting autogenerated Keys in Oracle with Oracle JDBC 10.2.03 > ---------------------------------------------------------------------- > > Key: LBCORE-15 > URL: http://jira.qos.ch/browse/LBCORE-15 > Project: logback-core > Issue Type: Bug > Components: Appender > Affects Versions: unspecified > Environment: Operating System: Windows > Platform: PC > Reporter: Klaus Unger > Assignee: Logback dev list > Priority: Blocker > Fix For: 0.9.10 > > > I've encountered troubles logging StackTrace/MDC entries with die DBAppender on our plattform! We are using Oracle 9.2.0.6.0 on a Solaris Box with Oracle JDBC Driver 10.2.0.3! > I've debugged the processing of LogMessages into DBAppenderBase.append()! > There I found a call "con.prepareStatement(getInsertSQL())" which is followed by a call "subAppend(...)" > As far as I understand Oracle Drivers return generatedKeys only, if you use the right prepareStatement() methods, which is in my understanding the following: > PreparedStatement prepareStatement(String sql, int autoGeneratedKeys) > throws SQLException > @see http://java.sun.com/j2se/1.5.0/docs/api/java/sql/Connection.html#prepareSta… > which is available since JDK 1.4 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r1861 - logback/trunk/logback-site/src/site/pages
by noreply.ceki＠qos.ch 22 Oct '08

22 Oct '08

Author: ceki Date: Wed Oct 22 22:58:35 2008 New Revision: 1861 Modified: logback/trunk/logback-site/src/site/pages/news.html Log: - updating the news.html file Modified: logback/trunk/logback-site/src/site/pages/news.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/news.html (original) +++ logback/trunk/logback-site/src/site/pages/news.html Wed Oct 22 22:58:35 2008 @@ -145,7 +145,11 @@ - + Fixed issue <a + href="http://jira.qos.ch/browse/LBCLASSIC-48">LBCLASSIC-48</a> + reported by Peter Royal. SyslogAppender now correctly outputs hours + as 0-23 and not as 1-12 as previously. + <a href="http://jira.qos.ch/browse/LBCLASSIC-53">LBCLASSIC-53</a>

1 0

svn commit: r1859 - logback/trunk/logback-examples
by noreply.ceki＠qos.ch 22 Oct '08

22 Oct '08

Author: ceki Date: Wed Oct 22 19:34:05 2008 New Revision: 1859 Modified: logback/trunk/logback-examples/pom.xml Log: indentation changes only Modified: logback/trunk/logback-examples/pom.xml ============================================================================== --- logback/trunk/logback-examples/pom.xml (original) +++ logback/trunk/logback-examples/pom.xml Wed Oct 22 19:34:05 2008 @@ -1,11 +1,13 @@ -<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> +<project xmlns="http://maven.apache.org/POM/4.0.0" + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> <version>0.9.10-SNAPSHOT</version> </parent> - + <modelVersion>4.0.0</modelVersion> <groupId>ch.qos.logback</groupId> @@ -15,49 +17,47 @@ <name>Logback Examples Module</name> <url>http://logback.qos.ch</url> - <description> - Logback: the generic, reliable, fast and flexible logging library for Java. + <description> + Logback: the generic, reliable, fast and flexible logging + library for Java. </description> <licenses> <license> - <name> GNU Lesser General Public License</name> - <url>http://www.gnu.org/licenses/lgpl.html</url> + <name>GNU Lesser General Public License</name> + <url>http://www.gnu.org/licenses/lgpl.html</url> </license> </licenses> <dependencies> - + <dependency> <groupId>ch.qos.logback</groupId> <artifactId>logback-core</artifactId> </dependency> - + <dependency> <groupId>ch.qos.logback</groupId> <artifactId>logback-classic</artifactId> </dependency> - + <dependency> <groupId>ch.qos.logback</groupId> <artifactId>logback-access</artifactId> </dependency> - + <dependency> - <groupId>org.slf4j</groupId> - <artifactId>slf4j-ext</artifactId> + <groupId>org.slf4j</groupId> + <artifactId>slf4j-ext</artifactId> </dependency> - + <dependency> <groupId>javax.servlet</groupId> <artifactId>servlet-api</artifactId> <scope>compile</scope> <optional>true</optional> </dependency> - - </dependencies> - - + </dependencies> <build> <resources> @@ -76,31 +76,30 @@ </configuration> </plugin> - <plugin> - <artifactId>maven-antrun-plugin</artifactId> - <executions> - <execution> - <phase>package</phase> - <configuration> - <tasks> - <property name="slf4jJAR" - value="${settings.localRepository}/org/slf4j/slf4j-api/${slf4j.version}/slf4j-api-${slf4j.version}.jar"/> - <echo>Copying ${slf4jJAR} to lib/</echo> - <delete> - <fileset dir="lib/" includes="slf4j-*SNAPSHOT.jar"/> - </delete> - <copy file="${slf4jJAR}" todir="lib/"/> - </tasks> - </configuration> - <goals> - <goal>run</goal> - </goals> - </execution> - </executions> - </plugin> - - - </plugins> + <plugin> + <artifactId>maven-antrun-plugin</artifactId> + <executions> + <execution> + <phase>package</phase> + <configuration> + <tasks> + <property name="slf4jJAR" + value="${settings.localRepository}/org/slf4j/slf4j-api/${slf4j.version}/slf4j-api-${slf4j.version}.jar" /> + <echo>Copying ${slf4jJAR} to lib/</echo> + <delete> + <fileset dir="lib/" + includes="slf4j-*SNAPSHOT.jar" /> + </delete> + <copy file="${slf4jJAR}" todir="lib/" /> + </tasks> + </configuration> + <goals> + <goal>run</goal> + </goals> + </execution> + </executions> + </plugin> + </plugins> </build> </project> \ No newline at end of file

1 0

svn commit: r1858 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect
by noreply.ceki＠qos.ch 22 Oct '08

22 Oct '08

Author: ceki Date: Wed Oct 22 11:04:21 2008 New Revision: 1858 Added: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle.sql - copied, changed from r1857, /logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle9i.sql Removed: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/db2l.sql logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle9i.sql Log: - Removed superfluous file db2l.sql - renamed oracle9i.sql as oracle.sql Copied: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle.sql (from r1857, /logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle9i.sql) ============================================================================== --- /logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle9i.sql (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle.sql Wed Oct 22 11:04:21 2008 @@ -1,8 +1,9 @@ -- This SQL script creates the required tables by ch.qos.logback.classic.db.DBAppender -- --- It is intended for Oracle 9i databases. Tested on version 9.2 +-- It is intended for Oracle 9i, 10g and 11g databases. Tested on version 9.2, 10g and +-- 11g. --- The following lines are useful in cleaning any previous tables +-- The following lines are useful in cleaning any previously existing tables --drop TRIGGER logging_event_id_seq_trig; --drop SEQUENCE logging_event_id_seq; @@ -29,6 +30,11 @@ ); +-- the / suffix may or may not be needed depending on your SQL Client +-- Some SQL Clients, e.g. SQuirrel SQL has trouble with the following +-- trigger creation command, while SQLPlus (the basic SQL Client which +-- ships with Oracle) has no trouble at all. + CREATE TRIGGER logging_event_id_seq_trig BEFORE INSERT ON logging_event FOR EACH ROW @@ -38,7 +44,6 @@ FROM DUAL; END; / --- the / suffix may or may not be needed depending on your SQL Client CREATE TABLE logging_event_property

1 0

[JIRA] Created: (LBGENERAL-23) add support for package version & jar name in the stack trace
by James Strachan (JIRA) 21 Oct '08

21 Oct '08

add support for package version & jar name in the stack trace ------------------------------------------------------------- Key: LBGENERAL-23 URL: http://jira.qos.ch/browse/LBGENERAL-23 Project: logback-general Issue Type: New Feature Reporter: James Strachan Assignee: Logback dev list add support for this patch... https://issues.apache.org/bugzilla/show_bug.cgi?id=45721 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

3 7

[JIRA] Commented: (LBCORE-15) Problems getting autogenerated Keys in Oracle with Oracle JDBC 10.2.03
by Ceki Gulcu (JIRA) 21 Oct '08

21 Oct '08

[ http://jira.qos.ch/browse/LBCORE-15?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu commented on LBCORE-15: ---------------------------------- I have tested the existing code on Oracle 11g (version 11.1.0.6.0) and it seems to work just fine. I'll see if I can reproduce it with Oracle 10g. > Problems getting autogenerated Keys in Oracle with Oracle JDBC 10.2.03 > ---------------------------------------------------------------------- > > Key: LBCORE-15 > URL: http://jira.qos.ch/browse/LBCORE-15 > Project: logback-core > Issue Type: Bug > Components: Appender > Affects Versions: unspecified > Environment: Operating System: Windows > Platform: PC > Reporter: Klaus Unger > Assignee: Logback dev list > Priority: Blocker > > I've encountered troubles logging StackTrace/MDC entries with die DBAppender on our plattform! We are using Oracle 9.2.0.6.0 on a Solaris Box with Oracle JDBC Driver 10.2.0.3! > I've debugged the processing of LogMessages into DBAppenderBase.append()! > There I found a call "con.prepareStatement(getInsertSQL())" which is followed by a call "subAppend(...)" > As far as I understand Oracle Drivers return generatedKeys only, if you use the right prepareStatement() methods, which is in my understanding the following: > PreparedStatement prepareStatement(String sql, int autoGeneratedKeys) > throws SQLException > @see http://java.sun.com/j2se/1.5.0/docs/api/java/sql/Connection.html#prepareSta… > which is available since JDK 1.4 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r1857 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect
by noreply.ceki＠qos.ch 21 Oct '08

21 Oct '08

Author: ceki Date: Tue Oct 21 23:25:22 2008 New Revision: 1857 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle9i.sql Log: minor comment Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle9i.sql ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle9i.sql (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle9i.sql Tue Oct 21 23:25:22 2008 @@ -38,6 +38,8 @@ FROM DUAL; END; / +-- the / suffix may or may not be needed depending on your SQL Client + CREATE TABLE logging_event_property (

1 0

svn commit: r1856 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic
by noreply.ceki＠qos.ch 20 Oct '08

20 Oct '08

Author: ceki Date: Mon Oct 20 22:04:18 2008 New Revision: 1856 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PackageTest.java Log: Adapt to JUnit4 style Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PackageTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PackageTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PackageTest.java Mon Oct 20 22:04:18 2008 @@ -16,7 +16,7 @@ public static Test suite() { TestSuite suite = new TestSuite(); suite.addTestSuite(LoggerContextTest.class); - suite.addTestSuite(LoggerPerfTest.class); + suite.addTest(new JUnit4TestAdapter(LoggerPerfTest.class)); suite.addTest(new JUnit4TestAdapter(DynamicLoggerContextTest.class)); suite.addTest(new JUnit4TestAdapter(PatternLayoutTest.class)); suite.addTestSuite(BasicLoggerTest.class);

1 0