October 2008 - logback-dev - mailman3.qos.ch

svn commit: r1845 - logback/trunk/logback-site/src/site/pages
by noreply.ceki＠qos.ch 17 Oct '08

17 Oct '08

Author: ceki Date: Fri Oct 17 23:47:24 2008 New Revision: 1845 Modified: logback/trunk/logback-site/src/site/pages/news.html Log: refer to the correct issue Modified: logback/trunk/logback-site/src/site/pages/news.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/news.html (original) +++ logback/trunk/logback-site/src/site/pages/news.html Fri Oct 17 23:47:24 2008 @@ -103,7 +103,7 @@ Fixed issue <a - href="http://jira.qos.ch/browse/LBCORE-27">LBCORE-55</a> reported by + href="http://jira.qos.ch/browse/LBCORE-55">LBCORE-55</a> reported by Natan Cox. <code>WriterAppender</code> now outputs its presentation footer and file footer in the the correct order.

1 0

svn commit: r1844 - logback/trunk/logback-site/src/site/pages
by noreply.ceki＠qos.ch 17 Oct '08

17 Oct '08

Author: ceki Date: Fri Oct 17 23:45:58 2008 New Revision: 1844 Modified: logback/trunk/logback-site/src/site/pages/news.html Log: various updates Modified: logback/trunk/logback-site/src/site/pages/news.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/news.html (original) +++ logback/trunk/logback-site/src/site/pages/news.html Fri Oct 17 23:45:58 2008 @@ -29,7 +29,7 @@ <hr width="80%" align="center" /> - <h3>XXth of September 2008 - Release of version 0.9.10</h3> + <h3>XXth of October 2008 - Release of version 0.9.10</h3> In case of errors during initialization, logback-classic now automatically prints out its internal status. This has been @@ -60,6 +60,8 @@ developpers list. +  + Fixed issue <a href="http://jira.qos.ch/browse/LBCORE-48">LBCORE-48</a>. During rollover, compression of large files would bring all logging to a @@ -77,16 +79,44 @@ href="http://jira.qos.ch/browse/LBCORE-42">LBCORE-42</a>. If the parent directory of the log file does not exist, then FileAppender will create it, including any necessary but nonexistent parent - directories. + directories. + + + Fixed issue <a + href="http://jira.qos.ch/browse/LBCORE-17">LBCORE-17</a> reported by + Thorbjørn Ravn Andersen. Logback now relies on Geronimo JMS + API specifications instead of Sun's JMS API specification, the + latter requiring manual installation. With Geronimo JMS, logback can + be built using Maven without needing to manually install any + dependencies. + + + Fixed issue <a + href="http://jira.qos.ch/browse/LBCORE-23">LBCORE-23</a>. In + PatternLayout, parenthesis can be used to group conversion + patterns. It follows that the '(' and ')' carry special meaning and + need to be escaped to be used as literals. This is now properly + documented. + + + <a href="http://jira.qos.ch/browse/LBCORE-32">LBCORE-32</a> + + + Fixed issue <a + href="http://jira.qos.ch/browse/LBCORE-27">LBCORE-55</a> reported by + Natan Cox. <code>WriterAppender</code> now outputs its presentation + footer and file footer in the the correct order. Fixed issue <a href="http://jira.qos.ch/browse/LBCORE-27">LBCORE-27</a> reported by - Peter Royal. SMTPAppender now outputs its presentation footer and - file footer in the the correct order. + Peter Royal. <code>SMTPAppender</code> now outputs its presentation + footer and file footer in the the correct order. +  + Fixed issue <a href="http://jira.qos.ch/browse/LBCLASSIC-67">LBCLASSIC-67</a> reported by Alessandro Fustini. SMTPAppender now correctly @@ -114,17 +144,7 @@ command and SSL connections. - Fixed issue <a - href="http://jira.qos.ch/browse/LBCORE-17">LBCORE-17</a> - reported by Thorbjørn Ravn Andersen. Logback now relies on - Geronimo JMS API specifications instead of Sun's JMS API - specification, the latter requiring manual installation. With - Geronimo JMS, logback can be built using Maven without needing to - manually install any dependencies. - - - <a href="http://jira.qos.ch/browse/LBCORE-32">LBCORE-32</a> - + <a href="http://jira.qos.ch/browse/LBCLASSIC-53">LBCLASSIC-53</a>

1 0

svn commit: r1843 - logback/trunk
by noreply.ceki＠qos.ch 17 Oct '08

17 Oct '08

Author: ceki Date: Fri Oct 17 23:45:34 2008 New Revision: 1843 Modified: logback/trunk/pom.xml Log: SLF4J 1.5.5 has been released Modified: logback/trunk/pom.xml ============================================================================== --- logback/trunk/pom.xml (original) +++ logback/trunk/pom.xml Fri Oct 17 23:45:34 2008 @@ -36,7 +36,7 @@ <properties>  - <slf4j.version>1.5.4-SNAPSHOT</slf4j.version> + <slf4j.version>1.5.5</slf4j.version> <slf4j.ext.version>1.0-alpha0</slf4j.ext.version> <consolePlugin.version>1.1.0</consolePlugin.version> </properties>

1 0

[JIRA] Created: (LBCORE-55) getPresentationFooter and getFileFooter are swapped
by Natan Cox (JIRA) 17 Oct '08

17 Oct '08

getPresentationFooter and getFileFooter are swapped --------------------------------------------------- Key: LBCORE-55 URL: http://jira.qos.ch/browse/LBCORE-55 Project: logback-core Issue Type: Bug Components: Appender Reporter: Natan Cox Assignee: Logback dev list If I look into the code I can see in WriterAppender writeFooter String h = layout.getFileFooter(); if ((h != null) && (this.writer != null)) { try { this.writer.write(h); String pf = layout.getPresentationFooter(); if (pf != null) { this.writer.write(pf); } And if I look into HTMLLayoutBase I see getFileFooter => </body></html> getPresentationFooter => </table> which means we are first closing the HTML and then the TABLE? Fix: String pf = layout.getPresentationFooter(); if ((pf != null) && (this.writer != null)) { try { this.writer.write(pf); String h = layout.getFileFooter(); if (h != null) { this.writer.write(h); } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 1

svn commit: r1842 - in logback/trunk/logback-core/src: main/java/ch/qos/logback/core test/java/ch/qos/logback/core test/java/ch/qos/logback/core/appender
by noreply.ceki＠qos.ch 17 Oct '08

17 Oct '08

Author: ceki Date: Fri Oct 17 23:42:28 2008 New Revision: 1842 Added: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/PackageTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/WriterAppenderTest.java Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/WriterAppender.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/AllCoreTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java Log: Fixing LBCORE-55 In WriterAppender, getPresentationFooter and getFileFooter are now printed in the correct order, presentation footer first, file footer last. Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/WriterAppender.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/WriterAppender.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/WriterAppender.java Fri Oct 17 23:42:28 2008 @@ -17,12 +17,12 @@ import ch.qos.logback.core.status.ErrorStatus; /** - * WriterAppender appends events to a hava.io.Writer. - * This class provides basic services that other appenders build upon. + * WriterAppender appends events to a hava.io.Writer. This class provides basic + * services that other appenders build upon. + * + * For more information about this appender, please refer to the online manual + * at http://logback.qos.ch/manual/appenders.html#WriterAppender * - * For more information about this appender, please refer to the online manual at - * http://logback.qos.ch/manual/appenders.html#WriterAppender - * * @author Ceki Gülcü */ public class WriterAppender<E> extends AppenderBase<E> { @@ -97,16 +97,14 @@ public void start() { int errors = 0; if (this.layout == null) { - addStatus( - new ErrorStatus("No layout set for the appender named \"" + name - + "\".", this)); + addStatus(new ErrorStatus("No layout set for the appender named \"" + + name + "\".", this)); errors++; } if (this.writer == null) { - addStatus( - new ErrorStatus("No writer set for the appender named \"" + name - + "\".", this)); + addStatus(new ErrorStatus("No writer set for the appender named \"" + + name + "\".", this)); errors++; } // only error free appenders should be activated @@ -147,9 +145,8 @@ this.writer.close(); this.writer = null; } catch (IOException e) { - addStatus( - new ErrorStatus("Could not close writer for WriterAppener.", this, - e)); + addStatus(new ErrorStatus("Could not close writer for WriterAppener.", + this, e)); } } } @@ -205,48 +202,48 @@ } void writeHeader() { - if (layout != null) { - String h = layout.getFileHeader(); + if (layout != null && (this.writer != null)) { + try { - if ((h != null) && (this.writer != null)) { - try { + String h = layout.getFileHeader(); + if (h != null) { this.writer.write(h); - String ph = layout.getPresentationHeader(); - if (ph != null) { - this.writer.write(ph); - } - // append a line separator. This should be useful in most cases and should - // not hurt. + } + String ph = layout.getPresentationHeader(); + if (ph != null) { + this.writer.write(ph); + } + // If at least one of file header or presentation header were not null, then append a line separator. + // This should be useful in most cases and should not hurt. + if ((h != null) || (ph != null)) { this.writer.write(Layout.LINE_SEP); this.writer.flush(); - } catch (IOException ioe) { - this.started = false; - addStatus(new ErrorStatus( - "Failed to write header for appender named [" + name + "].", - this, ioe)); } + } catch (IOException ioe) { + this.started = false; + addStatus(new ErrorStatus("Failed to write header for appender named [" + + name + "].", this, ioe)); } } } void writeFooter() { - if (layout != null) { - String h = layout.getFileFooter(); - if ((h != null) && (this.writer != null)) { - try { + if (layout != null && this.writer != null) { + try { + String pf = layout.getPresentationFooter(); + if (pf != null) { + this.writer.write(pf); + } + String h = layout.getFileFooter(); + if (h != null) { this.writer.write(h); - String pf = layout.getPresentationFooter(); - if (pf != null) { - this.writer.write(pf); - } - // flushing is mandatory if the writer is not later closed. - this.writer.flush(); - } catch (IOException ioe) { - this.started = false; - addStatus(new ErrorStatus( - "Failed to write footer for appender named [" + name + "].", - this, ioe)); } + // flushing is mandatory if the writer is not later closed. + this.writer.flush(); + } catch (IOException ioe) { + this.started = false; + addStatus(new ErrorStatus("Failed to write footer for appender named [" + + name + "].", this, ioe)); } } } @@ -258,7 +255,7 @@ * be closed when the appender instance is closed. * * @param writer - * An already opened Writer. + * An already opened Writer. */ public synchronized void setWriter(Writer writer) { // close any previously opened writer Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/AllCoreTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/AllCoreTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/AllCoreTest.java Fri Oct 17 23:42:28 2008 @@ -20,6 +20,7 @@ suite.addTest(ch.qos.logback.core.util.PackageTest.suite()); suite.addTest(ch.qos.logback.core.helpers.PackageTest.suite()); suite.addTest(ch.qos.logback.core.pattern.PackageTest.suite()); + suite.addTest(ch.qos.logback.core.PackageTest.suite()); suite.addTest(ch.qos.logback.core.joran.PackageTest.suite()); suite.addTest(ch.qos.logback.core.appender.PackageTest.suite()); suite.addTest(ch.qos.logback.core.rolling.PackageTest.suite()); Added: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/PackageTest.java ============================================================================== --- (empty file) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/PackageTest.java Fri Oct 17 23:42:28 2008 @@ -0,0 +1,15 @@ +package ch.qos.logback.core; + +import junit.framework.JUnit4TestAdapter; +import junit.framework.Test; +import junit.framework.TestCase; +import junit.framework.TestSuite; + +public class PackageTest extends TestCase { + + public static Test suite() { + TestSuite suite = new TestSuite(); + suite.addTest(new JUnit4TestAdapter(WriterAppenderTest.class)); + return suite; + } +} Added: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/WriterAppenderTest.java ============================================================================== --- (empty file) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/WriterAppenderTest.java Fri Oct 17 23:42:28 2008 @@ -0,0 +1,114 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2008, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ + +package ch.qos.logback.core; + + +import static org.junit.Assert.*; + +import java.io.StringWriter; +import java.io.Writer; + +import org.junit.After; +import org.junit.Before; +import org.junit.Test; + +import ch.qos.logback.core.pattern.parser.SamplePatternLayout; + +public class WriterAppenderTest { + + Context context = new ContextBase(); + + @Before + public void setUp() throws Exception { + } + + @After + public void tearDown() throws Exception { + } + + @Test + public void smoke() { + String FILE_HEADER = "FILE_HEADER "; + String PRESENTATION_HEADER = "PRESENTATION_HEADER"; + String PRESENTATION_FOOTER = "PRESENTATION_FOOTER "; + String FILE_FOOTER = "FILE_FOOTER"; + headerFooterCheck(FILE_HEADER, PRESENTATION_HEADER, PRESENTATION_FOOTER, FILE_FOOTER); + } + + @Test + public void nullFileHeader() { + String FILE_HEADER = null; + String PRESENTATION_HEADER = "PRESENTATION_HEADER"; + String PRESENTATION_FOOTER = "PRESENTATION_FOOTER "; + String FILE_FOOTER = "FILE_FOOTER"; + headerFooterCheck(FILE_HEADER, PRESENTATION_HEADER, PRESENTATION_FOOTER, FILE_FOOTER); + } + + @Test + public void nullPresentationHeader() { + String FILE_HEADER = "FILE_HEADER "; + String PRESENTATION_HEADER = null; + String PRESENTATION_FOOTER = "PRESENTATION_FOOTER "; + String FILE_FOOTER = "FILE_FOOTER"; + headerFooterCheck(FILE_HEADER, PRESENTATION_HEADER, PRESENTATION_FOOTER, FILE_FOOTER); + } + + @Test + public void nullPresentationFooter() { + String FILE_HEADER = "FILE_HEADER "; + String PRESENTATION_HEADER = "PRESENTATION_HEADER"; + String PRESENTATION_FOOTER = null; + String FILE_FOOTER = "FILE_FOOTER"; + headerFooterCheck(FILE_HEADER, PRESENTATION_HEADER, PRESENTATION_FOOTER, FILE_FOOTER); + } + + @Test + public void nullFileFooter() { + String FILE_HEADER = "FILE_HEADER "; + String PRESENTATION_HEADER = "PRESENTATION_HEADER"; + String PRESENTATION_FOOTER = "PRESENTATION_FOOTER "; + String FILE_FOOTER = null; + headerFooterCheck(FILE_HEADER, PRESENTATION_HEADER, PRESENTATION_FOOTER, FILE_FOOTER); + } + + public void headerFooterCheck(String fileHeader, String presentationHeader, String presentationFooter, String fileFooter) { + WriterAppender<Object> wa = new WriterAppender<Object>(); + wa.setContext(context); + Writer sw = new StringWriter(); + + SamplePatternLayout<Object> spl = new SamplePatternLayout<Object>(); + spl.setContext(context); + + spl.setFileHeader(fileHeader); + spl.setPresentationHeader(presentationHeader); + spl.setPresentationFooter(presentationFooter); + spl.setFileFooter(fileFooter); + + spl.start(); + + wa.setLayout(spl); + wa.setWriter(sw); + wa.start(); + + wa.stop(); + String result = sw.toString(); + + String expectedHeader = emtptyIfNull(fileHeader) + emtptyIfNull(presentationHeader); + assertTrue(result, result.startsWith(expectedHeader)); + + String expectedFooter = emtptyIfNull(presentationFooter) + emtptyIfNull(fileFooter); + assertTrue(result, result.endsWith(expectedFooter)); + } + + String emtptyIfNull(String s) { + return s == null ? "" : s; + } +} Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java Fri Oct 17 23:42:28 2008 @@ -85,12 +85,12 @@ public void testClose() { ConsoleAppender<Object> ca = (ConsoleAppender<Object>) getAppender(); DummyLayout<Object> dummyLayout = new DummyLayout<Object>(); - dummyLayout.setFileFooter("closed"); + dummyLayout.setFileFooter("CLOSED"); ca.setLayout(dummyLayout); ca.start(); ca.doAppend(new Object()); ca.stop(); - assertEquals(DummyLayout.DUMMY + "closed", tee.toString()); + assertEquals(DummyLayout.DUMMY + "CLOSED", tee.toString()); }

1 0

[JIRA] Resolved: (LBGENERAL-14) Log4j bridge TRACE level
by Ceki Gulcu (JIRA) 17 Oct '08

17 Oct '08

[ http://jira.qos.ch/browse/LBGENERAL-14?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu resolved LBGENERAL-14. --------------------------------- Resolution: Won't Fix The log4j bridge has moved into the SLF4J project. Moreover, the bug you mention has been fixed there. See also http://bugzilla.slf4j.org/show_bug.cgi?id=74 > Log4j bridge TRACE level > ------------------------ > > Key: LBGENERAL-14 > URL: http://jira.qos.ch/browse/LBGENERAL-14 > Project: logback-general > Issue Type: Bug > Components: build-structure > Affects Versions: unspecified > Environment: Operating System: Linux > Platform: PC > Reporter: Markus Wolf > Assignee: Logback dev list > > While trying to use logbacks log4j bridge to have JBoss EmbeddedEJB3 to log I stumbled over the following stacktrace. > I use logback-*-0.9.7 and slf4j-*-1.4.0. > Caused by: java.lang.IllegalStateException: Unknown Priority TRACE > at org.apache.log4j.Category.priorityToLevel(Category.java:351) > at org.apache.log4j.Category.log(Category.java:332) > at org.jboss.logging.Log4jLoggerPlugin.trace(Log4jLoggerPlugin.java:119) > at org.jboss.logging.Logger.trace(Logger.java:152) > at org.jboss.kernel.plugins.bootstrap.AbstractBootstrap.run(AbstractBootstrap.java:93) > at org.jboss.ejb3.embedded.EJB3StandaloneBootstrap.createKernel(EJB3StandaloneBootstrap.java:422) > at org.jboss.ejb3.embedded.EJB3StandaloneBootstrap.boot(EJB3StandaloneBootstrap.java:375) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

reducing resource contention in logback
by Ceki Gulcu 17 Oct '08

17 Oct '08

Hello all, Ralph and I had a lengthy chat discussing his contribution in LBCLASSIC-35 http://jira.qos.ch/browse/LBCLASSIC-35 For the public record, here is a brief summary of the exchange. His premise is that by carefully modifying synchronization in the AppenderBase and Logger classes we can significantly reduce contention among various threads using logback. The changes must preserve logging event atomicity. For example, if event0 consist of a message m0 and exception e0, and event1 consist of message m1, when an appender writes event0 and event1, possibly sent by different threads, the output must never be m0,m1,e0 but always m0,e0,m1 or alternatively m1,m0,e0. In other words, event intermingling is disallowed even if event ordering is not guaranteed. Raph modified the Logger class so that iterating on the appenders is done without locking. He currently uses ConcurrentHashMap. I think that CopyOnWriteArrayList would also work fine and result in simpler code. Ralph has also modified the doAppend method in AppenderBase pushing the synchronization point to within each derived appender class. Thus it becomes the responsibility of each appender to manage its own synchronization. These changes open the way for threads which support concurrent calls to be invoked without any contention by multiple threads. Of course, the underlying resource, where the logging output is eventually written to, still remains as a contention point. Cheers, -- Ceki Gülcü Logback: The reliable, generic, fast and flexible logging framework for Java. http://logback.qos.ch

1 0

svn commit: r1841 - logback/trunk/logback-classic/src/main/java/org/slf4j/impl
by noreply.ceki＠qos.ch 17 Oct '08

17 Oct '08

Author: ceki Date: Fri Oct 17 21:44:30 2008 New Revision: 1841 Modified: logback/trunk/logback-classic/src/main/java/org/slf4j/impl/StaticLoggerBinder.java Log: logback 0.9.10 targets SLF4J 1.5.5 Modified: logback/trunk/logback-classic/src/main/java/org/slf4j/impl/StaticLoggerBinder.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/org/slf4j/impl/StaticLoggerBinder.java (original) +++ logback/trunk/logback-classic/src/main/java/org/slf4j/impl/StaticLoggerBinder.java Fri Oct 17 21:44:30 2008 @@ -48,12 +48,12 @@ public static final StaticLoggerBinder SINGLETON = new StaticLoggerBinder(); /** - * Version tag used to check compatibility. The value of this field is - * modified with each release. + * Declare the version of the SLF4J API this implementation is compiled against. + * The value of this field is usually modified with each release. */ - //to avoid constant folding by the compiler, VERSION field should *not* be final - public static String VERSION = "1.5.4-SNAPSHOT"; - + // to avoid constant folding by the compiler, this field must *not* be final + public static String REQUESTED_API_VERSION = "1.5.5"; // !final + private static final String loggerFactoryClassStr = ContextSelector.class .getName();

1 0

[JIRA] Commented: (LBCLASSIC-35) Deadlock when running on multiple core processors
by Ceki Gulcu (JIRA) 17 Oct '08

17 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-35?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu commented on LBCLASSIC-35: ------------------------------------- I think we should talk over your patch over the phone or via IRC. > Deadlock when running on multiple core processors > ------------------------------------------------- > > Key: LBCLASSIC-35 > URL: http://jira.qos.ch/browse/LBCLASSIC-35 > Project: logback-classic > Issue Type: Bug > Components: Other > Affects Versions: unspecified > Environment: Operating System: Windows > Platform: PC > Reporter: Toni Heimala > Assignee: Ceki Gulcu > Priority: Blocker > Attachments: patch.txt, patch2.txt > > > When you run logging into same file from many threads on a system that has more than one physical processor (Dual Core for example), a deadlock will occur after a while. This can not be reproduced on HyperThreading processors. Here's an example program that will demonstrate the behavior: > ----------------------------- > Main.java > ----------------------------- > import java.util.Date; > import java.util.concurrent.ScheduledThreadPoolExecutor; > import java.util.concurrent.TimeUnit; > import org.slf4j.Logger; > import org.slf4j.LoggerFactory; > import ch.qos.logback.classic.LoggerContext; > import ch.qos.logback.classic.joran.JoranConfigurator; > import ch.qos.logback.core.joran.spi.JoranException; > public class Main extends Thread > { > private final static String LOGGER_CONFIGURATION_FILE = "logger.xml"; > private final Logger logger = LoggerFactory.getLogger(Main.class); > > private final long start; > > public Main() > throws JoranException > { > start = new Date().getTime(); > LoggerContext lc = (LoggerContext)LoggerFactory.getILoggerFactory(); > JoranConfigurator configurator = new JoranConfigurator(); > lc.shutdownAndReset(); > configurator.setContext(lc); > configurator.doConfigure(LOGGER_CONFIGURATION_FILE); > } > > public void start() > { > ScheduledThreadPoolExecutor ex1 = new ScheduledThreadPoolExecutor(1); > ScheduledThreadPoolExecutor ex2 = new ScheduledThreadPoolExecutor(1); > ScheduledThreadPoolExecutor ex3 = new ScheduledThreadPoolExecutor(1); > ScheduledThreadPoolExecutor ex4 = new ScheduledThreadPoolExecutor(1); > ScheduledThreadPoolExecutor ex5 = new ScheduledThreadPoolExecutor(1); > ex1.scheduleAtFixedRate(new Task("EX1"), 10, 10, TimeUnit.MICROSECONDS); > ex2.scheduleAtFixedRate(new Task("EX2"), 10, 10, TimeUnit.MICROSECONDS); > ex3.scheduleAtFixedRate(new Task("EX3"), 10, 10, TimeUnit.MICROSECONDS); > ex4.scheduleAtFixedRate(new Task("EX4"), 10, 10, TimeUnit.MICROSECONDS); > ex5.scheduleAtFixedRate(new Task("EX5"), 10, 10, TimeUnit.MICROSECONDS); > > super.start(); > } > > public void run() > { > try > { > while(true) > { > logger.debug("[MAIN] {}", new Date().getTime() - start); > Thread.sleep(10); > } > } > catch (InterruptedException e) > { > logger.info("[MAIN]: Interrupted: {}", e.getMessage()); > } > } > > public static void main(String[] args) > { > try > { > Main main = new Main(); > main.start(); > } > catch (JoranException e) > { > System.out.println("Failed to load application: " + e.getMessage()); > } > } > } > ------------------------------- > Task.java > ------------------------------- > import java.util.Date; > import org.slf4j.Logger; > import org.slf4j.LoggerFactory; > public class Task implements Runnable > { > private final Logger logger = LoggerFactory.getLogger(Task.class); > private final Logger logger_main = LoggerFactory.getLogger(Main.class); > private final String name; > private final long start; > > public Task(final String name) > { > this.name = name; > start = new Date().getTime(); > } > public void run() > { > logger.debug("[{}] {}", name, new Date().getTime() - start); > logger_main.debug("[MAIN] - [{}] {}", name, new Date().getTime() - start); > } > } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

3 2

[JIRA] Issue Comment Edited: (LBCLASSIC-35) Deadlock when running on multiple core processors
by Ralph Goers (JIRA) 16 Oct '08

16 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-35?page=com.atlassian.jira.plugin.syste… ] Ralph Goers edited comment on LBCLASSIC-35 at 10/16/08 9:56 PM: ---------------------------------------------------------------- Updated patch. This one makes the Appender name required and immutable, removes all the synchronization from Logger while calling Appenders and makes sure that an AppenderAttachableImpl is always attached to the Logger eliminating any race conditions that might occur during reconfiguration. was (Author: ralphgoers): Updated patch. This one makes the Appender name required and immutable, removes all the synchronization from Logger and makes sure that an AppenderAttachableImpl is always attached to the Logger eliminating any race conditions that might occur during reconfiguration. > Deadlock when running on multiple core processors > ------------------------------------------------- > > Key: LBCLASSIC-35 > URL: http://jira.qos.ch/browse/LBCLASSIC-35 > Project: logback-classic > Issue Type: Bug > Components: Other > Affects Versions: unspecified > Environment: Operating System: Windows > Platform: PC > Reporter: Toni Heimala > Assignee: Ceki Gulcu > Priority: Blocker > Attachments: patch.txt, patch2.txt > > > When you run logging into same file from many threads on a system that has more than one physical processor (Dual Core for example), a deadlock will occur after a while. This can not be reproduced on HyperThreading processors. Here's an example program that will demonstrate the behavior: > ----------------------------- > Main.java > ----------------------------- > import java.util.Date; > import java.util.concurrent.ScheduledThreadPoolExecutor; > import java.util.concurrent.TimeUnit; > import org.slf4j.Logger; > import org.slf4j.LoggerFactory; > import ch.qos.logback.classic.LoggerContext; > import ch.qos.logback.classic.joran.JoranConfigurator; > import ch.qos.logback.core.joran.spi.JoranException; > public class Main extends Thread > { > private final static String LOGGER_CONFIGURATION_FILE = "logger.xml"; > private final Logger logger = LoggerFactory.getLogger(Main.class); > > private final long start; > > public Main() > throws JoranException > { > start = new Date().getTime(); > LoggerContext lc = (LoggerContext)LoggerFactory.getILoggerFactory(); > JoranConfigurator configurator = new JoranConfigurator(); > lc.shutdownAndReset(); > configurator.setContext(lc); > configurator.doConfigure(LOGGER_CONFIGURATION_FILE); > } > > public void start() > { > ScheduledThreadPoolExecutor ex1 = new ScheduledThreadPoolExecutor(1); > ScheduledThreadPoolExecutor ex2 = new ScheduledThreadPoolExecutor(1); > ScheduledThreadPoolExecutor ex3 = new ScheduledThreadPoolExecutor(1); > ScheduledThreadPoolExecutor ex4 = new ScheduledThreadPoolExecutor(1); > ScheduledThreadPoolExecutor ex5 = new ScheduledThreadPoolExecutor(1); > ex1.scheduleAtFixedRate(new Task("EX1"), 10, 10, TimeUnit.MICROSECONDS); > ex2.scheduleAtFixedRate(new Task("EX2"), 10, 10, TimeUnit.MICROSECONDS); > ex3.scheduleAtFixedRate(new Task("EX3"), 10, 10, TimeUnit.MICROSECONDS); > ex4.scheduleAtFixedRate(new Task("EX4"), 10, 10, TimeUnit.MICROSECONDS); > ex5.scheduleAtFixedRate(new Task("EX5"), 10, 10, TimeUnit.MICROSECONDS); > > super.start(); > } > > public void run() > { > try > { > while(true) > { > logger.debug("[MAIN] {}", new Date().getTime() - start); > Thread.sleep(10); > } > } > catch (InterruptedException e) > { > logger.info("[MAIN]: Interrupted: {}", e.getMessage()); > } > } > > public static void main(String[] args) > { > try > { > Main main = new Main(); > main.start(); > } > catch (JoranException e) > { > System.out.println("Failed to load application: " + e.getMessage()); > } > } > } > ------------------------------- > Task.java > ------------------------------- > import java.util.Date; > import org.slf4j.Logger; > import org.slf4j.LoggerFactory; > public class Task implements Runnable > { > private final Logger logger = LoggerFactory.getLogger(Task.class); > private final Logger logger_main = LoggerFactory.getLogger(Main.class); > private final String name; > private final long start; > > public Task(final String name) > { > this.name = name; > start = new Date().getTime(); > } > public void run() > { > logger.debug("[{}] {}", name, new Date().getTime() - start); > logger_main.debug("[MAIN] - [{}] {}", name, new Date().getTime() - start); > } > } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0