October 2008 - logback-dev - mailman3.qos.ch

[JIRA] Created: (LBCLASSIC-79) NullPointerException in JMX Configurator setLoggerLevel
by Jean-Luc Geering (JIRA) 17 Nov '08

17 Nov '08

NullPointerException in JMX Configurator setLoggerLevel ------------------------------------------------------- Key: LBCLASSIC-79 URL: http://jira.qos.ch/browse/LBCLASSIC-79 Project: logback-classic Issue Type: Bug Affects Versions: 0.9.11 Reporter: Jean-Luc Geering Assignee: Logback dev list import org.slf4j.LoggerFactory; import ch.qos.logback.classic.LoggerContext; import ch.qos.logback.classic.jmx.Configurator; import ch.qos.logback.classic.jmx.ConfiguratorMBean; public class Test { public static void main(String[] args) { LoggerFactory.getLogger("com.test1"); LoggerFactory.getLogger("com.test2"); LoggerContext lc = (LoggerContext) LoggerFactory.getILoggerFactory(); ConfiguratorMBean configurator = new Configurator(lc); configurator.setLoggerLevel("com", "info"); configurator.setLoggerLevel("com", "null"); } } Exception in thread "main" java.lang.NullPointerException at ch.qos.logback.classic.Logger.setLevel(Logger.java:193) at ch.qos.logback.classic.jmx.Configurator.setLoggerLevel(Configurator.java:92) at Test.main(Test.java:14) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 1

[JIRA] Created: (LBCLASSIC-61) JMXConfigurationAction should allow a configurable ObjectName.
by Anders Engström (JIRA) 07 Nov '08

07 Nov '08

JMXConfigurationAction should allow a configurable ObjectName. -------------------------------------------------------------- Key: LBCLASSIC-61 URL: http://jira.qos.ch/browse/LBCLASSIC-61 Project: logback-classic Issue Type: Improvement Affects Versions: 0.9.9 Reporter: Anders Engström Assignee: Logback dev list Currently there is no way to customize the ObjectName the MBean is bound to (besides using a ContextSelector - which can be a hassle). This is an issue when deploying several applications in the same JVM (read: multiple web-applications in the same servlet engine). This patch modifies JMXConfiguratorAction to accept two additional attributes that allow customizing the ObjectName for the MBean: <jmxConfigurator/> This yields the default ObjectName of "ch.qos.logback.classic:Name=${nameOfContext},Type=ch.qos.logback.classic.jmx.Configurator". <jmxConfigurator namespace="foo"/> This results in "ch.qos.logback.classic:Name=${nameOfContext},Type=ch.qos.logback.classic.jmx.Configurator,Namespace=foo". <jmxConfigurator objectName="logback:name=foo,type=bar"/> Which obviously results in "logback:name=foo,type=bar" :) Let me know if I need to adjust the patch in any way. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 3

svn commit: r1927 - in logback/trunk/logback-classic/src/test: input/joran java/ch/qos/logback/classic/net
by noreply.ceki＠qos.ch 31 Oct '08

31 Oct '08

Author: ceki Date: Fri Oct 31 19:58:24 2008 New Revision: 1927 Added: logback/trunk/logback-classic/src/test/input/joran/syslog_LBCLASSIC_50.xml - copied unchanged from r1899, /logback/trunk/logback-classic/src/test/input/joran/syslog_147.xml Removed: logback/trunk/logback-classic/src/test/input/joran/syslog_147.xml Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SyslogAppenderTest.java Log: - fixed SyslogAppenderTest failing on machines with . in their names. Reported by Thorbjørn Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SyslogAppenderTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SyslogAppenderTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SyslogAppenderTest.java Fri Oct 31 19:58:24 2008 @@ -25,7 +25,6 @@ import ch.qos.logback.core.joran.spi.JoranException; import ch.qos.logback.core.net.SyslogConstants; import ch.qos.logback.core.testUtil.RandomUtil; -import ch.qos.logback.core.util.StatusPrinter; public class SyslogAppenderTest { @@ -40,7 +39,7 @@ @Test public void basic() throws InterruptedException { int port = RandomUtil.getRandomServerPort(); - + MockSyslogServer mockServer = new MockSyslogServer(1, port); mockServer.start(); // give MockSyslogServer head start @@ -62,7 +61,6 @@ logger.addAppender(sa); String logMsg = "hello"; logger.debug(logMsg); - // StatusPrinter.print(lc.getStatusManager()); // wait max 2 seconds for mock server to finish. However, it should // much sooner than that. @@ -71,14 +69,13 @@ assertEquals(1, mockServer.getMessageList().size()); String msg = mockServer.getMessageList().get(0); + String threadName = Thread.currentThread().getName(); + String expected = "<" + (SyslogConstants.LOG_MAIL + SyslogConstants.DEBUG_SEVERITY) + ">"; assertTrue(msg.startsWith(expected)); - String first = "<\\d{2}>\\w{3} \\d{2} \\d{2}(:\\d{2}){2} \\w* "; - String threadName = Thread.currentThread().getName(); - System.out.println("msg is \""+msg+"\""); - System.out.println("threadName is \""+threadName+"\""); + String first = "<\\d{2}>\\w{3} \\d{2} \\d{2}(:\\d{2}){2} [\\w.]* "; assertTrue(msg.matches(first + "\\[" + threadName + "\\] " + loggerName + " " + logMsg)); @@ -87,7 +84,7 @@ @Test public void tException() throws InterruptedException { int port = RandomUtil.getRandomServerPort(); - + MockSyslogServer mockServer = new MockSyslogServer(21, port); mockServer.start(); // give MockSyslogServer head start @@ -130,7 +127,7 @@ + (SyslogConstants.LOG_MAIL + SyslogConstants.DEBUG_SEVERITY) + ">"; assertTrue(msg.startsWith(expected)); - String expectedPrefix = "<\\d{2}>\\w{3} \\d{2} \\d{2}(:\\d{2}){2} \\w* "; + String expectedPrefix = "<\\d{2}>\\w{3} \\d{2} \\d{2}(:\\d{2}){2} [\\w.]* "; String threadName = Thread.currentThread().getName(); String expectedResult = expectedPrefix + "\\[" + threadName + "\\] " + loggerName + " " + logMsg; @@ -138,7 +135,7 @@ } @Test - public void bug147() throws JoranException { + public void LBCLASSIC_50() throws JoranException { LoggerContext lc = (LoggerContext) LoggerFactory.getILoggerFactory(); @@ -146,10 +143,9 @@ configurator.setContext(lc); lc.shutdownAndReset(); configurator.doConfigure(TestConstants.JORAN_ONPUT_PREFIX - + "/syslog_147.xml"); + + "/syslog_LBCLASSIC_50.xml"); org.slf4j.Logger logger = LoggerFactory.getLogger(this.getClass()); logger.info("hello"); - StatusPrinter.print(lc); } }

2 1

Building trunk fails tests
by Thorbjørn Ravn Andersen 31 Oct '08

31 Oct '08

I just pulled out logback trunk, and ran "mvn install" This gave two failures and aborted the build "Results : Failed tests: basic(ch.qos.logback.classic.net.SyslogAppenderTest) tException(ch.qos.logback.classic.net.SyslogAppenderTest) Tests run: 207, Failures: 2, Errors: 0, Skipped: 8 " This is OS X 10.5.5 with 64-bit 1.6 JVM. /Thorbjørn

2 7

svn commit: r1926 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net
by noreply.ceki＠qos.ch 31 Oct '08

31 Oct '08

Author: ceki Date: Fri Oct 31 18:22:23 2008 New Revision: 1926 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SyslogAppenderTest.java Log: tracking message contents on OS X Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SyslogAppenderTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SyslogAppenderTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SyslogAppenderTest.java Fri Oct 31 18:22:23 2008 @@ -77,6 +77,8 @@ String first = "<\\d{2}>\\w{3} \\d{2} \\d{2}(:\\d{2}){2} \\w* "; String threadName = Thread.currentThread().getName(); + System.out.println("msg is \""+msg+"\""); + System.out.println("threadName is \""+threadName+"\""); assertTrue(msg.matches(first + "\\[" + threadName + "\\] " + loggerName + " " + logMsg));

1 0

[JIRA] Commented: (LBCLASSIC-47) LoggingEvent.formattedMessage is only initialized in c'tor.
by Joern Huxhorn (JIRA) 31 Oct '08

31 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-47?page=com.atlassian.jira.plugin.syste… ] Joern Huxhorn commented on LBCLASSIC-47: ---------------------------------------- Thank you for implementing this change, Jörn. > LoggingEvent.formattedMessage is only initialized in c'tor. > ----------------------------------------------------------- > > Key: LBCLASSIC-47 > URL: http://jira.qos.ch/browse/LBCLASSIC-47 > Project: logback-classic > Issue Type: Bug > Components: Other > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Joern Huxhorn > Assignee: Ceki Gulcu > Fix For: 0.9.12 > > > LoggingEvent.formattedMessage is only initialized if message and arguments are supplied during construction. If the default c'tor is used and message and arguments are provided using setMessage and setArgumentArray then formattedMessage will stay null. > Instead, formattedMessage should be declared transient and the actual formatting should take place lazily during getFormattedMessage call. > This would fix this problem, would increase general logging performance (formatting only if actually needed) and would decrease the size of serialized log events significantly while it would not change anything from the callers point of view. > This is a follow-up of LBCLASSIC-32. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Updated: (LBCLASSIC-54) TurboFilterAttachableImpl.addTurboFilter() will behave funny if newFilter.turboNext != null
by Ceki Gulcu (JIRA) 31 Oct '08

31 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-54?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu updated LBCLASSIC-54: -------------------------------- Attachment: ChainIterationPerfTest.java Results: 0 chain avg=9.5244857 0 list avg=8.4000333 1 chain avg=31.9388743 1 list avg=33.4933838 2 chain avg=52.7171824 2 list avg=56.2649762 3 chain avg=89.927586 3 list avg=98.16051 > TurboFilterAttachableImpl.addTurboFilter() will behave funny if newFilter.turboNext != null > ------------------------------------------------------------------------------------------- > > Key: LBCLASSIC-54 > URL: http://jira.qos.ch/browse/LBCLASSIC-54 > Project: logback-classic > Issue Type: Bug > Reporter: Anton Tagunov > Assignee: Logback dev list > Priority: Minor > Attachments: ChainIterationPerfTest.java > > > Hi! > addTurboFilter() sets tailFilter incorrectly if newFilter.nextFilter != null > Here's what I was trying to do. > I implement a new TurboFilter. > This TurboFilter is an interceptor that captures log messages and stores them for analysis. > This is part of Unit Test. This Unit Test has to ensure that a specific message has been logged. > This TurboFilter is not configured via logback.xml > It can be but I don't want that to be mandatory. > Instead this TurboFilter needs to bind itself to LoggerContext programmatically, via Logback API. > It also need to bind itself as _the first filter in the chain_. > Here's how I've tried to do it: > final LogbackMessageProducer nuvo = new LogbackMessageProducer(true); > > /* make sure we're the first in the chain */ > final TurboFilter oldFirst = tfa.getFirstTurboFilter(); > nuvo.setNext(oldFirst); > > tfa.clearAllTurboFilters(); > tfa.addTurboFilter(nuvo); > However should somebody else call addTurboFilter(some-other-filter) after this behavior shall be funny. > Basically all old turbo filters that were bound before my code executed shall be lost. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Commented: (LBCLASSIC-54) TurboFilterAttachableImpl.addTurboFilter() will behave funny if newFilter.turboNext != null
by Ceki Gulcu (JIRA) 31 Oct '08

31 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-54?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu commented on LBCLASSIC-54: ------------------------------------- The most general solution would be to add methods such as add(int index, TurboFilter tf) and remove(int index, TurboFilter tf) which would make TurboFitlerAttacable more similar to the java.util.List interface. Performance of iterating over the chain was the reason why opted for arranging filters (and turbo filters) in a linked chain. This was in JDK 1.1 or 1.2. In JDK 1.5, my tests show that the iterating over the chain is not faster with our custom implementation than with a vanilla ArrayList. Actually, for the most important case, where there are no turbo filters (empty chain), the vanilla list is about 12% faster! We go from 9.5 nanoseconds per iteration to 8.4 nanoseconds. Imagine my surprise. I thus intend to refactor the code and migrate to a more standard solution. > TurboFilterAttachableImpl.addTurboFilter() will behave funny if newFilter.turboNext != null > ------------------------------------------------------------------------------------------- > > Key: LBCLASSIC-54 > URL: http://jira.qos.ch/browse/LBCLASSIC-54 > Project: logback-classic > Issue Type: Bug > Reporter: Anton Tagunov > Assignee: Logback dev list > Priority: Minor > > Hi! > addTurboFilter() sets tailFilter incorrectly if newFilter.nextFilter != null > Here's what I was trying to do. > I implement a new TurboFilter. > This TurboFilter is an interceptor that captures log messages and stores them for analysis. > This is part of Unit Test. This Unit Test has to ensure that a specific message has been logged. > This TurboFilter is not configured via logback.xml > It can be but I don't want that to be mandatory. > Instead this TurboFilter needs to bind itself to LoggerContext programmatically, via Logback API. > It also need to bind itself as _the first filter in the chain_. > Here's how I've tried to do it: > final LogbackMessageProducer nuvo = new LogbackMessageProducer(true); > > /* make sure we're the first in the chain */ > final TurboFilter oldFirst = tfa.getFirstTurboFilter(); > nuvo.setNext(oldFirst); > > tfa.clearAllTurboFilters(); > tfa.addTurboFilter(nuvo); > However should somebody else call addTurboFilter(some-other-filter) after this behavior shall be funny. > Basically all old turbo filters that were bound before my code executed shall be lost. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Commented: (LBCLASSIC-54) TurboFilterAttachableImpl.addTurboFilter() will behave funny if newFilter.turboNext != null
by Ceki Gulcu (JIRA) 31 Oct '08

31 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-54?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu commented on LBCLASSIC-54: ------------------------------------- Hi Anton, In the TurboFilterAttachable interface, the getFirstTurboFilter is meant to be used by test. I never intended for the turbo filter chain to be manipulated through that method. I intend to modify the TurboFilterAttachable interface by adding a getCopyOfTurboFilterChain and then removing getFirstTurboFilter. This should allow you insert a new filter at the beginning and reconstruct the chain with a copy obtained via getCopyOfTurboFilterChain. Would it be helpful if there was a method to insert a TF a the beginning of the chain? I could add that method as well. > TurboFilterAttachableImpl.addTurboFilter() will behave funny if newFilter.turboNext != null > ------------------------------------------------------------------------------------------- > > Key: LBCLASSIC-54 > URL: http://jira.qos.ch/browse/LBCLASSIC-54 > Project: logback-classic > Issue Type: Bug > Reporter: Anton Tagunov > Assignee: Logback dev list > Priority: Minor > > Hi! > addTurboFilter() sets tailFilter incorrectly if newFilter.nextFilter != null > Here's what I was trying to do. > I implement a new TurboFilter. > This TurboFilter is an interceptor that captures log messages and stores them for analysis. > This is part of Unit Test. This Unit Test has to ensure that a specific message has been logged. > This TurboFilter is not configured via logback.xml > It can be but I don't want that to be mandatory. > Instead this TurboFilter needs to bind itself to LoggerContext programmatically, via Logback API. > It also need to bind itself as _the first filter in the chain_. > Here's how I've tried to do it: > final LogbackMessageProducer nuvo = new LogbackMessageProducer(true); > > /* make sure we're the first in the chain */ > final TurboFilter oldFirst = tfa.getFirstTurboFilter(); > nuvo.setNext(oldFirst); > > tfa.clearAllTurboFilters(); > tfa.addTurboFilter(nuvo); > However should somebody else call addTurboFilter(some-other-filter) after this behavior shall be funny. > Basically all old turbo filters that were bound before my code executed shall be lost. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r1925 - in logback/trunk: logback-access/src/test/java/ch/qos/logback/access/jetty logback-classic/src/test/java/ch/qos/logback/classic/net logback-classic/src/test/java/ch/qos/logback/classic/net/mock logback-core/src/test/java/ch/qos/logback/core/testUtil
by noreply.ceki＠qos.ch 31 Oct '08

31 Oct '08

Author: ceki Date: Fri Oct 31 11:07:57 2008 New Revision: 1925 Added: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/testUtil/RandomUtil.java Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyFixture.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SyslogAppenderTest.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/mock/MockSyslogServer.java Log: - use random ports for tests to reduce the probability in LINGERING ports between successive runs Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java ============================================================================== --- logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java (original) +++ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java Fri Oct 31 11:07:57 2008 @@ -15,31 +15,34 @@ import ch.qos.logback.access.spi.AccessEvent; import ch.qos.logback.access.spi.Util; import ch.qos.logback.access.testUtil.NotifyingListAppender; +import ch.qos.logback.core.testUtil.RandomUtil; public class JettyBasicTest { - static RequestLogImpl requestLogImpl; - static JettyFixture fixture; + static RequestLogImpl REQYEST_LOG_IMPL; + static JettyFixture JETTY_FIXTURE; + static int RANDOM_SERVER_PORT = RandomUtil.getRandomServerPort(); + @BeforeClass static public void startServer() throws Exception { // System.out.println("*** JettyBasicTest.startServer called"); - requestLogImpl = new RequestLogImpl(); - JettyFixture fixture = new JettyFixture(requestLogImpl); - fixture.start(); + REQYEST_LOG_IMPL = new RequestLogImpl(); + JETTY_FIXTURE = new JettyFixture(REQYEST_LOG_IMPL, RANDOM_SERVER_PORT); + JETTY_FIXTURE.start(); } @AfterClass static public void stopServer() throws Exception { // System.out.println("*** JettyBasicTest.stopServer called"); - if (fixture != null) { - fixture.stop(); + if (JETTY_FIXTURE != null) { + JETTY_FIXTURE.stop(); } } @Test public void getRequest() throws Exception { - URL url = new URL("http://localhost:" + JettyFixture.PORT + "/"); + URL url = new URL("http://localhost:" + RANDOM_SERVER_PORT + "/"); HttpURLConnection connection = (HttpURLConnection) url.openConnection(); connection.setDoInput(true); @@ -47,14 +50,14 @@ assertEquals("hello world", result); - NotifyingListAppender listAppender = (NotifyingListAppender) requestLogImpl + NotifyingListAppender listAppender = (NotifyingListAppender) REQYEST_LOG_IMPL .getAppender("list"); listAppender.list.clear(); } @Test public void eventGoesToAppenders() throws Exception { - URL url = new URL("http://localhost:" + JettyFixture.PORT + "/"); + URL url = new URL(JETTY_FIXTURE.getUrl()); HttpURLConnection connection = (HttpURLConnection) url.openConnection(); connection.setDoInput(true); @@ -62,7 +65,7 @@ assertEquals("hello world", result); - NotifyingListAppender listAppender = (NotifyingListAppender) requestLogImpl + NotifyingListAppender listAppender = (NotifyingListAppender) REQYEST_LOG_IMPL .getAppender("list"); synchronized (listAppender) { listAppender.wait(100); @@ -77,8 +80,7 @@ @Test public void postContentConverter() throws Exception { - // System.out.println("into test"); - URL url = new URL("http://localhost:" + JettyFixture.PORT + "/"); + URL url = new URL(JETTY_FIXTURE.getUrl()); String msg = "test message"; HttpURLConnection connection = (HttpURLConnection) url.openConnection(); @@ -99,7 +101,7 @@ // StatusPrinter.print(requestLogImpl.getStatusManager()); - NotifyingListAppender listAppender = (NotifyingListAppender) requestLogImpl + NotifyingListAppender listAppender = (NotifyingListAppender) REQYEST_LOG_IMPL .getAppender("list"); synchronized (listAppender) { Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyFixture.java ============================================================================== --- logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyFixture.java (original) +++ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyFixture.java Fri Oct 31 11:07:57 2008 @@ -26,25 +26,28 @@ public class JettyFixture { RequestLogImpl requestLogImpl; - public static final int PORT = 1234; + private final int port; + Server server; + String url; - public JettyFixture(RequestLogImpl impl) { + public JettyFixture(RequestLogImpl impl, int port) { requestLogImpl = impl; + this.port = port; + url = "http://localhost:" + port + "/"; } public String getName() { return "Jetty Test Setup"; } - Server server; - String url = "http://localhost:" + PORT + "/"; + public String getUrl() { + return url; + } public void start() throws Exception { - // System.out.println("into setUp"); - server = new Server(); Connector connector = new SelectChannelConnector(); - connector.setPort(PORT); + connector.setPort(port); server.setConnectors(new Connector[] { connector }); ContextHandler context = new ContextHandler(); Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SyslogAppenderTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SyslogAppenderTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SyslogAppenderTest.java Fri Oct 31 11:07:57 2008 @@ -24,6 +24,7 @@ import ch.qos.logback.classic.net.mock.MockSyslogServer; import ch.qos.logback.core.joran.spi.JoranException; import ch.qos.logback.core.net.SyslogConstants; +import ch.qos.logback.core.testUtil.RandomUtil; import ch.qos.logback.core.util.StatusPrinter; public class SyslogAppenderTest { @@ -38,8 +39,8 @@ @Test public void basic() throws InterruptedException { - int port = MockSyslogServer.PORT + 1; - + int port = RandomUtil.getRandomServerPort(); + MockSyslogServer mockServer = new MockSyslogServer(1, port); mockServer.start(); // give MockSyslogServer head start @@ -83,7 +84,8 @@ @Test public void tException() throws InterruptedException { - int port = MockSyslogServer.PORT + 2; + int port = RandomUtil.getRandomServerPort(); + MockSyslogServer mockServer = new MockSyslogServer(21, port); mockServer.start(); // give MockSyslogServer head start Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/mock/MockSyslogServer.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/mock/MockSyslogServer.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/mock/MockSyslogServer.java Fri Oct 31 11:07:57 2008 @@ -20,8 +20,6 @@ */ public class MockSyslogServer extends Thread { - public static final int PORT = 14500; - final int loopLen; final int port; Added: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/testUtil/RandomUtil.java ============================================================================== --- (empty file) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/testUtil/RandomUtil.java Fri Oct 31 11:07:57 2008 @@ -0,0 +1,24 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2008, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ +package ch.qos.logback.core.testUtil; + +import java.util.Random; + +public class RandomUtil { + + private static Random random = new Random(); + + public static int getRandomServerPort() { + int r = random.nextInt(20000); + // the first 1024 ports are usually reserved for the OS + return r + 1024; + } + +}

1 0