October 2008 - logback-dev - mailman3.qos.ch

[JIRA] Resolved: (LBCLASSIC-6) Automatic reloading of logback.xml upon change
by Ceki Gulcu (JIRA) 30 Oct '08

30 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-6?page=com.atlassian.jira.plugin.system… ] Ceki Gulcu resolved LBCLASSIC-6. -------------------------------- Resolution: Duplicate > Automatic reloading of logback.xml upon change > ---------------------------------------------- > > Key: LBCLASSIC-6 > URL: http://jira.qos.ch/browse/LBCLASSIC-6 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: Windows > Platform: PC > Reporter: Ceki Gulcu > Assignee: Logback dev list > Priority: Minor > > It would be nice if logback-classic could reload its config file upon change. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Resolved: (LBCLASSIC-28) Include PrintStream suitable to replace System.out/err
by Ceki Gulcu (JIRA) 30 Oct '08

30 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-28?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu resolved LBCLASSIC-28. --------------------------------- Resolution: Duplicate > Include PrintStream suitable to replace System.out/err > ------------------------------------------------------ > > Key: LBCLASSIC-28 > URL: http://jira.qos.ch/browse/LBCLASSIC-28 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: Windows > Platform: PC > Reporter: Michael Newcomb > Assignee: Logback dev list > Priority: Minor > > It is becoming a common need to replace standard System.out/System.err with PrintStreams that are incorporated into the log. > It would be nice if this functionality was available with either SLF4J or at least Logback. > Thanks, > Michael -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Commented: (LBCLASSIC-47) LoggingEvent.formattedMessage is only initialized in c'tor.
by Ceki Gulcu (JIRA) 30 Oct '08

30 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-47?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu commented on LBCLASSIC-47: ------------------------------------- Your argument about saving space during serialization is quite convincing. > LoggingEvent.formattedMessage is only initialized in c'tor. > ----------------------------------------------------------- > > Key: LBCLASSIC-47 > URL: http://jira.qos.ch/browse/LBCLASSIC-47 > Project: logback-classic > Issue Type: Bug > Components: Other > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Joern Huxhorn > Assignee: Ceki Gulcu > > LoggingEvent.formattedMessage is only initialized if message and arguments are supplied during construction. If the default c'tor is used and message and arguments are provided using setMessage and setArgumentArray then formattedMessage will stay null. > Instead, formattedMessage should be declared transient and the actual formatting should take place lazily during getFormattedMessage call. > This would fix this problem, would increase general logging performance (formatting only if actually needed) and would decrease the size of serialized log events significantly while it would not change anything from the callers point of view. > This is a follow-up of LBCLASSIC-32. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r1919 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic
by noreply.ceki＠qos.ch 30 Oct '08

30 Oct '08

Author: ceki Date: Thu Oct 30 20:47:44 2008 New Revision: 1919 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java Log: removed unused import Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java Thu Oct 30 20:47:44 2008 @@ -13,7 +13,6 @@ import org.junit.Before; import org.junit.Test; -import org.slf4j.LoggerFactory; import ch.qos.logback.core.status.StatusManager;

1 0

[JIRA] Resolved: (LBCLASSIC-49) LoggerContext.getLogger(final String name) doesn't check if name is null
by Ceki Gulcu (JIRA) 30 Oct '08

30 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-49?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu resolved LBCLASSIC-49. --------------------------------- Fix Version/s: 0.9.12 Resolution: Fixed The getLogger() method in LoggerContext class will now throw an IllegalArgumentException when invoked with a null argument. I think that is the best logback-classic can do, since a null name argument is illegal. LoggerContext.getLogger(null) has to return something but can't... > LoggerContext.getLogger(final String name) doesn't check if name is null > ------------------------------------------------------------------------ > > Key: LBCLASSIC-49 > URL: http://jira.qos.ch/browse/LBCLASSIC-49 > Project: logback-classic > Issue Type: Bug > Components: Other > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Oliver Lietz > Assignee: Logback dev list > Fix For: 0.9.12 > > > hence loggerCache.get(name) could fail (NPE) in line 117: > java.lang.NullPointerException > at java.util.Hashtable.get(Hashtable.java:336) > at ch.qos.logback.classic.LoggerContext.getLogger(LoggerContext.java:117) > at ch.qos.logback.classic.LoggerContext.getLogger(LoggerContext.java:44) > at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:88) > at org.apache.sling.osgi.log.LogSupport.getLogger(LogSupport.java:322) > at org.apache.sling.osgi.log.LogSupport.logOut(LogSupport.java:333) > at org.apache.sling.osgi.log.LogSupport.fireLogEvent(LogSupport.java:167) > at org.apache.sling.osgi.log.LogSupport.bundleChanged(LogSupport.java:216) > at org.apache.felix.framework.util.EventDispatcher.invokeBundleListenerCallback(EventDispatcher.java:690) > at org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:619) > at org.apache.felix.framework.util.EventDispatcher.run(EventDispatcher.java:816) > at org.apache.felix.framework.util.EventDispatcher.access$000(EventDispatcher.java:42) > at org.apache.felix.framework.util.EventDispatcher$1.run(EventDispatcher.java:94) > at java.lang.Thread.run(Thread.java:613) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r1918 - in logback/trunk/logback-classic/src: main/java/ch/qos/logback/classic test/java/ch/qos/logback/classic
by noreply.ceki＠qos.ch 30 Oct '08

30 Oct '08

Author: ceki Date: Thu Oct 30 20:42:34 2008 New Revision: 1918 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PackageTest.java Log: Fixes LBCLASSIC-49 The getLogger() method in LoggerContext class will now throw an IllegalArgumentException when invoked with a null argument. Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java Thu Oct 30 20:42:34 2008 @@ -105,6 +105,10 @@ public final Logger getLogger(final String name) { + if(name == null) { + throw new IllegalArgumentException("name argument cannot be null"); + } + // if we are asking for the root logger, then let us return it without // wasting time if (ROOT_NAME.equalsIgnoreCase(name)) { Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java Thu Oct 30 20:42:34 2008 @@ -1,7 +1,7 @@ /** - * LOGBack: the generic, reliable, fast and flexible logging framework. + * Logback: the generic, reliable, fast and flexible logging framework. * - * Copyright (C) 1999-2006, QOS.ch + * Copyright (C) 2000-2008, QOS.ch * * This library is free software, you can redistribute it and/or modify it under * the terms of the GNU Lesser General Public License as published by the Free @@ -9,25 +9,33 @@ */ package ch.qos.logback.classic; -import junit.framework.TestCase; +import static org.junit.Assert.*; + +import org.junit.Before; +import org.junit.Test; +import org.slf4j.LoggerFactory; + import ch.qos.logback.core.status.StatusManager; -public class LoggerContextTest extends TestCase { +public class LoggerContextTest { LoggerContext lc; - protected void setUp() throws Exception { - Logger.instanceCount = 0; - lc = new LoggerContext(); - lc.setName("x"); + @Before + public void setUp() throws Exception { + Logger.instanceCount = 0; + lc = new LoggerContext(); + lc.setName("x"); } - public void testRootGetLogger() { + @Test + public void testRootGetLogger() { Logger root = lc.getLogger(LoggerContext.ROOT_NAME); assertEquals(Level.DEBUG, root.getLevel()); assertEquals(Level.DEBUG, root.getEffectiveLevel()); } - public void testLoggerX() { + @Test + public void testLoggerX() { Logger x = lc.getLogger("x"); assertNotNull(x); assertEquals("x", x.getName()); @@ -35,31 +43,44 @@ assertEquals(Level.DEBUG, x.getEffectiveLevel()); } - public void testEmpty() { + @Test + public void testNull() { + try { + lc.getLogger((String) null); + fail("null should cause an exception"); + } catch (IllegalArgumentException e) { + } + } + + @Test + public void testEmpty() { Logger empty = lc.getLogger(""); LoggerTestHelper.assertNameEquals(empty, ""); LoggerTestHelper.assertLevels(null, empty, Level.DEBUG); Logger dot = lc.getLogger("."); LoggerTestHelper.assertNameEquals(dot, "."); -// LoggerTestHelper.assertNameEquals(dot.parent, ""); -// LoggerTestHelper.assertNameEquals(dot.parent.parent, "root"); + // LoggerTestHelper.assertNameEquals(dot.parent, ""); + // LoggerTestHelper.assertNameEquals(dot.parent.parent, "root"); -// assertNull(dot.parent.parent.parent); + // assertNull(dot.parent.parent.parent); LoggerTestHelper.assertLevels(null, dot, Level.DEBUG); assertEquals(3, Logger.instanceCount); } + @Test public void testDotDot() { Logger dotdot = lc.getLogger(".."); assertEquals(4, Logger.instanceCount); LoggerTestHelper.assertNameEquals(dotdot, ".."); -// LoggerTestHelper.assertNameEquals(dotdot.parent, "."); -// LoggerTestHelper.assertNameEquals(dotdot.parent.parent, ""); -// LoggerTestHelper.assertNameEquals(dotdot.parent.parent.parent, "root"); + // LoggerTestHelper.assertNameEquals(dotdot.parent, "."); + // LoggerTestHelper.assertNameEquals(dotdot.parent.parent, ""); + // LoggerTestHelper.assertNameEquals(dotdot.parent.parent.parent, "root"); } - public void testLoggerXY() { + + @Test + public void testLoggerXY() { assertEquals(1, Logger.instanceCount); Logger xy = lc.getLogger("x.y"); @@ -78,26 +99,28 @@ assertEquals(3, Logger.instanceCount); } - public void testLoggerMultipleChildren() { - assertEquals(1, Logger.instanceCount); - Logger xy0 = lc.getLogger("x.y0"); - LoggerTestHelper.assertNameEquals(xy0, "x.y0"); - - Logger xy1 = lc.getLogger("x.y1"); - LoggerTestHelper.assertNameEquals(xy1, "x.y1"); - - LoggerTestHelper.assertLevels(null, xy0, Level.DEBUG); - LoggerTestHelper.assertLevels(null, xy1, Level.DEBUG); - assertEquals(4, Logger.instanceCount); - - for(int i = 0; i < 100; i++) { - Logger xy_i = lc.getLogger("x.y"+i); - LoggerTestHelper.assertNameEquals(xy_i, "x.y"+i); - LoggerTestHelper.assertLevels(null, xy_i, Level.DEBUG); - } - assertEquals(102, Logger.instanceCount); - } + @Test + public void testLoggerMultipleChildren() { + assertEquals(1, Logger.instanceCount); + Logger xy0 = lc.getLogger("x.y0"); + LoggerTestHelper.assertNameEquals(xy0, "x.y0"); + + Logger xy1 = lc.getLogger("x.y1"); + LoggerTestHelper.assertNameEquals(xy1, "x.y1"); + + LoggerTestHelper.assertLevels(null, xy0, Level.DEBUG); + LoggerTestHelper.assertLevels(null, xy1, Level.DEBUG); + assertEquals(4, Logger.instanceCount); + + for (int i = 0; i < 100; i++) { + Logger xy_i = lc.getLogger("x.y" + i); + LoggerTestHelper.assertNameEquals(xy_i, "x.y" + i); + LoggerTestHelper.assertLevels(null, xy_i, Level.DEBUG); + } + assertEquals(102, Logger.instanceCount); + } + @Test public void testMultiLevel() { Logger wxyz = lc.getLogger("w.x.y.z"); LoggerTestHelper.assertNameEquals(wxyz, "w.x.y.z"); @@ -110,22 +133,24 @@ LoggerTestHelper.assertLevels(null, lc.getLogger("w.x.y"), Level.INFO); LoggerTestHelper.assertLevels(null, wxyz, Level.INFO); } - + + @Test public void testStatusWithUnconfiguredContext() { - Logger logger = lc.getLogger(LoggerContextTest.class); - - for (int i = 0; i < 3; i++) { - logger.debug("test"); - } - - logger = lc.getLogger("x.y.z"); - - for (int i = 0; i < 3; i++) { - logger.debug("test"); - } - - StatusManager sm = lc.getStatusManager(); - assertTrue("StatusManager has recieved too many messages", sm.getCount() == 1); + Logger logger = lc.getLogger(LoggerContextTest.class); + + for (int i = 0; i < 3; i++) { + logger.debug("test"); + } + + logger = lc.getLogger("x.y.z"); + + for (int i = 0; i < 3; i++) { + logger.debug("test"); + } + + StatusManager sm = lc.getStatusManager(); + assertTrue("StatusManager has recieved too many messages", + sm.getCount() == 1); } } \ No newline at end of file Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PackageTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PackageTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PackageTest.java Thu Oct 30 20:42:34 2008 @@ -15,7 +15,7 @@ public static Test suite() { TestSuite suite = new TestSuite(); - suite.addTestSuite(LoggerContextTest.class); + suite.addTest(new JUnit4TestAdapter(LoggerContextTest.class)); suite.addTest(new JUnit4TestAdapter(LoggerPerfTest.class)); suite.addTest(new JUnit4TestAdapter(DynamicLoggerContextTest.class)); suite.addTest(new JUnit4TestAdapter(PatternLayoutTest.class));

1 0

[JIRA] Commented: (LBCLASSIC-55) Report URL config has been loaded from when debug="true"
by Ceki Gulcu (JIRA) 30 Oct '08

30 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-55?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu commented on LBCLASSIC-55: ------------------------------------- Hello Anton, At initialization time, logback will report whether it is reading logback-test.xml or logback.xml. Is this what you meant, or did you mean something else? > Report URL config has been loaded from when debug="true" > -------------------------------------------------------- > > Key: LBCLASSIC-55 > URL: http://jira.qos.ch/browse/LBCLASSIC-55 > Project: logback-classic > Issue Type: Improvement > Reporter: Anton Tagunov > Assignee: Ceki Gulcu > > Hi! > <configuration debug="true"> is nice. > It will be even nicer if it also reports what URL the config is being loaded from. > Thx! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Commented: (LBCORE-21) TimeBasedRollingPolicy do NOT work as expected
by Ceki Gulcu (JIRA) 30 Oct '08

30 Oct '08

[ http://jira.qos.ch/browse/LBCORE-21?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu commented on LBCORE-21: ---------------------------------- The link to revision 1917 was mistakenly associated with this bug. It should have been associated with LBCORE-26. > TimeBasedRollingPolicy do NOT work as expected > ---------------------------------------------- > > Key: LBCORE-21 > URL: http://jira.qos.ch/browse/LBCORE-21 > Project: logback-core > Issue Type: Bug > Components: Rolling > Affects Versions: unspecified > Environment: Operating System: Linux > Platform: All > Reporter: Eric > Assignee: Logback dev list > Priority: Blocker > > When I use TimeBasedRollingPolicy as the rolling & triggering policy for the RollingFileAppender, only the last log line appears in the new log file after the 1st rolling trigger. > The reason is that the TimeBasedRollingPolicy kept rolling for every log event after the 1st rolling trigger. It causes by a bug in isTriggeringEvent() method - the method uses the un-initialized value of 'currentTime' (which is 0) to set the time of the 'lastCheck' Date object. > Original method : > public boolean isTriggeringEvent(File activeFile, final Object event) { > //currentTime= System.currentTimeMillis(); > if (getCurrentTime() >= nextCheck) { > //addInfo("Time to trigger roll-over"); > // We set the elapsedPeriodsFileName before we set the 'lastCheck' variable > // The elapsedPeriodsFileName corresponds to the file name of the period > // that just elapsed. > elapsedPeriodsFileName = activeFileNamePattern.convertDate(lastCheck); > //addInfo("elapsedPeriodsFileName set to "+elapsedPeriodsFileName); > lastCheck.setTime(currentTime); > nextCheck = rc.getNextCheckMillis(lastCheck); > > Date x = new Date(); > x.setTime(nextCheck); > //addInfo("Next check on "+ x); > return true; > } else { > return false; > } > } > Suggested Changes - uses a local long variable to store the value of getCurrentTime() and uses it in the method for comparison and assignment: > public boolean isTriggeringEvent(File activeFile, final Object event) { > //currentTime= System.currentTimeMillis(); > long curT = getCurrentTime(); > if (curT >= nextCheck) { > //addInfo("Time to trigger roll-over"); > // We set the elapsedPeriodsFileName before we set the 'lastCheck' variable > // The elapsedPeriodsFileName corresponds to the file name of the period > // that just elapsed. > elapsedPeriodsFileName = activeFileNamePattern.convertDate(lastCheck); > //addInfo("elapsedPeriodsFileName set to "+elapsedPeriodsFileName); > lastCheck.setTime(curT); > nextCheck = rc.getNextCheckMillis(lastCheck); > //Date x = new Date(); > //x.setTime(nextCheck); > //addInfo("Next check on "+ x); > return true; > } else { > return false; > } > } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Commented: (LBCORE-26) TimeBasedRollingPolicy append logs into a old log file, instead of rolling the log file.
by Ceki Gulcu (JIRA) 30 Oct '08

30 Oct '08

[ http://jira.qos.ch/browse/LBCORE-26?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu commented on LBCORE-26: ---------------------------------- Details for this commit can be seen at http://svn.qos.ch/viewvc?root=svn&revision=1917&pathrev=1917&view=rev > TimeBasedRollingPolicy append logs into a old log file, instead of rolling the log file. > ---------------------------------------------------------------------------------------- > > Key: LBCORE-26 > URL: http://jira.qos.ch/browse/LBCORE-26 > Project: logback-core > Issue Type: Bug > Components: Rolling > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Tsutomu YANO > Assignee: Logback dev list > Priority: Critical > Fix For: 0.9.12 > > > If you use TimeBasedRollingPolicy to rollover a log file and no log wasn't wrote into the log beyond the timing of rollover, and if you restart your application, the log file doesn't roll, then new log will be appended into old log file. > EVIDENCE: > 1. in logback.xml, set your FileNamePattern like 'log.%d{yyyy-MM-dd_HH-mm}.log'. > 2. Simply do a kind of thing, which will make some logs into your log file. > 3. Wait for some minutes. > 4. restart your application. > 5. do a kind of thing, which will make some logs into your log file. > the FileNamePattern is 'log.%d{yyyy-MM-dd_HH-mm}.log', so the log file will be roll every minutes. On case 5 of above example, the log file should be roll over, because some minutes already have passed after last logs wrote into the log file. But the file didn't be roll overed. > THE CAUSE: > In start() method of TimeBasedRollingPolicy, you initialize a variable 'lastCheck' to System.currentTimeStamp(). So if you restart your application, the last check time will be set to just NOW. > you should initialize the variable to a last modified time of a current log file. > See below source code. from '//modified by Tsutomu YANO' to '//until here'. > SOURCE: > public void start() { > // set the LR for our utility object > util.setContext(this.context); > compress.setContext(this.context); > // find out period from the filename pattern > if (fileNamePatternStr != null) { > fileNamePattern = new FileNamePattern(fileNamePatternStr, this.context); > determineCompressionMode(); > } else { > addWarn(FNP_NOT_SET); > addWarn(SEE_FNP_NOT_SET); > throw new IllegalStateException(FNP_NOT_SET + SEE_FNP_NOT_SET); > } > DateTokenConverter dtc = fileNamePattern.getDateTokenConverter(); > if (dtc == null) { > throw new IllegalStateException("FileNamePattern [" + fileNamePattern.getPattern() + "] does not contain a valid DateToken"); > } > int len = fileNamePatternStr.length(); > switch (compressionMode) { > case Compress.GZ: > activeFileNamePattern = new FileNamePattern(fileNamePatternStr.substring(0, len - 3), this.context); > break; > case Compress.ZIP: > activeFileNamePattern = new FileNamePattern(fileNamePatternStr.substring(0, len - 4), this.context); > break; > case Compress.NONE: > activeFileNamePattern = fileNamePattern; > } > addInfo("Will use the pattern " + activeFileNamePattern + " for the active file"); > rc = new RollingCalendar(); > rc.init(dtc.getDatePattern()); > addInfo("The date pattern is '" + dtc.getDatePattern() + "' from file name pattern '" + fileNamePattern.getPattern() + "'."); > rc.printPeriodicity(this); > > //modified by Tsutomu YANO > //if a current log file exists, initialize a 'lastCheck' variable to the > //last modified date of the file. > File currentFile = new File(getParentFileName()); > if(currentFile.exists() && currentFile.canRead()) { > lastCheck.setTime(currentFile.lastModified()); > } else { > // currentTime = System.currentTimeMillis(); > lastCheck.setTime(getCurrentTime()); > } > //until here > > nextCheck = rc.getNextCheckMillis(lastCheck); > // Date nc = new Date(); > // nc.setTime(nextCheck); > } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Resolved: (LBCORE-26) TimeBasedRollingPolicy append logs into a old log file, instead of rolling the log file.
by Ceki Gulcu (JIRA) 30 Oct '08

30 Oct '08

[ http://jira.qos.ch/browse/LBCORE-26?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu resolved LBCORE-26. ------------------------------ Fix Version/s: 0.9.12 Resolution: Fixed Problem solved in revision 1917 which will be available in logback 0.9.12. > TimeBasedRollingPolicy append logs into a old log file, instead of rolling the log file. > ---------------------------------------------------------------------------------------- > > Key: LBCORE-26 > URL: http://jira.qos.ch/browse/LBCORE-26 > Project: logback-core > Issue Type: Bug > Components: Rolling > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Tsutomu YANO > Assignee: Logback dev list > Priority: Critical > Fix For: 0.9.12 > > > If you use TimeBasedRollingPolicy to rollover a log file and no log wasn't wrote into the log beyond the timing of rollover, and if you restart your application, the log file doesn't roll, then new log will be appended into old log file. > EVIDENCE: > 1. in logback.xml, set your FileNamePattern like 'log.%d{yyyy-MM-dd_HH-mm}.log'. > 2. Simply do a kind of thing, which will make some logs into your log file. > 3. Wait for some minutes. > 4. restart your application. > 5. do a kind of thing, which will make some logs into your log file. > the FileNamePattern is 'log.%d{yyyy-MM-dd_HH-mm}.log', so the log file will be roll every minutes. On case 5 of above example, the log file should be roll over, because some minutes already have passed after last logs wrote into the log file. But the file didn't be roll overed. > THE CAUSE: > In start() method of TimeBasedRollingPolicy, you initialize a variable 'lastCheck' to System.currentTimeStamp(). So if you restart your application, the last check time will be set to just NOW. > you should initialize the variable to a last modified time of a current log file. > See below source code. from '//modified by Tsutomu YANO' to '//until here'. > SOURCE: > public void start() { > // set the LR for our utility object > util.setContext(this.context); > compress.setContext(this.context); > // find out period from the filename pattern > if (fileNamePatternStr != null) { > fileNamePattern = new FileNamePattern(fileNamePatternStr, this.context); > determineCompressionMode(); > } else { > addWarn(FNP_NOT_SET); > addWarn(SEE_FNP_NOT_SET); > throw new IllegalStateException(FNP_NOT_SET + SEE_FNP_NOT_SET); > } > DateTokenConverter dtc = fileNamePattern.getDateTokenConverter(); > if (dtc == null) { > throw new IllegalStateException("FileNamePattern [" + fileNamePattern.getPattern() + "] does not contain a valid DateToken"); > } > int len = fileNamePatternStr.length(); > switch (compressionMode) { > case Compress.GZ: > activeFileNamePattern = new FileNamePattern(fileNamePatternStr.substring(0, len - 3), this.context); > break; > case Compress.ZIP: > activeFileNamePattern = new FileNamePattern(fileNamePatternStr.substring(0, len - 4), this.context); > break; > case Compress.NONE: > activeFileNamePattern = fileNamePattern; > } > addInfo("Will use the pattern " + activeFileNamePattern + " for the active file"); > rc = new RollingCalendar(); > rc.init(dtc.getDatePattern()); > addInfo("The date pattern is '" + dtc.getDatePattern() + "' from file name pattern '" + fileNamePattern.getPattern() + "'."); > rc.printPeriodicity(this); > > //modified by Tsutomu YANO > //if a current log file exists, initialize a 'lastCheck' variable to the > //last modified date of the file. > File currentFile = new File(getParentFileName()); > if(currentFile.exists() && currentFile.canRead()) { > lastCheck.setTime(currentFile.lastModified()); > } else { > // currentTime = System.currentTimeMillis(); > lastCheck.setTime(getCurrentTime()); > } > //until here > > nextCheck = rc.getNextCheckMillis(lastCheck); > // Date nc = new Date(); > // nc.setTime(nextCheck); > } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0