October 2008 - logback-dev - mailman3.qos.ch

svn commit: r1901 - in logback/trunk: logback-access/src/test/java/ch/qos/logback/access/db logback-classic/src/test/java/ch/qos/logback/classic/db
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 14:56:19 2008 New Revision: 1901 Added: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestFixture.java - copied, changed from r1874, /logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestInfrastructure.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestFixture.java - copied, changed from r1899, /logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java Removed: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestInfrastructure.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTest.java logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/PackageTest.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTest.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/PackageTest.java Log: placing DBAppender fixture in a separate class. DBAppenderTest no longer extends the fixture. This should make the code a somewhat clearer Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTest.java ============================================================================== --- logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTest.java (original) +++ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTest.java Wed Oct 29 14:56:19 2008 @@ -1,29 +1,49 @@ package ch.qos.logback.access.db; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.fail; + import java.sql.ResultSet; import java.sql.SQLException; import java.sql.Statement; +import org.junit.After; +import org.junit.AfterClass; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; + import ch.qos.logback.access.dummy.DummyRequest; import ch.qos.logback.access.dummy.DummyResponse; import ch.qos.logback.access.dummy.DummyServerAdapter; -import ch.qos.logback.access.spi.AccessEvent; import ch.qos.logback.access.spi.AccessContext; +import ch.qos.logback.access.spi.AccessEvent; import ch.qos.logback.core.db.DriverManagerConnectionSource; import ch.qos.logback.core.util.StatusPrinter; -public class DBAppenderTest extends DBAppenderTestInfrastructure { +public class DBAppenderTest { AccessContext context; DBAppender appender; DriverManagerConnectionSource connectionSource; - public DBAppenderTest(String name) { - super(name); + static DBAppenderTestFixture DB_APPENDER_TEST_FIXTURE; + + @BeforeClass + static public void fixtureSetUp() throws SQLException { + DB_APPENDER_TEST_FIXTURE = new DBAppenderTestFixture(); + DB_APPENDER_TEST_FIXTURE.setUp(); + } + + @AfterClass + static public void fixtureTearDown() throws SQLException { + DB_APPENDER_TEST_FIXTURE.tearDown(); } - + + @Before public void setUp() throws SQLException { - super.setUp(); context = new AccessContext(); context.setName("default"); appender = new DBAppender(); @@ -31,10 +51,10 @@ appender.setContext(context); connectionSource = new DriverManagerConnectionSource(); connectionSource.setContext(context); - connectionSource.setDriverClass(DRIVER_CLASS); - connectionSource.setUrl(url); - connectionSource.setUser(user); - connectionSource.setPassword(password); + connectionSource.setDriverClass(DBAppenderTestFixture.DRIVER_CLASS); + connectionSource.setUrl(DB_APPENDER_TEST_FIXTURE.url); + connectionSource.setUser(DB_APPENDER_TEST_FIXTURE.user); + connectionSource.setPassword(DB_APPENDER_TEST_FIXTURE.password); connectionSource.start(); appender.setConnectionSource(connectionSource); } @@ -44,13 +64,14 @@ appender.start(); } + @After public void tearDown() throws SQLException { - super.tearDown(); context = null; appender = null; connectionSource = null; } + @Test public void testAppendAccessEvent() throws SQLException { setInsertHeadersAndStart(false); @@ -80,6 +101,7 @@ } + @Test public void testCheckNoHeadersAreInserted() throws Exception { setInsertHeadersAndStart(false); @@ -97,6 +119,7 @@ stmt.close(); } + @Test public void testAppendHeaders() throws SQLException { setInsertHeadersAndStart(true); @@ -131,15 +154,17 @@ stmt.close(); } + @Test public void testAppendMultipleEvents() throws SQLException { + String uri = "testAppendMultipleEvents"; for (int i = 0; i < 10; i++) { - AccessEvent event = createAccessEvent(); + AccessEvent event = createAccessEvent(uri); appender.append(event); } Statement stmt = connectionSource.getConnection().createStatement(); ResultSet rs = null; - rs = stmt.executeQuery("SELECT * FROM access_event"); + rs = stmt.executeQuery("SELECT * FROM access_event where requestURI='"+uri+"'"); int count = 0; while (rs.next()) { count++; @@ -151,7 +176,12 @@ } private AccessEvent createAccessEvent() { + return createAccessEvent(""); + } + + private AccessEvent createAccessEvent(String uri) { DummyRequest request = new DummyRequest(); + request.setRequestUri(uri); DummyResponse response = new DummyResponse(); DummyServerAdapter adapter = new DummyServerAdapter(request, response); Copied: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestFixture.java (from r1874, /logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestInfrastructure.java) ============================================================================== --- /logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestInfrastructure.java (original) +++ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestFixture.java Wed Oct 29 14:56:19 2008 @@ -5,11 +5,9 @@ import java.sql.SQLException; import java.sql.Statement; -import junit.framework.TestCase; - import org.hsqldb.Server; -public abstract class DBAppenderTestInfrastructure extends TestCase { +public class DBAppenderTestFixture { public static final String DRIVER_CLASS = "org.hsqldb.jdbcDriver"; String serverProps; @@ -19,11 +17,8 @@ Server server; boolean isNetwork = true; - public DBAppenderTestInfrastructure(String name) { - super(name); - } - protected void setUp() throws SQLException { + void setUp() throws SQLException { if (isNetwork) { if (url == null) { url = "jdbc:hsqldb:hsql://localhost/test"; @@ -55,7 +50,7 @@ createTables(); } - protected void tearDown() throws SQLException { + void tearDown() throws SQLException { dropTables(); if (isNetwork) { server.stop(); @@ -67,7 +62,7 @@ return DriverManager.getConnection(url, user, password); } - void createTables() throws SQLException { + private void createTables() throws SQLException { Connection conn = newConnection(); StringBuffer buf = new StringBuffer(); buf.append("CREATE TABLE access_event ("); @@ -94,7 +89,7 @@ query(conn, buf.toString()); } - void dropTables() throws SQLException { + private void dropTables() throws SQLException { Connection conn = newConnection(); StringBuffer buf = new StringBuffer(); @@ -106,7 +101,7 @@ query(conn, buf.toString()); } - void query(Connection conn, String expression) throws SQLException { + private void query(Connection conn, String expression) throws SQLException { Statement st = null; st = conn.createStatement(); Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/PackageTest.java ============================================================================== --- logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/PackageTest.java (original) +++ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/PackageTest.java Wed Oct 29 14:56:19 2008 @@ -15,7 +15,7 @@ public static Test suite() { TestSuite suite = new TestSuite(); - suite.addTestSuite(DBAppenderTest.class); + suite.addTest(new JUnit4TestAdapter(DBAppenderTest.class)); suite.addTest(new JUnit4TestAdapter(DBAppenderIntegrationTest.class)); return suite; } Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTest.java Wed Oct 29 14:56:19 2008 @@ -1,10 +1,18 @@ package ch.qos.logback.classic.db; +import static org.junit.Assert.*; + import java.sql.ResultSet; import java.sql.SQLException; import java.sql.Statement; import java.util.Map; +import org.junit.After; +import org.junit.AfterClass; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; + import ch.qos.logback.classic.Level; import ch.qos.logback.classic.Logger; import ch.qos.logback.classic.LoggerContext; @@ -12,19 +20,28 @@ import ch.qos.logback.classic.spi.LoggingEvent; import ch.qos.logback.core.db.DriverManagerConnectionSource; -public class DBAppenderTest extends DBAppenderTestBase { +public class DBAppenderTest { LoggerContext lc; Logger logger; DBAppender appender; DriverManagerConnectionSource connectionSource; - public DBAppenderTest(String name) { - super(name); + static DBAppenderTestFixture DB_APPENDER_TEST_FIXTURE; + + @BeforeClass + public static void fixtureSetUp() throws SQLException { + DB_APPENDER_TEST_FIXTURE = new DBAppenderTestFixture(); + DB_APPENDER_TEST_FIXTURE.setUp(); } - + + @AfterClass + public static void fixtureTearDown() throws SQLException { + DB_APPENDER_TEST_FIXTURE.tearDown(); + } + + @Before public void setUp() throws SQLException { - super.setUp(); lc = new LoggerContext(); lc.setName("default"); logger = lc.getLogger("root"); @@ -33,23 +50,24 @@ appender.setContext(lc); connectionSource = new DriverManagerConnectionSource(); connectionSource.setContext(lc); - connectionSource.setDriverClass(HSQLDB_DRIVER_CLASS); - connectionSource.setUrl(url); - connectionSource.setUser(user); - connectionSource.setPassword(password); + connectionSource.setDriverClass(DBAppenderTestFixture.HSQLDB_DRIVER_CLASS); + connectionSource.setUrl(DB_APPENDER_TEST_FIXTURE.url); + connectionSource.setUser(DB_APPENDER_TEST_FIXTURE.user); + connectionSource.setPassword(DB_APPENDER_TEST_FIXTURE.password); connectionSource.start(); appender.setConnectionSource(connectionSource); appender.start(); } + @After public void tearDown() throws SQLException { - super.tearDown(); logger = null; lc = null; appender = null; connectionSource = null; } + @Test public void testAppendLoggingEvent() throws SQLException { LoggingEvent event = createLoggingEvent(); Copied: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestFixture.java (from r1899, /logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java) ============================================================================== --- /logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestFixture.java Wed Oct 29 14:56:19 2008 @@ -1,18 +1,18 @@ package ch.qos.logback.classic.db; +import static org.junit.Assert.assertNotNull; + import java.io.PrintWriter; import java.sql.Connection; import java.sql.SQLException; import java.sql.Statement; import java.util.Properties; -import junit.framework.TestCase; - import org.hsqldb.Server; import org.hsqldb.ServerConstants; import org.hsqldb.jdbcDriver; -public abstract class DBAppenderTestBase extends TestCase { +public class DBAppenderTestFixture { public static final String HSQLDB_DRIVER_CLASS = "org.hsqldb.jdbcDriver"; // String serverProps; @@ -24,8 +24,7 @@ // boolean isNetwork = true; HsqlMode mode = HsqlMode.MEM; - public DBAppenderTestBase(String name) { - super(name); + public DBAppenderTestFixture() { } public void setUp() throws SQLException { @@ -92,7 +91,7 @@ // return DriverManager.getConnection(url, user, password); } - void createTables() throws SQLException { + private void createTables() throws SQLException { Connection conn = newConnection(); assertNotNull(conn); StringBuffer buf = new StringBuffer(); @@ -129,7 +128,7 @@ query(conn, buf.toString()); } - void dropTables() throws SQLException { + private void dropTables() throws SQLException { Connection conn = newConnection(); StringBuffer buf = new StringBuffer(); buf.append("DROP TABLE logging_event_exception IF EXISTS;"); @@ -144,7 +143,7 @@ query(conn, buf.toString()); } - void query(Connection conn, String expression) throws SQLException { + private void query(Connection conn, String expression) throws SQLException { Statement st = null; st = conn.createStatement(); Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/PackageTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/PackageTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/PackageTest.java Wed Oct 29 14:56:19 2008 @@ -15,7 +15,7 @@ public static Test suite() { TestSuite suite = new TestSuite(); - suite.addTestSuite(DBAppenderTest.class); + suite.addTest(new JUnit4TestAdapter(DBAppenderTest.class)); return suite; } } \ No newline at end of file

1 0

[JIRA] Created: (LBCLASSIC-72) Please implement a getter for StackTraceElementProxy.ste
by Joern Huxhorn (JIRA) 29 Oct '08

29 Oct '08

Please implement a getter for StackTraceElementProxy.ste -------------------------------------------------------- Key: LBCLASSIC-72 URL: http://jira.qos.ch/browse/LBCLASSIC-72 Project: logback-classic Issue Type: Improvement Reporter: Joern Huxhorn Assignee: Logback dev list I just checked out your latest changes concerning package version information because I have to implement it for Lilith when the next version of Logback is released. At the moment StackTraceElementProxy does not have a getter for the contained StackTraceElement. It would be really helpful for me if I could access it. Otherwise I'd have to parse it from steAsString which I'd really like to prevent. I'd suggest to implement both a getter and a setter for the StackTraceElement. steAsString would need to be set to null if the STE is changed. Additionally, I'd suggest to make steAsString transient since it can be restored after deserialization. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 6

[JIRA] Commented: (LBCLASSIC-46) ThrowableInformation should keep the Throwable cause hierarchy intact.
by Joern Huxhorn (JIRA) 29 Oct '08

29 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-46?page=com.atlassian.jira.plugin.syste… ] Joern Huxhorn commented on LBCLASSIC-46: ---------------------------------------- Oh, that was a misunderstanding. I didn't mean that the stacktrace shouldn't be reduced, I wanted to suggest to just drop the information message about the dropped frames because it wouldn't fit into a StackTraceElementProxy so it couldn't be added anymore in my example above. Alternatively, we could add an additional int omittedFrames to contain info abou the number of omitted frames. What I'd really like to have is the raw data so I can access the different field without additional processing. > ThrowableInformation should keep the Throwable cause hierarchy intact. > ---------------------------------------------------------------------- > > Key: LBCLASSIC-46 > URL: http://jira.qos.ch/browse/LBCLASSIC-46 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Joern Huxhorn > Assignee: Ceki Gulcu > Priority: Minor > > Instead of a String representation of the whole Throwable stack trace incl. cause ThrowableInformation should instead look like this: > public class ThrowableInformation implements Serializable > { > String throwableClassName; > String message; > StackTraceElement[] stackTrace; > ThrowableInformation cause; > } > I omitted get/set and private in this example. > StackTraceElement is perfectly Serializable and did also receive a public c'tor in Java 5 so I guess that the current ThrowableInformation is more or less a relict of log4j which had to stay compatible with older Java versions. > You could obviously keep the getThrowableStrRep() method for compatibility. > This bug is somewhat related to LBCLASSIC-45 because I think that ThrowableInformation should also, as LoggingEvent, be just a dumb data container with no real logic. > The logic to extract the relevant StackTraceElements should IMHO be moved either into Logger or into a static factory method of ThrowableInformation. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Issue Comment Edited: (LBCLASSIC-46) ThrowableInformation should keep the Throwable cause hierarchy intact.
by Joern Huxhorn (JIRA) 29 Oct '08

29 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-46?page=com.atlassian.jira.plugin.syste… ] Joern Huxhorn edited comment on LBCLASSIC-46 at 10/29/08 2:14 PM: ------------------------------------------------------------------ Oh, that was a misunderstanding. I didn't mean that the stacktrace shouldn't be reduced, I wanted to suggest to just drop the information message about the dropped frames because it wouldn't fit into a StackTraceElementProxy so it couldn't be added anymore in my example above. Alternatively, we could add an additional int omittedFrames to contain info about the number of omitted frames. What I'd really like to have is the raw data so I can access the different field without additional processing. was (Author: jhuxhorn): Oh, that was a misunderstanding. I didn't mean that the stacktrace shouldn't be reduced, I wanted to suggest to just drop the information message about the dropped frames because it wouldn't fit into a StackTraceElementProxy so it couldn't be added anymore in my example above. Alternatively, we could add an additional int omittedFrames to contain info abou the number of omitted frames. What I'd really like to have is the raw data so I can access the different field without additional processing. > ThrowableInformation should keep the Throwable cause hierarchy intact. > ---------------------------------------------------------------------- > > Key: LBCLASSIC-46 > URL: http://jira.qos.ch/browse/LBCLASSIC-46 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Joern Huxhorn > Assignee: Ceki Gulcu > Priority: Minor > > Instead of a String representation of the whole Throwable stack trace incl. cause ThrowableInformation should instead look like this: > public class ThrowableInformation implements Serializable > { > String throwableClassName; > String message; > StackTraceElement[] stackTrace; > ThrowableInformation cause; > } > I omitted get/set and private in this example. > StackTraceElement is perfectly Serializable and did also receive a public c'tor in Java 5 so I guess that the current ThrowableInformation is more or less a relict of log4j which had to stay compatible with older Java versions. > You could obviously keep the getThrowableStrRep() method for compatibility. > This bug is somewhat related to LBCLASSIC-45 because I think that ThrowableInformation should also, as LoggingEvent, be just a dumb data container with no real logic. > The logic to extract the relevant StackTraceElements should IMHO be moved either into Logger or into a static factory method of ThrowableInformation. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Resolved: (LBCLASSIC-56) Dealing with the '\\' during substitution
by Ceki Gulcu (JIRA) 29 Oct '08

29 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-56?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu resolved LBCLASSIC-56. --------------------------------- Fix Version/s: 0.9.10 Resolution: Fixed resolved in revision 1706. > Dealing with the '\\' during substitution > ----------------------------------------- > > Key: LBCLASSIC-56 > URL: http://jira.qos.ch/browse/LBCLASSIC-56 > Project: logback-classic > Issue Type: Bug > Reporter: Ceki Gulcu > Assignee: Logback dev list > Fix For: 0.9.10 > > > QUOTE > I'm been unsuccessful at using the RollingFileAppender with a > FixedWindowRollingPolicy that has this FileNamePattern: > <FileNamePattern>${user.home}/Client%i.log</FileNamePattern> > "${user.home}/Client%i.log" gets correctly expanded to "C:\\Documents and > Settings\\Michel/Client%i.log" when it's passed to the > FixedWindowRollingPolicy constructor. > The problem starts once the filename gets parsed by > ch.qos.logback.core.pattern.parser.Parser: the filename becomes "C:ocuments > and Settingsichel/Client". > File rotations then fails (as would be expected) when trying to rename the > current log to "C:ocuments and Settingsichel/Client1.log" > Is there a way to configure logback to correctly deal with the "\\" used in > windows? > End of quote > For original report see: http://www.qos.ch/pipermail/logback-user/2008-June/000476.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Commented: (LBCLASSIC-46) ThrowableInformation should keep the Throwable cause hierarchy intact.
by Ceki Gulcu (JIRA) 29 Oct '08

29 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-46?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu commented on LBCLASSIC-46: ------------------------------------- The 'x commons framed omitted' helps to significantly reduce the number of printed stack lines for nested exceptions. However, I don't think the nested ThrowableProxy structure you propose precludes the calculation of commons frames. > ThrowableInformation should keep the Throwable cause hierarchy intact. > ---------------------------------------------------------------------- > > Key: LBCLASSIC-46 > URL: http://jira.qos.ch/browse/LBCLASSIC-46 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Joern Huxhorn > Assignee: Ceki Gulcu > Priority: Minor > > Instead of a String representation of the whole Throwable stack trace incl. cause ThrowableInformation should instead look like this: > public class ThrowableInformation implements Serializable > { > String throwableClassName; > String message; > StackTraceElement[] stackTrace; > ThrowableInformation cause; > } > I omitted get/set and private in this example. > StackTraceElement is perfectly Serializable and did also receive a public c'tor in Java 5 so I guess that the current ThrowableInformation is more or less a relict of log4j which had to stay compatible with older Java versions. > You could obviously keep the getThrowableStrRep() method for compatibility. > This bug is somewhat related to LBCLASSIC-45 because I think that ThrowableInformation should also, as LoggingEvent, be just a dumb data container with no real logic. > The logic to extract the relevant StackTraceElements should IMHO be moved either into Logger or into a static factory method of ThrowableInformation. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r1900 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 12:05:04 2008 New Revision: 1900 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/PackagingDataCalculator.java logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/StackTraceElementProxy.java Log: related to LBCLASSIC-72 In StackTracementElement proxy, the setPackageInfo method was renamed as setClassPackagingData for consistency. The steAsString field marked as transient to save a few byte during serialization (we can reconstruct this field from 'ste') Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/PackagingDataCalculator.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/PackagingDataCalculator.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/PackagingDataCalculator.java Wed Oct 29 12:05:04 2008 @@ -91,11 +91,11 @@ firsExactClassLoader = callerClass.getClassLoader(); } ClassPackagingData pi = calculateByExactType(callerClass); - step.setPackageInfo(pi); + step.setClassPackagingData(pi); } else { missfireCount++; ClassPackagingData pi = computeBySTEP(step, lastExactClassLoader); - step.setPackageInfo(pi); + step.setClassPackagingData(pi); } } populateUncommonFrames(commonFrames, stepArray, firsExactClassLoader); @@ -139,7 +139,7 @@ for (int i = 0; i < uncommonFrames; i++) { StackTraceElementProxy step = stepArray[i]; ClassPackagingData pi = computeBySTEP(step, firstExactClassLoader); - step.setPackageInfo(pi); + step.setClassPackagingData(pi); } } Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/StackTraceElementProxy.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/StackTraceElementProxy.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/StackTraceElementProxy.java Wed Oct 29 12:05:04 2008 @@ -7,7 +7,9 @@ private static final long serialVersionUID = -4832130320500439038L; final StackTraceElement ste; - private String steAsString; + // save a byte or two during serialization, as we can + // reconstruct this field from 'ste' + transient private String steAsString; private ClassPackagingData cpd; StackTraceElementProxy(StackTraceElement ste) { @@ -29,7 +31,7 @@ return ste; } - void setPackageInfo(ClassPackagingData cpd) { + void setClassPackagingData(ClassPackagingData cpd) { this.cpd = cpd; }

1 0

svn commit: r1899 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 11:21:49 2008 New Revision: 1899 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/StackTraceElementProxy.java Log: added a getter for 'ste' as requested in LBCLASSIC-72 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/StackTraceElementProxy.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/StackTraceElementProxy.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/StackTraceElementProxy.java Wed Oct 29 11:21:49 2008 @@ -17,13 +17,18 @@ this.ste = ste; } + public String getSTEAsString() { if (steAsString == null) { steAsString = "\tat " + ste.toString(); } return steAsString; } - + + public StackTraceElement getStackTraceElement() { + return ste; + } + void setPackageInfo(ClassPackagingData cpd) { this.cpd = cpd; }

1 0

svn commit: r1898 - logback/trunk/logback-site/src/site/pages
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 11:16:00 2008 New Revision: 1898 Modified: logback/trunk/logback-site/src/site/pages/faq.html Log: - removing questions which are best answered in SLF4J - added an entry about logger deserialization (related to LBCLASSIC-74 ) Modified: logback/trunk/logback-site/src/site/pages/faq.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/faq.html (original) +++ logback/trunk/logback-site/src/site/pages/faq.html Wed Oct 29 11:16:00 2008 @@ -32,35 +32,36 @@ <h3>Logback Classic</h3> - <ol type="1"> + <ol type="1"> <li> - <a href="#setup_jetty"> - How can I use logback-classic with Jetty ? - </a> - </li> - <li> - <a href="#auto_config"> - How does the automatic configuration work? - </a> - </li> + <a href="#logger_serialization">Are logback loggers + serializable?</a> + </li> + <li> - <a href="#intercept_calls_tomcat"> - How can I intercept JCL calls in Tomcat? - </a> - </li> + <a href="#auto_config">How does the automatic configuration + work?</a> + </li> <li> - <a href="#intercept_calls_jetty"> - How can I intercept JCL calls in Jetty ? + <a href="#setup_jetty">How can Jetty be instructed to use + logback-classic as its logging implementataion? </a> </li> </ol> + +  +  +  +  + <div class="section"> <h2>Logback project</h2> <dl> - <dt> <a name="why_lgpl">Why is logback distributed under LGPL and - not the Apache Software License?</a> + <dt> + <a name="why_lgpl" href="#why_lgpl">Why is logback distributed + under LGPL and not the Apache Software License?</a> </dt> <dd> @@ -79,22 +80,66 @@ </dd> </dl> </div> + <div class="section"> <h2>Logback-classic</h2> <dl> + +  + + <dt> + <a name="auto_config" href="#auto_config"> + How does the automatic configuration work? + </a> + </dt> + <dd> + <p>This question is answered in the <a + href="manual/joran.html#auto_configuration">relevant + section</a> of the logback manual. + </p> + + </dd> + + <hr/> + +  + + + + <dt> + <a name="logger_serialization" href="#logger_serialization"> + Are logback loggers serializable?</a> + </dt> + <dd> + <p>Yes. A logback logger <em>is</em> an SLF4J logger and SLF4J + loggers are serializable. This means that an object + referencing a logger will be alble to log after its + deserialization. + </p> + + <p>The deserialized logger instance will be generated by + <code>org.slf4j.LoggerFactory</code>. Thus, it is possible + for a logback logger to be deserialized as a log4j or j.u.l. + logger, depending on the deserialization environment.</p> + </dd> + + <hr/> +  + <dt> - <a name="setup_jetty"> - How can I use logback-classic with Jetty ? + <a name="setup_jetty" href="#"> + How can Jetty be instructed to use logback-classic as its + logging implementataion? </a> </dt> + <dd> <p>The Jetty application server uses SLF4J for its internal - logging. Here are the required steps to install logback as - SLF4J's underlaying implementation. + logging. </p> - <p>A few jars must be present in the <em>JETTY_HOME/lib</em> - directory. + <p>The following jar files must be present in the + <em>JETTY_HOME/lib</em> directory. </p> <p>Logback-classic is based on the SLF4J api. Therefore, the @@ -109,117 +154,21 @@ <p> To configure logback-classic, a file called <em>logback.xml</em> should be placed in the - <em>JETTY_HOME/resources</em> directory. You can find - configuration samples in the - <em>examples/src/chapter4/conf/</em> directory, in the - distribution of logback. + <em>JETTY_HOME/resources</em> directory. You can find sample + configuration files in the + <em>logback-examples/src/main/java/chapter4/conf/</em> folder + shipping within the logback distribution. </p> - <table border="0"> - <tr> - <td align="right"> - <a href="#top">[top]</a> - </td> - </tr> - </table> - <hr /> - </dd> - <dt> - <a name="auto_config"> - How does the automatic configuration work? - </a> - </dt> - <dd> - <p>This question is answered in the <a - href="manual/joran.html#auto_configuration">relevant - section</a> of the logback manual. - </p> - <table border="0"> - <tr> - <td align="right"> - <a href="#top">[top]</a> - </td> - </tr> - </table> - <hr /> - </dd> - <dt> - <a name="intercept_calls_tomcat"> - How can I intercept JCL calls in Tomcat? - </a> - </dt> - <dd> - <p>When a dependency of your webapp logs using Jakarta Commons - Logging (for example Struts), you can intercept these calls - and redirect them to logback. - </p> - <p>This can be done by using <em>jcl104-over-slf4j.jar</em> , - a module that is shipped with <a - href="http://www.slf4j.org">SLF4J</a> . - </p> - <p>If you have only one webapp, its <em>WEB-INF/lib</em> - directory should already contain the logback jars, namely - <em>logback-core-VERSION.jar</em> , - <em>logback-classic-VERSION.jar</em> and - <em>slf4j-api-VERSION.jar</em> . A logback configuration file, - named <em>logback.xml</em> should be placed in the - <em>WEB-INF/classes/</em> directory. - </p> - <p>You now need to add <code>jcl104-over-slf4j.jar</code> to - your <em>WEB-INF/lib</em> directory and remove - <code>commons-logging-1.0.4.jar</code> . The logging that used - to be directed to JCL should now be handled by logback. - </p> - - <p>In case several webapps share the logback jars, you might - place the previously mentionned jars in the - <em>common/lib/</em> directory of your Tomcat - installation. The <em>logback.xml</em> file should then be - placed in <em>common/classes</em> . - </p> - <table border="0"> - <tr> - <td align="right"> - <a href="#top">[top]</a> - </td> - </tr> - </table> - <hr /> - </dd> - <dt> - <a name="intercept_calls_jetty"> - How can I intercept JCL calls in Jetty ? - </a> - </dt> - <dd> - <p>Using logback as the logging implementation of choice for - frameworks depending on JCL can also be done in Jetty. - </p> - <p>In case you have only one webapp, the required steps are - exactly the same as <a href="#intercept_calls_tomcat">those - needed in Tomcat</a>. - </p> - <p>In case several webapps share the logback jars, you might - place the necessary jars in the <em>lib/</em> directory of - your Jetty installation. The <em>logback.xml</em> file should - then be placed in the <em>resources/</em> directory. - </p> - <p>However, due to <a - href="http://docs.codehaus.org/display/JETTY/Classloading"> - Jetty's internal Classloading mechanism</a>, the - <em>logback-classic-VERSION.jar</em> and - <em>slf4j-api-VERSION.jar</em> files should also be placed in - the <em>WEB-INF/lib/</em> directory of your webapps. - </p> - <table border="0"> - <tr> - <td align="right"> - <a href="#top">[top]</a> - </td> - </tr> - </table> </dd> + + <hr /> + + +  </dl> + + </div> </div>

1 0

[JIRA] Issue Comment Edited: (LBCLASSIC-46) ThrowableInformation should keep the Throwable cause hierarchy intact.
by Joern Huxhorn (JIRA) 29 Oct '08

29 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-46?page=com.atlassian.jira.plugin.syste… ] Joern Huxhorn edited comment on LBCLASSIC-46 at 10/29/08 11:06 AM: ------------------------------------------------------------------- After checking a bit of source, I think that this probably isn't exactly comparable to LBCLASSIC-72 :p Concerning ThrowableProxy i'd suggest the following structure: class ThrowableProxy { String throwableClassName; String message; StackTraceElementProxy[] stackTrace; ThrowableProxy cause; transient String stringRep; } The only downside would be that the "... x common frames omitted" message wouldn't be possible anymore. The question is, is it really necessary? I'd also suggest to create the string representation lazily on demand. I guess that we could save quite a big amount of time by lazy creation of string representations (in both ThrowableProxy, StackTraceElementProxy and also in case of LoggingEvent.getFormattedMessage(), see also LBCLASSIC-45 ) when needed instead of, like it is right now, during creation of the logging event itself. It's also leaner in case of serialization. was (Author: jhuxhorn): After checking a bit of source, I think that this probably isn't exactly comparable to LBCLASSIC-72 :p Concerning ThrowableProxy i'd suggest the following structure: class ThrowableProxy { String throwableClassName; String message; StackTraceElementProxy[] stackTrace; ThrowableProxy cause; transient String stringRep; } The only downside would be that the "... x common frames omitted" message wouldn't be possible anymore. The question is, is it really necessary? I'd also suggest to create the string representation lazily on demand. I guess that we could save quite a big amount of time by lazy creation of string representations (in both ThrowableProxy, StackTraceElementProxy and also in case of LoggingEvent.getFormattedMessage()) when needed instead of, like it is right now, during creation of the logging event itself. It's also leaner in case of serialization. > ThrowableInformation should keep the Throwable cause hierarchy intact. > ---------------------------------------------------------------------- > > Key: LBCLASSIC-46 > URL: http://jira.qos.ch/browse/LBCLASSIC-46 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Joern Huxhorn > Assignee: Logback dev list > Priority: Minor > > Instead of a String representation of the whole Throwable stack trace incl. cause ThrowableInformation should instead look like this: > public class ThrowableInformation implements Serializable > { > String throwableClassName; > String message; > StackTraceElement[] stackTrace; > ThrowableInformation cause; > } > I omitted get/set and private in this example. > StackTraceElement is perfectly Serializable and did also receive a public c'tor in Java 5 so I guess that the current ThrowableInformation is more or less a relict of log4j which had to stay compatible with older Java versions. > You could obviously keep the getThrowableStrRep() method for compatibility. > This bug is somewhat related to LBCLASSIC-45 because I think that ThrowableInformation should also, as LoggingEvent, be just a dumb data container with no real logic. > The logic to extract the relevant StackTraceElements should IMHO be moved either into Logger or into a static factory method of ThrowableInformation. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0