October 2008 - logback-dev - mailman3.qos.ch

svn commit: r1905 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/util
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 17:26:43 2008 New Revision: 1905 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/util/InitializationTest.java Log: - removing the "test" prefix from test methods. These are not needed for Junit4. - added copyright notice Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/util/InitializationTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/util/InitializationTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/util/InitializationTest.java Wed Oct 29 17:26:43 2008 @@ -1,3 +1,12 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2008, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ package ch.qos.logback.classic.util; @@ -45,7 +54,7 @@ // this test works only if logback-test.xml or logback.xml files are on the classpath. // However, this is something we try to avoid in order to simplify the life // of users trying to follows the manual and logback-examples from an IDE - public void testAutoconfig() { + public void atoconfig() { Appender appender = root.getAppender("STDOUT"); assertNotNull(appender); assertTrue(appender instanceof ConsoleAppender); @@ -56,7 +65,7 @@ // this test works only if logback-test.xml or logback.xml files are on the classpath. // However, this is something we try to avoid in order to simplify the life // of users trying to follows the manual and logback-examples from an IDE - public void testReset() throws JoranException { + public void reset() throws JoranException { { new ContextInitializer(lc).autoConfig(); Appender appender = root.getAppender("STDOUT"); @@ -71,7 +80,7 @@ } @Test - public void testAutoConfigFromSystemProperties() throws JoranException { + public void autoConfigFromSystemProperties() throws JoranException { doAutoConfigFromSystemProperties(TeztConstants.TEST_DIR_PREFIX + "input/autoConfig.xml"); doAutoConfigFromSystemProperties("autoConfigAsResource.xml"); // test passing a URL. note the relative path syntax with file:src/test/... @@ -87,7 +96,7 @@ } @Test - public void teztAutoStatusListener() throws JoranException { + public void autoStatusListener() throws JoranException { System.setProperty(ContextInitializer.STATUS_LISTENER_CLASS, TrivialStatusListener.class.getName()); List<StatusListener> sll = lc.getStatusManager().getCopyOfStatusListenerList(); assertEquals(0, sll.size()); @@ -97,7 +106,7 @@ } @Test - public void teztAutoOnConsoleStatusListener() throws JoranException { + public void autoOnConsoleStatusListener() throws JoranException { System.setProperty(ContextInitializer.STATUS_LISTENER_CLASS, ContextInitializer.SYSOUT); List<StatusListener> sll = lc.getStatusManager().getCopyOfStatusListenerList(); assertEquals(0, sll.size());

1 0

[JIRA] Resolved: (LBCLASSIC-51) Use of BasicStatusManager.iterator() without synchronization in ch.qos.logback.classic.jmx.Configurator
by Ceki Gulcu (JIRA) 29 Oct '08

29 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-51?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu resolved LBCLASSIC-51. --------------------------------- Fix Version/s: 0.9.10 Resolution: Fixed > Use of BasicStatusManager.iterator() without synchronization in ch.qos.logback.classic.jmx.Configurator > ------------------------------------------------------------------------------------------------------- > > Key: LBCLASSIC-51 > URL: http://jira.qos.ch/browse/LBCLASSIC-51 > Project: logback-classic > Issue Type: Bug > Components: Other > Affects Versions: unspecified > Environment: Operating System: Windows > Platform: PC > Reporter: Joern Huxhorn > Assignee: Ceki Gulcu > Fix For: 0.9.10 > > > We sometimes receive strange exceptions in our webapp: > [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: Exception in thread "Thread-6" java.lang.ArrayIndexOutOfBoundsException > [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: at java.lang.System.arraycopy(Native Method) > [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: at java.util.ArrayList.ensureCapacity(ArrayList.java:170) > [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: at java.util.ArrayList.add(ArrayList.java:351) > [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: at ch.qos.logback.core.BasicStatusManager.add(BasicStatusManager.java:38) > [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: at ch.qos.logback.core.spi.ContextAwareBase.addStatus(ContextAwareBase.java:59) > [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: at ch.qos.logback.core.spi.ContextAwareBase.addInfo(ContextAwareBase.java:64) > I just tried to analyze the problem and found out that ch.qos.logback.classic.jmx.Configurator is simply using the iterator of the status manager without synchronizing, as it's documented in BasicStatusManager. > So instead of > public List<String> getStatuses() { > List<String> list = new ArrayList<String>(); > Iterator<Status> it = context.getStatusManager().iterator(); > while(it.hasNext()) { > list.add(it.next().toString()); > } > return list; > } > it should probably be > public List<String> getStatuses() { > List<String> list = new ArrayList<String>(); > StatusManager sm = context.getStatusManager(); > Iterator<Status> it = sm.iterator(); > synchronized(sm) { > while(it.hasNext()) { > list.add(it.next().toString()); > } > } > return list; > } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Issue Comment Edited: (LBCLASSIC-57) SyslogAppender fails sporadically
by Ceki Gulcu (JIRA) 29 Oct '08

29 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-57?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu edited comment on LBCLASSIC-57 at 10/29/08 4:57 PM: --------------------------------------------------------------- Hello Anton, Would setting a hard (non-configurable) limit of say 250KB work for you? BTW, thank you for taking the time to find the root cause of the problem. was (Author: noreply.ceki(a)qos.ch) Hello Anton, Would setting a hard (non-configurable) limit of say 250KB work for you? > SyslogAppender fails sporadically > --------------------------------- > > Key: LBCLASSIC-57 > URL: http://jira.qos.ch/browse/LBCLASSIC-57 > Project: logback-classic > Issue Type: Bug > Environment: $ uname -a > Linux ... 2.6.9-67.ELsmp #1 SMP Wed Nov 7 13:56:44 EST 2007 x86_64 x86_64 x86_64 GNU/Linux > $ java -version > java version "1.6.0_03" > Java(TM) SE Runtime Environment (build 1.6.0_03-b05) > Java HotSpot(TM) Server VM (build 1.6.0_03-b05, mixed mode) > multiprocessor PC box > Reporter: Anton Tagunov > Assignee: Logback dev list > > * several JVM-s per Linux box > * 5 SyslogAppender-s logging to syslog-ng on 127.0.0.1 > Once in a while one of the SyslogAppender-s (the busiest one with longest messages) stops logging completely > Other SyslogAppender-ss continue working fine. > /usr/sbin/tcpdump has confirmed upd packets reach > syslog-ng port via 'lo' network interface for remaining appends > /usr/sbin/tcpdump has confirmed NO udp packets reach > syslog-ng port via 'lo' network interface for the failing appender > We have JMX enabled. JConsole does show StatusManager messages. > There are no error messages there. > Just the messages emitted during initial logback configuration > from logback.xml on the classpath. > We had invoked 'reload()' method via JMX. > StatusMananger messages observed via JMX show that reload had happened. > Full re-configuration had happened. > All 5 SyslogAppenders had been apparently re-created. > Yet NO udp messages had come from the SyslogAppender > replacing those which had previously failed. > Reloading did not help at all. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r1904 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 16:59:16 2008 New Revision: 1904 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SyslogAppenderBase.java Log: LBCLASSIC-57 Setting a message size limit of 256K. Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SyslogAppenderBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SyslogAppenderBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SyslogAppenderBase.java Wed Oct 29 16:59:16 2008 @@ -28,6 +28,7 @@ public abstract class SyslogAppenderBase<E> extends AppenderBase<E> { final static String SYSLOG_LAYOUT_URL = CoreGlobal.CODES_URL + "#syslog_layout"; + final static int MSG_SIZE_LIMIT = 256*1024; Layout<E> layout; int facility; @@ -77,6 +78,9 @@ try { String msg = layout.doLayout(eventObject); + if(msg != null && msg.length() > MSG_SIZE_LIMIT) { + msg = msg.substring(0, MSG_SIZE_LIMIT); + } sw.write(msg); sw.flush(); postProcess(eventObject, sw);

1 0

[JIRA] Commented: (LBCLASSIC-57) SyslogAppender fails sporadically
by Ceki Gulcu (JIRA) 29 Oct '08

29 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-57?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu commented on LBCLASSIC-57: ------------------------------------- Hello Anton, Would setting a hard (non-configurable) limit of say 250KB work for you? > SyslogAppender fails sporadically > --------------------------------- > > Key: LBCLASSIC-57 > URL: http://jira.qos.ch/browse/LBCLASSIC-57 > Project: logback-classic > Issue Type: Bug > Environment: $ uname -a > Linux ... 2.6.9-67.ELsmp #1 SMP Wed Nov 7 13:56:44 EST 2007 x86_64 x86_64 x86_64 GNU/Linux > $ java -version > java version "1.6.0_03" > Java(TM) SE Runtime Environment (build 1.6.0_03-b05) > Java HotSpot(TM) Server VM (build 1.6.0_03-b05, mixed mode) > multiprocessor PC box > Reporter: Anton Tagunov > Assignee: Logback dev list > > * several JVM-s per Linux box > * 5 SyslogAppender-s logging to syslog-ng on 127.0.0.1 > Once in a while one of the SyslogAppender-s (the busiest one with longest messages) stops logging completely > Other SyslogAppender-ss continue working fine. > /usr/sbin/tcpdump has confirmed upd packets reach > syslog-ng port via 'lo' network interface for remaining appends > /usr/sbin/tcpdump has confirmed NO udp packets reach > syslog-ng port via 'lo' network interface for the failing appender > We have JMX enabled. JConsole does show StatusManager messages. > There are no error messages there. > Just the messages emitted during initial logback configuration > from logback.xml on the classpath. > We had invoked 'reload()' method via JMX. > StatusMananger messages observed via JMX show that reload had happened. > Full re-configuration had happened. > All 5 SyslogAppenders had been apparently re-created. > Yet NO udp messages had come from the SyslogAppender > replacing those which had previously failed. > Reloading did not help at all. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Created: (LBCLASSIC-69) LevelToSyslogSeverity mistreating TRACE level
by Anton Tagunov (JIRA) 29 Oct '08

29 Oct '08

LevelToSyslogSeverity mistreating TRACE level --------------------------------------------- Key: LBCLASSIC-69 URL: http://jira.qos.ch/browse/LBCLASSIC-69 Project: logback-classic Issue Type: Bug Components: layout Affects Versions: 0.9.10 Reporter: Anton Tagunov Assignee: Logback dev list Hello, ch.qos.logback.classic.util.LevelToSyslogSeverity.convert() doesn't have a case for TRACE level. The result is this exception: This results in the following exception java.lang.IllegalArgumentException: Level TRACE is not a valid level for a printing method at ch.qos.logback.classic.util.LevelToSyslogSeverity.convert(LevelToSyslogSeverity.java:38) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 1

svn commit: r1903 - in logback/trunk/logback-classic/src: main/java/ch/qos/logback/classic/util test/java/ch/qos/logback/classic test/java/ch/qos/logback/classic/util
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 16:08:53 2008 New Revision: 1903 Added: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/util/LevelToSyslogSeverityTest.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/util/PackageTest.java Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/util/LevelToSyslogSeverity.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/AllClassicTest.java Log: LBCLASSIC-69 LevelToSyslogSeverity.convert method did not cover the TRACE level. Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/util/LevelToSyslogSeverity.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/util/LevelToSyslogSeverity.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/util/LevelToSyslogSeverity.java Wed Oct 29 16:08:53 2008 @@ -17,8 +17,8 @@ public class LevelToSyslogSeverity { /* - * Convert a level to equivalent syslog severity. Only levels for printing methods - * i.e DEBUG, WARN, INFO and ERROR are converted. + * Convert a level to equivalent syslog severity. Only levels for printing + * methods i.e TRACE, DEBUG, WARN, INFO and ERROR are converted. * */ static public int convert(LoggingEvent event) { @@ -34,6 +34,8 @@ return SyslogConstants.INFO_SEVERITY; case Level.DEBUG_INT: return SyslogConstants.DEBUG_SEVERITY; + case Level.TRACE_INT: + return SyslogConstants.DEBUG_SEVERITY; default: throw new IllegalArgumentException("Level " + level + " is not a valid level for a printing method"); Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/AllClassicTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/AllClassicTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/AllClassicTest.java Wed Oct 29 16:08:53 2008 @@ -20,6 +20,7 @@ suite.addTest(org.slf4j.impl.PackageTest.suite()); suite.addTest(ch.qos.logback.classic.PackageTest.suite()); + suite.addTest(ch.qos.logback.classic.util.PackageTest.suite()); suite.addTest(ch.qos.logback.classic.control.PackageTest.suite()); suite.addTest(ch.qos.logback.classic.joran.PackageTest.suite()); suite.addTest(ch.qos.logback.classic.boolex.PackageTest.suite()); Added: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/util/LevelToSyslogSeverityTest.java ============================================================================== --- (empty file) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/util/LevelToSyslogSeverityTest.java Wed Oct 29 16:08:53 2008 @@ -0,0 +1,39 @@ +package ch.qos.logback.classic.util; + +import static org.junit.Assert.*; + +import org.junit.Test; + +import ch.qos.logback.classic.Level; +import ch.qos.logback.classic.spi.LoggingEvent; +import ch.qos.logback.core.net.SyslogConstants; + +public class LevelToSyslogSeverityTest { + + @Test + public void smoke() { + + assertEquals(SyslogConstants.DEBUG_SEVERITY, LevelToSyslogSeverity + .convert(createEventOfLevel(Level.TRACE))); + + assertEquals(SyslogConstants.DEBUG_SEVERITY, LevelToSyslogSeverity + .convert(createEventOfLevel(Level.DEBUG))); + + assertEquals(SyslogConstants.INFO_SEVERITY, LevelToSyslogSeverity + .convert(createEventOfLevel(Level.INFO))); + + assertEquals(SyslogConstants.WARNING_SEVERITY, LevelToSyslogSeverity + .convert(createEventOfLevel(Level.WARN))); + + assertEquals(SyslogConstants.ERROR_SEVERITY, LevelToSyslogSeverity + .convert(createEventOfLevel(Level.ERROR))); + + } + + LoggingEvent createEventOfLevel(Level level) { + LoggingEvent event = new LoggingEvent(); + event.setLevel(level); + return event; + } + +} Added: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/util/PackageTest.java ============================================================================== --- (empty file) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/util/PackageTest.java Wed Oct 29 16:08:53 2008 @@ -0,0 +1,26 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 1999-2006, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ +package ch.qos.logback.classic.util; + + +import junit.framework.JUnit4TestAdapter; +import junit.framework.Test; +import junit.framework.TestCase; +import junit.framework.TestSuite; + +public class PackageTest extends TestCase { + + public static Test suite() { + TestSuite suite = new TestSuite(); + suite.addTest(new JUnit4TestAdapter(InitializationTest.class)); + suite.addTest(new JUnit4TestAdapter(LevelToSyslogSeverityTest.class)); + return suite; + } +} \ No newline at end of file

1 0

[JIRA] Created: (LBCLASSIC-70) Let the LogbackMDCAdapter exhibit a full copy on write semantics
by Szel Zoltan (JIRA) 29 Oct '08

29 Oct '08

Let the LogbackMDCAdapter exhibit a full copy on write semantics ---------------------------------------------------------------- Key: LBCLASSIC-70 URL: http://jira.qos.ch/browse/LBCLASSIC-70 Project: logback-classic Issue Type: Improvement Components: Other Affects Versions: 0.9.9, 0.9.10 Reporter: Szel Zoltan Assignee: Logback dev list Hi, I have implemented an async appender and i was very happy seeing that most of the methods of the MDCAdapter exhibits copy on write semantics. This is very handy in this scenerio, it helps to transfer the MDC map onto the background thread. But i have noticed, that the clear and setContextMap methods are breaking this semantics. Is there any chance in the next release to change the implementation of the clear and setContextMap to conform with cow? Thanks very much. P.S.: We are waiting for legal approval to contribute our appender implementation back to the community. Best Regards, Zoltan Szel -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 4

[JIRA] Created: (LBCLASSIC-71) Failed tests: lateServerLaunch(ch.qos.logback.classic.net.SocketAppenderTest) in r1815
by Joern Huxhorn (JIRA) 29 Oct '08

29 Oct '08

Failed tests: lateServerLaunch(ch.qos.logback.classic.net.SocketAppenderTest) in r1815 -------------------------------------------------------------------------------------- Key: LBCLASSIC-71 URL: http://jira.qos.ch/browse/LBCLASSIC-71 Project: logback-classic Issue Type: Bug Environment: java version "1.6.0_07" Java(TM) SE Runtime Environment (build 1.6.0_07-b06) Java HotSpot(TM) Client VM (build 10.0-b23, mixed mode, sharing) Maven version: 2.0.9 Java version: 1.6.0_07 OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows" Reporter: Joern Huxhorn Assignee: Logback dev list This test keeps failing on my system: java.lang.AssertionError: expected:<1> but was:<0> [..] at ch.qos.logback.classic.net.SocketAppenderTest.lateServerLaunch(SocketAppenderTest.java:195) Any idea why? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 7

svn commit: r1902 - in logback/trunk/logback-access/src/test/java/ch/qos/logback/access: jetty testUtil
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 15:12:39 2008 New Revision: 1902 Added: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/testUtil/ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/testUtil/NotifyingListAppender.java Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyFixture.java Log: reduce the probability of JettyBasicTest failing Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java ============================================================================== --- logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java (original) +++ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java Wed Oct 29 15:12:39 2008 @@ -1,6 +1,7 @@ package ch.qos.logback.access.jetty; -import static org.junit.Assert.*; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; import java.io.OutputStreamWriter; import java.io.PrintWriter; @@ -13,69 +14,76 @@ import ch.qos.logback.access.spi.AccessEvent; import ch.qos.logback.access.spi.Util; -import ch.qos.logback.core.read.ListAppender; +import ch.qos.logback.access.testUtil.NotifyingListAppender; -public class JettyBasicTest { +public class JettyBasicTest { static RequestLogImpl requestLogImpl; static JettyFixture fixture; - + @BeforeClass static public void startServer() throws Exception { - //System.out.println("*** JettyBasicTest.startServer called"); + // System.out.println("*** JettyBasicTest.startServer called"); requestLogImpl = new RequestLogImpl(); JettyFixture fixture = new JettyFixture(requestLogImpl); fixture.start(); } - + @AfterClass - static public void stopServer() throws Exception { - //System.out.println("*** JettyBasicTest.stopServer called"); - if(fixture != null) { + static public void stopServer() throws Exception { + // System.out.println("*** JettyBasicTest.stopServer called"); + if (fixture != null) { fixture.stop(); } } - + @Test - public void teztGetRequest() throws Exception { - URL url = new URL("http://localhost:"+ JettyFixture.PORT + "/"); + public void getRequest() throws Exception { + URL url = new URL("http://localhost:" + JettyFixture.PORT + "/"); HttpURLConnection connection = (HttpURLConnection) url.openConnection(); connection.setDoInput(true); String result = Util.readToString(connection.getInputStream()); - assertEquals("hello world", result); + assertEquals("hello world", result); - ListAppender appender = (ListAppender) requestLogImpl.getAppender("list"); - appender.list.clear(); + NotifyingListAppender listAppender = (NotifyingListAppender) requestLogImpl + .getAppender("list"); + listAppender.list.clear(); } @Test - public void teztEventGoesToAppenders() throws Exception { - URL url = new URL("http://localhost:"+ JettyFixture.PORT + "/"); + public void eventGoesToAppenders() throws Exception { + URL url = new URL("http://localhost:" + JettyFixture.PORT + "/"); HttpURLConnection connection = (HttpURLConnection) url.openConnection(); connection.setDoInput(true); String result = Util.readToString(connection.getInputStream()); assertEquals("hello world", result); - //Thread.sleep(100); - ListAppender appender = (ListAppender) requestLogImpl.getAppender("list"); - assertTrue(appender.list.size()>0); - AccessEvent event = (AccessEvent) appender.list.get(0); + + NotifyingListAppender listAppender = (NotifyingListAppender) requestLogImpl + .getAppender("list"); + synchronized (listAppender) { + listAppender.wait(100); + } + + assertTrue(listAppender.list.size() > 0); + AccessEvent event = (AccessEvent) listAppender.list.get(0); assertEquals("127.0.0.1", event.getRemoteHost()); assertEquals("localhost", event.getServerName()); - appender.list.clear(); + listAppender.list.clear(); } @Test - public void teztPostContentConverter() throws Exception { - //System.out.println("into test"); - URL url = new URL("http://localhost:"+ JettyFixture.PORT + "/"); + public void postContentConverter() throws Exception { + // System.out.println("into test"); + URL url = new URL("http://localhost:" + JettyFixture.PORT + "/"); String msg = "test message"; - + HttpURLConnection connection = (HttpURLConnection) url.openConnection(); - //this line is necessary to make the stream aware of when the message is over. + // this line is necessary to make the stream aware of when the message is + // over. connection.setFixedLengthStreamingMode(msg.getBytes().length); ((HttpURLConnection) connection).setRequestMethod("POST"); connection.setDoOutput(true); @@ -83,7 +91,6 @@ connection.setUseCaches(false); connection.setRequestProperty("Content-Type", "text/plain"); - PrintWriter output = new PrintWriter(new OutputStreamWriter(connection .getOutputStream())); output.print(msg); @@ -92,12 +99,16 @@ // StatusPrinter.print(requestLogImpl.getStatusManager()); - ListAppender listAppender = (ListAppender) requestLogImpl + NotifyingListAppender listAppender = (NotifyingListAppender) requestLogImpl .getAppender("list"); - Thread.sleep(100); + + synchronized (listAppender) { + listAppender.wait(100); + } + @SuppressWarnings("unused") AccessEvent event = (AccessEvent) listAppender.list.get(0); - + // we should test the contents of the requests // assertEquals(msg, event.getRequestContent()); } Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyFixture.java ============================================================================== --- logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyFixture.java (original) +++ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyFixture.java Wed Oct 29 15:12:39 2008 @@ -20,8 +20,8 @@ import ch.qos.logback.access.PatternLayout; import ch.qos.logback.access.spi.AccessEvent; +import ch.qos.logback.access.testUtil.NotifyingListAppender; import ch.qos.logback.core.ConsoleAppender; -import ch.qos.logback.core.read.ListAppender; public class JettyFixture { RequestLogImpl requestLogImpl; @@ -76,7 +76,7 @@ private void buildContext() { - ListAppender<AccessEvent> appender = new ListAppender<AccessEvent>(); + NotifyingListAppender appender = new NotifyingListAppender(); appender.setContext(requestLogImpl); appender.setName("list"); appender.start(); Added: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/testUtil/NotifyingListAppender.java ============================================================================== --- (empty file) +++ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/testUtil/NotifyingListAppender.java Wed Oct 29 15:12:39 2008 @@ -0,0 +1,28 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2008, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ +package ch.qos.logback.access.testUtil; + +import java.util.ArrayList; +import java.util.List; + +import ch.qos.logback.access.spi.AccessEvent; +import ch.qos.logback.core.AppenderBase; + +public class NotifyingListAppender extends AppenderBase<AccessEvent> { + + public List<AccessEvent> list = new ArrayList<AccessEvent>(); + + protected void append(AccessEvent e) { + list.add(e); + synchronized (this) { + this.notify(); + } + } +}

1 0