November 2008 - logback-dev

[JIRA] Created: (LBSITE-19) name-attribute is *not* mentioned in your CounterBasedEvaluator example
by Ceki Gulcu (JIRA) 27 Dec '08

27 Dec '08

name-attribute is *not* mentioned in your CounterBasedEvaluator example ----------------------------------------------------------------------- Key: LBSITE-19 URL: http://jira.qos.ch/browse/LBSITE-19 Project: logback-site Issue Type: Bug Affects Versions: 0.9.9 Reporter: Ceki Gulcu Assignee: Ceki Gulcu Fix For: 0.9.10 See http://www.qos.ch/pipermail/logback-user/2008-October/000661.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 4

[JIRA] Created: (LBCLASSIC-81) Deadlock while configuring at runtime and requesting a new logger
by Holger Mense (JIRA) 05 Dec '08

05 Dec '08

Deadlock while configuring at runtime and requesting a new logger ----------------------------------------------------------------- Key: LBCLASSIC-81 URL: http://jira.qos.ch/browse/LBCLASSIC-81 Project: logback-classic Issue Type: Bug Components: joran Affects Versions: 0.9.11 Environment: Windows XP Sun JDK 1.5.0_15 Logback 0.9.11 Reporter: Holger Mense Assignee: Logback dev list Priority: Critical In a multithreaded environment a request of a logger instance can led to a deadlock, when another thread tries to apply a new configuration. In GenericConfigurator.doConfigure(InputSource):97 a lock is set on a Context instance. Then the new configuration will be applied. During this, a lock on the logger is required. When now a new logger instance is requested by LoggerFactory, LoggerContext.getLogger(String) is called. The operation sets a lock on the root logger to create a new child logger. At the end the method LoggerContext.incSize() is called to increase the number of entries in the loggerCache. This method is declared as "synchronized" and needs a lock on LoggerContext. Requesting a new logger instance while starting a reconfiguration of logback leds to a deadlock. LoggerContext.incSize() waits for a lock of the context (which is locked by GenericConfigurator), while waiting for lock of logger in Logger.setLevel() - which is locked by LoggerContext. For further information, see the thread dump: ManagedService Update Queue@5, priority=5, in group 'main', status: 'MONITOR' blocks Start Level Event Dispatcher@6 waiting for Start Level Event Dispatcher@6 at ch.qos.logback.classic.Logger.setLevel(Logger.java:188) at ch.qos.logback.classic.joran.action.LoggerAction.begin(LoggerAction.java:63) at ch.qos.logback.core.joran.spi.Interpreter.callBeginAction(Interpreter.java:262) at ch.qos.logback.core.joran.spi.Interpreter.startElement(Interpreter.java:136) at ch.qos.logback.core.joran.spi.Interpreter.startElement(Interpreter.java:118) at ch.qos.logback.core.joran.spi.EventPlayer.play(EventPlayer.java:36) at ch.qos.logback.core.joran.spi.Interpreter.play(Interpreter.java:321) at ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:98) at ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:74) at ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:55) at ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:48) Start Level Event Dispatcher@6 daemon, priority=5, in group 'main', status: 'MONITOR' blocks ManagedService Update Queue@5 waiting for ManagedService Update Queue@5 at ch.qos.logback.classic.LoggerContext.incSize(LoggerContext.java:153) at ch.qos.logback.classic.LoggerContext.getLogger(LoggerContext.java:142) at ch.qos.logback.classic.LoggerContext.getLogger(LoggerContext.java:46) at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:161) at org.slf4j.bridge.SLF4JBridgeHandler.getSLF4JLogger(SLF4JBridgeHandler.java:149) at org.slf4j.bridge.SLF4JBridgeHandler.publish(SLF4JBridgeHandler.java:234) at java.util.logging.Logger.log(Logger.java:452) at java.util.logging.Logger.doLog(Logger.java:474) at java.util.logging.Logger.log(Logger.java:497) at java.util.logging.Logger.info(Logger.java:1.016) A quick fix is to set a lock on the LoggerContext in LoggerContext.getLogger(String). I am not sure, if this is the best solution, but it seems to work. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

[JIRA] Created: (LBCORE-70) Compressing log files does not work correctly
by Alain Oberdörfer (JIRA) 05 Dec '08

05 Dec '08

Compressing log files does not work correctly --------------------------------------------- Key: LBCORE-70 URL: http://jira.qos.ch/browse/LBCORE-70 Project: logback-core Issue Type: Bug Components: Rolling Affects Versions: 0.9.11 Environment: JVM 1.6.10 Windows 2003 Server GigaSpaces 6.0 Reporter: Alain Oberdörfer Assignee: Logback dev list In our environment compressing log files does not work correctly. As example here is the logger configuration: <appender name="rdf-api-debug-file-appender" class="ch.qos.logback.core.rolling.RollingFileAppender"> <append>true</append> <filter class="ch.qos.logback.classic.filter.ThresholdFilter"> <level>debug</level> </filter> <rollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy"> <fileNamePattern>D:/Temp/rdf-files/logs/%d{yyyy-MM-dd}/debug/rdf-api-debug.log.gz</fileNamePattern> </rollingPolicy> <layout class="ch.qos.logback.classic.PatternLayout"> <pattern>%date,%-5level,%logger,%thread,%message%n</pattern> </layout> </appender> At Nov, 5th I see a directory "D:/Temp/rdf-files/logs/2008-11-04/debug" with the following files (and time of last modifucation): rdf-api-debug.log, November 05, 2008, 12:12:26 AM rdf-api-debug.log855980476945031.tmp, November 05, 2008, 12:11:52 AM rdf-api-debug.log856014875320881.tmp, November 05, 2008, 12:12:26 AM rdf-api-debug.log.gz, November 05, 2008, 12:11:53 AM The first three files and the log file in the .gz-archive have all the same size. So compression works, but the original log file and the temporary files are not deleted. Our application uses several threads, perhaps this causes the problem. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 5

[JIRA] Created: (LBCLASSIC-73) LevelFilter should not match exact filter, but greaterOrEqual
by Bruno Navert (JIRA) 03 Dec '08

03 Dec '08

LevelFilter should not match exact filter, but greaterOrEqual ------------------------------------------------------------- Key: LBCLASSIC-73 URL: http://jira.qos.ch/browse/LBCLASSIC-73 Project: logback-classic Issue Type: Improvement Components: appender Affects Versions: 0.9.9 Reporter: Bruno Navert Assignee: Logback dev list Priority: Minor LevelFilter currently matches EXACT level, it would be useful to match on greaterOrEqual instead. This would allow setting filter to DEBUG for instance, and it would allow INFO,ERROR etc through -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 3

[JIRA] Created: (LBCORE-67) Unsecure usage of locks in AppenderAttachableImpl
by Joern Huxhorn (JIRA) 03 Dec '08

03 Dec '08

Unsecure usage of locks in AppenderAttachableImpl ------------------------------------------------- Key: LBCORE-67 URL: http://jira.qos.ch/browse/LBCORE-67 Project: logback-core Issue Type: Bug Components: Appender Affects Versions: 0.9.10 Reporter: Joern Huxhorn Assignee: Logback dev list Attachments: LockPatch.patch The unlock of a lock should, I would even say "must", always be done in a finally block. Otherwise really bad things (deadlock) can happen if an exception is thrown. See http://java.sun.com/j2se/1.5.0/docs/api/java/util/concurrent/locks/Lock.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

3 11

[JIRA] Created: (LBGENERAL-22) problem converting log4j.properties file
by Ceki Gulcu (JIRA) 02 Dec '08

02 Dec '08

problem converting log4j.properties file ---------------------------------------- Key: LBGENERAL-22 URL: http://jira.qos.ch/browse/LBGENERAL-22 Project: logback-general Issue Type: Bug Reporter: Ceki Gulcu Assignee: Logback dev list Rob Ross wrote: I have a few comments for you. First, the log4j properties translator ( http://logback.qos.ch/translator/Welcome.do ) does not quite work. Maybe it's based on an old version and is now out of date, but you should think about updating it. The file it produced did not translate my properties that I used in log4j.properties to specify the log file path into the equivalent substitutionProperty elements, and it did not translate the Levels I had set on the log4j appenders. It did wrap them in Threshold elements, but the current XML schema wants these specified in a "filter" element on the appender. Also, it did not translate the settings for the rolling file appender into the FileNamePattern element. However, the Joran configurator gave me detailed enough Exception messages that it was easy to determine what the problems were and fix them. ref: http://www.qos.ch/pipermail/logback-user/2008-July/000492.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 2

svn commit: r2040 - in logback-incubator/trunk: . logback-as400 logback-as400/src/main/java/foo
by noreply.ravn＠qos.ch 29 Nov '08

29 Nov '08

Author: ravn Date: Sat Nov 29 00:54:26 2008 New Revision: 2040 Modified: logback-incubator/trunk/logback-as400/pom.xml logback-incubator/trunk/logback-as400/src/main/java/foo/Bar.java logback-incubator/trunk/pom.xml Log: got correct jt400 dependency Modified: logback-incubator/trunk/logback-as400/pom.xml ============================================================================== --- logback-incubator/trunk/logback-as400/pom.xml (original) +++ logback-incubator/trunk/logback-as400/pom.xml Sat Nov 29 00:54:26 2008 @@ -11,7 +11,7 @@ <modelVersion>4.0.0</modelVersion> <groupId>ch.qos.logback</groupId> - <artifactId>logback-core</artifactId> + <artifactId>logback-as400</artifactId> <version>${parent.version}</version> <packaging>jar</packaging> <name>Logback AS400 Module</name> @@ -33,9 +33,11 @@ </licenses> <dependencies> - <groupId>net.sf.jt400</groupId> - <artifactId>jt400-full</artifactId> - <version>5.2</version> + <dependency> + <groupId>net.sf.jt400</groupId> + <artifactId>jt400-full</artifactId> + <version>5.0</version> + </dependency> </dependencies> Modified: logback-incubator/trunk/logback-as400/src/main/java/foo/Bar.java ============================================================================== --- logback-incubator/trunk/logback-as400/src/main/java/foo/Bar.java (original) +++ logback-incubator/trunk/logback-as400/src/main/java/foo/Bar.java Sat Nov 29 00:54:26 2008 @@ -1,7 +1,8 @@ package foo; + public class Bar { - public static void main(String[] args) { - System.out.println("Bar: " + java.util.Arrays.asList(args)); - } + public static void main(String[] args) throws Exception { + System.out.println(Class.forName("com.ibm.as400.access.AS400").getCanonicalName()); + } } \ No newline at end of file Modified: logback-incubator/trunk/pom.xml ============================================================================== --- logback-incubator/trunk/pom.xml (original) +++ logback-incubator/trunk/pom.xml Sat Nov 29 00:54:26 2008 @@ -22,12 +22,13 @@ </modules> <dependencies> - <dependency> + </dependencies> <properties>

1 0

svn commit: r2039 - logback-incubator/trunk/logback-as400
by noreply.ravn＠qos.ch 28 Nov '08

28 Nov '08

Author: ravn Date: Sat Nov 29 00:03:38 2008 New Revision: 2039 Added: logback-incubator/trunk/logback-as400/README.txt Modified: logback-incubator/trunk/logback-as400/pom.xml Log: added initial agenda :) Added: logback-incubator/trunk/logback-as400/README.txt ============================================================================== --- (empty file) +++ logback-incubator/trunk/logback-as400/README.txt Sat Nov 29 00:03:38 2008 @@ -0,0 +1,25 @@ +This logback project will eventually contain several AS400 specific +logback appenders. It is currently in the incubator to see if it +grows into a full project. + +Initial plans: + +* QPRINT compatible appender - i.e. one that wraps nicely in the 132 + character width spool file. Will this apply for other prints too? + +* SNDDST variant of SMTPAppender, sending mail natively. + +* Writing to members (a given column) through SequentialFile. + +Additional possibilities open for discussion: + +* Joblog entries + +* PEX event integration. + +* Message handling. + +* Masquerading AS400 stack traces as Java Exceptions. + + +Please email any ideas to ravn(a)runjva.com Modified: logback-incubator/trunk/logback-as400/pom.xml ============================================================================== --- logback-incubator/trunk/logback-as400/pom.xml (original) +++ logback-incubator/trunk/logback-as400/pom.xml Sat Nov 29 00:03:38 2008 @@ -14,7 +14,7 @@ <artifactId>logback-core</artifactId> <version>${parent.version}</version> <packaging>jar</packaging> - <name>Logback Core Module</name> + <name>Logback AS400 Module</name> <url>http://logback.qos.ch</url> <description> @@ -33,6 +33,9 @@ </licenses> <dependencies> + <groupId>net.sf.jt400</groupId> + <artifactId>jt400-full</artifactId> + <version>5.2</version> </dependencies>

1 0

svn commit: r2038 - in logback/trunk/logback-classic/src: main/java/ch/qos/logback/classic/joran/action test/input/joran test/java/ch/qos/logback/classic/joran
by noreply.ceki＠qos.ch 28 Nov '08

28 Nov '08

Author: ceki Date: Fri Nov 28 23:29:14 2008 New Revision: 2038 Added: logback/trunk/logback-classic/src/test/input/joran/loggerLevelByProperty.xml logback/trunk/logback-classic/src/test/input/joran/rootLevelByProperty.xml Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/joran/action/LevelAction.java logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/joran/action/LoggerAction.java logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/joran/action/RootLoggerAction.java logback/trunk/logback-classic/src/test/input/joran/evaluatorFilter.xml logback/trunk/logback-classic/src/test/input/joran/ignore.xml logback/trunk/logback-classic/src/test/input/joran/levelFilter.xml logback/trunk/logback-classic/src/test/input/joran/simpleLevel.xml logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/joran/JoranConfiguratorTest.java Log: - Added support variable substitution for the level attribute in <logger> and <root> elements - relevant test cases Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/joran/action/LevelAction.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/joran/action/LevelAction.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/joran/action/LevelAction.java Fri Nov 28 23:29:14 2008 @@ -42,7 +42,7 @@ String loggerName = l.getName(); - String levelStr = attributes.getValue(ActionConst.VALUE_ATTR); + String levelStr = ec.subst(attributes.getValue(ActionConst.VALUE_ATTR)); //addInfo("Encapsulating logger name is [" + loggerName // + "], level value is [" + levelStr + "]."); Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/joran/action/LoggerAction.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/joran/action/LoggerAction.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/joran/action/LoggerAction.java Fri Nov 28 23:29:14 2008 @@ -50,7 +50,8 @@ logger = loggerContext.getLogger(loggerName); - String levelStr = attributes.getValue(LEVEL_ATTRIBUTE); + String levelStr = ec.subst(attributes.getValue(LEVEL_ATTRIBUTE)); + if (!OptionHelper.isEmpty(levelStr)) { if (ActionConst.INHERITED.equalsIgnoreCase(levelStr) || ActionConst.NULL.equalsIgnoreCase(levelStr)) { Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/joran/action/RootLoggerAction.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/joran/action/RootLoggerAction.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/joran/action/RootLoggerAction.java Fri Nov 28 23:29:14 2008 @@ -1,7 +1,7 @@ /** - * LOGBack: the generic, reliable, fast and flexible logging framework. + * Logback: the generic, reliable, fast and flexible logging framework. * - * Copyright (C) 1999-2006, QOS.ch + * Copyright (C) 2000-2008, QOS.ch * * This library is free software, you can redistribute it and/or modify it under * the terms of the GNU Lesser General Public License as published by the Free @@ -30,7 +30,7 @@ LoggerContext loggerContext = (LoggerContext) this.context; root = loggerContext.getLogger(LoggerContext.ROOT_NAME); - String levelStr = attributes.getValue(ActionConst.LEVEL_ATTRIBUTE); + String levelStr = ec.subst(attributes.getValue(ActionConst.LEVEL_ATTRIBUTE)); if (!OptionHelper.isEmpty(levelStr)) { Level level = Level.toLevel(levelStr); addInfo("Setting level of ROOT logger to " + level); Modified: logback/trunk/logback-classic/src/test/input/joran/evaluatorFilter.xml ============================================================================== --- logback/trunk/logback-classic/src/test/input/joran/evaluatorFilter.xml (original) +++ logback/trunk/logback-classic/src/test/input/joran/evaluatorFilter.xml Fri Nov 28 23:29:14 2008 @@ -13,8 +13,7 @@ </filter> </appender> - <root> - <level value="debug" /> + <root level="debug"> <appender-ref ref="LIST" /> </root> </configuration> \ No newline at end of file Modified: logback/trunk/logback-classic/src/test/input/joran/ignore.xml ============================================================================== --- logback/trunk/logback-classic/src/test/input/joran/ignore.xml (original) +++ logback/trunk/logback-classic/src/test/input/joran/ignore.xml Fri Nov 28 23:29:14 2008 @@ -12,8 +12,7 @@ </layout> </appender> - <root> - <level value="DEBUG" /> + <root level="DEBUG"> <appender-ref ref="CONSOLE" /> </root> Modified: logback/trunk/logback-classic/src/test/input/joran/levelFilter.xml ============================================================================== --- logback/trunk/logback-classic/src/test/input/joran/levelFilter.xml (original) +++ logback/trunk/logback-classic/src/test/input/joran/levelFilter.xml Fri Nov 28 23:29:14 2008 @@ -1,7 +1,6 @@ <configuration> - <appender name="LIST" - class="ch.qos.logback.core.read.ListAppender"> + <appender name="LIST" class="ch.qos.logback.core.read.ListAppender"> <filter class="ch.qos.logback.classic.filter.LevelFilter"> <OnMatch>DENY</OnMatch> @@ -9,8 +8,7 @@ </filter> </appender> - <root> - <level value="debug" /> + <root level="debug"> <appender-ref ref="LIST" /> </root> </configuration> \ No newline at end of file Added: logback/trunk/logback-classic/src/test/input/joran/loggerLevelByProperty.xml ============================================================================== --- (empty file) +++ logback/trunk/logback-classic/src/test/input/joran/loggerLevelByProperty.xml Fri Nov 28 23:29:14 2008 @@ -0,0 +1,14 @@ +<?xml version="1.0" encoding="UTF-8" ?> +<!DOCTYPE configuration> + +<configuration debug="false"> + + <appender name="LIST" class="ch.qos.logback.core.read.ListAppender" /> + + <logger name="ch.qos.logback.classic.joran" level="${logback.level}" /> + + <root level="ERROR"> + <appender-ref ref="LIST" /> + </root> + +</configuration> Added: logback/trunk/logback-classic/src/test/input/joran/rootLevelByProperty.xml ============================================================================== --- (empty file) +++ logback/trunk/logback-classic/src/test/input/joran/rootLevelByProperty.xml Fri Nov 28 23:29:14 2008 @@ -0,0 +1,13 @@ +<?xml version="1.0" encoding="UTF-8" ?> +<!DOCTYPE configuration> + +<configuration debug="false"> + + <appender name="LIST" class="ch.qos.logback.core.read.ListAppender" /> + + <root level="${logback.level}"> + + <appender-ref ref="LIST" /> + </root> + +</configuration> Modified: logback/trunk/logback-classic/src/test/input/joran/simpleLevel.xml ============================================================================== --- logback/trunk/logback-classic/src/test/input/joran/simpleLevel.xml (original) +++ logback/trunk/logback-classic/src/test/input/joran/simpleLevel.xml Fri Nov 28 23:29:14 2008 @@ -3,17 +3,12 @@ <configuration debug="false"> - <appender name="LIST" class="ch.qos.logback.core.read.ListAppender"/> - - - <logger name="ch.qos.logback.classic.joran"> - <level value="INFO" /> - </logger> + <appender name="LIST" class="ch.qos.logback.core.read.ListAppender" /> - <root> - <level value="DEBUG" /> + <logger name="ch.qos.logback.classic.joran" level="INFO" /> + + <root level="DEBUG"> <appender-ref ref="LIST" /> </root> - + </configuration> - \ No newline at end of file Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/joran/JoranConfiguratorTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/joran/JoranConfiguratorTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/joran/JoranConfiguratorTest.java Fri Nov 28 23:29:14 2008 @@ -67,6 +67,36 @@ } @Test + public void testRootLoggerLevelSettingBySystemProperty() throws JoranException { + String propertyName = "logback.level"; + + System.setProperty(propertyName, "INFO"); + configure(TeztConstants.TEST_DIR_PREFIX + "input/joran/rootLevelByProperty.xml"); + StatusPrinter.print(loggerContext); + ListAppender listAppender = (ListAppender) root.getAppender("LIST"); + assertEquals(0, listAppender.list.size()); + String msg = "hello world"; + logger.debug(msg); + assertEquals(0, listAppender.list.size()); + System.clearProperty(propertyName); + } + + @Test + public void testLoggerLevelSettingBySystemProperty() throws JoranException { + String propertyName = "logback.level"; + + System.setProperty(propertyName, "DEBUG"); + configure(TeztConstants.TEST_DIR_PREFIX + "input/joran/loggerLevelByProperty.xml"); + StatusPrinter.print(loggerContext); + ListAppender listAppender = (ListAppender) root.getAppender("LIST"); + assertEquals(0, listAppender.list.size()); + String msg = "hello world"; + logger.debug(msg); + assertEquals(1, listAppender.list.size()); + System.clearProperty(propertyName); + } + + @Test public void testStatusListener() throws JoranException { configure(TeztConstants.TEST_DIR_PREFIX + "input/joran/statusListener.xml");

1 0

svn commit: r2037 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic
by noreply.ceki＠qos.ch 28 Nov '08

28 Nov '08

Author: ceki Date: Fri Nov 28 23:01:27 2008 New Revision: 2037 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java Log: - minor change Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java Fri Nov 28 23:01:27 2008 @@ -20,8 +20,8 @@ import org.slf4j.ILoggerFactory; import org.slf4j.Marker; -import ch.qos.logback.classic.spi.LoggerContextListener; import ch.qos.logback.classic.spi.LoggerComparator; +import ch.qos.logback.classic.spi.LoggerContextListener; import ch.qos.logback.classic.spi.LoggerContextRemoteView; import ch.qos.logback.classic.spi.TurboFilterList; import ch.qos.logback.classic.turbo.TurboFilter; @@ -29,9 +29,9 @@ import ch.qos.logback.core.CoreConstants; import ch.qos.logback.core.spi.FilterReply; import ch.qos.logback.core.spi.LifeCycle; -import ch.qos.logback.core.status.ErrorStatus; import ch.qos.logback.core.status.StatusListener; import ch.qos.logback.core.status.StatusManager; +import ch.qos.logback.core.status.WarnStatus; /** * LoggerContext glues many of the logback-classic components together. In @@ -63,7 +63,6 @@ boolean started = false; - public LoggerContext() { super(); this.loggerCache = new Hashtable<String, Logger>(); @@ -174,7 +173,7 @@ final void noAppenderDefinedWarning(final Logger logger) { if (noAppenderWarning++ == 0) { getStatusManager().add( - new ErrorStatus("No appenders present in context [" + getName() + new WarnStatus("No appenders present in context [" + getName() + "] for logger [" + logger.getName() + "].", logger)); } } @@ -261,15 +260,15 @@ private void resetListenersExceptResetResistant() { List<LoggerContextListener> toRetain = new ArrayList<LoggerContextListener>(); - - for(LoggerContextListener lcl: loggerContextListenerList) { - if(lcl.isResetResistant()) { + + for (LoggerContextListener lcl : loggerContextListenerList) { + if (lcl.isResetResistant()) { toRetain.add(lcl); } } loggerContextListenerList.retainAll(toRetain); } - + private void resetAllListeners() { loggerContextListenerList.clear(); } @@ -295,7 +294,7 @@ listener.onStop(this); } } - + // === end listeners ============================================== public boolean isStarted() { @@ -314,7 +313,7 @@ started = false; } - @Override + @Override public String toString() { return this.getClass().getName() + "[" + getName() + "]"; }

1 0