November 2008 - logback-dev

[JIRA] Commented: (LBCLASSIC-42) Multiple applications sharing the same config file
by Maarten Bosteels (JIRA) 20 Nov '08

20 Nov '08

[ http://jira.qos.ch/browse/LBCLASSIC-42?page=com.atlassian.jira.plugin.syste… ] Maarten Bosteels commented on LBCLASSIC-42: ------------------------------------------- yes it works. public void initLogging() throws JoranException { LoggerContext context = (LoggerContext) LoggerFactory.getILoggerFactory(); context.putProperty("appname", getApplicationName()); JoranConfigurator jc = new JoranConfigurator(); jc.setContext(context); context.shutdownAndReset(); jc.doConfigure("./src/main/resources/logback-settings.xml"); } <appender name="FILE" class="ch.qos.logback.core.FileAppender"> <file>/var/log/${appname}.log</file> <layout class="ch.qos.logback.classic.PatternLayout"> <Pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n</Pattern> </layout> </appender> > Multiple applications sharing the same config file > -------------------------------------------------- > > Key: LBCLASSIC-42 > URL: http://jira.qos.ch/browse/LBCLASSIC-42 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: Windows > Platform: PC > URL: http://marc.info/?t=120308330000003&r=1&w=2 > Reporter: Ceki Gulcu > Assignee: Ceki Gulcu > Priority: Minor > > The idea is to have a number of applications (over 20) to share the same config file so that the log output goes to different files. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r1978 - in logback/trunk/logback-classic/src/test/java/org: dummy slf4j/impl
by noreply.ceki＠qos.ch 18 Nov '08

18 Nov '08

Author: ceki Date: Tue Nov 18 20:42:41 2008 New Revision: 1978 Added: logback/trunk/logback-classic/src/test/java/org/slf4j/impl/RecursiveInitializationTest.java - copied, changed from r1977, /logback/trunk/logback-classic/src/test/java/org/dummy/RecursiveInitializationTest.java logback/trunk/logback-classic/src/test/java/org/slf4j/impl/RecursiveLBAppender.java - copied, changed from r1977, /logback/trunk/logback-classic/src/test/java/org/dummy/RecursiveLBAppender.java Removed: logback/trunk/logback-classic/src/test/java/org/dummy/RecursiveInitializationTest.java logback/trunk/logback-classic/src/test/java/org/dummy/RecursiveLBAppender.java Modified: logback/trunk/logback-classic/src/test/java/org/slf4j/impl/PackageTest.java Log: Moved tests to org.slf4j.impl instead of "dummy" Modified: logback/trunk/logback-classic/src/test/java/org/slf4j/impl/PackageTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/org/slf4j/impl/PackageTest.java (original) +++ logback/trunk/logback-classic/src/test/java/org/slf4j/impl/PackageTest.java Tue Nov 18 20:42:41 2008 @@ -15,6 +15,7 @@ public static Test suite() { TestSuite suite = new TestSuite(); + suite.addTest(new JUnit4TestAdapter(RecursiveInitializationTest.class)); suite.addTest(new JUnit4TestAdapter(LogbackMDCAdapterTest.class)); return suite; } Copied: logback/trunk/logback-classic/src/test/java/org/slf4j/impl/RecursiveInitializationTest.java (from r1977, /logback/trunk/logback-classic/src/test/java/org/dummy/RecursiveInitializationTest.java) ============================================================================== --- /logback/trunk/logback-classic/src/test/java/org/dummy/RecursiveInitializationTest.java (original) +++ logback/trunk/logback-classic/src/test/java/org/slf4j/impl/RecursiveInitializationTest.java Tue Nov 18 20:42:41 2008 @@ -1,4 +1,4 @@ -package org.dummy; +package org.slf4j.impl; import static org.junit.Assert.*; Copied: logback/trunk/logback-classic/src/test/java/org/slf4j/impl/RecursiveLBAppender.java (from r1977, /logback/trunk/logback-classic/src/test/java/org/dummy/RecursiveLBAppender.java) ============================================================================== --- /logback/trunk/logback-classic/src/test/java/org/dummy/RecursiveLBAppender.java (original) +++ logback/trunk/logback-classic/src/test/java/org/slf4j/impl/RecursiveLBAppender.java Tue Nov 18 20:42:41 2008 @@ -7,7 +7,7 @@ * the terms of the GNU Lesser General Public License as published by the Free * Software Foundation. */ -package org.dummy; +package org.slf4j.impl; import java.util.ArrayList; import java.util.List;

1 0

svn commit: r1977 - logback/trunk/logback-classic/src/test/java/org/dummy
by noreply.ceki＠qos.ch 18 Nov '08

18 Nov '08

Author: ceki Date: Tue Nov 18 20:40:42 2008 New Revision: 1977 Added: logback/trunk/logback-classic/src/test/java/org/dummy/RecursiveInitializationTest.java logback/trunk/logback-classic/src/test/java/org/dummy/RecursiveLBAppender.java Modified: logback/trunk/logback-classic/src/test/java/org/dummy/Log4jInvocation.java Log: - adding a very important test checking that initialization of logback can succeed even in presence of recursive calls to LoggerFactory.getLogger (invoked during the initialization of logback). See also http://bugzilla.slf4j.org/show_bug.cgi?id=106 and http://jira.qos.ch/browse/LBCORE-47 This test fails if SLF4J 1.5.5 is used. Related to http://bugzilla.slf4j.org/show_bug.cgi?id=113 and http://jira.qos.ch/browse/LBCORE-51 Modified: logback/trunk/logback-classic/src/test/java/org/dummy/Log4jInvocation.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/org/dummy/Log4jInvocation.java (original) +++ logback/trunk/logback-classic/src/test/java/org/dummy/Log4jInvocation.java Tue Nov 18 20:40:42 2008 @@ -1,3 +1,12 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2008, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ package org.dummy; import static org.junit.Assert.assertEquals; @@ -12,6 +21,12 @@ import ch.qos.logback.classic.PatternLayout; import ch.qos.logback.classic.spi.LoggingEvent; +/** + * Used to test log4j-over-slf4j + * + * @author Ceki Gulcu + * + */ public class Log4jInvocation { static final String HELLO = "Hello"; Added: logback/trunk/logback-classic/src/test/java/org/dummy/RecursiveInitializationTest.java ============================================================================== --- (empty file) +++ logback/trunk/logback-classic/src/test/java/org/dummy/RecursiveInitializationTest.java Tue Nov 18 20:40:42 2008 @@ -0,0 +1,47 @@ +package org.dummy; + +import static org.junit.Assert.*; + +import java.util.Random; + +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import ch.qos.logback.classic.LoggerContext; +import ch.qos.logback.classic.util.ContextInitializer; +import ch.qos.logback.core.status.Status; +import ch.qos.logback.core.status.StatusManager; + +public class RecursiveInitializationTest { + + int diff = new Random().nextInt(); + + @Before + public void setUp() throws Exception { + System.setProperty(ContextInitializer.CONFIG_FILE_PROPERTY, + "recursiveInit.xml"); + } + + @After + public void tearDown() throws Exception { + System.clearProperty(ContextInitializer.CONFIG_FILE_PROPERTY); + } + + @Test + public void recursiveLogbackInitialization() { + Logger logger = LoggerFactory.getLogger("RecursiveInitializationTest" + + diff); + logger.info("RecursiveInitializationTest"); + + LoggerContext loggerContext = (LoggerContext) LoggerFactory + .getILoggerFactory(); + StatusManager sm = loggerContext.getStatusManager(); + + assertEquals("Initialization should proceed without errors:", sm.getLevel(), + Status.INFO); + } + +} Added: logback/trunk/logback-classic/src/test/java/org/dummy/RecursiveLBAppender.java ============================================================================== --- (empty file) +++ logback/trunk/logback-classic/src/test/java/org/dummy/RecursiveLBAppender.java Tue Nov 18 20:40:42 2008 @@ -0,0 +1,53 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2008, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ +package org.dummy; + +import java.util.ArrayList; +import java.util.List; +import java.util.Random; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import ch.qos.logback.classic.PatternLayout; +import ch.qos.logback.classic.spi.LoggingEvent; +import ch.qos.logback.core.AppenderBase; + +public class RecursiveLBAppender extends AppenderBase<LoggingEvent> { + + public List<LoggingEvent> list = new ArrayList<LoggingEvent>(); + public List<String> stringList = new ArrayList<String>(); + + PatternLayout layout; + + public RecursiveLBAppender() { + this(null); + } + + public RecursiveLBAppender(PatternLayout layout) { + this.layout = layout; + } + + @Override + public void start() { + int diff = new Random().nextInt(); + Logger logger = LoggerFactory.getLogger("ResursiveLBAppender"+diff); + logger.info("testing"); + super.start(); + } + + protected void append(LoggingEvent e) { + list.add(e); + if(layout != null) { + String s = layout.doLayout(e); + stringList.add(s); + } + } +}

1 0

Least-effort logging with bytecode modification
by Ramon Nogueira 18 Nov '08

18 Nov '08

Hi At the company I work for we use the same logging pattern almost everywhere, for example: public class SomeClass { private static final Logger log = LoggerFactory.getLogger(SomeClass.class); public void someMethod() { log.debug("A log message"); } } I would like to simplify this to: import static logging.LogApi.*; public class SomeClass { private void someMethod(String someArg) { debug("A log message"); // from static import } } And then have code equivalent to the former generated (preferably at class load time) dynamically. This could save us hundreds of lines of boilerplate code and provide other interesting options like declarative rules regarding the "injected" logger name, perhaps through class/method annotations and pre-calculating the source location information. I thought of implementing this with AspectJ but its probably easier to just use ASM directly for such a simple case. Any ideas/suggestions/precedents? Thanks Ramon

9 22

Logback and Java requirement
by Thorbjørn Ravn Andersen 18 Nov '08

18 Nov '08

Hi Ceki. I just migrated an elderly application using log4j and jcl to logback except logback doesn't run under Java 1.4 (which is what I have on this AS/400). Bummer. I wanted the markers to be able to filter on threads. Oh well. I could not locate anywhere on the logback pages that Java 5 is a hard requirement (but it was mentioned way down in a slf4j page). I'd suggest you add a notice to the download page. (And it appears that http://retrotranslator.sourceforge.net/ works with logback under 1.4, but that stack traces look somewhat strange, I'll look into that later) -- Thorbjørn Ravn Andersen "...plus... Tubular Bells!"

2 4

Logback and Java 5
by Thorbjørn Ravn Andersen 18 Nov '08

18 Nov '08

Hi Ceki. I just migrated an elderly application using log4j and jcl to logback except logback doesn't run under Java 1.4 (which is what I have on this AS/400). Bummer. I wanted the markers to be able to filter on threads. Oh well. I could not locate anywhere on the logback pages that Java 5 is a hard requirement (but it was mentioned way down in a slf4j page). I'd suggest you add a notice to the download page. -- Thorbjørn Ravn Andersen "...plus... Tubular Bells!"

1 0

[JIRA] Created: (LBCORE-73) Add option to make <consolePlugin/> fail silently if no SocketServer is running
by Paul Nyheim (JIRA) 18 Nov '08

18 Nov '08

Add option to make <consolePlugin/> fail silently if no SocketServer is running ------------------------------------------------------------------------------- Key: LBCORE-73 URL: http://jira.qos.ch/browse/LBCORE-73 Project: logback-core Issue Type: Improvement Components: Appender Affects Versions: 0.9.11 Reporter: Paul Nyheim Assignee: Logback dev list Priority: Minor For my JUnit tests, I have configured a logback-test.xml file with only a <consolePlugin/> entry. (debug=false) However, when I run the tests on the build-server, I get the following printed to System.out: 09:02:23,596 |-ERROR in ch.qos.logback.classic.net.SocketAppender[null] - Could not connect to remote logback server at [localhost]. We will try again later. java.net.ConnectException: Connection refused: connect at java.net.ConnectException: Connection refused: connect at at java.net.PlainSocketImpl.socketConnect(Native Method) at at java.net.PlainSocketImpl.doConnect(PlainSocketImpl.java:333) at at java.net.PlainSocketImpl.connectToAddress(PlainSocketImpl.java:195) I realize that this message is part of logbacks internal status, however it would be nice to have the option to disable this message which pollutes the build-log on the build-server. Maybe by specifying an attribute like this: <consolePlugin silent="true"/> where the underlying Socketappender will be silent if it is not able to connect to the host and port. I'll see if I can upload a patch later today. Regards, Paul Nyheim -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 1

[JIRA] Commented: (LBCLASSIC-46) ThrowableInformation should keep the Throwable cause hierarchy intact.
by Joern Huxhorn (JIRA) 17 Nov '08

17 Nov '08

[ http://jira.qos.ch/browse/LBCLASSIC-46?page=com.atlassian.jira.plugin.syste… ] Joern Huxhorn commented on LBCLASSIC-46: ---------------------------------------- Well, you are right about the reconstruction. It's still possible, even though it's more complex than before because of the additional version information. I've implemented the parsing for the previous ThrowableInformation for the case where the setAccessible call on throwable failed due to SecurityException but I wasn't feeling too well about that approach from the beginning. I also lost the "x common frames omitted" feature because of it, just to save some processor cycles :p My main point is that it generates additional heat. Both the creation of the ThrowableProxy and the reparsing on my side will cost some logging time. I'm also a bit wary about future changes. Those are always more time-consuming and error-prone to implement in case of string parsing than with "proper" data objects. I would like to avoid both the performance impact and the instability inherent to the parsing approach, if possible. A ThrowableProxy like class ThrowableProxy { String throwableClassName; String message; StackTraceElementProxy[] stackTrace; ThrowableProxy cause; int omittedFrames; transient String stringRep; } shouldn't mean any more work on your side (probably even a bit less) and would mean quite a bit less for me. The only downside I see right now is that the "cause" ThrowableProxy would also cache it's string representation, meaning it would cost some memory. But this could be prevented by adding a flush() method which nulls the stringRep so ThrowableProxy could call flush() on the contained cause ThrowableProxy after creation of their own stringRep. One of the use cases I have in mind is to optionally only show the top-most and/or the root cause of the exception in the details view of Lilith. Just to show you that I actually have a reason beside the xml structure... :D I really hope you can do me this favor... > ThrowableInformation should keep the Throwable cause hierarchy intact. > ---------------------------------------------------------------------- > > Key: LBCLASSIC-46 > URL: http://jira.qos.ch/browse/LBCLASSIC-46 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Joern Huxhorn > Assignee: Ceki Gulcu > Priority: Minor > > Instead of a String representation of the whole Throwable stack trace incl. cause ThrowableInformation should instead look like this: > public class ThrowableInformation implements Serializable > { > String throwableClassName; > String message; > StackTraceElement[] stackTrace; > ThrowableInformation cause; > } > I omitted get/set and private in this example. > StackTraceElement is perfectly Serializable and did also receive a public c'tor in Java 5 so I guess that the current ThrowableInformation is more or less a relict of log4j which had to stay compatible with older Java versions. > You could obviously keep the getThrowableStrRep() method for compatibility. > This bug is somewhat related to LBCLASSIC-45 because I think that ThrowableInformation should also, as LoggingEvent, be just a dumb data container with no real logic. > The logic to extract the relevant StackTraceElements should IMHO be moved either into Logger or into a static factory method of ThrowableInformation. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Created: (LBSITE-21) Quickstart section on frontpage for new people
by Thorbjoern Ravn Andersen (JIRA) 17 Nov '08

17 Nov '08

Quickstart section on frontpage for new people ---------------------------------------------- Key: LBSITE-21 URL: http://jira.qos.ch/browse/LBSITE-21 Project: logback-site Issue Type: Improvement Components: Documentation Reporter: Thorbjoern Ravn Andersen Assignee: Logback dev list The current frontpage wants to give a lot of information about logback in general. It might be beneficial to a bypassing developer to provide a "Quickstart with Logback" link one of the very first paragraphs on the front page, so that they can get a "what does it take to do this, and what benefit do I get out of it". I suggest that it basically describes how to add a "Start" and "Stop" log message to HelloWorld and briefly list where else logback can send log messages to. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

pending message
by Thorbjørn Ravn Andersen 17 Nov '08

17 Nov '08

Hi Ceki. Sent a message earlier today which apparently got the wrong sender address so it awaits moderator approval. It is about AS/400 specific logback stuff. Could you have a look in the queue? -- Thorbjørn Ravn Andersen "...plus... Tubular Bells!"

1 0