March 2008 - logback-dev - mailman3.qos.ch

[Bug 52] New: Unable to use <onMatch> in logback.xml
by bugzilla-daemon＠pixie.qos.ch 19 Mar '08

19 Mar '08

http://bugzilla.qos.ch/show_bug.cgi?id=52 Summary: Unable to use <onMatch> in logback.xml Product: logback-core Version: unspecified Platform: All OS/Version: All Status: NEW Severity: major Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: kenichi-qos(a)sysart.jp With logback-0.9.2, when logback.xml contains <onMatch> or <onMismatch> tag, the following error occurs: ERROR in ch.qos.logback.core.joran.spi.Interpreter@30ae41 - no applicable action for [onMatch], current pattern is [[configuration][appender][filter][onMatch]] ERROR in ch.qos.logback.core.joran.spi.Interpreter@30ae41 - no applicable action for [onMismatch], current pattern is [[configuration][appender][filter][onMismatch]] Since I can specify neither <onMatch> nor <onMismatch>, I am unable to make use of EvaluatorFilter, which is one of the reasons I'm considering to use logback over log4j. The cause of the problem is the two methods which have been added to ch.qos.logback.core.filter.AbstractMatcherFilter (Revision 1380): http://svn.qos.ch/viewvc/logback/trunk/logback-core/src/main/java/ch/qos/lo… Because the return type of the getter method differs from the parameter type of the setter method, java.beans.PropertyDescriptor for the properties (onMatch and onMismatch) obtained in ch.qos.logback.core.util.PropertySetter contain no writeMethod (null value, confirmed with jdb-1.6), making PropertySetter.canContainComponent return NOT_FOUND. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 3

svn commit: r1651 - in logback/trunk: logback-classic/src/test logback-classic/src/test/input/joran logback-classic/src/test/java/ch/qos/logback/classic logback-classic/src/test/java/ch/qos/logback/classic/joran logback-core/src/main/java/ch/qos/logback/core/joran/spi logback-core/src/main/java/ch/qos/logback/core/spi logback-core/src/main/java/ch/qos/logback/core/util logback-core/src/test/java/ch/qos/logback/core/util
by noreply.ceki＠qos.ch 19 Mar '08

19 Mar '08

Author: ceki Date: Wed Mar 19 21:39:37 2008 New Revision: 1651 Added: logback/trunk/logback-classic/src/test/input/joran/evaluatorFilter.xml logback/trunk/logback-classic/src/test/input/joran/levelFilter.xml logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/joran/JoranConfiguratorTest.java - copied, changed from r1638, /logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/joran/BasicJoranTest.java Removed: logback/trunk/logback-classic/src/test/build.xml logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/joran/BasicJoranTest.java Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/StringListAppender.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/joran/PackageTest.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/spi/Interpreter.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/ContextAwareImpl.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/PropertySetter.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/util/PropertySetterTest.java Log: - added basic test for level and evaluatorFilter - PropertySetter can now deal with *any* enum type, not just FilterReply Added: logback/trunk/logback-classic/src/test/input/joran/evaluatorFilter.xml ============================================================================== --- (empty file) +++ logback/trunk/logback-classic/src/test/input/joran/evaluatorFilter.xml Wed Mar 19 21:39:37 2008 @@ -0,0 +1,20 @@ +<configuration> + + <appender name="LIST" + class="ch.qos.logback.core.read.ListAppender"> + + <filter class="ch.qos.logback.core.filter.EvaluatorFilter"> + <Name>myFilter</Name> + <OnMatch>DENY</OnMatch> + <Evaluator class="ch.qos.logback.classic.boolex.JaninoEventEvaluator"> + <Name>mdcEvaluator</Name> + <Expression>"to be ignored".equals(message)</Expression> + </Evaluator> + </filter> + </appender> + + <root> + <level value="debug" /> + <appender-ref ref="LIST" /> + </root> +</configuration> \ No newline at end of file Added: logback/trunk/logback-classic/src/test/input/joran/levelFilter.xml ============================================================================== --- (empty file) +++ logback/trunk/logback-classic/src/test/input/joran/levelFilter.xml Wed Mar 19 21:39:37 2008 @@ -0,0 +1,16 @@ +<configuration> + + <appender name="LIST" + class="ch.qos.logback.core.read.ListAppender"> + + <filter class="ch.qos.logback.classic.filter.LevelFilter"> + <OnMatch>DENY</OnMatch> + <level>ERROR</level> + </filter> + </appender> + + <root> + <level value="debug" /> + <appender-ref ref="LIST" /> + </root> +</configuration> \ No newline at end of file Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/StringListAppender.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/StringListAppender.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/StringListAppender.java Wed Mar 19 21:39:37 2008 @@ -38,7 +38,6 @@ public void setLayout(Layout<LoggingEvent> layout) { this.layout = layout; - } } Copied: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/joran/JoranConfiguratorTest.java (from r1638, /logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/joran/BasicJoranTest.java) ============================================================================== --- /logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/joran/BasicJoranTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/joran/JoranConfiguratorTest.java Wed Mar 19 21:39:37 2008 @@ -12,6 +12,7 @@ import junit.framework.Test; import junit.framework.TestCase; import junit.framework.TestSuite; +import ch.qos.logback.classic.Level; import ch.qos.logback.classic.Logger; import ch.qos.logback.classic.LoggerContext; import ch.qos.logback.classic.StringListAppender; @@ -22,10 +23,11 @@ import ch.qos.logback.classic.util.TeztConstants; import ch.qos.logback.core.joran.spi.JoranException; import ch.qos.logback.core.read.ListAppender; +import ch.qos.logback.core.util.StatusPrinter; -public class BasicJoranTest extends TestCase { +public class JoranConfiguratorTest extends TestCase { - public BasicJoranTest(String name) { + public JoranConfiguratorTest(String name) { super(name); } @@ -118,19 +120,61 @@ DebugUsersTurboFilter dutf = (DebugUsersTurboFilter)filter; assertEquals(2, dutf.getUsers().size()); } + - public void test() { + public void testLevelFilter() throws JoranException { + JoranConfigurator jc = new JoranConfigurator(); + LoggerContext loggerContext = new LoggerContext(); + jc.setContext(loggerContext); + jc.doConfigure(TeztConstants.TEST_DIR_PREFIX + + "input/joran/levelFilter.xml"); + + StatusPrinter.print(loggerContext); + + Logger logger = loggerContext.getLogger(this.getClass().getName()); + logger.warn("hello"); + logger.error("to be ignored"); + @SuppressWarnings("unchecked") + ListAppender<LoggingEvent> listAppender = (ListAppender) loggerContext + .getLogger("root").getAppender("LIST"); + + assertNotNull(listAppender); + assertEquals(1, listAppender.list.size()); + LoggingEvent back = listAppender.list.get(0); + assertEquals(Level.WARN, back.getLevel()); + assertEquals("hello", back.getMessage()); } - // COMMENTED_OUT_ - public static Test suite() { - TestSuite suite = new TestSuite(); - //suite.addTestSuite(BasicJoranTest.class); + + public void testEvaluatorFilter() throws JoranException { + JoranConfigurator jc = new JoranConfigurator(); + LoggerContext loggerContext = new LoggerContext(); + jc.setContext(loggerContext); + jc.doConfigure(TeztConstants.TEST_DIR_PREFIX + + "input/joran/evaluatorFilter.xml"); + + StatusPrinter.print(loggerContext); + + Logger logger = loggerContext.getLogger(this.getClass().getName()); + logger.warn("hello"); + logger.error("to be ignored"); - suite.addTest(new BasicJoranTest("testLevel")); + @SuppressWarnings("unchecked") + ListAppender<LoggingEvent> listAppender = (ListAppender) loggerContext + .getLogger("root").getAppender("LIST"); - //suite.addTest(new BasicJoranTest("testSimpleList")); - + assertNotNull(listAppender); + assertEquals(1, listAppender.list.size()); + LoggingEvent back = listAppender.list.get(0); + assertEquals(Level.WARN, back.getLevel()); + assertEquals("hello", back.getMessage()); + } + + + public static Test suite() { + TestSuite suite = new TestSuite(); + suite.addTestSuite(JoranConfiguratorTest.class); + //suite.addTest(new JoranConfiguratorTest("testEvaluatorFilter")); return suite; } } Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/joran/PackageTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/joran/PackageTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/joran/PackageTest.java Wed Mar 19 21:39:37 2008 @@ -15,7 +15,7 @@ public static Test suite() { TestSuite suite = new TestSuite(); - suite.addTestSuite(BasicJoranTest.class); + suite.addTestSuite(JoranConfiguratorTest.class); suite.addTestSuite(EvaluatorJoranTest.class); return suite; } Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/spi/Interpreter.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/spi/Interpreter.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/spi/Interpreter.java Wed Mar 19 21:39:37 2008 @@ -66,7 +66,7 @@ final private RuleStore ruleStore; final private InterpretationContext ec; final private ArrayList<ImplicitAction> implicitActions; - final private ContextAwareImpl cai; + final private CAI_WithLocatorSupport cai; Pattern pattern; Locator locator; EventPlayer player; @@ -88,7 +88,7 @@ Pattern skip = null; public Interpreter(Context context, RuleStore rs) { - this.cai = new ContextAwareImpl(this); + this.cai = new CAI_WithLocatorSupport(this); this.cai.setContext(context); ruleStore = rs; ec = new InterpretationContext(context, this); @@ -342,3 +342,28 @@ } } } + +/** + * When {@link Interpreter} class is used as the origin of an + * {@link ContextAwareImpl} instance, then XML locator information + * is lost. This class preserves locator information (as a string). + * + * @author ceki + */ +class CAI_WithLocatorSupport extends ContextAwareImpl { + + CAI_WithLocatorSupport(Interpreter interpreter) { + super(interpreter); + } + + @Override + protected Object getOrigin() { + Interpreter i = (Interpreter) super.getOrigin(); + Locator locator = i.locator; + if(locator != null) { + return Interpreter.class.getName()+"@"+locator.getLineNumber()+":"+locator.getColumnNumber(); + } else { + return Interpreter.class.getName()+"@NA:NA"; + } + } +} Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/ContextAwareImpl.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/ContextAwareImpl.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/ContextAwareImpl.java Wed Mar 19 21:39:37 2008 @@ -23,7 +23,7 @@ * * @author Ceki G&uumllcü */ -final public class ContextAwareImpl implements ContextAware { +public class ContextAwareImpl implements ContextAware { private int noContextWarning = 0; protected Context context; @@ -33,6 +33,10 @@ this.origin = origin; } + protected Object getOrigin() { + return origin; + } + public void setContext(Context context) { if (this.context == null) { this.context = context; @@ -66,27 +70,27 @@ } public void addInfo(String msg) { - addStatus(new InfoStatus(msg, origin)); + addStatus(new InfoStatus(msg, getOrigin())); } public void addInfo(String msg, Throwable ex) { - addStatus(new InfoStatus(msg, origin, ex)); + addStatus(new InfoStatus(msg, getOrigin(), ex)); } public void addWarn(String msg) { - addStatus(new WarnStatus(msg, origin)); + addStatus(new WarnStatus(msg, getOrigin())); } public void addWarn(String msg, Throwable ex) { - addStatus(new WarnStatus(msg, origin, ex)); + addStatus(new WarnStatus(msg, getOrigin(), ex)); } public void addError(String msg) { - addStatus(new ErrorStatus(msg, origin)); + addStatus(new ErrorStatus(msg, getOrigin())); } public void addError(String msg, Throwable ex) { - addStatus(new ErrorStatus(msg, origin, ex)); + addStatus(new ErrorStatus(msg, getOrigin(), ex)); } } Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/PropertySetter.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/PropertySetter.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/PropertySetter.java Wed Mar 19 21:39:37 2008 @@ -25,7 +25,7 @@ import java.lang.reflect.Method; import ch.qos.logback.core.spi.ContextAwareBase; -import ch.qos.logback.core.spi.FilterReply; + /** * General purpose Object property setter. Clients repeatedly invokes @@ -54,7 +54,10 @@ private static final int X_NOT_FOUND = 0; private static final int X_AS_COMPONENT = 1; private static final int X_AS_PROPERTY = 2; + + private static final Class[] STING_CLASS_PARAMETER = new Class[] {String.class}; + protected Object obj; protected Class objClass; protected PropertyDescriptor[] propertyDescriptors; @@ -237,7 +240,7 @@ return X_AS_PROPERTY; } else if (FileSize.class.isAssignableFrom(clazz)) { return X_AS_PROPERTY; - } else if (FilterReply.class.isAssignableFrom(clazz)){ + } else if (clazz.isEnum()){ return X_AS_PROPERTY; } else { return X_AS_COMPONENT; @@ -367,7 +370,7 @@ } } - String capitalizeFirstLetter(String name) { + private String capitalizeFirstLetter(String name) { return name.substring(0, 1).toUpperCase() + name.substring(1); } @@ -401,13 +404,23 @@ return Duration.valueOf(val); } else if (FileSize.class.isAssignableFrom(type)) { return FileSize.valueOf(val); - } else if (FilterReply.class.isAssignableFrom(type)) { - return FilterReply.valueOf(v); + } else if(type.isEnum()) { + return convertEnum(val, type); } return null; } + protected Object convertEnum(String val, Class type) { + try { + Method m = type.getMethod("valueOf", STING_CLASS_PARAMETER); + return m.invoke(null, val); + } catch (Exception e) { + addError("Failed to convert value ["+val+"] to enum ["+type.getName()+"]", e); + } + return null; + } + protected Method getMethod(String methodName) { if (methodDescriptors == null) { introspect(); Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/util/PropertySetterTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/util/PropertySetterTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/util/PropertySetterTest.java Wed Mar 19 21:39:37 2008 @@ -29,7 +29,10 @@ assertEquals(ContainmentType.AS_COMPONENT_COLLECTION, setter.canContainComponent("Window")); assertEquals(ContainmentType.AS_PROPERTY_COLLECTION, setter.canContainComponent("adjective")); + assertEquals(ContainmentType.AS_SINGLE_PROPERTY, setter.canContainComponent("filterReply")); + assertEquals(ContainmentType.AS_SINGLE_PROPERTY, setter.canContainComponent("houseColor")); + System.out.println(); } public void testSetProperty() { @@ -136,8 +139,7 @@ House house = new House(); PropertySetter setter = new PropertySetter(house); setter.setProperty("houseColor", "BLUE"); - //TODO fails for now - //assertEquals(HouseColor.BLUE, house.getHouseColor()); + assertEquals(HouseColor.BLUE, house.getHouseColor()); } }

1 0

svn commit: r1650 - logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser
by noreply.ceki＠qos.ch 19 Mar '08

19 Mar '08

Author: ceki Date: Wed Mar 19 19:58:42 2008 New Revision: 1650 Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/SamplePatternLayoutTest.java Log: - added a test case for including % as a literal in a conversion pattern Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/SamplePatternLayoutTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/SamplePatternLayoutTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/SamplePatternLayoutTest.java Wed Mar 19 19:58:42 2008 @@ -51,13 +51,17 @@ plb.setPattern("x(%OTT\\)"); plb.start(); String s = plb.doLayout(new Object()); - //System.out.println(s); - System.out.println(s); - - //StatusManager sm = context.getStatusManager(); - //StatusPrinter.print(sm); assertEquals("x(123)", s); + } + public void testPercentAsLiteral() { + PatternLayoutBase<Object> plb = getPatternLayoutBase(); + Context context = new ContextBase(); + plb.setContext(context); + plb.setPattern("hello \\% world"); + plb.start(); + String s = plb.doLayout(new Object()); + assertEquals("hello % world", s); }

1 0

[Bug 8] New: The insertion of a percent symbol causes the Parser to crash
by bugzilla-daemon＠pixie.qos.ch 19 Mar '08

19 Mar '08

http://bugzilla.qos.ch/show_bug.cgi?id=8 Summary: The insertion of a percent symbol causes the Parser to crash Product: logback-core Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Pattern AssignedTo: logback-dev(a)qos.ch ReportedBy: noreply.sebastien(a)qos.ch When inserting the percent char twice, so that it appears in the PatternLayout output, a number format exception is thrown. It does not prevent from using normally the PatternLayout. trace: ERROR in ch.qos.logback.core.joran.spi.Interpreter@131f71a - Exception in Action for tag <layout>8:14 java.lang.NumberFormatException: For input string: "% %" java.lang.NumberFormatException: For input string: "% %" at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48) at java.lang.Integer.parseInt(Integer.java:447) at java.lang.Integer.parseInt(Integer.java:497) at ch.qos.logback.core.pattern.FormatInfo.valueOf(FormatInfo.java:70) at ch.qos.logback.core.pattern.parser.Parser.T(Parser.java:84) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:51) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.parse(Parser.java:31) at ch.qos.logback.core.pattern.PatternLayoutBase.start(PatternLayoutBase.java:76) at ch.qos.logback.core.joran.action.AbstractLayoutAction.end(AbstractLayoutAction.java:75) at ch.qos.logback.core.joran.spi.Interpreter.callEndAction(Interpreter.java:289) at ch.qos.logback.core.joran.spi.Interpreter.endElement(Interpreter.java:152) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.endElement(AbstractSAXParser.java:633) at com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanEndElement(XMLNSDocumentScannerImpl.java:719) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(XMLDocumentFragmentScannerImpl.java:1685) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:368) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:834) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:764) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:148) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1242) at javax.xml.parsers.SAXParser.parse(SAXParser.java:375) at ch.qos.logback.core.joran.JoranConfiguratorBase.doConfigure(JoranConfiguratorBase.java:125) at ch.qos.logback.core.joran.JoranConfiguratorBase.doConfigure(JoranConfiguratorBase.java:101) at ch.qos.logback.core.joran.JoranConfiguratorBase.doConfigure(JoranConfiguratorBase.java:84) at ch.qos.logback.core.joran.JoranConfiguratorBase.doConfigure(JoranConfiguratorBase.java:77) at mainPackage.ConfigTester.main(ConfigTester.java:21) -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 5

svn commit: r1649 - logback-demo/trunk/src/main/java/ch/qos/logback/demo
by noreply.ceki＠qos.ch 19 Mar '08

19 Mar '08

Author: ceki Date: Wed Mar 19 18:26:56 2008 New Revision: 1649 Modified: logback-demo/trunk/src/main/java/ch/qos/logback/demo/Runner.java Log: - reduce the frequency of the task Modified: logback-demo/trunk/src/main/java/ch/qos/logback/demo/Runner.java ============================================================================== --- logback-demo/trunk/src/main/java/ch/qos/logback/demo/Runner.java (original) +++ logback-demo/trunk/src/main/java/ch/qos/logback/demo/Runner.java Wed Mar 19 18:26:56 2008 @@ -67,7 +67,7 @@ Runnable runnable = new LoggingTask("Howdydy-diddly-ho"); scheduledExecutorService.scheduleAtFixedRate(runnable, - 0, 3000, TimeUnit.MILLISECONDS); + 0, 10000, TimeUnit.MILLISECONDS); }

1 0

svn commit: r1648 - logback/trunk/logback-site/src/site/pages/manual
by noreply.ceki＠qos.ch 19 Mar '08

19 Mar '08

Author: ceki Date: Wed Mar 19 16:03:53 2008 New Revision: 1648 Modified: logback/trunk/logback-site/src/site/pages/manual/layouts.html Log: - added blurb on parentheses in layout patterns Modified: logback/trunk/logback-site/src/site/pages/manual/layouts.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/manual/layouts.html (original) +++ logback/trunk/logback-site/src/site/pages/manual/layouts.html Wed Mar 19 16:03:53 2008 @@ -1000,14 +1000,52 @@ <h3>Parentheses are special</h3> - In logback, parentheses withing the pattern string are treated + In logback, parentheses within the pattern string are treated as grouping tokens. Thus, it is possible to group a sub-pattern and apply formatting directives to that sub-pattern. - For example, + For example, the pattern - XXXXXXXXXXXXXXXXXX + %-30(%d{HH:mm:ss.SSS} [%thread]) %-5level %logger{32} - %msg%n + + will group the output generated by the sub-pattern + "%d{HH:mm:ss.SSS} [%thread]" so that it is right-padded if less + than 30 characters. + + + If without the grouping the output was + + 13:09:30 [main] DEBUG c.q.logback.demo.ContextListener - Classload hashcode is 13995234 +13:09:30 [main] DEBUG c.q.logback.demo.ContextListener - Initializing for ServletContext +13:09:30 [main] DEBUG c.q.logback.demo.ContextListener - Trying platform Mbean server +13:09:30 [pool-1-thread-1] INFO ch.qos.logback.demo.LoggingTask - Howdydy-diddly-ho - 0 +13:09:38 [btpool0-7] INFO c.q.l.demo.lottery.LotteryAction - Number: 50 was tried. +13:09:40 [btpool0-7] INFO c.q.l.d.prime.NumberCruncherImpl - Beginning to factor. +13:09:40 [btpool0-7] DEBUG c.q.l.d.prime.NumberCruncherImpl - Trying 2 as a factor. +13:09:40 [btpool0-7] INFO c.q.l.d.prime.NumberCruncherImpl - Found factor 2 + + + with the "%-30()" grouping applied it would be + + 13:09:30 [main] DEBUG c.q.logback.demo.ContextListener - Classload hashcode is 13995234 +13:09:30 [main] DEBUG c.q.logback.demo.ContextListener - Initializing for ServletContext +13:09:30 [main] DEBUG c.q.logback.demo.ContextListener - Trying platform Mbean server +13:09:30 [pool-1-thread-1] INFO ch.qos.logback.demo.LoggingTask - Howdydy-diddly-ho - 0 +13:09:38 [btpool0-7] INFO c.q.l.demo.lottery.LotteryAction - Number: 50 was tried. +13:09:40 [btpool0-7] INFO c.q.l.d.prime.NumberCruncherImpl - Beginning to factor. +13:09:40 [btpool0-7] DEBUG c.q.l.d.prime.NumberCruncherImpl - Trying 2 as a factor. +13:09:40 [btpool0-7] INFO c.q.l.d.prime.NumberCruncherImpl - Found factor 2 + + + + The latter form is more comfortable to read, especially for + long log files. + + If you need to treat the parenthesis character as a literal, it + needs to be escaped by preceding the parentheses with a + backslash. As in, $%d{HH:mm:ss.SSS} [%thread]$. +

1 0

svn commit: r1647 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern
by noreply.ceki＠qos.ch 19 Mar '08

19 Mar '08

Author: ceki Date: Wed Mar 19 13:19:48 2008 New Revision: 1647 Added: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/ConverterUtil.java Log: - missing file Added: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/ConverterUtil.java ============================================================================== --- (empty file) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/ConverterUtil.java Wed Mar 19 13:19:48 2008 @@ -0,0 +1,34 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 1999-2008, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ + +package ch.qos.logback.core.pattern; + +public class ConverterUtil { + + /** + * Start converters in the chain of converters. + * @param head + */ + public static void startConverters(Converter head) { + Converter c = head; + while (c != null) { + if (c instanceof DynamicConverter) { + DynamicConverter dc = (DynamicConverter) c; + dc.start(); + } else if(c instanceof CompositeConverter){ + CompositeConverter cc = (CompositeConverter) c; + Converter childConverter = cc.childConverter; + startConverters(childConverter); + } + c = c.getNext(); + } + } + +}

1 0

svn commit: r1646 - in logback/trunk: logback-classic/src/test/java/ch/qos/logback/classic logback-core/src/main/java/ch/qos/logback/core/html logback-core/src/main/java/ch/qos/logback/core/pattern logback-core/src/main/java/ch/qos/logback/core/rolling/helper
by noreply.ceki＠qos.ch 18 Mar '08

18 Mar '08

Author: ceki Date: Tue Mar 18 22:10:40 2008 New Revision: 1646 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PatternLayoutTest.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/html/HTMLLayoutBase.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/DynamicConverter.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/PatternLayoutBase.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/FileNamePattern.java Log: - composite patterns (those with parentheses) pass initial tests - startConverters method moved from DynamicConverter to ConvertUtil class. In fact, CompositeConverter have to be started as well. This was previously not the case and patterns with composites in them would not work. Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PatternLayoutTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PatternLayoutTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PatternLayoutTest.java Tue Mar 18 22:10:40 2008 @@ -78,6 +78,20 @@ assertTrue(val.contains("java.lang.Exception: Bogus exception")); } + public void testCompositePattern() { + PatternLayout pl = new PatternLayout(); + pl.setPattern("%-56(%d [%t] %lo{20}) - %m%n"); + Context context = new LoggerContext(); + pl.setContext(context); + pl.start(); + String val = pl.doLayout(getEventObject()); + // 2008-03-18 21:55:54,250 [main] c.q.l.c.pattern.ConverterTest - Some message + String regex = Contants4T.ISO_REGEX+" \\[main] c.q.l.c.p.ConverterTest - Some message\\s*"; + System.out.println(val); + assertTrue(val.matches(regex)); + + } + public void testNopExeptionHandler() { PatternLayout pl = new PatternLayout(); pl.setPattern("%nopex %m%n"); Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/html/HTMLLayoutBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/html/HTMLLayoutBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/html/HTMLLayoutBase.java Tue Mar 18 22:10:40 2008 @@ -4,7 +4,7 @@ import ch.qos.logback.core.LayoutBase; import ch.qos.logback.core.pattern.Converter; -import ch.qos.logback.core.pattern.DynamicConverter; +import ch.qos.logback.core.pattern.ConverterUtil; import ch.qos.logback.core.pattern.parser.Node; import ch.qos.logback.core.pattern.parser.Parser; import ch.qos.logback.core.pattern.parser.ScanException; @@ -74,7 +74,7 @@ p.setContext(getContext()); Node t = p.parse(); this.head = p.compile(t, getDefaultConverterMap()); - DynamicConverter.startConverters(this.head); + ConverterUtil.startConverters(this.head); } catch (ScanException ex) { addError("Incorrect pattern found", ex); errorCount++; Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/DynamicConverter.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/DynamicConverter.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/DynamicConverter.java Tue Mar 18 22:10:40 2008 @@ -52,19 +52,4 @@ protected List getOptionList() { return optionList; } - - /** - * Used to start DynamicConvertes in a chain of converters. - * @param head - */ - public static void startConverters(Converter head) { - Converter c = head; - while (c != null) { - if (c instanceof DynamicConverter) { - DynamicConverter dc = (DynamicConverter) c; - dc.start(); - } - c = c.getNext(); - } - } } Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/PatternLayoutBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/PatternLayoutBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/PatternLayoutBase.java Tue Mar 18 22:10:40 2008 @@ -78,7 +78,7 @@ Node t = p.parse(); this.head = p.compile(t, getEffectiveConverterMap()); postCompileProcessing(head); - DynamicConverter.startConverters(this.head); + ConverterUtil.startConverters(this.head); super.start(); } catch (ScanException sce) { StatusManager sm = getContext().getStatusManager(); Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/FileNamePattern.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/FileNamePattern.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/FileNamePattern.java Tue Mar 18 22:10:40 2008 @@ -16,7 +16,7 @@ import ch.qos.logback.core.Context; import ch.qos.logback.core.pattern.Converter; -import ch.qos.logback.core.pattern.DynamicConverter; +import ch.qos.logback.core.pattern.ConverterUtil; import ch.qos.logback.core.pattern.parser.Node; import ch.qos.logback.core.pattern.parser.Parser; import ch.qos.logback.core.pattern.parser.ScanException; @@ -47,7 +47,7 @@ setPattern(patternArg); setContext(contextArg); parse(); - DynamicConverter.startConverters(this.headTokenConverter); + ConverterUtil.startConverters(this.headTokenConverter); } void parse() {

1 0

svn commit: r1645 - in logback/trunk: logback-core/src/test/java/ch/qos/logback/core/pattern/parser logback-site/src/site/pages logback-site/src/site/pages/manual
by noreply.ceki＠qos.ch 13 Mar '08

13 Mar '08

Author: ceki Date: Thu Mar 13 17:55:08 2008 New Revision: 1645 Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/SamplePatternLayoutTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/TokenStreamTest.java logback/trunk/logback-site/src/site/pages/manual/layouts.html logback/trunk/logback-site/src/site/pages/news.html Log: - documenting and further testing parentheses support (bug 83) - updating news Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/SamplePatternLayoutTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/SamplePatternLayoutTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/SamplePatternLayoutTest.java Thu Mar 13 17:55:08 2008 @@ -42,9 +42,25 @@ //StatusManager sm = context.getStatusManager(); //StatusPrinter.print(sm); assertEquals("x123", s); + } + + public void testParentheses() { + PatternLayoutBase<Object> plb = getPatternLayoutBase(); + Context context = new ContextBase(); + plb.setContext(context); + plb.setPattern("x(%OTT\\)"); + plb.start(); + String s = plb.doLayout(new Object()); + //System.out.println(s); + System.out.println(s); + + //StatusManager sm = context.getStatusManager(); + //StatusPrinter.print(sm); + assertEquals("x(123)", s); } + @Override public Context getContext() { return context; Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/TokenStreamTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/TokenStreamTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/TokenStreamTest.java Thu Mar 13 17:55:08 2008 @@ -281,35 +281,42 @@ } public void testNested() throws ScanException { + List tl = new TokenStream("%(%a%(%b))").tokenize(); + List<Token> witness = new ArrayList<Token>(); + witness.add(Token.PERCENT_TOKEN); + witness.add(Token.LEFT_PARENTHESIS_TOKEN); + witness.add(Token.PERCENT_TOKEN); + witness.add(new Token(Token.KEYWORD, "a")); + witness.add(Token.PERCENT_TOKEN); + witness.add(Token.LEFT_PARENTHESIS_TOKEN); + witness.add(Token.PERCENT_TOKEN); + witness.add(new Token(Token.KEYWORD, "b")); + witness.add(Token.RIGHT_PARENTHESIS_TOKEN); + witness.add(Token.RIGHT_PARENTHESIS_TOKEN); + + assertEquals(witness, tl); + + } + + public void testEscapedParanteheses() throws ScanException { { - List tl = new TokenStream("%(%a%(%b))").tokenize(); + List tl = new TokenStream("\$%h\$").tokenize(); List<Token> witness = new ArrayList<Token>(); + witness.add(new Token(Token.LITERAL, "(")); witness.add(Token.PERCENT_TOKEN); - witness.add(Token.LEFT_PARENTHESIS_TOKEN); - witness.add(Token.PERCENT_TOKEN); - witness.add(new Token(Token.KEYWORD, "a")); - witness.add(Token.PERCENT_TOKEN); - witness.add(Token.LEFT_PARENTHESIS_TOKEN); - witness.add(Token.PERCENT_TOKEN); - witness.add(new Token(Token.KEYWORD, "b")); - witness.add(Token.RIGHT_PARENTHESIS_TOKEN); - witness.add(Token.RIGHT_PARENTHESIS_TOKEN); - + witness.add(new Token(Token.KEYWORD, "h")); + witness.add(new Token(Token.LITERAL, ")")); assertEquals(witness, tl); } - { - List tl = new TokenStream("\$%h\$").tokenize(); + List tl = new TokenStream("(%h\\)").tokenize(); List<Token> witness = new ArrayList<Token>(); witness.add(new Token(Token.LITERAL, "(")); witness.add(Token.PERCENT_TOKEN); witness.add(new Token(Token.KEYWORD, "h")); witness.add(new Token(Token.LITERAL, ")")); - assertEquals(witness, tl); } - // } - } \ No newline at end of file Modified: logback/trunk/logback-site/src/site/pages/manual/layouts.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/manual/layouts.html (original) +++ logback/trunk/logback-site/src/site/pages/manual/layouts.html Thu Mar 13 17:55:08 2008 @@ -998,6 +998,19 @@ </tr> </table> + <h3>Parentheses are special</h3> + + In logback, parentheses withing the pattern string are treated + as grouping tokens. Thus, it is possible to group a sub-pattern + and apply formatting directives to that sub-pattern. + + + For example, + + XXXXXXXXXXXXXXXXXX + + + <h3>Options</h3> Modified: logback/trunk/logback-site/src/site/pages/news.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/news.html (original) +++ logback/trunk/logback-site/src/site/pages/news.html Thu Mar 13 17:55:08 2008 @@ -60,8 +60,6 @@ client connections and to close them. - - Fixed <a href="http://bugzilla.qos.ch/show_bug.cgi?id=110">bug 110</a> in relation with the <code>requestParameterMap</code> field in <code>AccessEvent</code> - reported by Joern Huxhorn. @@ -77,6 +75,20 @@ nested as well as multiple file inclusions. + Fixed <a href="http://bugzilla.qos.ch/show_bug.cgi?id=100">bug + 100</a> reported by Joern Huxhorn. At serialization time, object + array passed as parameter, when the LoggingEvent is are now + serialized as strings. + + + + Fixed <a href="http://bugzilla.qos.ch/show_bug.cgi?id=109">bug + 109</a> reported by Joern Huxhorn. There should no longer be any + NullPointerExceptions thrown by deserialized + <code>AccessEvent</code> instances. + + + <hr width="80%" align="center" />

1 0

[Bug 136] New: ThrowableInformation should keep the Throwable cause hierarchy intact.
by bugzilla-daemon＠pixie.qos.ch 13 Mar '08

13 Mar '08

http://bugzilla.qos.ch/show_bug.cgi?id=136 Summary: ThrowableInformation should keep the Throwable cause hierarchy intact. Product: logback-classic Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: joern(a)huxhorn.de Instead of a String representation of the whole Throwable stack trace incl. cause ThrowableInformation should instead look like this: public class ThrowableInformation implements Serializable { String throwableClassName; String message; StackTraceElement[] stackTrace; ThrowableInformation cause; } I omitted get/set and private in this example. StackTraceElement is perfectly Serializable and did also receive a public c'tor in Java 5 so I guess that the current ThrowableInformation is more or less a relict of log4j which had to stay compatible with older Java versions. You could obviously keep the getThrowableStrRep() method for compatibility. This bug is somewhat related to bug #134 because I think that ThrowableInformation should also, as LoggingEvent, be just a dumb data container with no real logic. The logic to extract the relevant StackTraceElements should IMHO be moved either into Logger or into a static factory method of ThrowableInformation. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 1