March 2008 - logback-dev - mailman3.qos.ch

svn commit: r1624 - in logback/trunk/logback-classic/src: main/java/ch/qos/logback/classic/spi test/java/ch/qos/logback/classic/spi
by noreply.ceki＠qos.ch 04 Mar '08

04 Mar '08

Author: ceki Date: Tue Mar 4 11:51:19 2008 New Revision: 1624 Added: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/LoggerComparatorTest.java Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/LoggerComparator.java Log: - fixing bug #127 See http://bugzilla.qos.ch/show_bug.cgi?id=127 for further details Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/LoggerComparator.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/LoggerComparator.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/LoggerComparator.java Tue Mar 4 11:51:19 2008 @@ -8,9 +8,15 @@ public class LoggerComparator implements Comparator<Logger> { public int compare(Logger l1, Logger l2) { + if (l1.getName().equals(l2.getName())) { + return 0; + } if (l1.getName().equals(LoggerContext.ROOT_NAME)) { return -1; } + if (l2.getName().equals(LoggerContext.ROOT_NAME)) { + return 1; + } return l1.getName().compareTo(l2.getName()); } Added: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/LoggerComparatorTest.java ============================================================================== --- (empty file) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/LoggerComparatorTest.java Tue Mar 4 11:51:19 2008 @@ -0,0 +1,38 @@ +package ch.qos.logback.classic.spi; + +import org.junit.Before; +import org.junit.Test; +import static org.junit.Assert.*; + +import ch.qos.logback.classic.Logger; +import ch.qos.logback.classic.LoggerContext; + + +public class LoggerComparatorTest { + + LoggerComparator comparator = new LoggerComparator(); + LoggerContext lc = new LoggerContext(); + + Logger root = lc.getLogger("root"); + + Logger a = lc.getLogger("a"); + Logger b = lc.getLogger("b"); + + @Before + public void setUp() throws Exception { + + } + + + + @Test + public void testSmoke() { + assertEquals(0, comparator.compare(a, a)); + assertEquals(-1, comparator.compare(a, b)); + assertEquals(1, comparator.compare(b, a)); + assertEquals(-1, comparator.compare(root, a)); + // following two tests failed before bug #127 was fixed + assertEquals(1, comparator.compare(a, root)); + assertEquals(0, comparator.compare(root, root)); + } +}

1 0

svn commit: r1623 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern
by noreply.ceki＠qos.ch 04 Mar '08

04 Mar '08

Author: ceki Date: Tue Mar 4 10:43:09 2008 New Revision: 1623 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/ClassNameAbbreviator.java Log: it is slightly better if computeIndexes method is static Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/ClassNameAbbreviator.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/ClassNameAbbreviator.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/ClassNameAbbreviator.java Tue Mar 4 10:43:09 2008 @@ -66,7 +66,7 @@ return buf.toString(); } - int computeIndexes(final String className, int[] dotArray) { + static int computeIndexes(final String className, int[] dotArray) { int dotCount = 0; int k = 0; while (true) {

1 0

[Bug 131] New: Application name for a web-app
by bugzilla-daemon＠pixie.qos.ch 02 Mar '08

02 Mar '08

http://bugzilla.qos.ch/show_bug.cgi?id=131 Summary: Application name for a web-app Product: logback-classic Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: enhancement Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: noreply.ceki(a)qos.ch Logback should provide support for setting the application name of a web-app (or a JEE application) out of the box. The LoggingContext is a good place for this. See also: http://www.qos.ch/pipermail/logback-user/2008-March/000400.html -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0