June 2009 - logback-dev - mailman3.qos.ch

[JIRA] Created: (LBCORE-103) message implicit variable should have a more detailed documentation and usage for the EvaluatorFilter
by Johan Bos (JIRA) 30 Jun '09

30 Jun '09

message implicit variable should have a more detailed documentation and usage for the EvaluatorFilter ----------------------------------------------------------------------------------------------------- Key: LBCORE-103 URL: http://jira.qos.ch/browse/LBCORE-103 Project: logback-core Issue Type: Improvement Components: Appender Affects Versions: 0.9.15 Environment: Windows XP, Java 1.5 Sun JVM, Tomcat 5.0.27 Reporter: Johan Bos Assignee: Logback dev list Priority: Trivial I was expecting "message" implicit variable to contain the full message rendered by the %message or %msg from the pattern, but the recommanded way of logging, using LOG.debug("I want to log an object {}", object); is only formatted in the event.getFormattedMessage(), event.getMessage <=> message, but only contains the "I want to log an object {}" so if my matching string for the expression setting for the EvaluatorFilter is the dynamical part I can't never match my string, instead it got "{}". So, it would be less confusing for users to find in the documentation an explicit information on what message variable contains, and does not contain! Thank you I would be happy to explain my point if you find it unclear or irrelevant. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Created: (LBCLASSIC-141) ContextListener that stops the LoggerContext when using DefaultContextSelector
by Paul Nyheim (JIRA) 30 Jun '09

30 Jun '09

ContextListener that stops the LoggerContext when using DefaultContextSelector ------------------------------------------------------------------------------ Key: LBCLASSIC-141 URL: http://jira.qos.ch/browse/LBCLASSIC-141 Project: logback-classic Issue Type: Improvement Affects Versions: 0.9.15 Reporter: Paul Nyheim Assignee: Logback dev list Priority: Minor When using the "The simplest and easiest approach" to configure logback as described here: http://logback.qos.ch/manual/loggingSeparation.html, The LoggerContext never gets stopped when the application is redeployed in an applicationserver. This causes both memory leaks, and an unability to Rename log files using RollingFileAppender because several handles to the log file exists. An easy solution to this is to stop the LoggerContext in a ServletContextListener - much the same as for the ContextJNDISelector using ContextDetachingSCL. I will upload a file - based on the ContextDetatchingSCL which does the job. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

svn commit: r2315 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135
by noreply.ceki＠qos.ch 29 Jun '09

29 Jun '09

Author: ceki Date: Mon Jun 29 19:06:40 2009 New Revision: 2315 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java Log: reformat results Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java Mon Jun 29 19:06:40 2009 @@ -23,7 +23,7 @@ */ public class LoggingToFileThrouhput { - static int THREAD_COUNT = 10; + static int THREAD_COUNT = 1; static long OVERALL_DURATION_IN_MILLIS = 5000; public static void main(String args[]) throws InterruptedException { @@ -79,34 +79,34 @@ // java.vendor = Sun Microsystems Inc. // os.name = Windows XP // -// Threads 10: total of 309402 operations, or 61 operations per millisecond // Threads 1: total of 485077 operations, or 97 operations per millisecond +// Threads 10: total of 309402 operations, or 61 operations per millisecond //* After revision 2310 -//* Threads 10: total of 243362 operations, or 58 operations per millisecond //* Threads 1: total of 462465 operations, or 92 operations per millisecond +//* Threads 10: total of 243362 operations, or 48 operations per millisecond +// ==================== Linux ======================== // java.runtime.version = 1.6.0_11-b03 // java.vendor = Sun Microsystems Inc. // os.name = Linux // os.version = 2.6.25-gentoo-r6 -// Threads 10: total of 287943 operations, or 57 operations per millisecond // Threads 1: total of 356355 operations, or 71 operations per millisecond +// Threads 10: total of 287943 operations, or 57 operations per millisecond //* After revision 2310 -//* Threads 10: total of 311104 operations, or 62 operations per millisecond //* Threads 1: total of 331494 operations, or 66 operations per millisecond - +//* Threads 10: total of 311104 operations, or 58 operations per millisecond // java.runtime.version = jvmxa6460-20081105_25433 // java.vendor = IBM Corporation // java.version = 1.6.0 // os.name = Linux // os.version = 2.6.25-gentoo-r6 -// Threads 10 total of 142989 operations, or 28 operations per millisecond // Threads 1: total of 280381 operations, or 56 operations per millisecond +// Threads 10 total of 142989 operations, or 28 operations per millisecond //* After revision 2310 -//* Threads 10: total of 147660 operations, or 29 operations per millisecond -//* Threads 1: total of 305638 operations, or 61 operations per millisecond \ No newline at end of file +//* Threads 1: total of 305638 operations, or 61 operations per millisecond +//* Threads 10: total of 147660 operations, or 29 operations per millisecond \ No newline at end of file

1 0

svn commit: r2314 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135
by noreply.ceki＠qos.ch 29 Jun '09

29 Jun '09

Author: ceki Date: Mon Jun 29 19:00:06 2009 New Revision: 2314 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java Log: slightly slower results after revision 2310 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java Mon Jun 29 19:00:06 2009 @@ -82,10 +82,10 @@ // Threads 10: total of 309402 operations, or 61 operations per millisecond // Threads 1: total of 485077 operations, or 97 operations per millisecond -// After revision 2310 +//* After revision 2310 +//* Threads 10: total of 243362 operations, or 58 operations per millisecond +//* Threads 1: total of 462465 operations, or 92 operations per millisecond -// Threads 1: total of 462465 operations, or 92 operations per millisecond -//Threads 10: total of 243362 operations, or 48 operations per millisecond // java.runtime.version = 1.6.0_11-b03 // java.vendor = Sun Microsystems Inc. @@ -94,6 +94,10 @@ // Threads 10: total of 287943 operations, or 57 operations per millisecond // Threads 1: total of 356355 operations, or 71 operations per millisecond +//* After revision 2310 +//* Threads 10: total of 311104 operations, or 62 operations per millisecond +//* Threads 1: total of 331494 operations, or 66 operations per millisecond + // java.runtime.version = jvmxa6460-20081105_25433 // java.vendor = IBM Corporation @@ -103,3 +107,6 @@ // Threads 10 total of 142989 operations, or 28 operations per millisecond // Threads 1: total of 280381 operations, or 56 operations per millisecond +//* After revision 2310 +//* Threads 10: total of 147660 operations, or 29 operations per millisecond +//* Threads 1: total of 305638 operations, or 61 operations per millisecond \ No newline at end of file

1 0

svn commit: r2313 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/lbclassic139
by noreply.ceki＠qos.ch 29 Jun '09

29 Jun '09

Author: ceki Date: Mon Jun 29 18:54:35 2009 New Revision: 2313 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/lbclassic139/LB139_DeadlockTest.java Log: wait longer so that tests pass in slower machines Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/lbclassic139/LB139_DeadlockTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/lbclassic139/LB139_DeadlockTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/lbclassic139/LB139_DeadlockTest.java Mon Jun 29 18:54:35 2009 @@ -4,7 +4,7 @@ public class LB139_DeadlockTest { - @Test(timeout=2000) + @Test(timeout=3000) public void test() throws Exception { Worker worker = new Worker(); Accessor accessor = new Accessor(worker);

1 0

svn commit: r2312 - in logback/trunk: logback-classic/src/test/java/ch/qos/logback/classic logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135 logback-core/src/test/java/ch/qos/logback/core/appender logback-core/src/test/java/ch/qos/logback/core/contention logback-core/src/test/java/ch/qos/logback/core/rolling
by noreply.ceki＠qos.ch 29 Jun '09

29 Jun '09

Author: ceki Date: Mon Jun 29 18:44:28 2009 New Revision: 2312 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/TestConstants.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingRunnable.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/AbstractAppenderTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/DummyAppenderTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/FileAppenderTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/contention/RunnableWithCounterAndDone.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/RollingFileAppenderTest.java Log: Use Appender instead of AppenderBase in AbstractAppender related tests Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/TestConstants.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/TestConstants.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/TestConstants.java Mon Jun 29 18:44:28 2009 @@ -1,11 +1,11 @@ /** - * LOGBack: the reliable, fast and flexible logging library for Java. - * - * Copyright (C) 1999-2006, QOS.ch - * - * This library is free software, you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public License as - * published by the Free Software Foundation. + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. */ package ch.qos.logback.classic; Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingRunnable.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingRunnable.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingRunnable.java Mon Jun 29 18:44:28 2009 @@ -1,3 +1,12 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ package ch.qos.logback.classic.issue.lbclassic135; import ch.qos.logback.classic.Logger; Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java Mon Jun 29 18:44:28 2009 @@ -1,3 +1,12 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ package ch.qos.logback.classic.issue.lbclassic135; import ch.qos.logback.classic.Logger; Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/AbstractAppenderTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/AbstractAppenderTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/AbstractAppenderTest.java Mon Jun 29 18:44:28 2009 @@ -1,11 +1,11 @@ /** - * LOGBack: the reliable, fast and flexible logging library for Java. - * - * Copyright (C) 1999-2006, QOS.ch - * - * This library is free software, you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public License as - * published by the Free Software Foundation. + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. */ package ch.qos.logback.core.appender; @@ -15,7 +15,7 @@ import org.junit.Test; -import ch.qos.logback.core.AppenderBase; +import ch.qos.logback.core.Appender; import ch.qos.logback.core.Context; import ch.qos.logback.core.ContextBase; import ch.qos.logback.core.status.StatusChecker; @@ -25,19 +25,19 @@ abstract public class AbstractAppenderTest<E> { - abstract protected AppenderBase<E> getAppender(); - abstract protected AppenderBase<E> getConfiguredAppender(); + abstract protected Appender<E> getAppender(); + abstract protected Appender<E> getConfiguredAppender(); @Test public void testNewAppender() { // new appenders should be inactive - AppenderBase appender = getAppender(); + Appender appender = getAppender(); assertFalse( appender.isStarted()); } @Test public void testConfiguredAppender() { - AppenderBase appender = getConfiguredAppender(); + Appender appender = getConfiguredAppender(); appender.start(); assertTrue(appender.isStarted()); @@ -48,7 +48,7 @@ @Test public void testNoStart() { - AppenderBase<E> appender = getAppender(); + Appender<E> appender = getAppender(); Context context = new ContextBase(); appender.setContext(context); appender.setName("doh"); Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java Mon Jun 29 18:44:28 2009 @@ -1,11 +1,11 @@ /** - * LOGBack: the reliable, fast and flexible logging library for Java. - * - * Copyright (C) 1999-2006, QOS.ch - * - * This library is free software, you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public License as - * published by the Free Software Foundation. + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. */ package ch.qos.logback.core.appender; @@ -18,7 +18,7 @@ import org.junit.Before; import org.junit.Test; -import ch.qos.logback.core.AppenderBase; +import ch.qos.logback.core.Appender; import ch.qos.logback.core.ConsoleAppender; import ch.qos.logback.core.CoreConstants; import ch.qos.logback.core.layout.DummyLayout; @@ -53,11 +53,11 @@ } @Override - public AppenderBase<Object> getAppender() { + public Appender<Object> getAppender() { return new ConsoleAppender<Object>(); } - protected AppenderBase<Object> getConfiguredAppender() { + protected Appender<Object> getConfiguredAppender() { ConsoleAppender<Object> ca = new ConsoleAppender<Object>(); ca.setLayout(new NopLayout<Object>()); ca.start(); Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/DummyAppenderTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/DummyAppenderTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/DummyAppenderTest.java Mon Jun 29 18:44:28 2009 @@ -9,13 +9,13 @@ */ package ch.qos.logback.core.appender; -import static org.junit.Assert.*; +import static org.junit.Assert.assertEquals; import java.io.StringWriter; import org.junit.Test; -import ch.qos.logback.core.AppenderBase; +import ch.qos.logback.core.Appender; import ch.qos.logback.core.layout.DummyLayout; import ch.qos.logback.core.layout.NopLayout; @@ -23,11 +23,11 @@ public class DummyAppenderTest { - protected AppenderBase getAppender() { + protected Appender getAppender() { return new DummyAppender(new StringWriter()); } - protected AppenderBase getConfiguredAppender() { + protected Appender getConfiguredAppender() { DummyAppender<Object> da = new DummyAppender<Object>(new StringWriter()); da.setLayout(new NopLayout<Object>()); da.start(); Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/FileAppenderTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/FileAppenderTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/FileAppenderTest.java Mon Jun 29 18:44:28 2009 @@ -19,7 +19,7 @@ import org.junit.Test; -import ch.qos.logback.core.AppenderBase; +import ch.qos.logback.core.Appender; import ch.qos.logback.core.Context; import ch.qos.logback.core.ContextBase; import ch.qos.logback.core.FileAppender; @@ -35,11 +35,11 @@ int diff = new Random().nextInt(100); Context context = new ContextBase(); - protected AppenderBase<Object> getAppender() { + protected Appender<Object> getAppender() { return new FileAppender<Object>(); } - protected AppenderBase<Object> getConfiguredAppender() { + protected Appender<Object> getConfiguredAppender() { FileAppender<Object> appender = new FileAppender<Object>(); appender.setLayout(new NopLayout<Object>()); appender.setFile("temp.log"); Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/contention/RunnableWithCounterAndDone.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/contention/RunnableWithCounterAndDone.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/contention/RunnableWithCounterAndDone.java Mon Jun 29 18:44:28 2009 @@ -1,3 +1,12 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ package ch.qos.logback.core.contention; /** Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/RollingFileAppenderTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/RollingFileAppenderTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/RollingFileAppenderTest.java Mon Jun 29 18:44:28 2009 @@ -1,3 +1,12 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ package ch.qos.logback.core.rolling; @@ -10,7 +19,7 @@ import org.junit.Before; import org.junit.Test; -import ch.qos.logback.core.AppenderBase; +import ch.qos.logback.core.Appender; import ch.qos.logback.core.Context; import ch.qos.logback.core.ContextBase; import ch.qos.logback.core.appender.AbstractAppenderTest; @@ -41,12 +50,12 @@ @Override - protected AppenderBase<Object> getAppender() { + protected Appender<Object> getAppender() { return rfa; } @Override - protected AppenderBase<Object> getConfiguredAppender() { + protected Appender<Object> getConfiguredAppender() { rfa.setContext(context); tbrp.setFileNamePattern("toto-%d.log");

1 0

svn commit: r2311 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135
by noreply.ceki＠qos.ch 29 Jun '09

29 Jun '09

Author: ceki Date: Mon Jun 29 17:52:09 2009 New Revision: 2311 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java Log: throughput results after revision 2310 is applied show noticeable degradation in throughput of 10 to 20% (on windows) Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java Mon Jun 29 17:52:09 2009 @@ -14,7 +14,7 @@ */ public class LoggingToFileThrouhput { - static int THREAD_COUNT = 1; + static int THREAD_COUNT = 10; static long OVERALL_DURATION_IN_MILLIS = 5000; public static void main(String args[]) throws InterruptedException { @@ -73,6 +73,11 @@ // Threads 10: total of 309402 operations, or 61 operations per millisecond // Threads 1: total of 485077 operations, or 97 operations per millisecond +// After revision 2310 + +// Threads 1: total of 462465 operations, or 92 operations per millisecond +//Threads 10: total of 243362 operations, or 48 operations per millisecond + // java.runtime.version = 1.6.0_11-b03 // java.vendor = Sun Microsystems Inc. // os.name = Linux

1 0

svn commit: r2310 - in logback/trunk: logback-classic/src/main/java/ch/qos/logback/classic/pattern logback-classic/src/test/java/ch/qos/logback/classic/spi logback-core/src/main/java/ch/qos/logback/core
by noreply.ceki＠qos.ch 29 Jun '09

29 Jun '09

Author: ceki Date: Mon Jun 29 17:43:52 2009 New Revision: 2310 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/CallerDataConverter.java logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/DateConverter.java logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/MDCConverter.java logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/RelativeTimeConverter.java logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/SyslogStartConverter.java logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/TargetLengthBasedClassNameAbbreviator.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/PubLoggingEventVO.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/WriterAppender.java Log: Diminish contention in appender doAppender. Relates to LBCLASSIC-135 Instead of the doAppend method being synchronized, WriterAppender now uses UnsynchronizedAppenderBase as its super class. Consequently, various converters can no longer assume that they are invoked from within a synchronized block. Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/CallerDataConverter.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/CallerDataConverter.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/CallerDataConverter.java Mon Jun 29 17:43:52 2009 @@ -65,7 +65,6 @@ } } } - } private void addEvaluator(EventEvaluator<ILoggingEvent> ee) { @@ -76,7 +75,7 @@ } public String convert(ILoggingEvent le) { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); if (evaluatorList != null) { boolean printCallerData = false; Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/DateConverter.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/DateConverter.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/DateConverter.java Mon Jun 29 17:43:52 2009 @@ -17,56 +17,58 @@ import ch.qos.logback.classic.spi.ILoggingEvent; import ch.qos.logback.core.CoreConstants; - public class DateConverter extends ClassicConverter { - + long lastTimestamp = -1; - String timesmapStr = null; + String timestampStrCache = null; SimpleDateFormat simpleFormat = null; - + public void start() { - + String datePattern = getFirstOption(); - if(datePattern == null) { + if (datePattern == null) { datePattern = CoreConstants.ISO8601_PATTERN; } - + if (datePattern.equals(CoreConstants.ISO8601_STR)) { datePattern = CoreConstants.ISO8601_PATTERN; - } - + } + try { simpleFormat = new SimpleDateFormat(datePattern); - //maximumCacheValidity = CachedDateFormat.getMaximumCacheValidity(pattern); + // maximumCacheValidity = + // CachedDateFormat.getMaximumCacheValidity(pattern); } catch (IllegalArgumentException e) { - addWarn("Could not instantiate SimpleDateFormat with pattern " + datePattern, e); + addWarn("Could not instantiate SimpleDateFormat with pattern " + + datePattern, e); // default to the ISO8601 format simpleFormat = new SimpleDateFormat(CoreConstants.ISO8601_PATTERN); } - + List optionList = getOptionList(); - + // if the option list contains a TZ option, then set it. if (optionList != null && optionList.size() > 1) { TimeZone tz = TimeZone.getTimeZone((String) optionList.get(1)); simpleFormat.setTimeZone(tz); } } - + public String convert(ILoggingEvent le) { long timestamp = le.getTimeStamp(); - - // if called multiple times within the same millisecond - // return old value - if(timestamp == lastTimestamp) { - return timesmapStr; - } else { - lastTimestamp = timestamp; - // SimpleDateFormat is not thread safe. However, since - // the AppenderBase.doAppend is synchronized, we are should be - // OK. See also http://jira.qos.ch/browse/LBCLASSIC-36 - timesmapStr = simpleFormat.format(new Date(timestamp)); - return timesmapStr; + + synchronized (this) { + // if called multiple times within the same millisecond + // return cache value + if (timestamp == lastTimestamp) { + return timestampStrCache; + } else { + lastTimestamp = timestamp; + // SimpleDateFormat is not thread safe. + // See also http://jira.qos.ch/browse/LBCLASSIC-36 + timestampStrCache = simpleFormat.format(new Date(timestamp)); + return timestampStrCache; + } } } } Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/MDCConverter.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/MDCConverter.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/MDCConverter.java Mon Jun 29 17:43:52 2009 @@ -37,7 +37,7 @@ if (key == null) { // if no key is specified, return all the // values present in the MDC, separated with a single space. - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); Set<String> keys = mdcPropertyMap.keySet(); Iterator it = keys.iterator(); String tmpKey; Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/RelativeTimeConverter.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/RelativeTimeConverter.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/RelativeTimeConverter.java Mon Jun 29 17:43:52 2009 @@ -14,19 +14,18 @@ public class RelativeTimeConverter extends ClassicConverter { long lastTimestamp = -1; - String timesmapStr = null; - + String timesmapCache = null; + public String convert(ILoggingEvent event) { - long timestamp = event.getTimeStamp(); - - // if called multiple times within the same millisecond - // return old value - if(timestamp == lastTimestamp) { - return timesmapStr; - } else { - lastTimestamp = timestamp; - timesmapStr = Long.toString(timestamp - event.getLoggerContextVO().getBirthTime()); - return timesmapStr; + long now = event.getTimeStamp(); + + synchronized (this) { + // update timesmapStrCache only if now != lastTimestamp + if (now != lastTimestamp) { + lastTimestamp = now; + timesmapCache = Long.toString(now - event.getLoggerContextVO().getBirthTime()); + } + return timesmapCache; } } } Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/SyslogStartConverter.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/SyslogStartConverter.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/SyslogStartConverter.java Mon Jun 29 17:43:52 2009 @@ -61,7 +61,7 @@ sb.append("<"); sb.append(pri); sb.append(">"); - fillInTimestamp(sb, event.getTimeStamp()); + sb.append(computeTimeStampString(event.getTimeStamp())); sb.append(' '); sb.append(localHostName); sb.append(' '); @@ -85,13 +85,13 @@ } } - void fillInTimestamp(StringBuilder sb, long timestamp) { - // if called multiple times within the same millisecond - // use last value - if (timestamp != lastTimestamp) { - lastTimestamp = timestamp; - timesmapStr = simpleFormat.format(new Date(timestamp)); + String computeTimeStampString(long now) { + synchronized (this) { + if (now != lastTimestamp) { + lastTimestamp = now; + timesmapStr = simpleFormat.format(new Date(now)); + } + return timesmapStr; } - sb.append(timesmapStr); - } + } } Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/TargetLengthBasedClassNameAbbreviator.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/TargetLengthBasedClassNameAbbreviator.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/TargetLengthBasedClassNameAbbreviator.java Mon Jun 29 17:43:52 2009 @@ -14,17 +14,14 @@ public class TargetLengthBasedClassNameAbbreviator implements Abbreviator { - static private final int BUF_LIMIT = 256; - final int targetLength; - StringBuffer buf; public TargetLengthBasedClassNameAbbreviator(int targetLength) { - this.targetLength = targetLength; - buf = new StringBuffer(targetLength); + this.targetLength = targetLength; } public String abbreviate(String fqClassName) { + StringBuilder buf = new StringBuilder(targetLength); if (fqClassName == null) { throw new IllegalArgumentException("Class name may not be null"); } @@ -34,11 +31,6 @@ return fqClassName; } - if (buf.capacity() > BUF_LIMIT) { - buf = new StringBuffer(targetLength); - } - buf.setLength(0); - int[] dotIndexesArray = new int[ClassicConstants.MAX_DOTS]; // a.b.c contains 2 dots but 2+1 parts. // see also http://jira.qos.ch/browse/LBCLASSIC-110 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/PubLoggingEventVO.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/PubLoggingEventVO.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/PubLoggingEventVO.java Mon Jun 29 17:43:52 2009 @@ -21,7 +21,7 @@ import ch.qos.logback.classic.Level; /** - * A read/write and serializable implementation of {@link ILoggingEvent}. + * A read/write and serializable implementation of {@link ILoggingEvent}. * * @author Ceki Gülcü Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java Mon Jun 29 17:43:52 2009 @@ -58,7 +58,7 @@ private int statusRepeatCount = 0; private int exceptionCount = 0; - static final int ALLOWED_REPEATS = 5; + static final int ALLOWED_REPEATS = 3; public void doAppend(E eventObject) { // WARNING: The guard check MUST be the first statement in the Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/WriterAppender.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/WriterAppender.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/WriterAppender.java Mon Jun 29 17:43:52 2009 @@ -26,7 +26,7 @@ * * @author Ceki Gülcü */ -public class WriterAppender<E> extends AppenderBase<E> { +public class WriterAppender<E> extends UnsynchronizedAppenderBase<E> { /** * Immediate flush means that the underlying writer or output stream will be @@ -36,14 +36,16 @@ * is a good chance that the last few logs events are not actually written to * persistent media if and when the application crashes. * - * The <code>immediateFlush</code> variable is set to <code>true</code> - * by default. + * + * The <code>immediateFlush</code> variable is set to <code>true</code> by + * default. */ private boolean immediateFlush = true; /** - * The encoding to use when opening an InputStream. The - * <code>encoding</code> variable is set to <code>null</null> by default + * The encoding to use when opening an InputStream. + * + * The <code>encoding</code> variable is set to <code>null</null> by default * which results in the use of the system's default encoding. */ private String encoding; @@ -53,7 +55,6 @@ */ private Writer writer; - /** * The default constructor does nothing. */ @@ -64,12 +65,14 @@ * If the ImmediateFlush option is set to <code>true</code>, the * appender will flush at the end of each write. This is the default behavior. * If the option is set to <code>false</code>, then the underlying stream - * can defer writing to physical medium to a later time. Avoiding the - * flush operation at the end of each append results in a performance gain of - * 10 to 20 percent. However, there is safety tradeoff involved in skipping - * flushing. Indeed, when flushing is skipped, then it is likely that the last - * few log events will not be recorded on disk when the application exits. - * This is a high price to pay even for a 20% performance gain. + * can defer writing to physical medium to a later time. + * + * Avoiding the flush operation at the end of each append results in a + * performance gain of 10 to 20 percent. However, there is safety tradeoff + * involved in skipping flushing. Indeed, when flushing is skipped, then it is + * likely that the last few log events will not be recorded on disk when the + * application exits. This is a high price to pay even for a 20% performance + * gain. */ public void setImmediateFlush(boolean value) { immediateFlush = value; @@ -118,7 +121,8 @@ * Stop this appender instance. The underlying stream or writer is also * closed. * - * Stopped appenders cannot be reused. + * + * Stopped appenders cannot be reused. */ public synchronized void stop() { closeWriter(); @@ -177,7 +181,6 @@ encoding = value; } - void writeHeader() { if (layout != null && (this.writer != null)) { try { @@ -224,12 +227,13 @@ } /** - * Sets the Writer where the log output will go. The specified Writer must - * be opened by the user and be writable. The <code>java.io.Writer</code> - * will be closed when the appender instance is closed. + * + * Sets the Writer where the log output will go. The specified Writer must be + * opened by the user and be writable. The <code>java.io.Writer</code> will + * be closed when the appender instance is closed. * * @param writer - * An already opened Writer. + * An already opened Writer. */ public synchronized void setWriter(Writer writer) { // close any previously opened writer @@ -247,8 +251,10 @@ } /** - * Actual writing occurs here. Most subclasses of - * <code>WriterAppender</code> will need to override this method. + * Actual writing occurs here. + * + * Most subclasses of <code>WriterAppender</code> will need to override this + * method. * * @since 0.9.0 */ @@ -258,7 +264,10 @@ } try { - writerWrite(this.layout.doLayout(event), this.immediateFlush); + String output = this.layout.doLayout(event); + synchronized (this) { + writerWrite(output, this.immediateFlush); + } } catch (IOException ioe) { // as soon as an exception occurs, move to non-started state // and add a single ErrorStatus to the SM. @@ -266,5 +275,4 @@ addStatus(new ErrorStatus("IO failure in appender", this, ioe)); } } - }

1 0

[JIRA] Created: (LBSITE-28) Logback-Classic as Logging-Backend w/ Maven Jetty Plugin
by Sebastian Davids (JIRA) 28 Jun '09

28 Jun '09

Logback-Classic as Logging-Backend w/ Maven Jetty Plugin -------------------------------------------------------- Key: LBSITE-28 URL: http://jira.qos.ch/browse/LBSITE-28 Project: logback-site Issue Type: Improvement Reporter: Sebastian Davids Assignee: Logback dev list http://docs.codehaus.org/display/JETTY/Maven+Jetty+Plugin http://logback.qos.ch/faq.html#setup_jetty You should add the following or something similar to the FAQ: pom.xml: <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> ... <build> ... <plugins> <plugin> <groupId>org.mortbay.jetty</groupId> <artifactId>maven-jetty-plugin</artifactId> <configuration> ... <systemProperties> <systemProperty> <name>logback.configurationFile</name> <value>./src/etc/logback.xml</value> </systemProperty> </systemProperties> </configuration> <dependencies> <dependency> <groupId>ch.qos.logback</groupId> <artifactId>logback-classic</artifactId> <version>${lb.version}</version> </dependency> ... </dependencies> </plugin> </plugins> </build> <properties> <lb.version>0.9.15</lb.version> </properties> </project> If one just adds the dependency on logback-classic the BasicConfigurator will be used for Jetty, resulting in a lot of debug statements. The important part is the systemProperty. You might want to update the example at http://svn.qos.ch/repos/logback-demo/tags/STABLE also. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

DSL for configuring logback
by Ceki Gulcu 28 Jun '09

28 Jun '09

Hello all, At the Jazoon 2009 conference, I attended a talk by Hans Dockter on Gradle, a build framework based on Groovy. The ability to mix language features within the build file itself was quite convincing so as to switch on a dim light inside my head. I think it would be worthwhile to explore the creation of a DSL for configuring logback. Anyone interested to work on this? I have already asked Jason Dillon and he has not answered yet. Cheers, -- Ceki Gülcü Logback: The reliable, generic, fast and flexible logging framework for Java. http://logback.qos.ch

4 10