July 2009 - logback-dev - mailman3.qos.ch

[JIRA] Created: (LBSITE-32) Broken link in The Logback Manual
by Simon Barbey (JIRA) 13 Jul '09

13 Jul '09

Broken link in The Logback Manual --------------------------------- Key: LBSITE-32 URL: http://jira.qos.ch/browse/LBSITE-32 Project: logback-site Issue Type: Bug Components: Documentation Environment: Ubuntu, Firefox 3.0.11 Reporter: Simon Barbey Assignee: Logback dev list Priority: Trivial In the Logabck Manual located here http://logback.qos.ch/manual/index.html, the link for "Chapter 9: JMX Configurator" is broken (http://logback.qos.ch/manual/jmxConfigurator.html) However, the link pointed to the same subject in the right navigation bar seems good (http://logback.qos.ch/manual/jmxConfig.html) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

svn commit: r2342 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/turbo
by noreply.ceki＠qos.ch 12 Jul '09

12 Jul '09

Author: ceki Date: Sun Jul 12 22:47:09 2009 New Revision: 2342 Added: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/turbo/ReconfigureOnChangeFilter.java Log: - initial very rough implementation of automatic reconfiguration on configuration file change, related to LBCORE-59 Added: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/turbo/ReconfigureOnChangeFilter.java ============================================================================== --- (empty file) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/turbo/ReconfigureOnChangeFilter.java Sun Jul 12 22:47:09 2009 @@ -0,0 +1,105 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ +package ch.qos.logback.classic.turbo; + +import java.io.File; +import java.net.URL; + +import org.slf4j.Marker; + +import ch.qos.logback.classic.Level; +import ch.qos.logback.classic.Logger; +import ch.qos.logback.classic.LoggerContext; +import ch.qos.logback.classic.joran.JoranConfigurator; +import ch.qos.logback.core.CoreConstants; +import ch.qos.logback.core.joran.spi.JoranException; +import ch.qos.logback.core.spi.FilterReply; + +/** + * Reconfigure a LoggerContext when the configuration file changes. + * + * @author Ceki Gulcu + * + * */ +public class ReconfigureOnChangeFilter extends TurboFilter { + + final static long DEFAULT_REFRESH_PERIOD = 60*1000; // 1 minute + long refreshPeriod = DEFAULT_REFRESH_PERIOD; + File fileToScan; + protected long nextCheck; + long lastModified; + + @Override + public void start() { + URL url = (URL) context.getObject(CoreConstants.URL_OF_LAST_CONFIGURATION_VIA_JORAN); + if(url == null) { + fileToScan = convertToFile(url); + if(fileToScan != null) { + long inSeconds = refreshPeriod/1000; + addInfo("Will scan for changes in file ["+fileToScan+"] every "+inSeconds+" seconds"); + lastModified = fileToScan.lastModified(); + updateNextCheck(System.currentTimeMillis()); + super.start(); + } + } else { + addError("Could not find URL of file to scan."); + } + } + + File convertToFile(URL url) { + String protocol = url.getProtocol(); + if("file".equals(protocol)) { + File file = new File(url.getFile()); + return file; + } else { + addError("URL ["+url+"] is not of type file"); + return null; + } + } + + @Override + public FilterReply decide(Marker marker, Logger logger, Level level, String format, Object[] params, Throwable t) { + if(!isStarted()) { + return FilterReply.NEUTRAL; + } + + boolean changed = changeDetected(); + if(changed) { + reconfigure(); + } + return FilterReply.NEUTRAL; + } + + void updateNextCheck(long now) { + nextCheck = now + refreshPeriod; + } + + protected boolean changeDetected() { + long now = System.currentTimeMillis(); + if(now >= nextCheck) { + updateNextCheck(now); + return (lastModified != fileToScan.lastModified()); + } + return false; + } + + + protected void reconfigure() { + JoranConfigurator jc = new JoranConfigurator(); + jc.setContext(context); + LoggerContext lc = (LoggerContext) context; + lc.reset(); + try { + jc.doConfigure(fileToScan); + } catch (JoranException e) { + addError("Failure during reconfiguration", e); + } + } +}

1 0

svn commit: r2341 - in logback/trunk/logback-core/src/main/java/ch/qos/logback/core: . joran
by noreply.ceki＠qos.ch 12 Jul '09

12 Jul '09

Author: ceki Date: Sun Jul 12 22:46:59 2009 New Revision: 2341 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/CoreConstants.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/GenericConfigurator.java Log: - initial very rough implementation of automatic reconfiguration on configuration file change, related to LBCORE-59 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/CoreConstants.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/CoreConstants.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/CoreConstants.java Sun Jul 12 22:46:59 2009 @@ -83,4 +83,9 @@ static public final char TAB = '\t'; static public final String SEE_FNP_NOT_SET = "See also http://logback.qos.ch/codes.html#tbr_fnp_not_set"; + + // The url used for the last configuration via Joran. If a file is used for the + // configuration, then file.getURL() is registered + public static String URL_OF_LAST_CONFIGURATION_VIA_JORAN = "URL_OF_LAST_CONFIGURATION_VIA_JORAN"; + } Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/GenericConfigurator.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/GenericConfigurator.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/GenericConfigurator.java Sun Jul 12 22:46:59 2009 @@ -19,6 +19,7 @@ import org.xml.sax.InputSource; +import ch.qos.logback.core.CoreConstants; import ch.qos.logback.core.joran.event.SaxEvent; import ch.qos.logback.core.joran.event.SaxEventRecorder; import ch.qos.logback.core.joran.spi.DefaultNestedComponentRegistry; @@ -37,6 +38,7 @@ final public void doConfigure(URL url) throws JoranException { try { + informContextOfURLUsedForConfiguration(url); URLConnection urlConnection = url.openConnection(); // per http://jira.qos.ch/browse/LBCORE-105 urlConnection.setDefaultUseCaches(false); @@ -57,6 +59,7 @@ final public void doConfigure(File file) throws JoranException { FileInputStream fis = null; try { + informContextOfURLUsedForConfiguration(file.toURL()); fis = new FileInputStream(file); doConfigure(fis); } catch (IOException ioe) { @@ -76,6 +79,10 @@ } } + protected void informContextOfURLUsedForConfiguration(URL url) { + getContext().putObject(CoreConstants.URL_OF_LAST_CONFIGURATION_VIA_JORAN, url); + } + final public void doConfigure(InputStream inputStream) throws JoranException { doConfigure(new InputSource(inputStream)); }

1 0

svn commit: r2340 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic
by noreply.ceki＠qos.ch 12 Jul '09

12 Jul '09

Author: ceki Date: Sun Jul 12 21:19:15 2009 New Revision: 2340 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/AllClassicTest.java Log: - change in spacing Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/AllClassicTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/AllClassicTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/AllClassicTest.java Sun Jul 12 21:19:15 2009 @@ -32,5 +32,4 @@ ch.qos.logback.classic.issue.PackageTest.class}) public class AllClassicTest { - }

1 0

svn commit: r2339 - logback/trunk/logback-classic/src/main/java/org/slf4j/impl
by noreply.ceki＠qos.ch 12 Jul '09

12 Jul '09

Author: ceki Date: Sun Jul 12 21:18:30 2009 New Revision: 2339 Modified: logback/trunk/logback-classic/src/main/java/org/slf4j/impl/StaticLoggerBinder.java Log: - request SLF4J 1.5.8 Modified: logback/trunk/logback-classic/src/main/java/org/slf4j/impl/StaticLoggerBinder.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/org/slf4j/impl/StaticLoggerBinder.java (original) +++ logback/trunk/logback-classic/src/main/java/org/slf4j/impl/StaticLoggerBinder.java Sun Jul 12 21:18:30 2009 @@ -43,7 +43,7 @@ * against. The value of this field is usually modified with each release. */ // to avoid constant folding by the compiler, this field must *not* be final - public static String REQUESTED_API_VERSION = "1.5.6"; // !final + public static String REQUESTED_API_VERSION = "1.5.8"; // !final final static String NULL_CS_URL = CoreConstants.CODES_URL + "#null_CS";

1 0

svn commit: r2338 - logback/trunk/logback-site/src/site/pages/templates
by noreply.ceki＠qos.ch 10 Jul '09

10 Jul '09

Author: ceki Date: Fri Jul 10 11:38:46 2009 New Revision: 2338 Modified: logback/trunk/logback-site/src/site/pages/templates/footer.js Log: - linking to the W3 validator slows down the page Modified: logback/trunk/logback-site/src/site/pages/templates/footer.js ============================================================================== --- logback/trunk/logback-site/src/site/pages/templates/footer.js (original) +++ logback/trunk/logback-site/src/site/pages/templates/footer.js Fri Jul 10 11:38:46 2009 @@ -4,12 +4,13 @@ document.write('<tr>') document.write(' <td>') -document.write(' <a href="http://validator.w3.org/check?uri=referer">') -document.write(' <img align="left" src="http://www.w3.org/Icons/valid-xhtml10"') -document.write(' alt="Valid XHTML 1.0 Transitional" height="31" width="88" /></a>') +document.write('  ') +//document.write(' <a href="http://validator.w3.org/check?uri=referer">') +//document.write(' <img align="left" src="http://www.w3.org/Icons/valid-xhtml10"') +//document.write(' alt="Valid XHTML 1.0 Transitional" height="31" width="88" /></a>') document.write(' </td>') -document.write('<td valign="top">Copyright © 2000-2008 <a href="http://www.qos.ch/">QOS.ch</a></td>') +document.write('<td valign="top">Copyright © 2000-2009 <a href="http://www.qos.ch/">QOS.ch</a></td>') document.write('</tr>') document.write('</table>')

1 0

svn commit: r2337 - logback/trunk/logback-site/src/site/pages/manual
by noreply.ceki＠qos.ch 10 Jul '09

10 Jul '09

Author: ceki Date: Fri Jul 10 11:33:37 2009 New Revision: 2337 Modified: logback/trunk/logback-site/src/site/pages/manual/index.html Log: - Filter chains chapter renamed as Filters Modified: logback/trunk/logback-site/src/site/pages/manual/index.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/manual/index.html (original) +++ logback/trunk/logback-site/src/site/pages/manual/index.html Fri Jul 10 11:33:37 2009 @@ -90,7 +90,7 @@ </p></li> <li><p> - <a href="filters.html"><b>Chapter 6: Filter chains</b></a> + <a href="filters.html"><b>Chapter 6: Filters</b></a> </p></li> <li><p>

1 0

[JIRA] Created: (LBSITE-31) Confusing sentence in Chapter 6 'Logback Filters' section
by Mark Vedder (JIRA) 10 Jul '09

10 Jul '09

Confusing sentence in Chapter 6 'Logback Filters' section --------------------------------------------------------- Key: LBSITE-31 URL: http://jira.qos.ch/browse/LBSITE-31 Project: logback-site Issue Type: Bug Components: Documentation Affects Versions: 0.9.15 Reporter: Mark Vedder Assignee: Logback dev list Priority: Trivial In the 'Logback Filters' section of chapter 6, the second sentence of the first paragraph states: "It the event's level is equal to the configured level, the filter accepts of denies the event, depending on its configuration." I think that sentence has a couple of typos in it: - 'It' should be 'If' - 'of' should be 'or' So I think the sentence should be: "If the event's level is equal to the configured level, the filter accepts or denies the event, depending on its configuration." -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

[JIRA] Created: (LBSITE-30) Typo in Chapter 6 discussion of Filter Chains
by Mark Vedder (JIRA) 10 Jul '09

10 Jul '09

Typo in Chapter 6 discussion of Filter Chains --------------------------------------------- Key: LBSITE-30 URL: http://jira.qos.ch/browse/LBSITE-30 Project: logback-site Issue Type: Bug Components: Documentation Affects Versions: 0.9.15 Reporter: Mark Vedder Assignee: Logback dev list Priority: Trivial In the last sentence of the Logback Classic | Filter Chains section, the word 'attribute' should be plural: This: It will provide your filter with two attribute: OnMatch and OnMismatch, that can be configured like any other option. Should be: It will provide your filter with two attributes: OnMatch and OnMismatch, that can be configured like any other option. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

svn commit: r2336 - logback/trunk/logback-site/src/site/pages/manual
by noreply.ceki＠qos.ch 10 Jul '09

10 Jul '09

Author: ceki Date: Fri Jul 10 11:28:54 2009 New Revision: 2336 Modified: logback/trunk/logback-site/src/site/pages/manual/filters.html logback/trunk/logback-site/src/site/pages/manual/menu.js Log: - Filter chains chapters renamed as "Filters" as filters no longer maintain an internal linked list structure. - Fixed LBSITE-30 Modified: logback/trunk/logback-site/src/site/pages/manual/filters.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/manual/filters.html (original) +++ logback/trunk/logback-site/src/site/pages/manual/filters.html Fri Jul 10 11:28:54 2009 @@ -23,7 +23,7 @@ </div> <div id="content"> - <h1>Chapter 6: Filter chains</h1> + <h1>Chapter 6: Filters</h1> <div class="quote"> <p><em>Have lots of ideas and throw away the bad ones. You aren't @@ -172,9 +172,10 @@ would accept or deny an event depending on the content of its message), you can extend the <a href="../xref/ch/qos/logback/core/filter/AbstractMatcherFilter.html"> - <code>AbstractMatcherFilter</code></a> class. It will provide your filter with - two attribute: <em>OnMatch</em> and <em>OnMismatch</em>, that can be configured - like any other option. + <code>AbstractMatcherFilter</code></a> class. It will provide + your filter with two properties: <em>OnMatch</em> and + <em>OnMismatch</em>, both of which can be configured like any + other property. </p> <h3>Logback Filters</h3> Modified: logback/trunk/logback-site/src/site/pages/manual/menu.js ============================================================================== --- logback/trunk/logback-site/src/site/pages/manual/menu.js (original) +++ logback/trunk/logback-site/src/site/pages/manual/menu.js Fri Jul 10 11:28:54 2009 @@ -5,7 +5,7 @@ document.write('<p class="menu"><a href="configuration.html"><b>Ch3: Configuration</b></a>'); document.write('<p class="menu"><a href="appenders.html"><b>Ch4: Appenders</b></a>'); document.write('<p class="menu"><a href="layouts.html"><b>Ch5: Layouts</b></a>'); -document.write('<p class="menu"><a href="filters.html"><b>Ch6: Filter chains</b></a>'); +document.write('<p class="menu"><a href="filters.html"><b>Ch6: Filters</b></a>'); document.write('<p class="menu"><a href="mdc.html"><b>Ch7: Mapped Diagnostic Contexts</b></a>'); document.write('<p class="menu"><a href="loggingSeparation.html"><b>Ch8: Logging Separation</b></a>'); document.write('<p class="menu"><a href="jmxConfig.html"><b>Ch9: JMX Configurator</b></a>');

1 0