July 2009 - logback-dev - mailman3.qos.ch

[JIRA] Created: (LBCLASSIC-125) NoClassDefFoundError in PackagingDataCalculator.loadClass()
by Roland Klein (JIRA) 22 Jul '09

22 Jul '09

NoClassDefFoundError in PackagingDataCalculator.loadClass() ----------------------------------------------------------- Key: LBCLASSIC-125 URL: http://jira.qos.ch/browse/LBCLASSIC-125 Project: logback-classic Issue Type: Bug Affects Versions: 0.9.15 Environment: jdk 1.6 (build 1.6.0_10-b33) jboss 4.2.2ga Reporter: Roland Klein Assignee: Logback dev list In an EJB Client/Server Environment the loadClass() method could fail, because the vm issues a NoClassDefFoundError. And there is no corresponding catch, so the whole logging fails and throws a NoClassDefFoundError. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

4 10

svn commit: r2365 - in logback/trunk/logback-classic/src: main/java/ch/qos/logback/classic/spi test/java/ch/qos/logback/classic/spi
by noreply.ceki＠qos.ch 22 Jul '09

22 Jul '09

Author: ceki Date: Wed Jul 22 19:53:23 2009 New Revision: 2365 Added: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/BogusClassLoader.java Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/PackagingDataCalculator.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/LocalFirstClassLoader.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/PackagingDataCalculatorTest.java Log: - Fix LBCLASSIC-125 It was surprisingly difficult to write a test case where a NoClassDefFoundError was thrown See also http://jira.qos.ch/browse/LBCLASSIC-125 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/PackagingDataCalculator.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/PackagingDataCalculator.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/PackagingDataCalculator.java Wed Jul 22 19:53:23 2009 @@ -50,10 +50,10 @@ } public void calculate(IThrowableProxy tp) { - while(tp != null) { + while (tp != null) { populateFrames(tp.getStackTraceElementProxyArray()); tp = tp.getCause(); - } + } } void populateFrames(StackTraceElementProxy[] stepArray) { @@ -134,7 +134,7 @@ } String getImplementationVersion(Class type) { - if(type == null) { + if (type == null) { return "na"; } Package aPackage = type.getPackage(); @@ -194,6 +194,8 @@ return cl.loadClass(className); } catch (ClassNotFoundException e1) { return null; + } catch (NoClassDefFoundError e1) { + return null; } catch (Exception e) { e.printStackTrace(); // this is unexpected return null; @@ -203,8 +205,9 @@ /** * - * @param lastGuaranteedClassLoader may be null - * + * @param lastGuaranteedClassLoader + * may be null + * * @param className * @return */ @@ -226,6 +229,8 @@ return Class.forName(className); } catch (ClassNotFoundException e1) { return null; + } catch (NoClassDefFoundError e1) { + return null; } catch (Exception e) { e.printStackTrace(); // this is unexpected return null; Added: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/BogusClassLoader.java ============================================================================== --- (empty file) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/BogusClassLoader.java Wed Jul 22 19:53:23 2009 @@ -0,0 +1,48 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ +package ch.qos.logback.classic.spi; + +import java.net.URL; +import java.net.URLClassLoader; + +/** + * A trivial class loader which throws a NoClassDefFoundError if the requested + * class name contains the string "Bogus". + * + * @author Ceki G�lc� + */ +public class BogusClassLoader extends URLClassLoader { + + public BogusClassLoader(URL[] urls) { + super(urls); + } + + public BogusClassLoader(URL[] urls, ClassLoader parent) { + super(urls, parent); + } + + public Class<?> loadClass(String name) throws ClassNotFoundException { + return loadClass(name, false); + } + + /** + * Throw NoClassDefFoundError if the requested class contains the string + * "Bogus". Otherwise, delegate to super-class. + */ + protected Class<?> loadClass(String name, boolean resolve) + throws ClassNotFoundException { + + if (name.contains("Bogus")) { + throw new NoClassDefFoundError(); + } + + return super.loadClass(name, resolve); + } +} Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/LocalFirstClassLoader.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/LocalFirstClassLoader.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/LocalFirstClassLoader.java Wed Jul 22 19:53:23 2009 @@ -1,3 +1,12 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ package ch.qos.logback.classic.spi; import java.net.URL; Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/PackagingDataCalculatorTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/PackagingDataCalculatorTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/PackagingDataCalculatorTest.java Wed Jul 22 19:53:23 2009 @@ -13,6 +13,10 @@ import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertTrue; +import java.net.MalformedURLException; +import java.net.URL; +import java.net.URLClassLoader; + import org.junit.Test; import ch.qos.logback.classic.util.TeztHelper; @@ -92,26 +96,29 @@ } + private ClassLoader makeBogusClassLoader() throws MalformedURLException { + ClassLoader currentClassLoader = this.getClass().getClassLoader(); + BogusClassLoader bcl = new BogusClassLoader(new URL[] {}, + currentClassLoader); + return bcl; + } + @Test // Test http://jira.qos.ch/browse/LBCLASSIC-125 - public void noClassDefFoundError() { + public void noClassDefFoundError_LBCLASSIC_125Test() + throws MalformedURLException { + ClassLoader cl = (URLClassLoader) makeBogusClassLoader(); + Thread.currentThread().setContextClassLoader(cl); Throwable t = new Throwable("x"); ThrowableProxy tp = new ThrowableProxy(t); StackTraceElementProxy[] stepArray = tp.getStackTraceElementProxyArray(); - StackTraceElement bogusSTE = new StackTraceElement(MyBogus.class.getName(), - "myMethod", "myFile", 12); - StackTraceElementProxy bogusSTEP;// = new StackTraceElementProxy(bogusSTE); - System.out.println(stepArray.length); - for (int i = 0; i < stepArray.length; i++) { - System.out.println(i); - - stepArray[i] = new StackTraceElementProxy(bogusSTE); - } + StackTraceElement bogusSTE = new StackTraceElement("com.Bogus", "myMethod", + "myFile", 12); + stepArray[0] = new StackTraceElementProxy(bogusSTE); PackagingDataCalculator pdc = tp.getPackagingDataCalculator(); + // NoClassDefFoundError should be caught pdc.calculate(tp); - System.out.println(ThrowableProxyUtil.asString(tp)); - - System.out.println(new MyBogus()); - + } + }

1 0

svn commit: r2364 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi
by noreply.ceki＠qos.ch 22 Jul '09

22 Jul '09

Author: ceki Date: Wed Jul 22 18:29:29 2009 New Revision: 2364 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/PackagingDataCalculator.java Log: typo fix Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/PackagingDataCalculator.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/PackagingDataCalculator.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/PackagingDataCalculator.java Wed Jul 22 18:29:29 2009 @@ -57,7 +57,7 @@ } void populateFrames(StackTraceElementProxy[] stepArray) { - // in the initial part of this method we populate package informnation for + // in the initial part of this method we populate package information for // common stack frames final Throwable t = new Throwable("local stack reference"); final StackTraceElement[] localteSTEArray = t.getStackTrace();

1 0

svn commit: r2363 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi
by noreply.ceki＠qos.ch 22 Jul '09

22 Jul '09

Author: ceki Date: Wed Jul 22 10:12:44 2009 New Revision: 2363 Removed: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/BasicCPDCTest.java Log: - renamed BasicCPDCTest as PackagingDataCalculatorTest - added a new test case (which does not yet compile)

1 0

svn commit: r2362 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi
by noreply.ceki＠qos.ch 22 Jul '09

22 Jul '09

Author: ceki Date: Wed Jul 22 10:12:24 2009 New Revision: 2362 Added: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/PackagingDataCalculatorTest.java - copied, changed from r2357, /logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/BasicCPDCTest.java Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/PackageTest.java Log: - renamed BasicCPDCTest as PackagingDataCalculatorTest - added a new test case (which does not yet compile) Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/PackageTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/PackageTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/PackageTest.java Wed Jul 22 10:12:24 2009 @@ -17,6 +17,6 @@ @SuiteClasses( { ContextListenerTest.class, CallerDataTest.class, LoggerComparatorTest.class, LoggingEventSerializationTest.class, LoggingEventSerializationPerfTest.class, ThrowableProxyTest.class, - BasicCPDCTest.class }) + PackagingDataCalculatorTest.class }) public class PackageTest { } \ No newline at end of file Copied: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/PackagingDataCalculatorTest.java (from r2357, /logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/BasicCPDCTest.java) ============================================================================== --- /logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/BasicCPDCTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/spi/PackagingDataCalculatorTest.java Wed Jul 22 10:12:24 2009 @@ -1,24 +1,24 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ + package ch.qos.logback.classic.spi; import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertTrue; -import org.junit.After; -import org.junit.Before; import org.junit.Test; import ch.qos.logback.classic.util.TeztHelper; import ch.qos.logback.core.util.SystemInfo; -public class BasicCPDCTest { - - @Before - public void setUp() throws Exception { - } - - @After - public void tearDown() throws Exception { - } +public class PackagingDataCalculatorTest { public void verify(ThrowableProxy tp) { for (StackTraceElementProxy step : tp.getStackTraceElementProxyArray()) { @@ -29,16 +29,6 @@ } @Test - public void otherJD() { - System.out.println(SystemInfo.getJavaVendor()); - } - - @Test - public void integration() throws Exception { - - } - - @Test public void smoke() throws Exception { Throwable t = new Throwable("x"); ThrowableProxy tp = new ThrowableProxy(t); @@ -101,4 +91,27 @@ + (d0 * slackFactor), d0 * slackFactor > d1); } + + @Test + // Test http://jira.qos.ch/browse/LBCLASSIC-125 + public void noClassDefFoundError() { + Throwable t = new Throwable("x"); + ThrowableProxy tp = new ThrowableProxy(t); + StackTraceElementProxy[] stepArray = tp.getStackTraceElementProxyArray(); + StackTraceElement bogusSTE = new StackTraceElement(MyBogus.class.getName(), + "myMethod", "myFile", 12); + StackTraceElementProxy bogusSTEP;// = new StackTraceElementProxy(bogusSTE); + System.out.println(stepArray.length); + for (int i = 0; i < stepArray.length; i++) { + System.out.println(i); + + stepArray[i] = new StackTraceElementProxy(bogusSTE); + } + PackagingDataCalculator pdc = tp.getPackagingDataCalculator(); + pdc.calculate(tp); + System.out.println(ThrowableProxyUtil.asString(tp)); + + System.out.println(new MyBogus()); + + } }

1 0

[JIRA] Created: (LBCLASSIC-109) Logger allows TRACE messages when reset to DEBUG
by Andrew Ruch (JIRA) 21 Jul '09

21 Jul '09

Logger allows TRACE messages when reset to DEBUG ------------------------------------------------ Key: LBCLASSIC-109 URL: http://jira.qos.ch/browse/LBCLASSIC-109 Project: logback-classic Issue Type: Bug Environment: SLF4J 1.5.6 and Logback 0.9.15 Reporter: Andrew Ruch Assignee: Logback dev list Priority: Minor When reconfiguring the LoggerContext, TRACE messages are logged even when the Logger level is set to DEBUG. As Ceki pointed out, the following test reproduces the issue. @Test public void levelResetTest() { LoggerContext loggerContext = new LoggerContext(); Logger root = loggerContext.getLogger(LoggerContext.ROOT_NAME); root.setLevel(Level.TRACE); assertTrue(root.isTraceEnabled()); loggerContext.reset(); //Logger is reset to DEBUG assertFalse(root.isTraceEnabled()); <-- assertion fails assertTrue(root.isDebugEnabled()); } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 1

[JIRA] Created: (LBCLASSIC-143) SocketAppender is reporting an ERROR if connection could not be established.
by Joern Huxhorn (JIRA) 20 Jul '09

20 Jul '09

SocketAppender is reporting an ERROR if connection could not be established. ---------------------------------------------------------------------------- Key: LBCLASSIC-143 URL: http://jira.qos.ch/browse/LBCLASSIC-143 Project: logback-classic Issue Type: Bug Components: appender Affects Versions: 0.9.16 Environment: java version "1.6.0_13" Java(TM) SE Runtime Environment (build 1.6.0_13-b03-211) Java HotSpot(TM) 64-Bit Server VM (build 11.3-b02-83, mixed mode) Reporter: Joern Huxhorn Assignee: Logback dev list 13:40:59,399 |-INFO in ch.qos.logback.classic.net.SocketAppender[LogbackClassic] - Starting a new connector thread. 13:40:59,400 |-ERROR in ch.qos.logback.classic.net.SocketAppender[LogbackClassic] - Could not connect to remote logback server at [localhost]. We will try again later. java.net.ConnectException: Connection refused I think the ERROR should only be an INFO (or WARN) because it's no problem if the connection is created later when the server is available. There's nothing fatal about it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 1

svn commit: r2361 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net
by noreply.ceki＠qos.ch 20 Jul '09

20 Jul '09

Author: ceki Date: Mon Jul 20 20:15:38 2009 New Revision: 2361 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SocketAppenderBase.java Log: Failing to reconnect to remote server should be reported as a warning and not an error. Fixes LBCLASSIC-143 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SocketAppenderBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SocketAppenderBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SocketAppenderBase.java Mon Jul 20 20:15:38 2009 @@ -133,7 +133,7 @@ msg += " We will try again later."; fireConnector(); // fire the connector thread } - addError(msg, e); + addWarn(msg, e); } }

1 0

[JIRA] Created: (LBCORE-59) Support for reconfiguration at runtime
by Michael Osipov (JIRA) 20 Jul '09

20 Jul '09

Support for reconfiguration at runtime -------------------------------------- Key: LBCORE-59 URL: http://jira.qos.ch/browse/LBCORE-59 Project: logback-core Issue Type: New Feature Components: Joran Affects Versions: 0.9.9 Reporter: Michael Osipov Assignee: Logback dev list Joran should support reconfiguration at runime like log4j's DOMConfigurator#configureAndWatch. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

4 8

Is this really an ERROR?
by Joern Huxhorn 20 Jul '09

20 Jul '09

I get the following output during the start of Lilith using Logback 0.9.16: 13:40:59,399 |-INFO in ch.qos.logback.classic.net.SocketAppender[LogbackClassic] - Starting a new connector thread. 13:40:59,400 |-ERROR in ch.qos.logback.classic.net.SocketAppender[LogbackClassic] - Could not connect to remote logback server at [localhost]. We will try again later. java.net.ConnectException: Connection refused I think the ERROR should only be an INFO (or WARN if available) because it's no problem if the connection is created later when the server is available. There's nothing fatal about it. Regards, Joern.

2 2