September 2009 - logback-dev

[JIRA] Created: (LBCLASSIC-154) All threads become blocked in ReconfigureOnChangeFilter when changing log level under load
by Andrew Perrine (JIRA) 03 Dec '09

03 Dec '09

All threads become blocked in ReconfigureOnChangeFilter when changing log level under load ------------------------------------------------------------------------------------------ Key: LBCLASSIC-154 URL: http://jira.qos.ch/browse/LBCLASSIC-154 Project: logback-classic Issue Type: Bug Affects Versions: 0.917 Environment: Linux metro2a.star.dev.diginsite.com 2.6.18-128.1.1.el5 #1 SMP Mon Jan 26 13:58:24 EST 2009 x86_64 x86_64 x86_64 GNU/Linux Java(TM) SE Runtime Environment (build 1.6.0_11-b03) Java HotSpot(TM) 64-Bit Server VM (build 11.0-b16, mixed mode) Reporter: Andrew Perrine Assignee: Logback dev list We were testing logback's new <configuration scan="true"> feature and when we changed the logging level while our application was under load, all threads became blocked inside logback (full stack trace is very long, here are two examples): "http-0.0.0.0-8080-148" daemon prio=10 tid=0x00002aab58679800 nid=0x26ed waiting for monitor entry [0x000000004e617000..0x000000004e618c10] java.lang.Thread.State: BLOCKED (on object monitor) at ch.qos.logback.classic.turbo.ReconfigureOnChangeFilter.decide(ReconfigureOnChangeFilter.java:99) - waiting to lock <0x00002aaabd743d58> (a ch.qos.logback.classic.LoggerContext) at ch.qos.logback.classic.spi.TurboFilterList.getTurboFilterChainDecision(TurboFilterList.java:47) at ch.qos.logback.classic.LoggerContext.getTurboFilterChainDecision_0_3OrMore(LoggerContext.java:251) at ch.qos.logback.classic.Logger.callTurboFilters(Logger.java:770) at ch.qos.logback.classic.Logger.isDebugEnabled(Logger.java:488) at ch.qos.logback.classic.Logger.isDebugEnabled(Logger.java:484) at org.slf4j.ext.LoggerWrapper.debug(LoggerWrapper.java:238) at com.diginsite.product.ofx.presentation.CustomRequestWrapper.addCNtoOFXRequest(OFXFilter.java:191) at com.diginsite.product.ofx.presentation.CustomRequestWrapper.<init>(OFXFilter.java:153) at com.diginsite.product.ofx.presentation.OFXFilter.doFilter(OFXFilter.java:56) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.hyperic.hq.product.servlet.filter.JMXFilter.doFilter(JMXFilter.java:324) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:230) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175) at org.jboss.web.tomcat.security.SecurityAssociationValve.invoke(SecurityAssociationValve.java:182) at org.jboss.web.tomcat.security.JaccContextValve.invoke(JaccContextValve.java:84) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.jboss.web.tomcat.service.jca.CachedConnectionValve.invoke(CachedConnectionValve.java:157) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:262) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583) at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:446) at java.lang.Thread.run(Thread.java:619) "http-0.0.0.0-8080-15" daemon prio=10 tid=0x00002aab600b0400 nid=0x5669 waiting on condition [0x0000000046799000..0x000000004679ac10] java.lang.Thread.State: WAITING (parking) at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x00002aaabd755128> (a java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync) at java.util.concurrent.locks.LockSupport.park(LockSupport.java:158) at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:747) at java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireShared(AbstractQueuedSynchronizer.java:877) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireShared(AbstractQueuedSynchronizer.java:1197) at java.util.concurrent.locks.ReentrantReadWriteLock$ReadLock.lock(ReentrantReadWriteLock.java:594) at ch.qos.logback.core.spi.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:57) at ch.qos.logback.classic.Logger.appendLoopOnAppenders(Logger.java:271) at ch.qos.logback.classic.Logger.callAppenders(Logger.java:258) at ch.qos.logback.classic.Logger.buildLoggingEventAndAppend(Logger.java:440) at ch.qos.logback.classic.Logger.filterAndLog_0_Or3Plus(Logger.java:394) at ch.qos.logback.classic.Logger.log(Logger.java:813) at org.slf4j.ext.EventLogger.logEvent(EventLogger.java:36) at com.diginsite.services.logging.LoggerUtil.logEvent(LoggerUtil.java:29) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

4 14

[JIRA] Created: (LBCORE-119) ReconfigureOnChangeFilter doesn't pick up changes if there are spaces in the filename
by Anders Wallgren (JIRA) 01 Dec '09

01 Dec '09

ReconfigureOnChangeFilter doesn't pick up changes if there are spaces in the filename ------------------------------------------------------------------------------------- Key: LBCORE-119 URL: http://jira.qos.ch/browse/LBCORE-119 Project: logback-core Issue Type: Bug Affects Versions: 0.9.17 Reporter: Anders Wallgren Assignee: Logback dev list ReconfigureOnChangeFilter.start doesn't unencode the URL encoding of spaces, so it will never detect changes since the url-encoded filename doesn't exist. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 7

[JIRA] Created: (LBCLASSIC-121) Make some of the Import-Package declarations in logback-classic OSGi bundle optional
by Pavol Juhos (JIRA) 25 Nov '09

25 Nov '09

Make some of the Import-Package declarations in logback-classic OSGi bundle optional ------------------------------------------------------------------------------------ Key: LBCLASSIC-121 URL: http://jira.qos.ch/browse/LBCLASSIC-121 Project: logback-classic Issue Type: Improvement Components: Other Affects Versions: 0.9.15 Environment: OSGi Service Platform Release 4 Reporter: Pavol Juhos Assignee: Logback dev list Priority: Minor It might be a good idea to mark some additional packages imported by logback-classis bundle as optional. Namely this applies to packages javax.servlet, javax.servlet.http, javax.management By importing package javax.servlet you are forcing the users to deploy Sevlet API bundle even in non-web application environment. The current <Import-Package> declaration in maven-bundle-plugin configuration: <Import-Package>sun.reflect;resolution:=optional, javax.jms;resolution:=optional, * </Import-Package> Suggested update: <Import-Package>sun.reflect;resolution:=optional, javax.jms;resolution:=optional, javax.servlet.*;resolution:=optional, javax.management;resolution:=optional, * </Import-Package> Feel free to close this as invalid if the above mentioned packages are _always_ required for correct operation of logback-classic. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

3 3

[JIRA] Created: (LBCLASSIC-151) Export-Package: org.slf4j.impl; version="1.5.6" but 1.5.8 required
by Bulat Nigmatullin (JIRA) 18 Nov '09

18 Nov '09

Export-Package: org.slf4j.impl;version="1.5.6" but 1.5.8 required ----------------------------------------------------------------- Key: LBCLASSIC-151 URL: http://jira.qos.ch/browse/LBCLASSIC-151 Project: logback-classic Issue Type: Bug Affects Versions: 0.917 Reporter: Bulat Nigmatullin Assignee: Logback dev list Priority: Minor In pom.xml you says <properties> −  <slf4j.version>1.5.8</slf4j.version> <consolePlugin.version>1.1.0</consolePlugin.version> </properties> but in MANIFEST.MF exported org.slf4j.impl version 1.5.6. Please, fix version in MANIFEST.MF and upload it to Maven repository. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

[JIRA] Created: (LBCLASSIC-108) LOGBack Classic Bundle does not declare ch.qos.logback.core.rolling as Import-Package
by Christian Brensing (JIRA) 18 Nov '09

18 Nov '09

LOGBack Classic Bundle does not declare ch.qos.logback.core.rolling as Import-Package ------------------------------------------------------------------------------------- Key: LBCLASSIC-108 URL: http://jira.qos.ch/browse/LBCLASSIC-108 Project: logback-classic Issue Type: Bug Components: Other Affects Versions: 0.9.15 Reporter: Christian Brensing Assignee: Logback dev list Priority: Minor The LOGBack Classic Bundle has no Import-Package for ch.qos.logback.core.rolling (and rolling.helper), resulting in a ClassNotFoundException when using e.g. the RollingFileAppender from the Core-Bundle. The ClassNotFoundException will be raised because the Bundle which initializes the LoggerContext (Classic) can not load the Appender from the Core-Bundle. The Bnd-Tool by Peter Kriens and the Maven-Felix-Plugin only detects package dependencies that are imported in java classes. Runtime dependencies like Appenders must be explicitly configured in the bnd-file or pom. This issue is identically to the one I reported for the SpringSource-Bundle-Repository, see https://issuetracker.springsource.com/browse/BRITS-165. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

[JIRA] Created: (LBCLASSIC-149) ContextNameConverter does not use the context of the event
by Ceki Gulcu (JIRA) 13 Nov '09

13 Nov '09

ContextNameConverter does not use the context of the event ---------------------------------------------------------- Key: LBCLASSIC-149 URL: http://jira.qos.ch/browse/LBCLASSIC-149 Project: logback-classic Issue Type: Bug Reporter: Ceki Gulcu Assignee: Logback dev list ContextNameConverter instead of reading the context name found in the event passed as parameter, uses the context to which it (the ContextNameConverter instance) is attached to. Usually the two contexts are the same. However, when an event is sent to a remote server, the wrong information is displayed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 1

[JIRA] Created: (LBCORE-98) TimeBasedRollingPolicy: name of file in zip archive is <FileNamePattern>.nanos.tmp
by Anders Wallgren (JIRA) 13 Nov '09

13 Nov '09

TimeBasedRollingPolicy: name of file in zip archive is <FileNamePattern>.nanos.tmp ---------------------------------------------------------------------------------- Key: LBCORE-98 URL: http://jira.qos.ch/browse/LBCORE-98 Project: logback-core Issue Type: Bug Components: Rolling Affects Versions: 0.9.15 Environment: Windows Reporter: Anders Wallgren Assignee: Logback dev list Priority: Minor The name of the filename in the zip archive is a temp filename, based on the FileNamePattern, no the FileNamePattern itself. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 4

[JIRA] Created: (LBCORE-101) OSGi manifest headers too restrictive
by david varnes (JIRA) 12 Nov '09

12 Nov '09

OSGi manifest headers too restrictive ------------------------------------- Key: LBCORE-101 URL: http://jira.qos.ch/browse/LBCORE-101 Project: logback-core Issue Type: Bug Affects Versions: 0.9.15 Reporter: david varnes Assignee: Logback dev list This issue is very similar and could be addressed at the same time as LBCLASSIC-119, LBCLASSIC-121 & LBCLASSIC-131. The Import-Package definition for logback-core requires that the javax.* packages be available at runtime. The pom.xml file and my usage seem to indicate that they should be optional. Attached patch adds javax.* as 'optional' in addition to the exiting janino declaration. thanks ! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

[JIRA] Created: (LBCORE-118) EvaluatorFilter returns OnMatch when marker is null
by Manuel Kueblboeck (JIRA) 10 Nov '09

10 Nov '09

EvaluatorFilter returns OnMatch when marker is null --------------------------------------------------- Key: LBCORE-118 URL: http://jira.qos.ch/browse/LBCORE-118 Project: logback-core Issue Type: Bug Components: Other Affects Versions: 0.9.17 Environment: Windows XP Reporter: Manuel Kueblboeck Assignee: Logback dev list Priority: Minor <appender name="Alert" class="ch.qos.logback.core.ConsoleAppender"> <filter class="ch.qos.logback.core.filter.EvaluatorFilter"> <evaluator name="isAlert"> <expression>marker.getName().equals("Alert")</expression> </evaluator> <OnMatch>ACCEPT</OnMatch> <OnMismatch>DENY</OnMismatch> </filter> <layout class="ch.qos.logback.classic.PatternLayout"> <Pattern>ALERT: %d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n</Pattern> </layout> </appender> In the above example, when an event is logged without an attached marker, the filter returns OnMatch. I would expect that it returns OnMismatch. A work around for this issue is to change the expression to this: <expression>marker != null && marker.getName().equals("Alert")</expression> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 3

[JIRA] Created: (LBCLASSIC-155) ThrowableProxy passed into EventEvaluator
by Hontvári József (JIRA) 10 Nov '09

10 Nov '09

ThrowableProxy passed into EventEvaluator ----------------------------------------- Key: LBCLASSIC-155 URL: http://jira.qos.ch/browse/LBCLASSIC-155 Project: logback-classic Issue Type: Bug Components: Other Affects Versions: 0.917 Reporter: Hontvári József Assignee: Logback dev list In an event evaluator which is called in the option part of an "ex" formatting specifier I cannot use a "throwable instanceof example" expression, because the evaluator receives a ThrowableProxy and not a Throwable. Here is a stack trace, dumped from the evaluator expression. It does include a ThrowableProxyConverter.convert call: java.lang.Exception: Stack trace at java.lang.Thread.dumpStack(Thread.java:1206) at mireka.E.f(E.java:21) at SC.eval0(SC.java:3) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.codehaus.janino.ScriptEvaluator.evaluate(ScriptEvaluator.java) at org.codehaus.janino.ScriptEvaluator.evaluate(ScriptEvaluator.java) at ch.qos.logback.core.boolex.JaninoEventEvaluatorBase.evaluat (JaninoEventEvaluatorBase.java:53) at ch.qos.logback.classic.pattern.ThrowableProxyConverter.convert(ThrowableProxyConverter.java:109) at ch.qos.logback.classic.pattern.ThrowableProxyConverter.convert(ThrowableProxyConverter.java:31) at ch.qos.logback.core.pattern.FormattingConverter.write(FormattingConverter.java:32) at ch.qos.logback.core.pattern.PatternLayoutBase.writeLoopOnConverters(PatternLayoutBase.java:110) at ch.qos.logback.classic.PatternLayout.doLayout(PatternLayout.java:132) at ch.qos.logback.classic.PatternLayout.doLayout(PatternLayout.java:51) at ch.qos.logback.core.WriterAppender.subAppend(WriterAppender.java:267) at ch.qos.logback.core.WriterAppender.append(WriterAppender.java:117) at ch.qos.logback.core.UnsynchronizedAppenderBase.doAppend(UnsynchronizedAppenderBase.java:89) at ch.qos.logback.core.spi.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:60) at ch.qos.logback.classic.Logger.appendLoopOnAppenders(Logger.java:271) at ch.qos.logback.classic.Logger.callAppenders(Logger.java:258) at ch.qos.logback.classic.Logger.buildLoggingEventAndAppend(Logger.java:440) at ch.qos.logback.classic.Logger.filterAndLog_0_Or3Plus(Logger.java:394) at ch.qos.logback.classic.Logger.debug(Logger.java:517) at org.subethamail.smtp.server.Session.run(Session.java:119) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 1