September 2009 - logback-dev

[JIRA] Created: (LBCLASSIC-119) Missing Export-Package declarations in logback-classic OSGi bundle
by Pavol Juhos (JIRA) 08 Nov '09

08 Nov '09

Missing Export-Package declarations in logback-classic OSGi bundle ------------------------------------------------------------------ Key: LBCLASSIC-119 URL: http://jira.qos.ch/browse/LBCLASSIC-119 Project: logback-classic Issue Type: Bug Components: Other Affects Versions: 0.9.15 Environment: OSGi environment Reporter: Pavol Juhos Assignee: Logback dev list Priority: Critical logback-classic OSGi bundle doesn't export logback implementation packages. These packages need to be imported by bundles implementing custom logback Appenders etc. The problem is most likely caused a misconfiguration of maven-bundle-plugin in logback-classic POM. Current configuration: <instructions> <Export-Package>ch.qos.logback.classic.*</Export-Package> <Export-Package>org.slf4j.impl;version=1.5.6</Export-Package> <Import-Package>sun.reflect;resolution:=optional, javax.jms;resolution:=optional, * </Import-Package> <Bundle-RequiredExecutionEnvironment>J2SE-1.5</Bundle-RequiredExecutionEnvironment> </instructions> Suggested configuration: <instructions> <Export-Package>ch.qos.logback.classic.*, org.slf4j.impl;version=1.5.6 </Export-Package> <Import-Package>sun.reflect;resolution:=optional, javax.jms;resolution:=optional, * </Import-Package> <Bundle-RequiredExecutionEnvironment>J2SE-1.5</Bundle-RequiredExecutionEnvironment> </instructions> Second Export-Package declaration seems to override the first one. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 1

[JIRA] Created: (LBCORE-121) Missing code for retrieving evaluators by name
by Ceki Gulcu (JIRA) 29 Sep '09

29 Sep '09

Missing code for retrieving evaluators by name ---------------------------------------------- Key: LBCORE-121 URL: http://jira.qos.ch/browse/LBCORE-121 Project: logback-core Issue Type: Bug Components: Joran Affects Versions: 0.9.17 Reporter: Ceki Gulcu Assignee: Logback dev list Evaluators are named entities, so they are in principle retrievable by name. However, for some reason, the retrieval code seems to be missing. http://www.qos.ch/pipermail/logback-user/2009-September/001324.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

branch, master, updated. 13ca0437f2069e812360f14deba53904f24ad7a9
by git-noreply＠pixie.qos.ch 26 Sep '09

26 Sep '09

The branch, master has been updated via 13ca0437f2069e812360f14deba53904f24ad7a9 (commit) from f0a9057c4c1574160f31fb8f173636602d5d0b3a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=13ca0437f2069e812360f14d… http://github.com/ceki/logback/commit/13ca0437f2069e812360f14deba53904f24ad… commit 13ca0437f2069e812360f14deba53904f24ad7a9 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Sat Sep 26 17:40:36 2009 +0200 - correct link to Jazoon presentation diff --git a/logback-site/src/site/pages/documentation.html b/logback-site/src/site/pages/documentation.html index 2efdfe8..e426b97 100644 --- a/logback-site/src/site/pages/documentation.html +++ b/logback-site/src/site/pages/documentation.html @@ -75,9 +75,13 @@ </li> <li><a - href="http://beta.parleys.com/#state=state_player&id=357">SLF4J + href="http://www.devoxx.com:5080/player/main.html#state=state_player&id=357&slide…">SLF4J and Logback projects</a>, by C. Gülcü and S. Pennec - (Jazoon presentation with audio). </li> + (Jazoon presentation with audio). If the previous link does not + work, please try the <a + href="http://beta.parleys.com/share/parleysshare2.swf?pageId=357">back + up</a>. + </li> <li><a href="http://www.infoq.com/news/2007/08/logback">Logback: Evolving Java Logging</a> by Geoffrey Wiseman ----------------------------------------------------------------------- Summary of changes: logback-site/src/site/pages/documentation.html | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

Git as a version control system?
by Ceki Gulcu 22 Sep '09

22 Sep '09

Hi all, I was wondering if we should be moving to git as our version control system. I really like the fact that git's repository is stored on the local disk. It also appears that git makes it easier for developers to contribute patches. Could anybody confirm or care to share their experiences with git? Is there anyone against using git? BR -- Ceki Gülcü Logback: The reliable, generic, fast and flexible logging framework for Java. http://logback.qos.ch

6 24

Enable the JIRA RPC interface?
by david＠davidkarlsen.com 22 Sep '09

22 Sep '09

hi. Can you enable the RPC services for JIRA - that way it's possible to use Mylyn as a frontend. -- David J. M. Karlsen - +47 90 68 22 43 http://www.davidkarlsen.com http://mp3.davidkarlsen.com

2 1

branch, master, updated. f0a9057c4c1574160f31fb8f173636602d5d0b3a
by git-noreply＠pixie.qos.ch 19 Sep '09

19 Sep '09

The branch, master has been updated via f0a9057c4c1574160f31fb8f173636602d5d0b3a (commit) from 0900ca3cdd75ee9a5bbbdfc92cc02997a4ddbaa8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=f0a9057c4c1574160f31fb8f… http://github.com/ceki/logback/commit/f0a9057c4c1574160f31fb8f173636602d5d0… commit f0a9057c4c1574160f31fb8f173636602d5d0b3a Author: Ceki Gulcu <ceki(a)qos.ch> Date: Sat Sep 19 17:54:39 2009 +0200 - corrected the expected line number in ConverterTest - fixed TimeBasedRollingWithArchiveRemovalTest.java which would fail when the number of period+currentMonth - maxHistory is placed in the previous year. - minor editing in license.html diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java index bfa1536..c1ff3b5 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java @@ -74,7 +74,7 @@ public class ConverterTest { StringBuffer buf = new StringBuffer(); converter.write(buf, le); // the number below should be the line number of the previous line - assertEquals("76", buf.toString()); + assertEquals("75", buf.toString()); } } diff --git a/logback-core/src/main/java/ch/qos/logback/core/sift/AppenderTrackerImpl.java b/logback-core/src/main/java/ch/qos/logback/core/sift/AppenderTrackerImpl.java index 1bc86b2..20cc37c 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/sift/AppenderTrackerImpl.java +++ b/logback-core/src/main/java/ch/qos/logback/core/sift/AppenderTrackerImpl.java @@ -165,9 +165,9 @@ public class AppenderTrackerImpl<E> implements AppenderTracker<E> { this.timestamp = timestamp; } - public long getTimestamp() { - return timestamp; - } +// public long getTimestamp() { +// return timestamp; +// } public void setTimestamp(long timestamp) { this.timestamp = timestamp; diff --git a/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingWithArchiveRemovalTest.java b/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingWithArchiveRemovalTest.java index 20b4f90..af4a068 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingWithArchiveRemovalTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingWithArchiveRemovalTest.java @@ -18,6 +18,7 @@ import static org.junit.Assert.assertTrue; import java.io.File; import java.io.FileFilter; import java.util.ArrayList; +import java.util.Calendar; import java.util.HashSet; import java.util.List; import java.util.Set; @@ -93,16 +94,22 @@ public class TimeBasedRollingWithArchiveRemovalTest { // large maxPeriod, a 3 times as many number of periods to simulate doRollover(randomOutputDir + "clean-%d{" + MONTHLY_DATE_PATTERN + "}.txt", MILLIS_IN_MONTH, 20, 20 * 3); - check(expectedCountWithoutDirs(20)); + check(expectedCountWithoutFolders(20)); } @Test public void montlyRolloverOverManyPeriods() throws Exception { + System.out.println("randomOutputDir=" + randomOutputDir); // small maxHistory, many periods slashCount = computeSlashCount(MONTHLY_CROLOLOG_DATE_PATTERN); + int numPeriods = 40; + int maxHistory = 2; + doRollover(randomOutputDir + "/%d{" + MONTHLY_CROLOLOG_DATE_PATTERN - + "}/clean.txt.zip", MILLIS_IN_MONTH, 2, 40); - check(expectedCountWithDirs(2)); + + "}/clean.txt.zip", MILLIS_IN_MONTH, maxHistory, numPeriods); + int beginPeriod = Calendar.getInstance().get(Calendar.MONTH); + boolean extraFolder = extraFolder(numPeriods, 12, beginPeriod, maxHistory); + check(expectedCountWithFolders(2, extraFolder)); } @Test @@ -111,7 +118,7 @@ public class TimeBasedRollingWithArchiveRemovalTest { doRollover( randomOutputDir + "clean-%d{" + DAILY_DATE_PATTERN + "}.txt.zip", MILLIS_IN_DAY, 5, 5 * 3); - check(expectedCountWithoutDirs(5)); + check(expectedCountWithoutFolders(5)); } @Test @@ -121,8 +128,8 @@ public class TimeBasedRollingWithArchiveRemovalTest { + "}/clean.txt.zip", MILLIS_IN_DAY, 8, 8 * 3); int expectedDirMin = 9 + slashCount; int expectDirMax = expectedDirMin + 1 + 1; // plus 1 of stepping into a - // new month, and another 1 into - // a new year + // new month, and another 1 into + // a new year expectedFileAndDirCount(9, expectedDirMin, expectDirMax); } @@ -253,15 +260,29 @@ public class TimeBasedRollingWithArchiveRemovalTest { } } - int expectedCountWithoutDirs(int maxHistory) { + int expectedCountWithoutFolders(int maxHistory) { // maxHistory plus the currently active file return maxHistory + 1; } - int expectedCountWithDirs(int maxHistory) { + // sometimes, after a number of periods, there is an extra folder + // from the previous "era" because the latest period - maxHistory, enters the + // bound of the previous era. For example, with a maxHistory of 2, on 2009-09, + // after 40 periods, the current period is 2013-01. Going back two months, the + // year is 2012, and not 2013 (the current year). + boolean extraFolder(int numPeriods, int periodsPerEra, int beginPeriod, + int maxHistory) { + int remainder = (beginPeriod + numPeriods) % periodsPerEra; + return (remainder < maxHistory + 1); + } + + int expectedCountWithFolders(int maxHistory, boolean extraFolder) { // each slash adds a new directory // + one file and one directory per archived log file - return (maxHistory + 1) * 2 + slashCount; + int result = (maxHistory + 1) * 2 + slashCount; + if (extraFolder) + result++; + return result; } void check(int expectedCount) { diff --git a/logback-site/src/site/pages/license.html b/logback-site/src/site/pages/license.html index 3220c12..0bc88a2 100644 --- a/logback-site/src/site/pages/license.html +++ b/logback-site/src/site/pages/license.html @@ -59,7 +59,7 @@ as published by the Free Software Foundation. On the other hand, the EPL license will placate organizations - which refuse the various restrictions imposed by the LGPL. + which refuse certain restrictions imposed by the LGPL. If you wish to make a significant contribution to the logback ----------------------------------------------------------------------- Summary of changes: .../qos/logback/classic/pattern/ConverterTest.java | 2 +- .../qos/logback/core/sift/AppenderTrackerImpl.java | 6 ++-- .../TimeBasedRollingWithArchiveRemovalTest.java | 39 +++++++++++++++----- logback-site/src/site/pages/license.html | 2 +- 4 files changed, 35 insertions(+), 14 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

branch, master, updated. 0900ca3cdd75ee9a5bbbdfc92cc02997a4ddbaa8
by git-noreply＠pixie.qos.ch 19 Sep '09

19 Sep '09

The branch, master has been updated via 0900ca3cdd75ee9a5bbbdfc92cc02997a4ddbaa8 (commit) from f307862e460187cda2436215ffc049b57f68341b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=0900ca3cdd75ee9a5bbbdfc9… http://github.com/ceki/logback/commit/0900ca3cdd75ee9a5bbbdfc92cc02997a4ddb… commit 0900ca3cdd75ee9a5bbbdfc92cc02997a4ddbaa8 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Sat Sep 19 16:39:37 2009 +0200 testing diff --git a/test.txt b/test.txt new file mode 100644 index 0000000..e69de29 ----------------------------------------------------------------------- Summary of changes: .../test/witness/rolling/tbr-test1.0 => test.txt | 0 1 files changed, 0 insertions(+), 0 deletions(-) copy logback-core/src/test/witness/rolling/tbr-test1.0 => test.txt (100%) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

Dual licensing logback
by Ceki Gulcu 17 Sep '09

17 Sep '09

Hello all, After a very long investigation resulting in a better understanding of licensing issues, I think dual-licensing logback under EPL 1.0 and LGPL 2.1 would help with the project's adoption. Licensees can then choose either the terms of the EPL or the terms of the LGPL when they use logback. The EPL license will placate organizations which refuse the restrictions imposed by the LGPL whereas the LGPL license ensures continuity in licensing and also keeps the door open for licensees already bound by the terms of (L)GPL. Comments? ps. If you intend to respond, please do so on logback-users@. -- Ceki Gülcü Logback: The reliable, generic, fast and flexible logging framework for Java. http://logback.qos.ch

1 0

[JIRA] Issue Comment Edited: (LBCORE-26) TimeBasedRollingPolicy append logs into a old log file, instead of rolling the log file.
by Ceki Gulcu (JIRA) 15 Sep '09

15 Sep '09

[ http://jira.qos.ch/browse/LBCORE-26?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu edited comment on LBCORE-26 at 9/15/09 3:29 PM: ----------------------------------------------------------- Apparently this bug has resurfaced. See http://www.qos.ch/pipermail/logback-user/2009-September/001295.html <configuration scan="true"> <appender name="LOG" class="ch.qos.logback.core.rolling.RollingFileAppender"> <file>/var/log/zeugma/selectterms/selectterms.log </file> <rollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy"> <FileNamePattern>/var/log/zeugma/selectterms/selectterms.%d{yyyy-MM-dd}.log.gz</FileNamePattern> <MaxHistory>30</MaxHistory> </rollingPolicy> <layout class="ch.qos.logback.classic.PatternLayout"> <Pattern>%date [%thread] %-5level %logger - %msg%n</Pattern> </layout> </appender> <root level="info"> <appender-ref ref="LOG" /> </root> </configuration> was (Author: noreply.ceki(a)qos.ch) Apparently this bug has resurfaced. See http://www.qos.ch/pipermail/logback-user/2009-September/001295.html > TimeBasedRollingPolicy append logs into a old log file, instead of rolling the log file. > ---------------------------------------------------------------------------------------- > > Key: LBCORE-26 > URL: http://jira.qos.ch/browse/LBCORE-26 > Project: logback-core > Issue Type: Bug > Components: Rolling > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Tsutomu YANO > Assignee: Ceki Gulcu > Priority: Critical > Fix For: 0.9.12 > > > If you use TimeBasedRollingPolicy to rollover a log file and no log wasn't wrote into the log beyond the timing of rollover, and if you restart your application, the log file doesn't roll, then new log will be appended into old log file. > EVIDENCE: > 1. in logback.xml, set your FileNamePattern like 'log.%d{yyyy-MM-dd_HH-mm}.log'. > 2. Simply do a kind of thing, which will make some logs into your log file. > 3. Wait for some minutes. > 4. restart your application. > 5. do a kind of thing, which will make some logs into your log file. > the FileNamePattern is 'log.%d{yyyy-MM-dd_HH-mm}.log', so the log file will be roll every minutes. On case 5 of above example, the log file should be roll over, because some minutes already have passed after last logs wrote into the log file. But the file didn't be roll overed. > THE CAUSE: > In start() method of TimeBasedRollingPolicy, you initialize a variable 'lastCheck' to System.currentTimeStamp(). So if you restart your application, the last check time will be set to just NOW. > you should initialize the variable to a last modified time of a current log file. > See below source code. from '//modified by Tsutomu YANO' to '//until here'. > SOURCE: > public void start() { > // set the LR for our utility object > util.setContext(this.context); > compress.setContext(this.context); > // find out period from the filename pattern > if (fileNamePatternStr != null) { > fileNamePattern = new FileNamePattern(fileNamePatternStr, this.context); > determineCompressionMode(); > } else { > addWarn(FNP_NOT_SET); > addWarn(SEE_FNP_NOT_SET); > throw new IllegalStateException(FNP_NOT_SET + SEE_FNP_NOT_SET); > } > DateTokenConverter dtc = fileNamePattern.getDateTokenConverter(); > if (dtc == null) { > throw new IllegalStateException("FileNamePattern [" + fileNamePattern.getPattern() + "] does not contain a valid DateToken"); > } > int len = fileNamePatternStr.length(); > switch (compressionMode) { > case Compress.GZ: > activeFileNamePattern = new FileNamePattern(fileNamePatternStr.substring(0, len - 3), this.context); > break; > case Compress.ZIP: > activeFileNamePattern = new FileNamePattern(fileNamePatternStr.substring(0, len - 4), this.context); > break; > case Compress.NONE: > activeFileNamePattern = fileNamePattern; > } > addInfo("Will use the pattern " + activeFileNamePattern + " for the active file"); > rc = new RollingCalendar(); > rc.init(dtc.getDatePattern()); > addInfo("The date pattern is '" + dtc.getDatePattern() + "' from file name pattern '" + fileNamePattern.getPattern() + "'."); > rc.printPeriodicity(this); > > //modified by Tsutomu YANO > //if a current log file exists, initialize a 'lastCheck' variable to the > //last modified date of the file. > File currentFile = new File(getParentFileName()); > if(currentFile.exists() && currentFile.canRead()) { > lastCheck.setTime(currentFile.lastModified()); > } else { > // currentTime = System.currentTimeMillis(); > lastCheck.setTime(getCurrentTime()); > } > //until here > > nextCheck = rc.getNextCheckMillis(lastCheck); > // Date nc = new Date(); > // nc.setTime(nextCheck); > } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Reopened: (LBCORE-26) TimeBasedRollingPolicy append logs into a old log file, instead of rolling the log file.
by Ceki Gulcu (JIRA) 15 Sep '09

15 Sep '09

[ http://jira.qos.ch/browse/LBCORE-26?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu reopened LBCORE-26: ------------------------------ Apparently this bug has resurfaced. See http://www.qos.ch/pipermail/logback-user/2009-September/001295.html > TimeBasedRollingPolicy append logs into a old log file, instead of rolling the log file. > ---------------------------------------------------------------------------------------- > > Key: LBCORE-26 > URL: http://jira.qos.ch/browse/LBCORE-26 > Project: logback-core > Issue Type: Bug > Components: Rolling > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Tsutomu YANO > Assignee: Ceki Gulcu > Priority: Critical > Fix For: 0.9.12 > > > If you use TimeBasedRollingPolicy to rollover a log file and no log wasn't wrote into the log beyond the timing of rollover, and if you restart your application, the log file doesn't roll, then new log will be appended into old log file. > EVIDENCE: > 1. in logback.xml, set your FileNamePattern like 'log.%d{yyyy-MM-dd_HH-mm}.log'. > 2. Simply do a kind of thing, which will make some logs into your log file. > 3. Wait for some minutes. > 4. restart your application. > 5. do a kind of thing, which will make some logs into your log file. > the FileNamePattern is 'log.%d{yyyy-MM-dd_HH-mm}.log', so the log file will be roll every minutes. On case 5 of above example, the log file should be roll over, because some minutes already have passed after last logs wrote into the log file. But the file didn't be roll overed. > THE CAUSE: > In start() method of TimeBasedRollingPolicy, you initialize a variable 'lastCheck' to System.currentTimeStamp(). So if you restart your application, the last check time will be set to just NOW. > you should initialize the variable to a last modified time of a current log file. > See below source code. from '//modified by Tsutomu YANO' to '//until here'. > SOURCE: > public void start() { > // set the LR for our utility object > util.setContext(this.context); > compress.setContext(this.context); > // find out period from the filename pattern > if (fileNamePatternStr != null) { > fileNamePattern = new FileNamePattern(fileNamePatternStr, this.context); > determineCompressionMode(); > } else { > addWarn(FNP_NOT_SET); > addWarn(SEE_FNP_NOT_SET); > throw new IllegalStateException(FNP_NOT_SET + SEE_FNP_NOT_SET); > } > DateTokenConverter dtc = fileNamePattern.getDateTokenConverter(); > if (dtc == null) { > throw new IllegalStateException("FileNamePattern [" + fileNamePattern.getPattern() + "] does not contain a valid DateToken"); > } > int len = fileNamePatternStr.length(); > switch (compressionMode) { > case Compress.GZ: > activeFileNamePattern = new FileNamePattern(fileNamePatternStr.substring(0, len - 3), this.context); > break; > case Compress.ZIP: > activeFileNamePattern = new FileNamePattern(fileNamePatternStr.substring(0, len - 4), this.context); > break; > case Compress.NONE: > activeFileNamePattern = fileNamePattern; > } > addInfo("Will use the pattern " + activeFileNamePattern + " for the active file"); > rc = new RollingCalendar(); > rc.init(dtc.getDatePattern()); > addInfo("The date pattern is '" + dtc.getDatePattern() + "' from file name pattern '" + fileNamePattern.getPattern() + "'."); > rc.printPeriodicity(this); > > //modified by Tsutomu YANO > //if a current log file exists, initialize a 'lastCheck' variable to the > //last modified date of the file. > File currentFile = new File(getParentFileName()); > if(currentFile.exists() && currentFile.canRead()) { > lastCheck.setTime(currentFile.lastModified()); > } else { > // currentTime = System.currentTimeMillis(); > lastCheck.setTime(getCurrentTime()); > } > //until here > > nextCheck = rc.getNextCheckMillis(lastCheck); > // Date nc = new Date(); > // nc.setTime(nextCheck); > } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0