January 2011 - logback-dev - mailman3.qos.ch

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.27-18-gef8c30e
by git-noreply＠pixie.qos.ch 18 Jan '11

18 Jan '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via ef8c30e3a4eebe0bfdf07720fee75da99b979a35 (commit) from 3bcc7b76ca93f073641e4e6b9f01dfbe1c73c0e9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=ef8c30e3a4eebe0bfdf07720… http://github.com/ceki/logback/commit/ef8c30e3a4eebe0bfdf07720fee75da99b979… commit ef8c30e3a4eebe0bfdf07720fee75da99b979a35 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Jan 18 11:40:02 2011 +0100 allow for 3 gaps diff --git a/logback-core/src/test/java/ch/qos/logback/core/util/ResilienceUtil.java b/logback-core/src/test/java/ch/qos/logback/core/util/ResilienceUtil.java index 070a0fe..95d3643 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/util/ResilienceUtil.java +++ b/logback-core/src/test/java/ch/qos/logback/core/util/ResilienceUtil.java @@ -39,7 +39,7 @@ public class ResilienceUtil { assertTrue("totalLines="+totalLines+" less than "+lowerLimit, totalLines > lowerLimit); // we want some gaps which indicate recuperation - assertTrue("gaps="+gaps+" less than 3", gaps > 3); + assertTrue("gaps="+gaps+" less than 3", gaps >= 3); } } ----------------------------------------------------------------------- Summary of changes: .../ch/qos/logback/core/util/ResilienceUtil.java | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.27-17-g3bcc7b7
by git-noreply＠pixie.qos.ch 18 Jan '11

18 Jan '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 3bcc7b76ca93f073641e4e6b9f01dfbe1c73c0e9 (commit) from cc3b519ef885a7e779a6c179867dc05a51de81ff (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=3bcc7b76ca93f073641e4e6b… http://github.com/ceki/logback/commit/3bcc7b76ca93f073641e4e6b9f01dfbe1c73c… commit 3bcc7b76ca93f073641e4e6b9f01dfbe1c73c0e9 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Jan 18 11:38:41 2011 +0100 lower the bound to 60% diff --git a/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilience_AS_ROOT_Test.java b/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilience_AS_ROOT_Test.java index b556ea6..345e89a 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilience_AS_ROOT_Test.java +++ b/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilience_AS_ROOT_Test.java @@ -117,7 +117,7 @@ public class FileAppenderResilience_AS_ROOT_Test { p.waitFor(); // the extrernal script has the file system ready for IO 50% of the time double bestCase = 0.5; - ResilienceUtil.verify(logfileStr, "^(\\d{1,3}) x*$", NUM_STEPS, bestCase*0.7); + ResilienceUtil.verify(logfileStr, "^(\\d{1,3}) x*$", NUM_STEPS, bestCase*0.6); System.out.println("Done go"); } ----------------------------------------------------------------------- Summary of changes: .../core/FileAppenderResilience_AS_ROOT_Test.java | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.27-16-gcc3b519
by git-noreply＠pixie.qos.ch 18 Jan '11

18 Jan '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via cc3b519ef885a7e779a6c179867dc05a51de81ff (commit) from 85d47057b85ae7f800915418ef8c3549322effd4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=cc3b519ef885a7e779a6c179… http://github.com/ceki/logback/commit/cc3b519ef885a7e779a6c179867dc05a51de8… commit cc3b519ef885a7e779a6c179867dc05a51de81ff Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Jan 18 11:34:37 2011 +0100 let the caller determine the success ratio lower bound diff --git a/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilienceTest.java b/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilienceTest.java index 497caad..960c63a 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilienceTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilienceTest.java @@ -76,7 +76,7 @@ public class FileAppenderResilienceTest { double bestCaseSuccessRatio = 1/delayCoeff; ResilienceUtil - .verify(logfileStr, "^hello (\\d{1,5})$", runner.getCounter(), bestCaseSuccessRatio); + .verify(logfileStr, "^hello (\\d{1,5})$", runner.getCounter(), bestCaseSuccessRatio*0.9); } } diff --git a/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilience_AS_ROOT_Test.java b/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilience_AS_ROOT_Test.java index 2e39ae6..b556ea6 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilience_AS_ROOT_Test.java +++ b/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilience_AS_ROOT_Test.java @@ -117,7 +117,7 @@ public class FileAppenderResilience_AS_ROOT_Test { p.waitFor(); // the extrernal script has the file system ready for IO 50% of the time double bestCase = 0.5; - ResilienceUtil.verify(logfileStr, "^(\\d{1,3}) x*$", NUM_STEPS, bestCase); + ResilienceUtil.verify(logfileStr, "^(\\d{1,3}) x*$", NUM_STEPS, bestCase*0.7); System.out.println("Done go"); } diff --git a/logback-core/src/test/java/ch/qos/logback/core/util/ResilienceUtil.java b/logback-core/src/test/java/ch/qos/logback/core/util/ResilienceUtil.java index 6119fb9..070a0fe 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/util/ResilienceUtil.java +++ b/logback-core/src/test/java/ch/qos/logback/core/util/ResilienceUtil.java @@ -11,7 +11,7 @@ import java.util.regex.Pattern; public class ResilienceUtil { - static public void verify(String logfile, String regexp, long totalSteps, double bestCaseSuccessRatio) throws NumberFormatException, IOException { + static public void verify(String logfile, String regexp, long totalSteps, double successRatioLowerBound) throws NumberFormatException, IOException { FileReader fr = new FileReader(logfile); BufferedReader br = new BufferedReader(fr); Pattern p = Pattern.compile(regexp); @@ -35,7 +35,6 @@ public class ResilienceUtil { fr.close(); br.close(); - double successRatioLowerBound = bestCaseSuccessRatio * 0.9; int lowerLimit = (int) (totalSteps*successRatioLowerBound); assertTrue("totalLines="+totalLines+" less than "+lowerLimit, totalLines > lowerLimit); ----------------------------------------------------------------------- Summary of changes: .../logback/core/FileAppenderResilienceTest.java | 2 +- .../core/FileAppenderResilience_AS_ROOT_Test.java | 2 +- .../ch/qos/logback/core/util/ResilienceUtil.java | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.27-15-g85d4705
by git-noreply＠pixie.qos.ch 18 Jan '11

18 Jan '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 85d47057b85ae7f800915418ef8c3549322effd4 (commit) from 81b32976042ead74528173abd18b456df43023f7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=85d47057b85ae7f800915418… http://github.com/ceki/logback/commit/85d47057b85ae7f800915418ef8c3549322ef… commit 85d47057b85ae7f800915418ef8c3549322effd4 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Jan 18 11:26:37 2011 +0100 failed renaming tests does not seems to work on Linux where renaming succeeds... diff --git a/logback-core/src/test/scala/ch/qos/logback/core/rolling/TimeBasedRolling2Test.scala b/logback-core/src/test/scala/ch/qos/logback/core/rolling/TimeBasedRolling2Test.scala index 97af666..2a94519 100644 --- a/logback-core/src/test/scala/ch/qos/logback/core/rolling/TimeBasedRolling2Test.scala +++ b/logback-core/src/test/scala/ch/qos/logback/core/rolling/TimeBasedRolling2Test.scala @@ -19,6 +19,7 @@ import org.junit.Test import ch.qos.logback.core.encoder.EchoEncoder import java.io.{FileOutputStream, File} import ch.qos.logback.core.util.{StatusPrinter, Compare, CoreTestConstants} +import ch.qos.logback.core.testUtil.Env class TimeBasedRolling2Test extends RollingScaffolding { @@ -176,7 +177,9 @@ class TimeBasedRolling2Test extends RollingScaffolding { @Test - def failed_rename = { + def failed_rename: Unit = { + + if(!Env.isWindows) return null var fos: FileOutputStream = null try { ----------------------------------------------------------------------- Summary of changes: .../core/rolling/TimeBasedRolling2Test.scala | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.27-14-g81b3297
by git-noreply＠pixie.qos.ch 17 Jan '11

17 Jan '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 81b32976042ead74528173abd18b456df43023f7 (commit) from 5b0b5091b70745f7ba3bbc65da0d948a936d2b56 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=81b32976042ead74528173ab… http://github.com/ceki/logback/commit/81b32976042ead74528173abd18b456df4302… commit 81b32976042ead74528173abd18b456df43023f7 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Mon Jan 17 23:05:24 2011 +0100 ongoing work diff --git a/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java b/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java index dc84dec..fe75250 100644 --- a/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java +++ b/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java @@ -265,7 +265,7 @@ public class LogbackValve extends ValveBase implements Lifecycle, Context, this.name = name; } - public long getBithTime() { + public long getBirthTime() { return birthTime; } diff --git a/logback-site/src/site/pages/codes.html b/logback-site/src/site/pages/codes.html index 53df822..72d04d1 100644 --- a/logback-site/src/site/pages/codes.html +++ b/logback-site/src/site/pages/codes.html @@ -366,6 +366,13 @@ is invoked. + On the Windows platform, <a + href="http://technet.microsoft.com/en-us/sysinternals/bb896653">Process + Explorer</a> can help you locate the processes which reference a + given file (Find -> Find Handle or DLL). On Linux, you can use + the <a href="http://www.manpagez.com/man/8/lsof/">lsof</a> command + to find which process has a file open. + In practice, it can be hard to ensure that there are no file handle references to log files. It can be easier to avoid file renaming altogether. As a first step, let us note that for ----------------------------------------------------------------------- Summary of changes: .../ch/qos/logback/access/tomcat/LogbackValve.java | 2 +- logback-site/src/site/pages/codes.html | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBSITE-42) SMTPHost property name incorrect in documentation
by Jay Taylor (JIRA) 17 Jan '11

17 Jan '11

SMTPHost property name incorrect in documentation ------------------------------------------------- Key: LBSITE-42 URL: http://jira.qos.ch/browse/LBSITE-42 Project: logback-site Issue Type: Bug Components: Documentation Affects Versions: 0.9.26 Environment: Linux hostname-03 2.6.27-17-server #1 SMP Fri Mar 12 04:04:33 UTC 2010 i686 GNU/Linux Reporter: Jay Taylor Assignee: Logback dev list Priority: Trivial The following documentation appears to have some incorrect information: http://logback.qos.ch/manual/appenders.html#SMTPAppender The table includes a property named "smtpHost". Using this value results in logback ignoring the setting and attempting to send mail through localhost. The correct property name appears to be "SMTPHost". The documentation also states that the parameter is mandatory. It appears to fall back to localhost if it is not encountered (perhaps java-mail is doing that). I would assume that "smtpPort" is incorrect too based on the setter name of "SMTPPort" in SMTPAppenderBase. Log info: |-INFO in ch.qos.logback.core.joran.action.AppenderAction - About to instantiate appender of type [ch.qos.logback.classic.net.SMTPAppender] |-INFO in ch.qos.logback.core.joran.action.AppenderAction - Naming appender as [TEST] |-ERROR in ch.qos.logback.core.joran.spi.Interpreter@22:13 - no applicable action for [smtpHost], current pattern is [[configuration][appender][smtpHost]] |-INFO in ch.qos.logback.core.joran.action.AppenderAction - About to instantiate appender of type [ch.qos.logback.classic.net.SMTPAppender] ... |-ERROR in ch.qos.logback.classic.net.SMTPAppender[POR] - Error occured while sending e-mail notification. javax.mail.SendFailedException: Send failure (javax.mail.MessagingException: Could not connect to SMTP host: localhost, port: 25 (java.net.ConnectException: Connection refused)) at javax.mail.SendFailedException: Send failure (javax.mail.MessagingException: Could not connect to SMTP host: localhost, port: 25 (java.net.ConnectException: Connection refused)) at at javax.mail.Transport.send(Transport.java:163) at at javax.mail.Transport.send(Transport.java:48) at at ch.qos.logback.core.net.SMTPAppenderBase.sendBuffer(SMTPAppenderBase.java:323) at at ch.qos.logback.core.net.SMTPAppenderBase.append(SMTPAppenderBase.java:181) at at ch.qos.logback.core.AppenderBase.doAppend(AppenderBase.java:85) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 4

[JIRA] Created: (LBCORE-187) TimestampAction should base current time on LoggerContext birthtime field
by Ceki Gulcu (JIRA) 17 Jan '11

17 Jan '11

TimestampAction should base current time on LoggerContext birthtime field ------------------------------------------------------------------------- Key: LBCORE-187 URL: http://jira.qos.ch/browse/LBCORE-187 Project: logback-core Issue Type: Bug Affects Versions: 0.9.26 Reporter: Ceki Gulcu Assignee: Logback dev list As things stand currently, TimestampAction uses the date of invocation of the config file as the value to format and place as a property. Under certain circumstances, it might be useful to take the context's birth date as input value. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 4

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.27-13-g5b0b509
by git-noreply＠pixie.qos.ch 17 Jan '11

17 Jan '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 5b0b5091b70745f7ba3bbc65da0d948a936d2b56 (commit) from 20233406053eb9803270621f59386f9602827dba (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=5b0b5091b70745f7ba3bbc65… http://github.com/ceki/logback/commit/5b0b5091b70745f7ba3bbc65da0d948a936d2… commit 5b0b5091b70745f7ba3bbc65da0d948a936d2b56 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Mon Jan 17 21:05:24 2011 +0100 new sample config file diff --git a/logback-examples/src/main/java/chapters/appenders/conf/logback-timestamp-contextBirth.xml b/logback-examples/src/main/java/chapters/appenders/conf/logback-timestamp-contextBirth.xml new file mode 100644 index 0000000..58f39dc --- /dev/null +++ b/logback-examples/src/main/java/chapters/appenders/conf/logback-timestamp-contextBirth.xml @@ -0,0 +1,22 @@ +<configuration> + +  + <timestamp key="bySecond" datePattern="yyyyMMdd'T'HHmmss" + timeReference="contextBirth"/> + + <appender name="FILE" class="ch.qos.logback.core.FileAppender"> +  + <file>log-${bySecond}.txt</file> + <encoder> + <pattern>%logger{35} - %msg%n</pattern> + </encoder> + </appender> + + <root level="DEBUG"> + <appender-ref ref="FILE" /> + </root> +</configuration> ----------------------------------------------------------------------- Summary of changes: ...tamp.xml => logback-timestamp-contextBirth.xml} | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) copy logback-examples/src/main/java/chapters/appenders/conf/{logback-timestamp.xml => logback-timestamp-contextBirth.xml} (54%) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.27-12-g2023340
by git-noreply＠pixie.qos.ch 17 Jan '11

17 Jan '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 20233406053eb9803270621f59386f9602827dba (commit) from af3d5737f6caae2471a3881d6c9c14191c71d4ed (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=20233406053eb9803270621f… http://github.com/ceki/logback/commit/20233406053eb9803270621f59386f9602827… commit 20233406053eb9803270621f59386f9602827dba Author: Ceki Gulcu <ceki(a)qos.ch> Date: Mon Jan 17 21:02:40 2011 +0100 - renamed context bithTime property as birthTime - added support for timeReference attribute in the the timestamp element in config files (XML and Groovy) diff --git a/logback-classic/src/main/groovy/ch/qos/logback/classic/gaffer/ConfigurationDelegate.groovy b/logback-classic/src/main/groovy/ch/qos/logback/classic/gaffer/ConfigurationDelegate.groovy index 8feb3cd..8193d52 100644 --- a/logback-classic/src/main/groovy/ch/qos/logback/classic/gaffer/ConfigurationDelegate.groovy +++ b/logback-classic/src/main/groovy/ch/qos/logback/classic/gaffer/ConfigurationDelegate.groovy @@ -29,7 +29,8 @@ import ch.qos.logback.core.status.StatusListener import java.text.SimpleDateFormat import ch.qos.logback.classic.turbo.TurboFilter import ch.qos.logback.core.CoreConstants -import ch.qos.logback.core.util.ContextUtil; +import ch.qos.logback.core.util.ContextUtil +import ch.qos.logback.core.joran.action.TimestampAction; /** * @author Ceki Gücü @@ -156,9 +157,18 @@ public class ConfigurationDelegate extends ContextAwareBase { context.addTurboFilter(turboFilter) } - String timestamp(String datePattern) { + String timestamp(String datePattern, long timeReference = -1) { + Date reference = null; + + if(timeReference == -1) { + addInfo("Using current interpretation time, i.e. now, as time reference."); + reference = new Date() + } else { + reference = new Date(timeReference) + addInfo("Using " + reference +" as time reference."); + } SimpleDateFormat sdf = new SimpleDateFormat(datePattern); - sdf.format(new Date()); + sdf.format(reference) } } diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/spi/LoggerContextVO.java b/logback-classic/src/main/java/ch/qos/logback/classic/spi/LoggerContextVO.java index 5289051..d2c2e36 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/spi/LoggerContextVO.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/spi/LoggerContextVO.java @@ -44,7 +44,7 @@ public class LoggerContextVO implements Serializable { public LoggerContextVO(LoggerContext lc) { this.name = lc.getName(); this.propertyMap = lc.getCopyOfPropertyMap(); - this.birthTime = lc.getBithTime(); + this.birthTime = lc.getBirthTime(); } public String getName() { diff --git a/logback-classic/src/test/groovy/ch/qos/logback/classic/gaffer/ConfigurationDelegateTest.groovy b/logback-classic/src/test/groovy/ch/qos/logback/classic/gaffer/ConfigurationDelegateTest.groovy index 2e5d65f..427d743 100644 --- a/logback-classic/src/test/groovy/ch/qos/logback/classic/gaffer/ConfigurationDelegateTest.groovy +++ b/logback-classic/src/test/groovy/ch/qos/logback/classic/gaffer/ConfigurationDelegateTest.groovy @@ -22,6 +22,7 @@ import ch.qos.logback.core.rolling.TimeBasedRollingPolicy import ch.qos.logback.classic.encoder.PatternLayoutEncoder import ch.qos.logback.core.util.CoreTestConstants import ch.qos.logback.core.rolling.SizeAndTimeBasedFNATP +import ch.qos.logback.core.joran.action.TimestampAction /** * @author Ceki Gücü @@ -66,6 +67,13 @@ class ConfigurationDelegateTest { assertEquals(year.toString(), result) } + @Test + void timestampWithContextBirthAsReference() { + String result = configurationDelegate.timestamp("yyyy", context.birthTime) + long year = Calendar.getInstance().get(Calendar.YEAR); + assertEquals(year.toString(), result) + } + @Test void loggerWithoutName() { diff --git a/logback-core/src/main/java/ch/qos/logback/core/Context.java b/logback-core/src/main/java/ch/qos/logback/core/Context.java index d348f30..c750620 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/Context.java +++ b/logback-core/src/main/java/ch/qos/logback/core/Context.java @@ -95,7 +95,7 @@ public interface Context extends PropertyContainer { * * @return The time as measured when this class was created. */ - public long getBithTime(); + public long getBirthTime(); /** * Object used for synchronization purposes. diff --git a/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java b/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java index f811400..b091759 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java +++ b/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java @@ -118,7 +118,7 @@ public class ContextBase implements Context { } } - public long getBithTime() { + public long getBirthTime() { return birthTime; } diff --git a/logback-core/src/main/java/ch/qos/logback/core/joran/action/TimestampAction.java b/logback-core/src/main/java/ch/qos/logback/core/joran/action/TimestampAction.java index 6c1ad3a..d252773 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/joran/action/TimestampAction.java +++ b/logback-core/src/main/java/ch/qos/logback/core/joran/action/TimestampAction.java @@ -32,6 +32,8 @@ import ch.qos.logback.core.util.OptionHelper; */ public class TimestampAction extends Action { static String DATE_PATTERN_ATTRIBUTE = "datePattern"; + static String TIME_REFERENCE_ATTRIBUTE = "timeReference"; + static String CONTEXT_BIRTH = "contextBirth"; boolean inError = false; @@ -40,7 +42,7 @@ public class TimestampAction extends Action { throws ActionException { String keyStr = attributes.getValue(KEY_ATTRIBUTE); if (OptionHelper.isEmpty(keyStr)) { - addError("Attrubute named [" + KEY_ATTRIBUTE + "] cannot be empty"); + addError("Attribute named [" + KEY_ATTRIBUTE + "] cannot be empty"); inError = true; } String datePatternStr = attributes.getValue(DATE_PATTERN_ATTRIBUTE); @@ -50,11 +52,22 @@ public class TimestampAction extends Action { inError = true; } + String timeReferenceStr = attributes.getValue(TIME_REFERENCE_ATTRIBUTE); + Date timeReference = null; + if (CONTEXT_BIRTH.equalsIgnoreCase(timeReferenceStr)) { + addInfo("Using context birth as time reference."); + timeReference = new Date(context.getBirthTime()); + } else { + timeReference = new Date(); + addInfo("Using current interpretation time, i.e. now, as time reference."); + } + + if (inError) return; SimpleDateFormat sdf = new SimpleDateFormat(datePatternStr); - String val = sdf.format(new Date()); + String val = sdf.format(timeReference); addInfo("Adding property to the context with key=\"" + keyStr + "\" and value=\"" + val + "\" to the context"); diff --git a/logback-site/src/site/pages/manual/appenders.html b/logback-site/src/site/pages/manual/appenders.html index a71913d..e7d6d4a 100644 --- a/logback-site/src/site/pages/manual/appenders.html +++ b/logback-site/src/site/pages/manual/appenders.html @@ -546,23 +546,47 @@ public interface Appender<E> extends LifeCycle, ContextAware, FilterAttachabl </configuration></pre> - The timestamp element takes two attributes key and datePattern. The key - attribute is the name of the key under which the timestamp will be - available to subsequent configuration elements <a + The timestamp element takes two mandatory attributes key and datePattern + and an optional timeReference + attribute. The key attribute is the name + of the key under which the timestamp will be available to + subsequent configuration elements <a href="configuration.html#variableSubstitution">as a variable</a>. The datePattern attribute denotes the date pattern used to convert the current time (at which the configuration file is parsed) into a string. The date pattern should follow the conventions defined in <a - href="http://java.sun.com/j2se/1.4.2/docs/api/java/text/SimpleDateFormat.html">SimpleDateFormat</a>. + href="http://java.sun.com/j2se/1.4.2/docs/api/java/text/SimpleDateFormat.html">SimpleDateFormat</a>. The + timeReference attribute denotes the time + reference for the time stamp. The default is the + interpretation/parsing time of the configuration file, i.e. the + current time. However, under certain circumstances it might be + useful to use the context birth time as time reference. This can be + accomplished by setting the timeReference + attribute to <code>"contextBirth"</code>. - Experiment with by running the command: + Experiment with the <code><timestamp></code> element by + running the command: java chapters.appenders.ConfigurationTester src/main/java/chapters/appenders/conf/logback-timestamp.xml + To use the logger context birth date as time reference, you + would set the timeReference attribute to + "contextBirth" as shown below. + + + Example: Timestamp using context birth date as time reference + (logback-examples/src/main/java/chapters/appenders/conf/logback-timestamp-contextBirth.xml) + + View as .groovy + <pre id="logback-timestamp-contextBirth" class="prettyprint source"><configuration> + <timestamp key="bySecond" datePattern="yyyyMMdd'T'HHmmss" + timeReference="contextBirth"/> + ... +</configuration></pre> + <h2> <a name="RollingFileAppender" href="#RollingFileAppender">RollingFileAppender</a> </h2> diff --git a/logback-site/src/site/pages/manual/groovy.html b/logback-site/src/site/pages/manual/groovy.html index 8e06a19..e7fba36 100644 --- a/logback-site/src/site/pages/manual/groovy.html +++ b/logback-site/src/site/pages/manual/groovy.html @@ -216,18 +216,24 @@ root(DEBUG, ["FILE"])</pre>  - <h3>• timestamp(String datePattern)</h3> + <h3>• timestamp(String datePattern, long timeReference = -1)</h3> The <code>timestamp()</code> method method returns a string - corresponding to the current time formatted according to the - <code>datePattern</code> passed as a parameter. The datePattern - parameter should follow the conventions defined by <a - href="http://java.sun.com/j2se/1.4.2/docs/api/java/text/SimpleDateFormat.html">SimpleDateFormat</a>. + corresponding to the <code>timeReference</code> parameter + formatted according to the <code>datePattern</code> parameter. The + <code>datePattern</code> parameter should follow the conventions + defined by <a + href="http://java.sun.com/j2se/1.4.2/docs/api/java/text/SimpleDateFormat.html">SimpleDateFormat</a>. If + the <code>timeReference</code> value is unspecified, it defaults + to -1, in which case current time, that is time when the + configuration file is parsed, is used as the time + reference. Depending on the circumstances, occasion, you might + wish to use <code>context.birthTime</code> as the time reference. In the next example, the <code>bySecond</code> variable is assigned the current time in the "yyyyMMdd'T'HHmmss" format. The - bySecond variable is then used to define the value of the file property. diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index 57a55fb..fd6ee67 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -30,6 +30,21 @@ <h3>January xx, 2011 - Release of version 0.9.28</h3> + <div style="border: 1px solid #F44; background-color: #FED; padding-left: 1ex; padding-right: 1ex;"> + + <h4>Breaking change: In the Context interface, the previously + misspelled property <code>bithTime</code> is now renamed as + <code>birthTime</code>.</h4> + + In the <a + href="apidocs/ch/qos/logback/core/Context.html">Context</a> + interface, the previously misspelled property + <code>bithTime</code> ia now renamed as + <code>birthTime</code>. This is a backward-incompatible + change. All pre-existing references to "bithTime" property now + need to referenced as "birthTime". + </div> + Fixed <a href="http://jira.qos.ch/browse/LBCLASSIC-238">issue 238</a> reported by Robert Elliot. <code>GEventEvaluator</code>'s start method now correctly sets the state of the instance. @@ -40,6 +55,11 @@ href="http://jira.qos.ch/browse/LBCLASSIC-239">LBCLASSIC-239</a> reported by Artyom Kalita. + It is now possible to use the context birth time as the time + reference for the <a + href="manual/appenders.html#uniquelyNamed"><code><timestamp></code></a> + element in configuration files. + <hr width="80%" align="center" /> <h3>December 22nd, 2010 - Release of version 0.9.27</h3> ----------------------------------------------------------------------- Summary of changes: .../classic/gaffer/ConfigurationDelegate.groovy | 16 +++++++-- .../qos/logback/classic/spi/LoggerContextVO.java | 2 +- .../gaffer/ConfigurationDelegateTest.groovy | 8 ++++ .../src/main/java/ch/qos/logback/core/Context.java | 2 +- .../main/java/ch/qos/logback/core/ContextBase.java | 2 +- .../logback/core/joran/action/TimestampAction.java | 17 ++++++++- logback-site/src/site/pages/manual/appenders.html | 38 ++++++++++++++++---- logback-site/src/site/pages/manual/groovy.html | 18 ++++++--- logback-site/src/site/pages/news.html | 20 ++++++++++ 9 files changed, 102 insertions(+), 21 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.27-11-gaf3d573
by git-noreply＠pixie.qos.ch 17 Jan '11

17 Jan '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via af3d5737f6caae2471a3881d6c9c14191c71d4ed (commit) from 5d5e0dad21d8449ae5e870638b1270b6cd944ad3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=af3d5737f6caae2471a3881d… http://github.com/ceki/logback/commit/af3d5737f6caae2471a3881d6c9c14191c71d… commit af3d5737f6caae2471a3881d6c9c14191c71d4ed Author: Ceki Gulcu <ceki(a)qos.ch> Date: Mon Jan 17 17:15:17 2011 +0100 doc on renaming errors diff --git a/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java b/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java index 9cb62d5..40d3713 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java +++ b/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java @@ -86,7 +86,7 @@ public class TimeBasedRollingPolicy<E> extends RollingPolicyBase implements // the maxHistory property is given to TimeBasedRollingPolicy instead of to // the TimeBasedFileNamingAndTriggeringPolicy. This makes it more convenient - // for the user at the cost of inconsistency at the level of this code. + // for the user at the cost of inconsistency here. if (maxHistory != NO_DELETE_HISTORY) { archiveRemover = timeBasedFileNamingAndTriggeringPolicy.getArchiveRemover(); archiveRemover.setMaxHistory(maxHistory); diff --git a/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilienceTest.java b/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilienceTest.java index fa8ca4b..497caad 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilienceTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/FileAppenderResilienceTest.java @@ -74,9 +74,9 @@ public class FileAppenderResilienceTest { runner.setDone(true); t.join(); - double bestCase = 1/delayCoeff; + double bestCaseSuccessRatio = 1/delayCoeff; ResilienceUtil - .verify(logfileStr, "^hello (\\d{1,5})$", runner.getCounter(), bestCase); + .verify(logfileStr, "^hello (\\d{1,5})$", runner.getCounter(), bestCaseSuccessRatio); } } diff --git a/logback-core/src/test/java/ch/qos/logback/core/util/ResilienceUtil.java b/logback-core/src/test/java/ch/qos/logback/core/util/ResilienceUtil.java index 9a8d2e5..6119fb9 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/util/ResilienceUtil.java +++ b/logback-core/src/test/java/ch/qos/logback/core/util/ResilienceUtil.java @@ -11,7 +11,7 @@ import java.util.regex.Pattern; public class ResilienceUtil { - static public void verify(String logfile, String regexp, long totalSteps, double bestCase) throws NumberFormatException, IOException { + static public void verify(String logfile, String regexp, long totalSteps, double bestCaseSuccessRatio) throws NumberFormatException, IOException { FileReader fr = new FileReader(logfile); BufferedReader br = new BufferedReader(fr); Pattern p = Pattern.compile(regexp); @@ -35,9 +35,8 @@ public class ResilienceUtil { fr.close(); br.close(); - double expectedSuccessRate = bestCase * 0.7; - // at least 40% of the logs should have been written - int lowerLimit = (int) (totalSteps*expectedSuccessRate); + double successRatioLowerBound = bestCaseSuccessRatio * 0.9; + int lowerLimit = (int) (totalSteps*successRatioLowerBound); assertTrue("totalLines="+totalLines+" less than "+lowerLimit, totalLines > lowerLimit); // we want some gaps which indicate recuperation diff --git a/logback-core/src/test/scala/ch/qos/logback/core/rolling/TimeBasedRolling2Test.scala b/logback-core/src/test/scala/ch/qos/logback/core/rolling/TimeBasedRolling2Test.scala index eb94065..97af666 100644 --- a/logback-core/src/test/scala/ch/qos/logback/core/rolling/TimeBasedRolling2Test.scala +++ b/logback-core/src/test/scala/ch/qos/logback/core/rolling/TimeBasedRolling2Test.scala @@ -176,7 +176,7 @@ class TimeBasedRolling2Test extends RollingScaffolding { @Test - def renaming = { + def failed_rename = { var fos: FileOutputStream = null try { diff --git a/logback-site/src/site/pages/codes.html b/logback-site/src/site/pages/codes.html index a959b31..53df822 100644 --- a/logback-site/src/site/pages/codes.html +++ b/logback-site/src/site/pages/codes.html @@ -352,20 +352,47 @@ <hr/> - <a name="renamingError" href="#renamingError">Failed to rename file [x]] to [y]</a> + <a name="renamingError" href="#renamingError">Failed to rename file [x] to [y].</a> A log file cannot be renamed if there are handles referencing that file. For example, when the file is read by another process - such as less, tail, etc. During application hot redeployment, the - old instance of the application will have open references to the log - file as long as the old instance is not gargabe collected. - - - File renaming problems can be avoided altogether if the less</code>, <code>tail</code>, etc. During + application hot-redeployment, the old instance of the application + will have open references to log files until the old instance is + completely shutdown or until the <code>stop()</code> method on its + <a + href="apidocs/ch/qos/logback/classic/LoggerContext.html"><code>LoggerContext</code></a> + is invoked. + + + In practice, it can be hard to ensure that there are no file + handle references to log files. It can be easier to avoid file + renaming altogether. As a first step, let us note that for + <code>TimeBasedRollingPolicy</code>, the file option can be omitted. If omitted, no + file renaming will be performed during roll over. Thus, in order to + avoid file renaming errors just leave blank the file option of - <code>RollingFileAppender</code> is left blank. + <code>RollingFileAppender</code>, as shown in the next configuration + snippet. + + <pre class="prettyprint source"><appender name="FILE" class="ch.qos.logback.core.rolling.RollingFileAppender"> +  + <rollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy"> + <fileNamePattern>mylog.%d{yyyy-MM-dd}.log</fileNamePattern> + </rollingPolicy> + + <encoder> + <pattern>%relative [%thread] %level %logger - %msg%n</pattern> + </encoder> +</appender></pre> + + For <code>FixedWindowRollingPolicy</code>, the file option is + mandatory. + + <hr/> diff --git a/logback-site/src/site/pages/manual/appenders.html b/logback-site/src/site/pages/manual/appenders.html index a37f67c..a71913d 100644 --- a/logback-site/src/site/pages/manual/appenders.html +++ b/logback-site/src/site/pages/manual/appenders.html @@ -709,185 +709,9 @@ public interface RollingPolicy extends LifeCycle { its parent via the <code>setParent</code> method. - <h4> - <a name="FixedWindowRollingPolicy" - href="#FixedWindowRollingPolicy">FixedWindowRollingPolicy</a> - </h4> - - When rolling over, <a - href="../xref/ch/qos/logback/core/rolling/FixedWindowRollingPolicy.html"> - <code>FixedWindowRollingPolicy</code></a> renames files according - to a fixed window algorithm as described below. - - - The fileNamePattern option - represents the file name pattern for the archived (rolled over) log - files. This option is required and must include an integer token - %i somewhere within the pattern. - - - Here are the available properties for - <code>FixedWindowRollingPolicy</code> - - - <table class="bodyTable"> - <tr class="a"> - <th>Property Name</th> - <th>Type</th> - <th>Description</th> - </tr> - <tr class="b"> - <td>minIndex</td> - <td><code>int</code></td> - <td> - This option represents the lower bound for the window's - index. - - </td> - </tr> - <tr class="a"> - <td>maxIndex</td> - <td><code>int</code></td> - <td> - This option represents the upper bound for the window's - index. - - </td> - </tr> - <tr class="b"> - <td>fileNamePattern</td> - <td><code>String</code></td> - <td> - This option represents the pattern that will be followed - by the <code>FixedWindowRollingPolicy</code> when renaming - the log files. It must contain the string %i, which - will indicate the position where the value of the current - window index will be inserted. - - For example, using MyLogFile%i.log associated - with minimum and maximum values of 1 and 3 - will produce archive files named MyLogFile1.log, - MyLogFile2.log and MyLogFile3.log. - - Note that file compression is also specified via this - property. For example, fileNamePattern set to - MyLogFile%i.log.zip means that archived files must be - compressed using the zip format; gz format - is also supported. - - </td> - </tr> - </table> - - Given that the fixed window rolling policy requires as many file - renaming operations as the window size, large window sizes are - strongly discouraged. When large values are specified by the user, - the current implementation will automatically reduce the window - size to 12. - - - Let us go over a more concrete example of the fixed window - rollover policy. Suppose that minIndex - is set to 1, maxIndex set to - 3, fileNamePattern property - set to foo%i.log, and that fileNamePattern property is set to - foo.log. - - - <table class="bodyTable"> - <tr class="a"> - <th>Number of rollovers</th> - <th>Active output target</th> - <th>Archived log files</th> - <th>Description</th> - </tr> - <tr class="b"> - <td>0</td> - <td>foo.log</td> - <td>-</td> - <td>No rollover has happened yet, logback logs into the initial - file. - </td> - </tr> - <tr class="a"> - <td>1</td> - <td>foo.log</td> - <td>foo1.log</td> - <td>First rollover. foo.log is renamed as - foo1.log. A new foo.log file is created and - becomes the active output target. - </td> - </tr> - <tr class="b"> - <td>2</td> - <td>foo.log</td> - <td>foo1.log, foo2.log</td> - <td>Second rollover. foo1.log is renamed as - foo2.log. foo.log is renamed as - foo1.log. A new foo.log file is created and - becomes the active output target. - </td> - </tr> - <tr class="a"> - <td>3</td> - <td>foo.log</td> - <td>foo1.log, foo2.log, foo3.log</td> - <td>Third rollover. foo2.log is renamed as - foo3.log. foo1.log is renamed as - foo2.log. foo.log is renamed as - foo1.log. A new foo.log file is created and - becomes the active output target. - </td> - </tr> - <tr class="b"> - <td>4</td> - <td>foo.log</td> - <td>foo1.log, foo2.log, foo3.log</td> - <td>In this and subsequent rounds, the rollover begins by - deleting foo3.log. Other files are renamed by - incrementing their index as shown in previous steps. In this and - subsequent rollovers, there will be three archive logs and one - active log file. - </td> - </tr> - </table> - - The configuration file below gives an example of configuring - <code>RollingFileAppender</code> and - <code>FixedWindowRollingPolicy</code>. Note that the File option is mandatory even if it contains - some of the same information as conveyed with the fileNamePattern option. - - - Example: Sample configuration of a <code>RollingFileAppender</code> using a - <code>FixedWindowRollingPolicy</code> (logback-examples/src/main/java/chapters/appenders/conf/logback-RollingFixedWindow.xml) +  - View as .groovy - <pre id="logback-RollingFixedWindow" class="prettyprint source"><configuration> - <appender name="FILE" class="ch.qos.logback.core.rolling.RollingFileAppender"> - <file>test.log</file> - - <rollingPolicy class="ch.qos.logback.core.rolling.FixedWindowRollingPolicy"> - <fileNamePattern>tests.%i.log.zip</fileNamePattern> - <minIndex>1</minIndex> - <maxIndex>3</maxIndex> - </rollingPolicy> - - <triggeringPolicy class="ch.qos.logback.core.rolling.SizeBasedTriggeringPolicy"> - <maxFileSize>5MB</maxFileSize> - </triggeringPolicy> - <encoder> - <pattern>%-4relative [%thread] %-5level %logger{35} - %msg%n</pattern> - </encoder> - </appender> - - <root level="DEBUG"> - <appender-ref ref="FILE" /> - </root> -</configuration></pre> <h4> <a name="TimeBasedRollingPolicy" href="#TimeBasedRollingPolicy">TimeBasedRollingPolicy</a> @@ -1119,7 +943,7 @@ public interface RollingPolicy extends LifeCycle { /wombat/foo.txt file will be created where logging output will go for the rest of November 24rd. At midnight November 24th, /wombat/foo.txt will be compressed and - renamed as /wombat/foo.2009-11-24.gz. and so on. + renamed as /wombat/foo.2009-11-24.gz and so on. </td> </tr> @@ -1140,9 +964,13 @@ public interface RollingPolicy extends LifeCycle { the file specified by the file property. It follows that the name of the active log file will not change over time. However, if you choose to omit the File property, then the active file will be + class="option">file property, then the active file will be computed anew for each period based on the value of fileNamePattern. + class="option">fileNamePattern. By leaving the file option unset you can avoid file <a + href="../codes.html#renamingError">renaming errors</a> which occur + while there exist external file handles refrencing log files during + roll over. The maxHistory property controls the @@ -1234,6 +1062,187 @@ public interface RollingPolicy extends LifeCycle { </configuration></pre> + <h4> + <a name="FixedWindowRollingPolicy" + href="#FixedWindowRollingPolicy">FixedWindowRollingPolicy</a> + </h4> + + When rolling over, <a + href="../xref/ch/qos/logback/core/rolling/FixedWindowRollingPolicy.html"> + <code>FixedWindowRollingPolicy</code></a> renames files according + to a fixed window algorithm as described below. + + + The fileNamePattern option + represents the file name pattern for the archived (rolled over) log + files. This option is required and must include an integer token + %i somewhere within the pattern. + + + Here are the available properties for + <code>FixedWindowRollingPolicy</code> + + + <table class="bodyTable"> + <tr class="a"> + <th>Property Name</th> + <th>Type</th> + <th>Description</th> + </tr> + <tr class="b"> + <td>minIndex</td> + <td><code>int</code></td> + <td> + This option represents the lower bound for the window's + index. + + </td> + </tr> + <tr class="a"> + <td>maxIndex</td> + <td><code>int</code></td> + <td> + This option represents the upper bound for the window's + index. + + </td> + </tr> + <tr class="b"> + <td>fileNamePattern</td> + <td><code>String</code></td> + <td> + This option represents the pattern that will be followed + by the <code>FixedWindowRollingPolicy</code> when renaming + the log files. It must contain the string %i, which + will indicate the position where the value of the current + window index will be inserted. + + For example, using MyLogFile%i.log associated + with minimum and maximum values of 1 and 3 + will produce archive files named MyLogFile1.log, + MyLogFile2.log and MyLogFile3.log. + + Note that file compression is also specified via this + property. For example, fileNamePattern set to + MyLogFile%i.log.zip means that archived files must be + compressed using the zip format; gz format + is also supported. + + </td> + </tr> + </table> + + Given that the fixed window rolling policy requires as many file + renaming operations as the window size, large window sizes are + strongly discouraged. When large values are specified by the user, + the current implementation will automatically reduce the window + size to 12. + + + Let us go over a more concrete example of the fixed window + rollover policy. Suppose that minIndex + is set to 1, maxIndex set to + 3, fileNamePattern property + set to foo%i.log, and that fileNamePattern property is set to + foo.log. + + + <table class="bodyTable"> + <tr class="a"> + <th>Number of rollovers</th> + <th>Active output target</th> + <th>Archived log files</th> + <th>Description</th> + </tr> + <tr class="b"> + <td>0</td> + <td>foo.log</td> + <td>-</td> + <td>No rollover has happened yet, logback logs into the initial + file. + </td> + </tr> + <tr class="a"> + <td>1</td> + <td>foo.log</td> + <td>foo1.log</td> + <td>First rollover. foo.log is renamed as + foo1.log. A new foo.log file is created and + becomes the active output target. + </td> + </tr> + <tr class="b"> + <td>2</td> + <td>foo.log</td> + <td>foo1.log, foo2.log</td> + <td>Second rollover. foo1.log is renamed as + foo2.log. foo.log is renamed as + foo1.log. A new foo.log file is created and + becomes the active output target. + </td> + </tr> + <tr class="a"> + <td>3</td> + <td>foo.log</td> + <td>foo1.log, foo2.log, foo3.log</td> + <td>Third rollover. foo2.log is renamed as + foo3.log. foo1.log is renamed as + foo2.log. foo.log is renamed as + foo1.log. A new foo.log file is created and + becomes the active output target. + </td> + </tr> + <tr class="b"> + <td>4</td> + <td>foo.log</td> + <td>foo1.log, foo2.log, foo3.log</td> + <td>In this and subsequent rounds, the rollover begins by + deleting foo3.log. Other files are renamed by + incrementing their index as shown in previous steps. In this and + subsequent rollovers, there will be three archive logs and one + active log file. + </td> + </tr> + </table> + + The configuration file below gives an example of configuring + <code>RollingFileAppender</code> and + <code>FixedWindowRollingPolicy</code>. Note that the File option is mandatory even if it contains + some of the same information as conveyed with the fileNamePattern option. + + + Example: Sample configuration of a <code>RollingFileAppender</code> using a + <code>FixedWindowRollingPolicy</code> (logback-examples/src/main/java/chapters/appenders/conf/logback-RollingFixedWindow.xml) + + View as .groovy + <pre id="logback-RollingFixedWindow" class="prettyprint source"><configuration> + <appender name="FILE" class="ch.qos.logback.core.rolling.RollingFileAppender"> + <file>test.log</file> + + <rollingPolicy class="ch.qos.logback.core.rolling.FixedWindowRollingPolicy"> + <fileNamePattern>tests.%i.log.zip</fileNamePattern> + <minIndex>1</minIndex> + <maxIndex>3</maxIndex> + </rollingPolicy> + + <triggeringPolicy class="ch.qos.logback.core.rolling.SizeBasedTriggeringPolicy"> + <maxFileSize>5MB</maxFileSize> + </triggeringPolicy> + <encoder> + <pattern>%-4relative [%thread] %-5level %logger{35} - %msg%n</pattern> + </encoder> + </appender> + + <root level="DEBUG"> + <appender-ref ref="FILE" /> + </root> +</configuration></pre> + + <h3> <a name="SizeAndTimeBasedFNATP" href="#SizeAndTimeBasedFNATP">Size and time based archiving</a> diff --git a/logback-site/src/site/pages/manual/filters.html b/logback-site/src/site/pages/manual/filters.html index 46d555c..f354b8c 100644 --- a/logback-site/src/site/pages/manual/filters.html +++ b/logback-site/src/site/pages/manual/filters.html @@ -570,8 +570,8 @@ public class SampleFilter extends Filter>ILoggingEvent> { automatically by <code>JaninoEventEvaluator</code>. - Given that the OnMatch property is - set to NEUTRAL and the OnMismatch + Given that the OnMismatch property is + set to NEUTRAL and the OnMatch property set to DENY, this evalutor filter will drop all logging events whose message contains the string "billing". ----------------------------------------------------------------------- Summary of changes: .../core/rolling/TimeBasedRollingPolicy.java | 2 +- .../logback/core/FileAppenderResilienceTest.java | 4 +- .../ch/qos/logback/core/util/ResilienceUtil.java | 7 +- .../core/rolling/TimeBasedRolling2Test.scala | 2 +- logback-site/src/site/pages/codes.html | 43 ++- logback-site/src/site/pages/manual/appenders.html | 371 ++++++++++---------- logback-site/src/site/pages/manual/filters.html | 4 +- 7 files changed, 234 insertions(+), 199 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0