- logback-dev - mailman3.qos.ch

LoggerContext logger cache
by Ralph Goers 07 Oct '09

07 Oct '09

LoggerContext uses a Hashtable for the logger cache. A Google on "hashtable ConcurrentHashMap performance" shows that ConcurrentHashMap should perform much better under load. I looked at doing this in my fork and can't see any reason why it would be a problem. I did see a post where ConcurrentHashMap is quite a bit larger than Hashtable, but since there is only going to be one of these that shouldn't be a problem. http://www.informit.com/guides/content.aspx?g=java&seqNum=246 Ralph

2 2

branch, master, updated. 3ad0c4474488b4c967e504acb7b9598200a5a048
by git-noreply＠pixie.qos.ch 06 Oct '09

06 Oct '09

The branch, master has been updated via 3ad0c4474488b4c967e504acb7b9598200a5a048 (commit) from e2bbfe2159e869b2ab0feeefeed1074fc6f44fea (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=3ad0c4474488b4c967e504ac… http://github.com/ceki/logback/commit/3ad0c4474488b4c967e504acb7b9598200a5a… commit 3ad0c4474488b4c967e504acb7b9598200a5a048 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Oct 6 18:00:41 2009 +0200 - trying dotted lines diff --git a/logback-site/src/site/pages/css/common.css b/logback-site/src/site/pages/css/common.css index 9bd6d28..1795ebc 100644 --- a/logback-site/src/site/pages/css/common.css +++ b/logback-site/src/site/pages/css/common.css @@ -222,10 +222,13 @@ code { } .option { - border: 1px solid black; - font-family: Arial, sans-serif; - padding-left: 3px; - padding-right: 3px; + border-top: 1px dotted black; + border-bottom: 1px dotted black; + border-left: 1px dotted black; + border-right: 1px dotted black; + padding-left: 2px; + padding-right: 2px; + font-family: Arial, sans-serif; } .highlight { ----------------------------------------------------------------------- Summary of changes: logback-site/src/site/pages/css/common.css | 11 +++++++---- 1 files changed, 7 insertions(+), 4 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

branch, master, updated. e2bbfe2159e869b2ab0feeefeed1074fc6f44fea
by git-noreply＠pixie.qos.ch 06 Oct '09

06 Oct '09

The branch, master has been updated via e2bbfe2159e869b2ab0feeefeed1074fc6f44fea (commit) from 13ca0437f2069e812360f14deba53904f24ad7a9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=e2bbfe2159e869b2ab0feeef… http://github.com/ceki/logback/commit/e2bbfe2159e869b2ab0feeefeed1074fc6f44… commit e2bbfe2159e869b2ab0feeefeed1074fc6f44fea Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Oct 6 17:41:10 2009 +0200 As discussed on IRC with Charles Johnson, added 3px padding around options which now look less cramped. diff --git a/logback-site/src/site/pages/css/common.css b/logback-site/src/site/pages/css/common.css index 65eec8a..9bd6d28 100644 --- a/logback-site/src/site/pages/css/common.css +++ b/logback-site/src/site/pages/css/common.css @@ -25,6 +25,7 @@ div.source { font-family: Courier, "MS Courier New", Prestige, monospace; padding-left: 1ex; white-space: pre; + overflow: scroll; } .source { @@ -217,11 +218,14 @@ code { .attr { font-family: Courier, monospace; font-style:italic; + } .option { border: 1px solid black; font-family: Arial, sans-serif; + padding-left: 3px; + padding-right: 3px; } .highlight { ----------------------------------------------------------------------- Summary of changes: logback-site/src/site/pages/css/common.css | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBCLASSIC-158) Interleaved messages from multiple threads
by Michael Olson (JIRA) 05 Oct '09

05 Oct '09

Interleaved messages from multiple threads ------------------------------------------ Key: LBCLASSIC-158 URL: http://jira.qos.ch/browse/LBCLASSIC-158 Project: logback-classic Issue Type: Bug Components: appender Affects Versions: 0.917 Environment: Mac OS X 10.5.8, Eclipse 20090920-1017, Java SE 6, Mac Pro with 2 processors with 4 cores each Reporter: Michael Olson Assignee: Logback dev list Priority: Critical Note: I'm using pastebin so that the formatting is not messed with by JIRA and so that I can refer to line numbers. My apologies if that makes it more difficult to examine my files. I've just moved to logback from log4j (which I was using only with the default configuration) using the slf4j wrappers. I'm using a configuration which is a slightly changed version of one found in the documentation; the configuration can be found here: http://logback.pastebin.com/m1a6f2875 These two log file excerpts are from that configuration: http://logback.pastebin.com/m5e08cb57 - note lines 3 and 4 http://logback.pastebin.com/m7e575564 - note lines 2, 3, and 4 Then this configuration, which only changes the class levels, is for the next log (I wanted to be precise): http://logback.pastebin.com/f6195004e This log file is from this morning: http://logback.pastebin.com/f42bdb83f Note lines 2 and 3. You'll notice, I'm sure, that these are all from the end of my log files; I have not observed this behavior elsewhere in my logs. The observed problems have been during my shutdown procedure. Specifically, the class PostItemSubmitter, with 4 threads, is waiting on input from CalaisSubmitter (it is trying to retrieve an object from a LinkedBlockingQueue with a get() operation). In these particular logs, CalaisSubmitter has run into fatal errors (over SLA, whoops) and has put no data in the queue, so all four threads are currently blocked on their input queue. After all of the CalaisSubmitter threads are shutdown, the main thread tries to shut down the PostItemSubmitter threads. It does this by calling a function in the thread's instance which sets a boolean value to false that controls the continued execution of the main program loop. After it has set those variables, the main thread will check the size of the queue; if it is 0, which it is in this case, then it will interrupt any threads that have not stopped after one second. It will do this immediately, so all four threads will receive Thread.interrupt() calls in sequence. When those threads are interrupted, they throw an InterruptedException. The catch statement looks like this: catch (InterruptedException e) { if (running) logger.error("Interrupted getting item from queue"); else logger.info("Shutdown aborted queue operation"); } In at least two of these three logs, it seems clear that the problem lies in how the interrupted threads are using the static logger defined for their class, which looks like this: private static Logger logger = LoggerFactory.getLogger(PostItemSubmitter.class); In the other log, the interleaving comes with the CalaisSubmitter, but you can see at least one aborted queue operation, so the reason could be similar (that class is also interrupted on an empty queue and catches those interrupts in the same way). Let me know if you need any more information to help diagnose the problem. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 3

[JIRA] Created: (LBCORE-121) Missing code for retrieving evaluators by name
by Ceki Gulcu (JIRA) 29 Sep '09

29 Sep '09

Missing code for retrieving evaluators by name ---------------------------------------------- Key: LBCORE-121 URL: http://jira.qos.ch/browse/LBCORE-121 Project: logback-core Issue Type: Bug Components: Joran Affects Versions: 0.9.17 Reporter: Ceki Gulcu Assignee: Logback dev list Evaluators are named entities, so they are in principle retrievable by name. However, for some reason, the retrieval code seems to be missing. http://www.qos.ch/pipermail/logback-user/2009-September/001324.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

branch, master, updated. 13ca0437f2069e812360f14deba53904f24ad7a9
by git-noreply＠pixie.qos.ch 26 Sep '09

26 Sep '09

The branch, master has been updated via 13ca0437f2069e812360f14deba53904f24ad7a9 (commit) from f0a9057c4c1574160f31fb8f173636602d5d0b3a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=13ca0437f2069e812360f14d… http://github.com/ceki/logback/commit/13ca0437f2069e812360f14deba53904f24ad… commit 13ca0437f2069e812360f14deba53904f24ad7a9 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Sat Sep 26 17:40:36 2009 +0200 - correct link to Jazoon presentation diff --git a/logback-site/src/site/pages/documentation.html b/logback-site/src/site/pages/documentation.html index 2efdfe8..e426b97 100644 --- a/logback-site/src/site/pages/documentation.html +++ b/logback-site/src/site/pages/documentation.html @@ -75,9 +75,13 @@ </li> <li><a - href="http://beta.parleys.com/#state=state_player&id=357">SLF4J + href="http://www.devoxx.com:5080/player/main.html#state=state_player&id=357&slide…">SLF4J and Logback projects</a>, by C. Gülcü and S. Pennec - (Jazoon presentation with audio). </li> + (Jazoon presentation with audio). If the previous link does not + work, please try the <a + href="http://beta.parleys.com/share/parleysshare2.swf?pageId=357">back + up</a>. + </li> <li><a href="http://www.infoq.com/news/2007/08/logback">Logback: Evolving Java Logging</a> by Geoffrey Wiseman ----------------------------------------------------------------------- Summary of changes: logback-site/src/site/pages/documentation.html | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

Git as a version control system?
by Ceki Gulcu 22 Sep '09

22 Sep '09

Hi all, I was wondering if we should be moving to git as our version control system. I really like the fact that git's repository is stored on the local disk. It also appears that git makes it easier for developers to contribute patches. Could anybody confirm or care to share their experiences with git? Is there anyone against using git? BR -- Ceki Gülcü Logback: The reliable, generic, fast and flexible logging framework for Java. http://logback.qos.ch

6 24

Enable the JIRA RPC interface?
by david＠davidkarlsen.com 22 Sep '09

22 Sep '09

hi. Can you enable the RPC services for JIRA - that way it's possible to use Mylyn as a frontend. -- David J. M. Karlsen - +47 90 68 22 43 http://www.davidkarlsen.com http://mp3.davidkarlsen.com

2 1

branch, master, updated. f0a9057c4c1574160f31fb8f173636602d5d0b3a
by git-noreply＠pixie.qos.ch 19 Sep '09

19 Sep '09

The branch, master has been updated via f0a9057c4c1574160f31fb8f173636602d5d0b3a (commit) from 0900ca3cdd75ee9a5bbbdfc92cc02997a4ddbaa8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=f0a9057c4c1574160f31fb8f… http://github.com/ceki/logback/commit/f0a9057c4c1574160f31fb8f173636602d5d0… commit f0a9057c4c1574160f31fb8f173636602d5d0b3a Author: Ceki Gulcu <ceki(a)qos.ch> Date: Sat Sep 19 17:54:39 2009 +0200 - corrected the expected line number in ConverterTest - fixed TimeBasedRollingWithArchiveRemovalTest.java which would fail when the number of period+currentMonth - maxHistory is placed in the previous year. - minor editing in license.html diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java index bfa1536..c1ff3b5 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java @@ -74,7 +74,7 @@ public class ConverterTest { StringBuffer buf = new StringBuffer(); converter.write(buf, le); // the number below should be the line number of the previous line - assertEquals("76", buf.toString()); + assertEquals("75", buf.toString()); } } diff --git a/logback-core/src/main/java/ch/qos/logback/core/sift/AppenderTrackerImpl.java b/logback-core/src/main/java/ch/qos/logback/core/sift/AppenderTrackerImpl.java index 1bc86b2..20cc37c 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/sift/AppenderTrackerImpl.java +++ b/logback-core/src/main/java/ch/qos/logback/core/sift/AppenderTrackerImpl.java @@ -165,9 +165,9 @@ public class AppenderTrackerImpl<E> implements AppenderTracker<E> { this.timestamp = timestamp; } - public long getTimestamp() { - return timestamp; - } +// public long getTimestamp() { +// return timestamp; +// } public void setTimestamp(long timestamp) { this.timestamp = timestamp; diff --git a/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingWithArchiveRemovalTest.java b/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingWithArchiveRemovalTest.java index 20b4f90..af4a068 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingWithArchiveRemovalTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingWithArchiveRemovalTest.java @@ -18,6 +18,7 @@ import static org.junit.Assert.assertTrue; import java.io.File; import java.io.FileFilter; import java.util.ArrayList; +import java.util.Calendar; import java.util.HashSet; import java.util.List; import java.util.Set; @@ -93,16 +94,22 @@ public class TimeBasedRollingWithArchiveRemovalTest { // large maxPeriod, a 3 times as many number of periods to simulate doRollover(randomOutputDir + "clean-%d{" + MONTHLY_DATE_PATTERN + "}.txt", MILLIS_IN_MONTH, 20, 20 * 3); - check(expectedCountWithoutDirs(20)); + check(expectedCountWithoutFolders(20)); } @Test public void montlyRolloverOverManyPeriods() throws Exception { + System.out.println("randomOutputDir=" + randomOutputDir); // small maxHistory, many periods slashCount = computeSlashCount(MONTHLY_CROLOLOG_DATE_PATTERN); + int numPeriods = 40; + int maxHistory = 2; + doRollover(randomOutputDir + "/%d{" + MONTHLY_CROLOLOG_DATE_PATTERN - + "}/clean.txt.zip", MILLIS_IN_MONTH, 2, 40); - check(expectedCountWithDirs(2)); + + "}/clean.txt.zip", MILLIS_IN_MONTH, maxHistory, numPeriods); + int beginPeriod = Calendar.getInstance().get(Calendar.MONTH); + boolean extraFolder = extraFolder(numPeriods, 12, beginPeriod, maxHistory); + check(expectedCountWithFolders(2, extraFolder)); } @Test @@ -111,7 +118,7 @@ public class TimeBasedRollingWithArchiveRemovalTest { doRollover( randomOutputDir + "clean-%d{" + DAILY_DATE_PATTERN + "}.txt.zip", MILLIS_IN_DAY, 5, 5 * 3); - check(expectedCountWithoutDirs(5)); + check(expectedCountWithoutFolders(5)); } @Test @@ -121,8 +128,8 @@ public class TimeBasedRollingWithArchiveRemovalTest { + "}/clean.txt.zip", MILLIS_IN_DAY, 8, 8 * 3); int expectedDirMin = 9 + slashCount; int expectDirMax = expectedDirMin + 1 + 1; // plus 1 of stepping into a - // new month, and another 1 into - // a new year + // new month, and another 1 into + // a new year expectedFileAndDirCount(9, expectedDirMin, expectDirMax); } @@ -253,15 +260,29 @@ public class TimeBasedRollingWithArchiveRemovalTest { } } - int expectedCountWithoutDirs(int maxHistory) { + int expectedCountWithoutFolders(int maxHistory) { // maxHistory plus the currently active file return maxHistory + 1; } - int expectedCountWithDirs(int maxHistory) { + // sometimes, after a number of periods, there is an extra folder + // from the previous "era" because the latest period - maxHistory, enters the + // bound of the previous era. For example, with a maxHistory of 2, on 2009-09, + // after 40 periods, the current period is 2013-01. Going back two months, the + // year is 2012, and not 2013 (the current year). + boolean extraFolder(int numPeriods, int periodsPerEra, int beginPeriod, + int maxHistory) { + int remainder = (beginPeriod + numPeriods) % periodsPerEra; + return (remainder < maxHistory + 1); + } + + int expectedCountWithFolders(int maxHistory, boolean extraFolder) { // each slash adds a new directory // + one file and one directory per archived log file - return (maxHistory + 1) * 2 + slashCount; + int result = (maxHistory + 1) * 2 + slashCount; + if (extraFolder) + result++; + return result; } void check(int expectedCount) { diff --git a/logback-site/src/site/pages/license.html b/logback-site/src/site/pages/license.html index 3220c12..0bc88a2 100644 --- a/logback-site/src/site/pages/license.html +++ b/logback-site/src/site/pages/license.html @@ -59,7 +59,7 @@ as published by the Free Software Foundation. On the other hand, the EPL license will placate organizations - which refuse the various restrictions imposed by the LGPL. + which refuse certain restrictions imposed by the LGPL. If you wish to make a significant contribution to the logback ----------------------------------------------------------------------- Summary of changes: .../qos/logback/classic/pattern/ConverterTest.java | 2 +- .../qos/logback/core/sift/AppenderTrackerImpl.java | 6 ++-- .../TimeBasedRollingWithArchiveRemovalTest.java | 39 +++++++++++++++----- logback-site/src/site/pages/license.html | 2 +- 4 files changed, 35 insertions(+), 14 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

branch, master, updated. 0900ca3cdd75ee9a5bbbdfc92cc02997a4ddbaa8
by git-noreply＠pixie.qos.ch 19 Sep '09

19 Sep '09

The branch, master has been updated via 0900ca3cdd75ee9a5bbbdfc92cc02997a4ddbaa8 (commit) from f307862e460187cda2436215ffc049b57f68341b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=0900ca3cdd75ee9a5bbbdfc9… http://github.com/ceki/logback/commit/0900ca3cdd75ee9a5bbbdfc92cc02997a4ddb… commit 0900ca3cdd75ee9a5bbbdfc92cc02997a4ddbaa8 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Sat Sep 19 16:39:37 2009 +0200 testing diff --git a/test.txt b/test.txt new file mode 100644 index 0000000..e69de29 ----------------------------------------------------------------------- Summary of changes: .../test/witness/rolling/tbr-test1.0 => test.txt | 0 1 files changed, 0 insertions(+), 0 deletions(-) copy logback-core/src/test/witness/rolling/tbr-test1.0 => test.txt (100%) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0