- logback-dev - mailman3.qos.ch

[JIRA] Created: (LBCLASSIC-150) allow for dynamic modificaton of a logging event
by Ceki Gulcu (JIRA) 24 Aug '09

24 Aug '09

allow for dynamic modificaton of a logging event ------------------------------------------------ Key: LBCLASSIC-150 URL: http://jira.qos.ch/browse/LBCLASSIC-150 Project: logback-classic Issue Type: New Feature Components: Other Affects Versions: 0.917 Reporter: Ceki Gulcu Assignee: Logback dev list It may be sometimes useful to dynamically change the level of a statement after an associated logging event is created. See for example the discussion on i18n: http://www.slf4j.org/pipermail/dev/2009-August/002500.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

Git
by Ralph Goers 23 Aug '09

23 Aug '09

I am working on LBCLASSIC-116 and should have working code for you in a couple of days. I've cloned the repository and am working on my Mac. So when it is ready how do I make it available for review?

2 1

build fails
by Ralph Goers 23 Aug '09

23 Aug '09

I did a fresh git clone on my Mac at home. I then ran mvn install. It failed with: [INFO] ------------------------------------------------------------------------ [INFO] Building Logback Examples Module [INFO] task-segment: [clean, install] [INFO] ------------------------------------------------------------------------ [INFO] [clean:clean] [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:compile] [INFO] Compiling 58 source files to /Users/rgoers/projects/logback/ logback/logback-examples/target/classes [INFO] [resources:testResources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:testCompile] [INFO] No sources to compile [INFO] [surefire:test] [INFO] No tests to run. [INFO] [jar:jar] [INFO] Building jar: /Users/rgoers/projects/logback/logback/logback- examples/target/logback-examples-0.9.18-SNAPSHOT.jar [INFO] Preparing source:jar [WARNING] Removing: jar from forked lifecycle, to prevent recursive invocation. [INFO] No goals needed for project - skipping [INFO] [source:jar {execution: default}] [INFO] Building jar: /Users/rgoers/projects/logback/logback/logback- examples/target/logback-examples-0.9.18-SNAPSHOT-sources.jar [INFO] [antrun:run {execution: default}] [INFO] Executing tasks [echo] Copying /Users/rgoers/.m2/repository/org/slf4j/slf4j-api/ 1.5.8/slf4j-api-1.5.8.jar to lib/ [INFO] ------------------------------------------------------------------------ [ERROR] BUILD ERROR [INFO] ------------------------------------------------------------------------ [INFO] Error executing ant tasks Embedded error: /Users/rgoers/projects/logback/logback/logback- examples/lib not found. [INFO] ------------------------------------------------------------------------

2 1

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. 0a9c28e40bfc48a91a097776c970cb421b37dd10
by git-noreply＠pixie.qos.ch 21 Aug '09

21 Aug '09

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 0a9c28e40bfc48a91a097776c970cb421b37dd10 (commit) via 3351c004a1517ae6a4203cad27a34615bf72780e (commit) from c7a58e5dbad4e2d6c9faf7a6c65444f841422797 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=0a9c28e40bfc48a91a097776… http://github.com/ceki/logback/commit/0a9c28e40bfc48a91a097776c970cb421b37d… commit 0a9c28e40bfc48a91a097776c970cb421b37dd10 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Fri Aug 21 22:39:18 2009 +0200 - Cleaning up the location of log files generated during testing - adding ignored files under logback-cire/src/test/input diff --git a/logback-core/src/test/input/.gitignore b/logback-core/src/test/input/.gitignore new file mode 100644 index 0000000..4d7ac69 --- /dev/null +++ b/logback-core/src/test/input/.gitignore @@ -0,0 +1 @@ +compress?.txt diff --git a/logback-core/src/test/java/ch/qos/logback/core/appender/FileAppenderTest.java b/logback-core/src/test/java/ch/qos/logback/core/appender/FileAppenderTest.java index 3ed4d8d..070c2a2 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/appender/FileAppenderTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/appender/FileAppenderTest.java @@ -42,8 +42,8 @@ public class FileAppenderTest extends AbstractAppenderTest<Object> { protected Appender<Object> getConfiguredAppender() { FileAppender<Object> appender = new FileAppender<Object>(); appender.setLayout(new NopLayout<Object>()); - appender.setFile("temp.log"); - appender.setName("temp.log"); + appender.setFile(CoreTestConstants.OUTPUT_DIR_PREFIX+"temp.log"); + appender.setName("test"); appender.setContext(context); appender.start(); return appender; @@ -57,7 +57,7 @@ public class FileAppenderTest extends AbstractAppenderTest<Object> { appender.setLayout(new DummyLayout<Object>()); appender.setAppend(false); appender.setFile(filename); - appender.setName("temp.log"); + appender.setName("smoke"); appender.setContext(context); appender.start(); appender.doAppend(new Object()); diff --git a/logback-core/src/test/java/ch/qos/logback/core/rolling/RollingFileAppenderTest.java b/logback-core/src/test/java/ch/qos/logback/core/rolling/RollingFileAppenderTest.java index d8d0ff2..eae0fa1 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/rolling/RollingFileAppenderTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/rolling/RollingFileAppenderTest.java @@ -26,6 +26,7 @@ import ch.qos.logback.core.layout.DummyLayout; import ch.qos.logback.core.status.Status; import ch.qos.logback.core.status.StatusChecker; import ch.qos.logback.core.status.StatusManager; +import ch.qos.logback.core.util.CoreTestConstants; import ch.qos.logback.core.util.StatusPrinter; public class RollingFileAppenderTest extends AbstractAppenderTest<Object> { @@ -58,7 +59,7 @@ public class RollingFileAppenderTest extends AbstractAppenderTest<Object> { @Override protected Appender<Object> getConfiguredAppender() { rfa.setContext(context); - tbrp.setFileNamePattern("toto-%d.log"); + tbrp.setFileNamePattern(CoreTestConstants.OUTPUT_DIR_PREFIX+"toto-%d.log"); tbrp.start(); rfa.setRollingPolicy(tbrp); @@ -76,7 +77,7 @@ public class RollingFileAppenderTest extends AbstractAppenderTest<Object> { rfa.setBufferedIO(true); rfa.setPrudent(true); - tbrp.setFileNamePattern("toto-%d.log"); + tbrp.setFileNamePattern(CoreTestConstants.OUTPUT_DIR_PREFIX+"toto-%d.log"); tbrp.start(); rfa.setRollingPolicy(tbrp); http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=3351c004a1517ae6a4203cad… http://github.com/ceki/logback/commit/3351c004a1517ae6a4203cad27a34615bf727… commit 3351c004a1517ae6a4203cad27a34615bf72780e Author: Ceki Gulcu <ceki(a)qos.ch> Date: Fri Aug 21 22:34:09 2009 +0200 - since git does not seem to like empty directories, have the ant build script inside logback-example/pom.xml create the lib directory. diff --git a/logback-examples/pom.xml b/logback-examples/pom.xml index ec96a3d..2d6a914 100644 --- a/logback-examples/pom.xml +++ b/logback-examples/pom.xml @@ -90,6 +90,7 @@ <phase>package</phase> <configuration> <tasks> + <mkdir dir="lib/"/> <property name="slf4jJAR" value="${settings.localRepository}/org/slf4j/slf4j-api/${slf4j.version}/slf4j-api-${slf4j.version}.jar" /> <echo>Copying ${slf4jJAR} to lib/</echo> ----------------------------------------------------------------------- Summary of changes: logback-core/src/test/input/.gitignore | 1 + .../logback/core/appender/FileAppenderTest.java | 6 +++--- .../core/rolling/RollingFileAppenderTest.java | 5 +++-- logback-examples/pom.xml | 1 + 4 files changed, 8 insertions(+), 5 deletions(-) create mode 100644 logback-core/src/test/input/.gitignore hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. c7a58e5dbad4e2d6c9faf7a6c65444f841422797
by git-noreply＠pixie.qos.ch 20 Aug '09

20 Aug '09

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via c7a58e5dbad4e2d6c9faf7a6c65444f841422797 (commit) from 8fbef05787a8441839f32403a302296916a892b5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=c7a58e5dbad4e2d6c9faf7a6… http://github.com/ceki/logback/commit/c7a58e5dbad4e2d6c9faf7a6c65444f841422… commit c7a58e5dbad4e2d6c9faf7a6c65444f841422797 Author: ceki <ceki@Orion> Date: Thu Aug 20 23:53:45 2009 +0200 -renamed ContextPropertyConverter as PropertyConverter diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/PatternLayout.java b/logback-classic/src/main/java/ch/qos/logback/classic/PatternLayout.java index 84f2636..88a7d6e 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/PatternLayout.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/PatternLayout.java @@ -16,7 +16,7 @@ import ch.qos.logback.classic.joran.action.ContextNameAction; import ch.qos.logback.classic.pattern.CallerDataConverter; import ch.qos.logback.classic.pattern.ClassOfCallerConverter; import ch.qos.logback.classic.pattern.ContextNameConverter; -import ch.qos.logback.classic.pattern.ContextPropertyConverter; +import ch.qos.logback.classic.pattern.PropertyConverter; import ch.qos.logback.classic.pattern.DateConverter; import ch.qos.logback.classic.pattern.EnsureExceptionHandling; import ch.qos.logback.classic.pattern.ExtendedThrowableProxyConverter; @@ -115,7 +115,7 @@ public class PatternLayout extends PatternLayoutBase<ILoggingEvent> { defaultConverterMap.put("marker", MarkerConverter.class.getName()); - defaultConverterMap.put("property", ContextPropertyConverter.class.getName()); + defaultConverterMap.put("property", PropertyConverter.class.getName()); defaultConverterMap.put("n", LineSeparatorConverter.class.getName()); diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/pattern/ContextPropertyConverter.java b/logback-classic/src/main/java/ch/qos/logback/classic/pattern/PropertyConverter.java similarity index 89% rename from logback-classic/src/main/java/ch/qos/logback/classic/pattern/ContextPropertyConverter.java rename to logback-classic/src/main/java/ch/qos/logback/classic/pattern/PropertyConverter.java index 7343317..7e01b94 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/pattern/ContextPropertyConverter.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/pattern/PropertyConverter.java @@ -14,7 +14,7 @@ import java.util.Map; import ch.qos.logback.classic.spi.ILoggingEvent; import ch.qos.logback.classic.spi.LoggerContextVO; -public final class ContextPropertyConverter extends ClassicConverter { +public final class PropertyConverter extends ClassicConverter { String key; diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java index 147b066..dd15c32 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java @@ -362,7 +362,7 @@ public class ConverterTest { @Test public void contextProperty() { - ContextPropertyConverter converter = new ContextPropertyConverter(); + PropertyConverter converter = new PropertyConverter(); converter.setContext(lc); List<String> ol = new ArrayList<String>(); ol.add("k"); ----------------------------------------------------------------------- Summary of changes: .../java/ch/qos/logback/classic/PatternLayout.java | 4 ++-- ...opertyConverter.java => PropertyConverter.java} | 2 +- .../qos/logback/classic/pattern/ConverterTest.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) rename logback-classic/src/main/java/ch/qos/logback/classic/pattern/{ContextPropertyConverter.java => PropertyConverter.java} (89%) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. 8fbef05787a8441839f32403a302296916a892b5
by git-noreply＠pixie.qos.ch 20 Aug '09

20 Aug '09

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 8fbef05787a8441839f32403a302296916a892b5 (commit) from 29f0061832915d56307bf0b82098092aa1fa3390 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=8fbef05787a8441839f32403… http://github.com/ceki/logback/commit/8fbef05787a8441839f32403a302296916a89… commit 8fbef05787a8441839f32403a302296916a892b5 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Thu Aug 20 23:50:13 2009 +0200 - added documentation on ContextPropertyConverter - added test cases in relation wit ContextPropertyConverter diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/PatternLayout.java b/logback-classic/src/main/java/ch/qos/logback/classic/PatternLayout.java index 23bc4f8..84f2636 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/PatternLayout.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/PatternLayout.java @@ -16,6 +16,7 @@ import ch.qos.logback.classic.joran.action.ContextNameAction; import ch.qos.logback.classic.pattern.CallerDataConverter; import ch.qos.logback.classic.pattern.ClassOfCallerConverter; import ch.qos.logback.classic.pattern.ContextNameConverter; +import ch.qos.logback.classic.pattern.ContextPropertyConverter; import ch.qos.logback.classic.pattern.DateConverter; import ch.qos.logback.classic.pattern.EnsureExceptionHandling; import ch.qos.logback.classic.pattern.ExtendedThrowableProxyConverter; @@ -114,6 +115,9 @@ public class PatternLayout extends PatternLayoutBase<ILoggingEvent> { defaultConverterMap.put("marker", MarkerConverter.class.getName()); + defaultConverterMap.put("property", ContextPropertyConverter.class.getName()); + + defaultConverterMap.put("n", LineSeparatorConverter.class.getName()); } diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/pattern/ContextPropertyConverter.java b/logback-classic/src/main/java/ch/qos/logback/classic/pattern/ContextPropertyConverter.java index 3f9b0fe..7343317 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/pattern/ContextPropertyConverter.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/pattern/ContextPropertyConverter.java @@ -16,23 +16,28 @@ import ch.qos.logback.classic.spi.LoggerContextVO; public final class ContextPropertyConverter extends ClassicConverter { - String propertyName; + String key; public void start() { String optStr = getFirstOption(); if (optStr != null) { - propertyName = optStr; + key = optStr; super.start(); } } public String convert(ILoggingEvent event) { - if(propertyName == null) { - return "ContextProperty_HAS_NO_NAME"; + if (key == null) { + return "Property_HAS_NO_KEY"; } else { LoggerContextVO lcvo = event.getLoggerContextVO(); Map<String, String> map = lcvo.getPropertyMap(); - return map.get(propertyName); + String val = map.get(key); + if (val != null) { + return val; + } else { + return System.getProperty(key); + } } } } diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/PatternLayoutTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/PatternLayoutTest.java index 256fc60..a5f74b5 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/PatternLayoutTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/PatternLayoutTest.java @@ -99,10 +99,18 @@ public class PatternLayoutTest extends AbstractPatternLayoutBaseTest { String regex = ISO_REGEX + " c.q.l.c.p.ConverterTest - Some message\\s*"; assertTrue(val.matches(regex)); - } @Test + public void contextProperty() { + pl.setPattern("%property{a}"); + pl.start(); + lc.putProperty("a", "b"); + + String val = pl.doLayout(getEventObject()); + assertEquals("b", val); + } + @Test public void testNopExeptionHandler() { pl.setPattern("%nopex %m%n"); pl.start(); diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java index 0524a71..147b066 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java @@ -359,4 +359,20 @@ public class ConverterTest { String result = converter.convert(event); assertEquals("aValue", result); } + + @Test + public void contextProperty() { + ContextPropertyConverter converter = new ContextPropertyConverter(); + converter.setContext(lc); + List<String> ol = new ArrayList<String>(); + ol.add("k"); + converter.setOptionList(ol); + converter.start(); + lc.setName("aValue"); + lc.putProperty("k", "v"); + ILoggingEvent event = makeLoggingEvent(null); + + String result = converter.convert(event); + assertEquals("v", result); + } } diff --git a/logback-site/src/site/pages/manual/configuration.html b/logback-site/src/site/pages/manual/configuration.html index 1f24aed..f725cf7 100644 --- a/logback-site/src/site/pages/manual/configuration.html +++ b/logback-site/src/site/pages/manual/configuration.html @@ -1150,6 +1150,14 @@ public class MyApp3 { <em>${java.home.dir}</em> will be interpreted as <em>/home/xyz</em>. </p> + <h4>properties are inserted into the logger context</h4> + + <p>Note that the values defined via <code><property></code> + element are actually inserted into the logger context. In other + words, they become properties of the logger context. Consequently, + they will be available in all logging events as well as remotely + after serialization.</p> + <p>The next example shows a variable, a.k.a. a substitution property, declared the beginning of the configuration file. It is then used further down the file to specify the location of the diff --git a/logback-site/src/site/pages/manual/layouts.html b/logback-site/src/site/pages/manual/layouts.html index f2e91a4..044c84a 100644 --- a/logback-site/src/site/pages/manual/layouts.html +++ b/logback-site/src/site/pages/manual/layouts.html @@ -909,6 +909,29 @@ Caller+2 at mainPackage.ConfigTester.main(ConfigTester.java:38)</div> </td> </tr> + + <tr> + <td align="center"> + <b>property{key}</b> + </td> + + <td> + <p >Used to output the value associated with a context + property named <em>key</em>. If <em>key</em> is not a + property of the logger context, then <em>key</em> will be + looked up in the System properties. </p> + + + <p>There is no default value for <em>key</em>. If it is + omitted, the returned value will be "Property_HAS_NO_KEY", + expliciting the error condition.</p> + + <p> + </p> + + </td> + </tr> + </table> <p>Given that in the context of conversion patterns the percent ----------------------------------------------------------------------- Summary of changes: .../java/ch/qos/logback/classic/PatternLayout.java | 4 +++ .../classic/pattern/ContextPropertyConverter.java | 15 ++++++++---- .../ch/qos/logback/classic/PatternLayoutTest.java | 10 +++++++- .../qos/logback/classic/pattern/ConverterTest.java | 16 +++++++++++++ .../src/site/pages/manual/configuration.html | 8 +++++++ logback-site/src/site/pages/manual/layouts.html | 23 ++++++++++++++++++++ 6 files changed, 70 insertions(+), 6 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. 29f0061832915d56307bf0b82098092aa1fa3390
by git-noreply＠pixie.qos.ch 20 Aug '09

20 Aug '09

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 29f0061832915d56307bf0b82098092aa1fa3390 (commit) from 6d81615d2d494dbe5bb0e480e0ea370cef9118e2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=29f0061832915d56307bf0b8… http://github.com/ceki/logback/commit/29f0061832915d56307bf0b82098092aa1fa3… commit 29f0061832915d56307bf0b82098092aa1fa3390 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Thu Aug 20 22:24:27 2009 +0200 - corrected url to git.qos.ch gitweb diff --git a/logback-site/src/site/pages/repos.html b/logback-site/src/site/pages/repos.html index 287877a..d2867fd 100644 --- a/logback-site/src/site/pages/repos.html +++ b/logback-site/src/site/pages/repos.html @@ -54,8 +54,8 @@ <tr> <td>on git.qos.ch</td> - <td><a href="http://git.qos.ch/?p=logback.git;a=summary"> - http://git.qos.ch/?p=logback.git;a=summary</a> (fast but minimal) + <td><a href="http://git.qos.ch/gitweb/?p=logback.git;a=summary"> + http://git.qos.ch/gitweb/?p=logback.git;a=summary</a> (fast but minimal) </td> </tr> </table> ----------------------------------------------------------------------- Summary of changes: logback-site/src/site/pages/repos.html | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

rebuilding git repositories
by Ceki Gulcu 20 Aug '09

20 Aug '09

Hello all, I am rebuilding both the slf4j and logback git repositories. A new version should be available in the coming hour or so. If you had cloned an earlier version of either the slf4j or logback repo, I am afraid you'll need to clone again. My apologies for the hassle, -- Ceki Gülcü Logback: The reliable, generic, fast and flexible logging framework for Java. http://logback.qos.ch

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. 660ad5b7f277c541df61a6f7086443be5840d6ad
by git-noreply＠pixie.qos.ch 20 Aug '09

20 Aug '09

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 660ad5b7f277c541df61a6f7086443be5840d6ad (commit) from 835deaf1634de83b11dfe6495f7a4ccb762b5f9a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/?p=logback.git;a=commit;h=660ad5b7f277c541df61a6f7086443b… http://github.com/ceki/logback/commit/660ad5b7f277c541df61a6f7086443be5840d… commit 660ad5b7f277c541df61a6f7086443be5840d6ad Author: Ceki Gulcu <ceki(a)qos.ch> Date: Thu Aug 20 14:33:31 2009 +0200 added documentation on git diff --git a/logback-site/src/site/pages/repos.html b/logback-site/src/site/pages/repos.html index 0d87089..24b53b7 100644 --- a/logback-site/src/site/pages/repos.html +++ b/logback-site/src/site/pages/repos.html @@ -24,7 +24,7 @@ </div> <p>We store the project's source code in a revision control system - called Subversion. Developers have write access to the repository, + called Git. Developers have write access to the repository, enabling them to make changes to the source code. Everyone else has read-access to the repository. Thus, anyone can check out latest development version of the software. Note that the latest @@ -33,34 +33,55 @@ download an official distribution. </p> - <p>There are several ways to access the Subversion repository:</p> + <p>There are several ways to access the git repository:</p> <h2>Web Access</h2> <p>If you just wish to browse around or download a few individual - files, you can do so with web-based ViewVC interface: + files, you can do so with your web-browser: </p> + + <table cellspacing="6"> - <p><a - href="http://svn.qos.ch/viewvc/logback/trunk/">http://svn.qos.ch/viewvc/logback/trunk/</a> - </p> + <tr> + <td>on github</td> + <td> + <a href="http://github.com/ceki/logback/tree/master"> + http://github.com/ceki/logback/tree/master</a> (slow but rich) + </td> + </tr> - <h2>Checking out a read-only copy</h2> - <p>To access the Subversion repositories anonymously, you will - need a Subversion client. You can check out the logback project - source code with the following command:</p> - -  - <p class="source">svn co http://svn.qos.ch/repos/logback/trunk/ target_directory</p> - - <p>Note that anonymous access allows read-only access. For - read-write access, please contact the logback <a - href="mailinglist.html">developer list</a> . - </p> - - - + <tr> + <td>on git.qos.ch</td> + <td><a href="http://git.qos.ch/?p=logback.git;a=summary"> + http://git.qos.ch/?p=logback.git;a=summary</a> (fast but minimal) + </td> + </tr> + </table> + + <h2>Cloning</h2> + + + <p>Anyone can clone logback's source repository. All you need is a + git client. To clone logback's git repository, issue one of the + two following commands: </p> + + <pre class="cmd">git clone git://git.qos.ch/logback</pre> + + or alternatively + + <pre class="cmd">git clone git://github.com/ceki/logback.git</pre> + + <p>In principle, the two repositories listed above are + identical.</p> + + + <h2>Subversion</h2> + + <p>Previously, we relied on Subversion as our version control + system. Git is considerably better.</p> + <script src="templates/footer.js" type="text/javascript"></script> </div> </body> ----------------------------------------------------------------------- Summary of changes: logback-site/src/site/pages/repos.html | 63 +++++++++++++++++++++----------- 1 files changed, 42 insertions(+), 21 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBCORE-115) SizeBasedTriggeringPolicy is not effecient enough because of using File.length() to check the active file size
by tomliliu (JIRA) 20 Aug '09

20 Aug '09

SizeBasedTriggeringPolicy is not effecient enough because of using File.length() to check the active file size -------------------------------------------------------------------------------------------------------------- Key: LBCORE-115 URL: http://jira.qos.ch/browse/LBCORE-115 Project: logback-core Issue Type: Improvement Components: Rolling Affects Versions: 0.9.17 Environment: windows, linux Reporter: tomliliu Assignee: Logback dev list Hi, It looks like SizeBasedTriggeringPolicy is not effecient enough because it will check active file size by calling File.length(), which will add a fixed overhead every 16 messages. (The performance definitely has been improved from 0.9.15 to 0.9.17 a lot by checking the file size every 16 message instead of every messages, we saw 20% overhead cut down on linux local file system.) We think SizeBasedTriggeringPolicy could work the FileAppender which keep track of how many bytes has been written through, and it's more efficient to check the file size based on how many bytes has been written. We also quickly made a mock up which keeps track of how many bytes written for comparison. Test Enviornment: Windows XP SP2, Linux 2.4 Test #1: Writing 10 bytes message 1, 000, 000 times. (No rotation happens) Platform File.length() Tracking bytes written overhead (%) Windows ~ 12, 200 ms ~ 10, 000 ms 22% Linux (local) ~ 10, 200 ms ~ 9, 800 ms 4% Linux (NFS) ~ 37, 700 ms ~ 27, 300 ms 38% Test #2: Writing 100 bytes messages 1, 000, 000 times. (No rotation happens) Platform File.length() Tracking bytes written overhead (%) Windows ~ 14, 000 ms ~ 11, 300 ms 23% Linux (local) ~ 11, 100 ms ~ 10, 300 ms 7% Linux (NFS) ~ 414, 600 ms ~366, 300 ms 13% Could you please consider improve the performance of SizeBasedTriggeringPolicy so that there is minimal overhead. Great Thanks, Tom -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 3