- logback-dev - mailman3.qos.ch

[JIRA] Created: (LBCORE-86) Simultaneous support of %d and %i
by Neil Lott (JIRA) 04 Feb '09

04 Feb '09

Simultaneous support of %d and %i --------------------------------- Key: LBCORE-86 URL: http://jira.qos.ch/browse/LBCORE-86 Project: logback-core Issue Type: Bug Components: Appender Affects Versions: 0.9.14 Reporter: Neil Lott Assignee: Logback dev list Hello Neil, FileNamePattern does not support the %d when used within FixedWindowRollingPolicy. Only %i is supported. It's a currentlimitation of the code. I suggest that you enter a jira issue requesting simultaneous support for %d and %i. Referencing or copying this thread would set a context for the problem which would be helpful. Cheers, Neil Lott wrote: Hi, I'm using a FileNamePattern with a FixedWindowPolicy: Here's my appender: <appender name="FILE" class="ch.qos.logback.core.rolling.RollingFileAppender"> <file>/usr/local/mystro/logs/MSAServer.log</file> <append>true</append> <rollingPolicy class="ch.qos.logback.core.rolling.FixedWindowRollingPolicy"> <FileNamePattern>/usr/local/neil/logs/MSAServer.%i.%d{yyyyMMdd-HHmmss}.gz</FileNamePattern> <MinIndex>1</MinIndex> <MaxIndex>3</MaxIndex> </rollingPolicy> <triggeringPolicy class="ch.qos.logback.core.rolling.SizeBasedTriggeringPolicy"> <MaxFileSize>1KB</MaxFileSize> </triggeringPolicy> <layout class="ch.qos.logback.classic.PatternLayout"> <Pattern>%d{ISO8601} %-5level [%thread] $%logger{0}.%M:%L\$ - %msg%n</Pattern> </layout> </appender> Here's the exception when the file rolls -- I had to alter the rollover method of FixedWindowPolicy in order to catch throwable to see what was going on: java.lang.IllegalArgumentException: Cannot convert 3 of typejava.lang.Integer at ch.qos.logback.core.rolling.helper.DateTokenConverter.convert(DateTokenConverter.java:60) [snip] Is this an intentional restriction to make the file name pattern have %i first and then %d? Thanks, Neil -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r2140 - in logback/trunk: logback-classic/src/main/java/ch/qos/logback/classic logback-classic/src/main/java/ch/qos/logback/classic/boolex logback-core/src/main/java/ch/qos/logback/core/joran/action logback-examples/src/main/java/chapter10/implicit logback-examples/src/main/java/chapter10/newRule logback-site/src/site/pages/manual
by noreply.ceki＠qos.ch 04 Feb '09

04 Feb '09

Author: ceki Date: Wed Feb 4 17:26:57 2009 New Revision: 2140 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/PatternLayout.java logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/boolex/JaninoEventEvaluator.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedComplexPropertyIA.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NewRuleAction.java logback/trunk/logback-examples/src/main/java/chapter10/implicit/PrintMe.java logback/trunk/logback-examples/src/main/java/chapter10/newRule/NewRuleCalculator.java logback/trunk/logback-examples/src/main/java/chapter10/newRule/new-rule.xml logback/trunk/logback-examples/src/main/java/chapter10/newRule/readme.txt logback/trunk/logback-site/src/site/pages/manual/onJoran.html Log: - Ongoing improvements to Joran documentation in chapter10 in relation to LBSITE-25 and LBSITE-24. - Cosmetic changes in code. Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/PatternLayout.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/PatternLayout.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/PatternLayout.java Wed Feb 4 17:26:57 2009 @@ -1,11 +1,11 @@ /** - * LOGBack: the reliable, fast and flexible logging library for Java. - * - * Copyright (C) 1999-2006, QOS.ch - * - * This library is free software, you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public License as - * published by the Free Software Foundation. + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. */ package ch.qos.logback.classic; Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/boolex/JaninoEventEvaluator.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/boolex/JaninoEventEvaluator.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/boolex/JaninoEventEvaluator.java Wed Feb 4 17:26:57 2009 @@ -1,7 +1,7 @@ /** * Logback: the generic, reliable, fast and flexible logging framework. * - * Copyright (C) 2000-2008, QOS.ch + * Copyright (C) 2000-2009, QOS.ch * * This library is free software, you can redistribute it and/or modify it under * the terms of the GNU Lesser General Public License as published by the Free Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedComplexPropertyIA.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedComplexPropertyIA.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedComplexPropertyIA.java Wed Feb 4 17:26:57 2009 @@ -1,7 +1,7 @@ /** - * LOGBack: the generic, reliable, fast and flexible logging framework. + * Logback: the generic, reliable, fast and flexible logging framework. * - * Copyright (C) 1999-2006, QOS.ch + * Copyright (C) 2000-2009, QOS.ch * * This library is free software, you can redistribute it and/or modify it under * the terms of the GNU Lesser General Public License as published by the Free @@ -41,17 +41,16 @@ Stack<IADataForComplexProperty> actionDataStack = new Stack<IADataForComplexProperty>(); public boolean isApplicable(Pattern pattern, Attributes attributes, - InterpretationContext ec) { - // System.out.println("in NestedComplexPropertyIA.isApplicable [" + pattern - // + "]"); + InterpretationContext ic) { + String nestedElementTagName = pattern.peekLast(); - // calling ec.peekObject with an empty stack will throw an exception - if (ec.isEmpty()) { + // calling ic.peekObject with an empty stack will throw an exception + if (ic.isEmpty()) { return false; } - Object o = ec.peekObject(); + Object o = ic.peekObject(); PropertySetter parentBean = new PropertySetter(o); parentBean.setContext(context); Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NewRuleAction.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NewRuleAction.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NewRuleAction.java Wed Feb 4 17:26:57 2009 @@ -1,7 +1,7 @@ /** - * LOGBack: the generic, reliable, fast and flexible logging framework. + * Logback: the generic, reliable, fast and flexible logging framework. * - * Copyright (C) 1999-2006, QOS.ch + * Copyright (C) 2000-2009, QOS.ch * * This library is free software, you can redistribute it and/or modify it under * the terms of the GNU Lesser General Public License as published by the Free Modified: logback/trunk/logback-examples/src/main/java/chapter10/implicit/PrintMe.java ============================================================================== --- logback/trunk/logback-examples/src/main/java/chapter10/implicit/PrintMe.java (original) +++ logback/trunk/logback-examples/src/main/java/chapter10/implicit/PrintMe.java Wed Feb 4 17:26:57 2009 @@ -50,10 +50,8 @@ // link the configurator with its context simpleConfigurator.setContext(context); - try { simpleConfigurator.doConfigure(args[0]); - } catch (Exception e) { - StatusPrinter.print(context); - } + StatusPrinter.printInCaseOfErrorsOrWarnings(context); + } } Modified: logback/trunk/logback-examples/src/main/java/chapter10/newRule/NewRuleCalculator.java ============================================================================== --- logback/trunk/logback-examples/src/main/java/chapter10/newRule/NewRuleCalculator.java (original) +++ logback/trunk/logback-examples/src/main/java/chapter10/newRule/NewRuleCalculator.java Wed Feb 4 17:26:57 2009 @@ -1,13 +1,12 @@ /** - * Logback: the reliable, fast and flexible logging library for Java. + * Logback: the generic, reliable, fast and flexible logging framework. * - * Copyright (C) 1999-2006, QOS.ch + * Copyright (C) 2000-2009, QOS.ch * * This library is free software, you can redistribute it and/or modify it under * the terms of the GNU Lesser General Public License as published by the Free * Software Foundation. */ - package chapter10.newRule; import java.util.HashMap; @@ -17,49 +16,44 @@ import ch.qos.logback.core.ContextBase; import ch.qos.logback.core.joran.action.Action; import ch.qos.logback.core.joran.action.NewRuleAction; -import ch.qos.logback.core.joran.spi.JoranException; import ch.qos.logback.core.joran.spi.Pattern; import ch.qos.logback.core.util.StatusPrinter; import chapter10.SimpleConfigurator; -import chapter10.calculator.ComputationAction2; - +import chapter10.calculator.ComputationAction1; /** * This example illustrates the usage of NewRuleAction which allows the Joran - * interpreter to learn new rules on the fly from the XML file being - * interpreted. - * - * This example relies heavily on the code from the joran.calculator package. - * + * interpreter to learn new rules on the fly. + * + * This example relies heavily on the code from the joran.calculator + * package. + * * @author Ceki Güulcü */ public class NewRuleCalculator { public static void main(String[] args) throws Exception { - + Context context = new ContextBase(); - - + Map<Pattern, Action> ruleMap = new HashMap<Pattern, Action>(); // we start with the rule for the top-most (root) element - ruleMap.put(new Pattern("*/computation"), new ComputationAction2()); + ruleMap.put(new Pattern("*/computation"), new ComputationAction1()); - // Associate "/new-rule" pattern with NewRuleAction from the + // Associate "/new-rule" pattern with NewRuleAction from the // org.apache.joran.action package. // - // We will let the XML file to teach the Joran interpreter about new rules - ruleMap.put( - new Pattern("/computation/new-rule"), new NewRuleAction()); + // We will let the XML file to teach the Joran interpreter about new rules + ruleMap.put(new Pattern("/computation/new-rule"), new NewRuleAction()); SimpleConfigurator simpleConfigurator = new SimpleConfigurator(ruleMap); // link the configurator with its context simpleConfigurator.setContext(context); - try { - simpleConfigurator.doConfigure(args[0]); - } catch (JoranException e) { - // Print any errors that might have occured. - StatusPrinter.print(context); - } - } + simpleConfigurator.doConfigure(args[0]); + + // Print any errors that might have occured. + StatusPrinter.printInCaseOfErrorsOrWarnings(context); + } + } Modified: logback/trunk/logback-examples/src/main/java/chapter10/newRule/new-rule.xml ============================================================================== --- logback/trunk/logback-examples/src/main/java/chapter10/newRule/new-rule.xml (original) +++ logback/trunk/logback-examples/src/main/java/chapter10/newRule/new-rule.xml Wed Feb 4 17:26:57 2009 @@ -1,20 +1,16 @@ -<?xml version="1.0" encoding="UTF-8" ?> -<!DOCTYPE computation> - - - - + <computation name="toto"> <new-rule pattern="*/computation/literal" - actionClass="chapter3.calculator.LiteralAction"/> + actionClass="chapter10.calculator.LiteralAction"/> <new-rule pattern="*/computation/add" - actionClass="chapter3.calculator.AddAction"/> + actionClass="chapter10.calculator.AddAction"/> <new-rule pattern="*/computation/multiply" - actionClass="chapter3.calculator.MultiplyAction"/> + actionClass="chapter10.calculator.MultiplyAction"/> <computation> <literal value="7"/> Modified: logback/trunk/logback-examples/src/main/java/chapter10/newRule/readme.txt ============================================================================== --- logback/trunk/logback-examples/src/main/java/chapter10/newRule/readme.txt (original) +++ logback/trunk/logback-examples/src/main/java/chapter10/newRule/readme.txt Wed Feb 4 17:26:57 2009 @@ -1,17 +1,8 @@ -+------------------------------+ -| | -| Joran Examples | -| | -| New rule | -| | -+------------------------------+ -This directory contains an example using the new rule action. +This directory contains an example showing how Joran can +learn new parsing rules on the fly. -It shows how Joran can learn new rules on the fly, while interpreting -the xml file. +For further documentation please see -For more in-depth informations about this example, please visit: - -http://logback.qos.ch/manual/joran.html#newRule + http://logback.qos.ch/manual/onJoran.html#newRule Modified: logback/trunk/logback-site/src/site/pages/manual/onJoran.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/manual/onJoran.html (original) +++ logback/trunk/logback-site/src/site/pages/manual/onJoran.html Wed Feb 4 17:26:57 2009 @@ -379,7 +379,7 @@ The next example, calculator2.xml file is a bit more complex, but also more interesting. - Example 3.: Calculator configuration + Example 10.: Calculator configuration file (logback-examples/src/main/java/chapter10/calculator/calculator2.xml) <div class="source"><pre><computation name="toto"> @@ -427,8 +427,8 @@ demonstrate the possibility elements that contain instances of the same element. Here's the content of calculator3.xml: - Example 3.: Calculator configuration file - (logback-examples/src/main/java/chapter3/calculator/calculator3.xml) + Example 10.: Calculator configuration file + (logback-examples/src/main/java/chapter10/calculator/calculator3.xml) <div class="source"><pre><computation name="toto"> <computation> @@ -444,7 +444,7 @@ Much like the use of parentheses in an algebrical equation, the presence of a <code>computation</code> element nested in another is managed by the <a - href="../xref/chapter3/calculator/ComputationAction2.html"> + href="../xref/chapter10/calculator/ComputationAction2.html"> <code>ComputationAction2</code></a> class using an internal stack. The well-formedness of XML will guarantee that a value saved by one <code>begin()</code> will be consumed only by the matching @@ -493,7 +493,7 @@ The <a href="../xref/chapter10/implicit/PrintMe.html"><code>PrintMe</code></a> application associates an <a - href="../xref/chapter3/implicit/NOPAction.html"> + href="../xref/chapter10/implicit/NOPAction.html"> <code>NOPAction</code></a> instance with the pattern "*/foo", that is any element named as "foo". As its name indicates, the <code>begin</code>() and <code>end</code>() methods of @@ -503,8 +503,8 @@ in its list of implicit actions. The <code>PrintMeImplicitAction</code> is applicable for any element which has a printme attribute set to - true. See the isApplicable method in - <code>PrintMeImplicitAction</code>. The <code>begin</code>() method + true. See the <code>isApplicable()</code> method in + <code>PrintMeImplicitAction</code>. The <code>begin()</code>() method of <code>PrintMeImplicitAction</code> prints the name of the current element on the console. @@ -512,7 +512,7 @@ The XML document implicit1.xml is designed to illustrate how implicit actions come into play. - Example 3.: Usage of implicit rules + Example 10.: Usage of implicit rules (logback-examples/src/main/java/chapter10/implicit/implicit1.xml) <foo> <xyz printme="true"> @@ -531,18 +531,25 @@ yields: Element [xyz] asked to be printed. -Element [abc] asked to be printed. +Element [abc] asked to be printed. +20:33:43,750 |-ERROR in c.q.l.c.joran.spi.Interpreter@10:9 - no applicable action for [xyz], current pattern is [[foo][xyz]] Given that <code>NOPAction</code> instance is explicitly - associated with the "*/foo" pattern, the - <code>PrintMeImplicitAction</code> is never triggered for any of the - <foo> elements. For other elements, the - <code>isApplicable</code> method of + associated with the "*/foo" pattern, <code>NOPActgion</code>'s + <code>begin()</code> and <code>end()</code> methods are invoked on + <foo> elements. <code>PrintMeImplicitAction</code> is never + triggered for any of the <foo> elements. For other elements, + since there are no matching explicit actions, the + <code>isApplicable()</code> method of <code>PrintMeImplicitAction</code> is invoked. It will return true only for elements having a printme attribute set to true, namely the first <xyz> element (but not - the second) and the <abc> element. This explains the output shown - above (previous paragraph). + the second) and the <abc> element. The second <xyz> element on + line 10, there are no applicable actions, an internal error message + is generated. This message is printed by the + <code>StatusPrinter.print</code> invocation, the last statement in + the <code>PrintMe</code> application. This explains the output shown + above (see previous paragraph). <h3><a name="iaPractice" href="#iaPractice">Implicit actions in @@ -556,86 +563,128 @@ <code>NestedComplexPropertyIA</code></a>. - - <code>NestedBasicPropertyIA</code> is applicable for any property + <code>NestedBasicPropertyIA</code> is applicable for any property whose type, is a primitive type, or equivalent object type in the <code>java.lang</code> package, an enumeration type, or any type adhering to the "valueOf" convention. A class is said to adhere to the "valueOf" convention if it contains a static method named <code>valueOf</code>() taking a <code>java.lang.String</code> as - parameter and returning an instance of the type in question. + parameter and returning an instance of the type in question. - <code>NestedComplexPropertyIA</code> action is applicable in the + <code>NestedComplexPropertyIA</code> action is applicable, in the remaining cases where <code>NestedBasicPropertyIA</code> is not - applicable. In other words, <code>NestedComplexPropertyIA</code> is - a last resort, catch-all, implicit action. It will - - - For example, the <a + applicable and if the object at the top of the object stack + has a setter or adder method for a property name equal to the + current element name. This strategy allows <a href="../xref/ch/qos/logback/core/joran/action/NestedComplexPropertyIA.html"> - <code>NestedComplexPropertyIA</code></a> extending <a - href="../xref/ch/qos/logback/core/joran/action/ImplicitAction.html"> - <code>ImplicitAction</code></a>, will instantiate the class - specified in a nested component and attach it to the parent - component by using setter method of the parent component and the - nested element's name. Under certain circumstances, a nested action - needs to be applied to an element say <a> and also to another - element nested within <a>. The current implementation of - <code>NestedComponentIA</code> is capable of handling multiply - nested elements requiring intervention by the same implicit action. + <code>NestedComplexPropertyIA</code></a> to instantiate the + appropriate class for the nested component and attach it to the + parent component (at the top of the object stack) by using the + setter/adder method of the parent component and the nested element's + name. The class to instantiate is specified by the class attribute of the nested element. However, + the class name can be deduced implicitly, if any of the following is + true: + + + <ol> + <li>there is an internal rule associating the parent object's + property with a designated class, + </li> + <li>the setter method contains a @DefaultClass attribute + designating a given class,</li> + + <li>the parameter type of the setter method is a contcrete class + possessing a public constructor, + </li> + </ol> + + In logback-classic, there are just two rules mapping (parent + class/property name) couples to a default class. + + <table class="bodyTable"> + <tr> + <th>Parent class </th> + <th>property name </th> + <th>default nested class</th> + </tr> + <tr > + <td>ch.qos.logback.core.AppenderBase</td> + <td>layout</td> + <td>ch.qos.logback.classic.PatternLayout</td> + </tr> + <tr class="alt"> + <td>ch.qos.logback.core.filter.EvaluatorFilter</td> + <td>evaluator</td> + <td>ch.qos.logback.classic.boolex.JaninoEventEvaluator</td> + </tr> + </table> + + This list may change in future releases. Please see + logback-classic <a + href="../xref/ch/qos/logback/classic/joran/JoranConfigurator.html">JoranConfigurator</a>'s + <code>addDefaultNestedComponentRegistryRules</code> method for the + latest rules. + + + In logback-access, the rules are very similar. In the default + class for the nested component, the ch.qos.logback.classic package + is replaced by ch.qos.logback.access. See logback-access <a + href="../xref/ch/qos/logback/access/joran/JoranConfigurator.html">JoranConfigurator</a>'s + <code>addDefaultNestedComponentRegistryRules</code> method for the + latest rules. - - - <a name="newRule"></a> - - <h3>New-rule action</h3> + <h3><a name="newRule" href="#newRule">New rules on the fly</a></h3> Joran includes an action which allows the Joran interpreter to - lean new rules on the fly while interpreting the XML file containing - the new rules. See the - logback-examples/src/main/java/joran/newRule/ directory for - sample code. - - - In this package, the <a - href="../xref/chapter3/newRule/NewRuleCalculator.html"> - <code>NewRuleCalculator</code></a> class contains the same setup as - we have seen so far, but for one line: - - ruleStore.addRule(new - Pattern("/computation/new-rule"), new NewRuleAction()); - - By adding this line, we ask Joran to allow new rules to be learnt - at parsing time. It works pretty much like the other rules: it has a - <code>begin()</code> and <code>end()</code> method, and is called each time - the parser finds a new-rule element. - - When called, the <code>begin()</code> method looks for a - pattern and a actionClass attribute. The action - class is then instanciated and added to the <code>RuleStore</code>, - along with its corresponding pattern. + learn new rules on the fly, that is while interpreting an XML + document. See the + logback-examples/src/main/java/chapter10/newRule/ directory + for sample code. In this package, the <a + href="../xref/chapter10/newRule/NewRuleCalculator.html"> + <code>NewRuleCalculator</code></a> application sets up just two + rules, one rule to process the top-most element, and a second rule + to learn new rules. Here is the relevant code from + <code>NewRuleCalculator</code>. + + + ruleMap.put(new Pattern("*/computation"), new ComputationAction1()); +ruleStore.addRule(new Pattern("/computation/new-rule"), new NewRuleAction()); + + <a + href="../xref/ch/qos/logback/core/joran/action/NewRuleAction.html"><code>NewRuleAction</code></a>, + part of logback-core, works pretty much like the other actions. It + has a <code>begin()</code> and <code>end()</code> method, and is + called each time the parser finds a new-rule element. When + invoked, the <code>begin()</code> method looks for pattern + and actionClass attributes. It then instantiates the + corresponding action class and adds the pattern/action association + as a new rule in Joran's rule store. + Here is how new rules can be declared in an xml file: <new-rule pattern="*/computation/literal" -actionClass="chapter10.calculator.LiteralAction"/> + actionClass="chapter10.calculator.LiteralAction"/> - Using new rule declarations, the preceding example, involving the + Using such new-rule declarations, we can transform + <code>NewRuleCalculator</code> to behave like the + <code>Calculator1</code> application we saw earlier. involving the calculation, could be expressed this way: - Example 3.: Configuration file using new + Example 10..: Configuration file using new rules on the fly - (logback-examples/src/main/java/chapter3/newrule/new-rule.xml) + (logback-examples/src/main/java/chapter10/newrule/new-rule.xml) -<div class="source"><pre><computation name="toto"> + <computation name="toto"> <new-rule pattern="*/computation/literal" - actionClass="chapter3.calculator.LiteralAction"/> + actionClass="chapter10.calculator.LiteralAction"/> <new-rule pattern="*/computation/add" - actionClass="chapter3.calculator.AddAction"/> + actionClass="chapter10.calculator.AddAction"/> <new-rule pattern="*/computation/multiply" - actionClass="chapter3.calculator.MultiplyAction"/> + actionClass="chapter10.calculator.MultiplyAction"/> <computation> <literal value="7"/> @@ -645,7 +694,18 @@ <literal value="3"/> <multiply/> -</computation></pre></div> +</computation> + + + java java chapter10.newRule.NewRuleCalculator src/main/java/chapter10/newRule/new-rule.xml + + yields + + The computation named [toto] resulted in the value 30 + + which is identical to the output of the <a + href="#calculator">original calculator example</a>. + <script src="templates/footer.js" type="text/javascript"></script> </div>

1 0

[JIRA] Issue Comment Edited: (LBCLASSIC-22) feature request: XMLLayout (cfr. log4j)
by Thorbjørn Ravn Andersen (JIRA) 04 Feb '09

04 Feb '09

[ http://jira.qos.ch/browse/LBCLASSIC-22?page=com.atlassian.jira.plugin.syste… ] Thorbjørn Ravn Andersen edited comment on LBCLASSIC-22 at 2/4/09 1:42 PM: -------------------------------------------------------------------------- revised and commented - generates humanly readable output including a ISO8601 date in the time attribute (which is allowed but unused by the log4j XMLLayout) was (Author: ravn): revised and commented - generates humanly readable output > feature request: XMLLayout (cfr. log4j) > --------------------------------------- > > Key: LBCLASSIC-22 > URL: http://jira.qos.ch/browse/LBCLASSIC-22 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: Linux > Platform: PC > Reporter: dirk > Assignee: Ceki Gulcu > Priority: Minor > Attachments: XMLLayout.jar, XMLLayout.java > > > see Summary -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Commented: (LBCLASSIC-22) feature request: XMLLayout (cfr. log4j)
by Thorbjørn Ravn Andersen (JIRA) 04 Feb '09

04 Feb '09

[ http://jira.qos.ch/browse/LBCLASSIC-22?page=com.atlassian.jira.plugin.syste… ] Thorbjørn Ravn Andersen commented on LBCLASSIC-22: -------------------------------------------------- This logback.xml snippet works with the uploaded XMLLayout.java file <appender name="FILE" class="ch.qos.logback.core.FileAppender"> <layout class="com.runjva.logback.xml.XMLLayout"> <LocationInfo>true</LocationInfo> <Properties>true</Properties> </layout> <File>c:/logback-output.xml</File> <Append>false</Append> </appender> The c:/logback-output.xml file can be read with the "File -> Load Log4j file" in the Chainsaw version which can be invoked with Java Web Start from http://logging.apache.org/log4j/docs/webstart/chainsaw/chainsawWebStart.jnlp > feature request: XMLLayout (cfr. log4j) > --------------------------------------- > > Key: LBCLASSIC-22 > URL: http://jira.qos.ch/browse/LBCLASSIC-22 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: Linux > Platform: PC > Reporter: dirk > Assignee: Ceki Gulcu > Priority: Minor > Attachments: XMLLayout.jar, XMLLayout.java > > > see Summary -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Updated: (LBCLASSIC-22) feature request: XMLLayout (cfr. log4j)
by Thorbjørn Ravn Andersen (JIRA) 04 Feb '09

04 Feb '09

[ http://jira.qos.ch/browse/LBCLASSIC-22?page=com.atlassian.jira.plugin.syste… ] Thorbjørn Ravn Andersen updated LBCLASSIC-22: --------------------------------------------- Attachment: XMLLayout.java revised and commented - generates humanly readable output > feature request: XMLLayout (cfr. log4j) > --------------------------------------- > > Key: LBCLASSIC-22 > URL: http://jira.qos.ch/browse/LBCLASSIC-22 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: Linux > Platform: PC > Reporter: dirk > Assignee: Ceki Gulcu > Priority: Minor > Attachments: XMLLayout.jar, XMLLayout.java > > > see Summary -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Updated: (LBCLASSIC-22) feature request: XMLLayout (cfr. log4j)
by Thorbjørn Ravn Andersen (JIRA) 04 Feb '09

04 Feb '09

[ http://jira.qos.ch/browse/LBCLASSIC-22?page=com.atlassian.jira.plugin.syste… ] Thorbjørn Ravn Andersen updated LBCLASSIC-22: --------------------------------------------- Comment: was deleted > feature request: XMLLayout (cfr. log4j) > --------------------------------------- > > Key: LBCLASSIC-22 > URL: http://jira.qos.ch/browse/LBCLASSIC-22 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: Linux > Platform: PC > Reporter: dirk > Assignee: Ceki Gulcu > Priority: Minor > Attachments: XMLLayout.jar, XMLLayout.java > > > see Summary -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Updated: (LBCLASSIC-22) feature request: XMLLayout (cfr. log4j)
by Thorbjørn Ravn Andersen (JIRA) 04 Feb '09

04 Feb '09

[ http://jira.qos.ch/browse/LBCLASSIC-22?page=com.atlassian.jira.plugin.syste… ] Thorbjørn Ravn Andersen updated LBCLASSIC-22: --------------------------------------------- Attachment: (was: XMLLayout.class) > feature request: XMLLayout (cfr. log4j) > --------------------------------------- > > Key: LBCLASSIC-22 > URL: http://jira.qos.ch/browse/LBCLASSIC-22 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: Linux > Platform: PC > Reporter: dirk > Assignee: Ceki Gulcu > Priority: Minor > Attachments: XMLLayout.jar, XMLLayout.java > > > see Summary -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Updated: (LBCLASSIC-22) feature request: XMLLayout (cfr. log4j)
by Thorbjørn Ravn Andersen (JIRA) 04 Feb '09

04 Feb '09

[ http://jira.qos.ch/browse/LBCLASSIC-22?page=com.atlassian.jira.plugin.syste… ] Thorbjørn Ravn Andersen updated LBCLASSIC-22: --------------------------------------------- Attachment: XMLLayout.class revised and commented version - generate readable XML output > feature request: XMLLayout (cfr. log4j) > --------------------------------------- > > Key: LBCLASSIC-22 > URL: http://jira.qos.ch/browse/LBCLASSIC-22 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: Linux > Platform: PC > Reporter: dirk > Assignee: Ceki Gulcu > Priority: Minor > Attachments: XMLLayout.class, XMLLayout.jar > > > see Summary -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r2139 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi
by noreply.ceki＠qos.ch 03 Feb '09

03 Feb '09

Author: ceki Date: Tue Feb 3 22:19:51 2009 New Revision: 2139 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/AppenderAttachableImpl.java Log: Use the recommended idion for j.u.c.locks Lock. See also http://java.sun.com/javase/6/docs/api/java/util/concurrent/locks/Lock.html This issue was discussed on the logback-dev list in Feb 2009 under the subject "IllegalMonitorStateException inAppenderAttachableImpl.appendLoopOnAppenders()" Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/AppenderAttachableImpl.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/AppenderAttachableImpl.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/AppenderAttachableImpl.java Tue Feb 3 22:19:51 2009 @@ -39,8 +39,8 @@ if (newAppender == null) { throw new IllegalArgumentException("Null argument disallowed"); } + w.lock(); try { - w.lock(); if (!appenderList.contains(newAppender)) { appenderList.add(newAppender); } @@ -54,8 +54,8 @@ */ public int appendLoopOnAppenders(E e) { int size = 0; + r.lock(); try { - r.lock(); for (Appender<E> appender : appenderList) { appender.doAppend(e); size++; @@ -74,8 +74,8 @@ */ public Iterator<Appender<E>> iteratorForAppenders() { List<Appender<E>> copy; + r.lock(); try { - r.lock(); copy = new ArrayList<Appender<E>>(appenderList); } finally { r.unlock(); @@ -96,8 +96,8 @@ } Appender<E> found = null; + r.lock(); try { - r.lock(); for (Appender<E> appender : appenderList) { if (name.equals(appender.getName())) { found = appender; @@ -121,8 +121,8 @@ return false; } boolean attached = false; + r.lock(); try { - r.lock(); for (Appender<E> a : appenderList) { if (a == appender) { attached = true; @@ -139,8 +139,8 @@ * Remove and stop all previously attached appenders. */ public void detachAndStopAllAppenders() { + w.lock(); try { - w.lock(); for (Appender<E> a : appenderList) { a.stop(); } @@ -159,8 +159,8 @@ return false; } boolean result; + w.lock(); try { - w.lock(); result = appenderList.remove(appender); } finally { w.unlock(); @@ -177,8 +177,8 @@ return false; } boolean removed = false; + w.lock(); try { - w.lock(); for (Appender<E> a : appenderList) { if (name.equals((a).getName())) { removed = appenderList.remove(a);

1 0

IllegalMonitorStateException in AppenderAttachableImpl.appendLoopOnAppenders()
by Szel, Zoltan (IDEAS) 03 Feb '09

03 Feb '09

Hi, We have hit the exception mentioned in the subject in one of our applications. We are using JDK 6 and Logback 0.9.14. Here is the stacktrace: Caused by: java.lang.IllegalMonitorStateException at java.util.concurrent.locks.ReentrantReadWriteLock$Sync.tryReleaseShared(ReentrantReadWriteLock.java:363) at java.util.concurrent.locks.AbstractQueuedSynchronizer.releaseShared(AbstractQueuedSynchronizer.java:1253) at java.util.concurrent.locks.ReentrantReadWriteLock$ReadLock.unlock(ReentrantReadWriteLock.java:745) at ch.qos.logback.core.spi.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:64) at ch.qos.logback.classic.Logger.appendLoopOnAppenders(Logger.java:270) at ch.qos.logback.classic.Logger.callAppenders(Logger.java:257) at ch.qos.logback.classic.Logger.buildLoggingEventAndAppend(Logger.java:439) at ch.qos.logback.classic.Logger.filterAndLog_1(Logger.java:411) at ch.qos.logback.classic.Logger.debug(Logger.java:504) I have checked the code and it seems to me this can only happen if the readLock.lock() method throws an exception: public int appendLoopOnAppenders(E e) { 56<http://logback.qos.ch/xref/ch/qos/logback/core/spi/AppenderAttachableImpl.h…> int size = 0; 57<http://logback.qos.ch/xref/ch/qos/logback/core/spi/AppenderAttachableImpl.h…> try { 58<http://logback.qos.ch/xref/ch/qos/logback/core/spi/AppenderAttachableImpl.h…> r.lock(); 59<http://logback.qos.ch/xref/ch/qos/logback/core/spi/AppenderAttachableImpl.h…> for (Appender<E> appender : appenderList) { 60<http://logback.qos.ch/xref/ch/qos/logback/core/spi/AppenderAttachableImpl.h…> appender.doAppend(e); 61<http://logback.qos.ch/xref/ch/qos/logback/core/spi/AppenderAttachableImpl.h…> size++; 62<http://logback.qos.ch/xref/ch/qos/logback/core/spi/AppenderAttachableImpl.h…> } 63<http://logback.qos.ch/xref/ch/qos/logback/core/spi/AppenderAttachableImpl.h…> } finally { 64<http://logback.qos.ch/xref/ch/qos/logback/core/spi/AppenderAttachableImpl.h…> r.unlock(); 65<http://logback.qos.ch/xref/ch/qos/logback/core/spi/AppenderAttachableImpl.h…> } 66<http://logback.qos.ch/xref/ch/qos/logback/core/spi/AppenderAttachableImpl.h…> return size; 67<http://logback.qos.ch/xref/ch/qos/logback/core/spi/AppenderAttachableImpl.h…> } if r.lock() in line 58 throws an exception for some reason than in the finally block the unlock will throw also an exception which will hide the original one. I cannot see any other reason why the unlock would throw this exception in this scenario. I am not yet able to reproduce it, but I thought this exception worth a mail. The only suggestion I have for now is to move the r.lock() call out of the try block, because if that is the bad guy, than we would have the original exception propagated. If I have more information on this issue I will update this thread. Regards, Zoltan Szel Morgan Stanley | IDEAS PRACTICE AREAS Lechner Odon fasor 8 | Floor 07 Budapest, 1095 Phone: +36 1 881-3978 Zoli.Szel(a)MorganStanley.com<mailto:Zoli.Szel@MorganStanley.com> -------------------------------------------------------- NOTICE: If received in error, please destroy and notify sender. Sender does not intend to waive confidentiality or privilege. Use of this email is prohibited when received in error.

4 9